GitLab

Bug: 955357
Change-Id: I50ecd9e1a2f6962fb3e8fe9f67627e13e2c09983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579024
Auto-Submit: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653611}

https://skia.googlesource.com/skia.git/+log/29c1c8029a52..82de21cb71c0


git log 29c1c8029a52..82de21cb71c0 --date=short --no-merges --format='%ad %ae %s'
2019-04-24 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
2019-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cff6f150eae1..62e274e86c7e (2 commits)
2019-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 707ed9974cb3..a161493942fa (9 commits)
2019-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 29e17ed2..7d439e09 (412 commits)
2019-04-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-04-23 reed@google.com (start to) explicitly use float for color values
2019-04-23 bsalomon@google.com Store tasks to execute before VK secondary command buffers generically.
2019-04-23 mtklein@google.com make -Werror or /WX optional, off by default
2019-04-23 mtklein@google.com fix sk_colorspace include guard
2019-04-23 reed@google.com remove dead function MakeSingleChannelOutput
2019-04-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-04-23 mtklein@google.com sort, dedup skia_public_includes
2019-04-23 mtklein@google.com inject SkUserConfig.h with -DSK_USER_CONFIG_HEADER
2019-04-23 mtklein@google.com another stray <include> -> ""
2019-04-23 ethannicholas@google.com added support for interpreting generic SkSL functions
2019-04-23 mtklein@google.com are these include paths no longer needed?
2019-04-23 herb@google.com Only call findImage when needed
2019-04-23 mtklein@google.com switch some idiosyncratic <includes> to ""


Created with:
  gclient setdep -r src/third_party/skia@82de21cb71c0

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=mtklein@chromium.org

Change-Id: If18feaef09f171c2ddf5d478a593d57000d28e0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580780Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653610}

Bug: 922900
Change-Id: Ibe7f81a00f6c832c000763fba872777b09b343c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573619
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653609}

Python is unable to find cipd if the path to depot_tools in PATH
is relative or uses shell tokens like '~'.

R=thakis@chromium.org

Bug: 952865
Change-Id: I1b17921f84862e515108ac449314f8497b9cbb84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571488Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653608}

If ServiceWorkerImportedScriptUpdateCheck is enabled, there are two
phases in updating: byte-to-byte checking and launching a new service
worker for install/activate events. If script change is found in phase
one, the download of changed script is paused. In the second phase,
we need to resume the paused download to avoid making new network
request again.

This patch is for the second phase: Creates a resume type
ServiceWorkerNewScriptLoader in loader factory to continue the download.

Bug: 648295
Change-Id: I3720629c04fe853ef5d3ebc81996035662d93a96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547411
Commit-Queue: Ting Shao <ting.shao@intel.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653607}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2723b186..7a4d9f89

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I2d511a2df8e0ee5138e49d1d2d47de9256bdf230
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582045Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#653606}

The histograms for number of pixels rastered per millisecond are not
looked at by anyone. Remove them.

R=enne@chromium.org

Bug: 955215
Change-Id: Id2d0fb0848888bedcc9177ed3b50ae36e3e7f803
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579460
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653605}

This will allow us to convert more Callbacks in the bluetooth component
over to OnceCallbacks, which will let us convert Callbacks in content
eventually.

R=reillyg@chromium.org

Bug: 953861
Change-Id: I22eacc0d77ffd56755d2f7adc039d7fe217f2cc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579249Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653604}

Before: https://screenshot.googleplex.com/G5PNviK7J2L.png
After: https://screenshot.googleplex.com/pXrazwXM0OU.png

Bug: 806868
Change-Id: I17074b52731a76709d9838de95e0556a7c511327
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581683Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#653603}

This is required because these waterfalls started failing after
https://chrome-internal.googlesource.com/infradata/config/+/078015fd725e195112a5ccfe609147e66929a26a

Bug: chromium:954875
Change-Id: Ic98e776ebf89ab3df54d15a1d87d606a81cd9f3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581628Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Artem Titarenko <artit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653602}

https://chromium.googlesource.com/angle/angle.git/+log/cb8f677cbfb4..c9a9cfcca176


git log cb8f677cbfb4..c9a9cfcca176 --date=short --no-merges --format='%ad %ae %s'
2019-04-24 jbeich@FreeBSD.org `environ` needs to be declared for (at least) FreeBSD.


Created with:
  gclient setdep -r src/third_party/angle@c9a9cfcca176

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I9389c0a4f7d706ba3afd09657d24426a6663d1da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582259Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#653601}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/70001899ab44..2635a51a68a1


Created with:
  gclient setdep -r src-internal@2635a51a68a1

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=cmumford@chromium.org,gab@chromium.org,droger@chromium.org

Change-Id: Ia6ede79c9dd08cca09a63433e70cd2d48465e424
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582260Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#653600}

Inhibits compiler optimizations in release builds that were
causing the dynamic stack allocation with alloca to be optimized
out, resulting in the same execution as CallWithPlainFunction().
The disassembly for this implementation shows that the dynamic
allocation is now present.

Change-Id: Id8507c70aa89b132847b267b579661c532339f65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582320
Auto-Submit: Mike Wittman <wittman@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653599}

As advised in [1], after porting all uses of Foo::Create() to
MakeGarbageCollected<Foo>() in //third_party/blink/renderer/core/svg,
this CL removes the unused factory methods.

[1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ

Bug: 939691
Change-Id: I1785f70be35d35096d239dda1dabe99911e8f380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581619
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653598}

Before this patch, the updateWith() is called in onpayerdetailchange
event, then opened payment sheet UI is aborted. This is a regression
since http://crrev.com/c/1558792.
We already had testRetryAndPayerDetailChangeEvent() test but it was hard
to detect the bug because requestShipping was always true in the test.
So, this patch adds a new test similar to the exiting test.

Bug: 817073, 941837
Change-Id: I44243a19c543c8094d4b9fc4b66519f0d899d730
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579159Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#653597}

Previously, TaskSchedulerImpl had 2 members foreground_pool_ and
native_foreground_pool_. This CL transforms these into a single pointer to
SchedulerWorkerPool, thus hiding implementation in source file.

Change-Id: I521e34e5a6ae72fa790b65be966b6919b9fff0f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554288
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653596}

WKHTTPCookieStore doesn't have a public api to retrieve cookies for URL,
so we have to use getAllCookies for single URL requests. and for that we
have to filter returned cookies based on the URL.
CRWWHTTPCookieStore is a wrapper over WKHTTPCookieStore that workaround
its problems, it adds caching and ensure that the WebsiteDataStore exist
with each getCookies cakk

Move the filtering step to IO Process instead of UI. Also create a
cache to save cookies so getAllCookies isn't called if it's not needed.

Bug: 941643
Change-Id: Ia2a7048646b01650874567c4942e2d107405324f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538777
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653595}

This CL:

- Moves the SkImageDeliverCB alias from ImageCaptureFrameGrabber to
  its inner class SingleShotFrameHandler.
- Stops referencing WebCallbacks in favor of CallbackPromiseAdapter
  (blink internal).

R=jbroman@chromium.org

BUG=945851,787245

Change-Id: I874d52aac7c53c8c32a77bd0f7defdaff3fac69b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582140
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653594}

Bug: 922813
Change-Id: I4743041c76c56cca59cadc207d400b538db37c58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580592Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: ericale <ericale@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653593}

https://android.googlesource.com/platform/external/perfetto.git/+log/8044f5ea87ef..6b4473dce4d7


git log 8044f5ea87ef..6b4473dce4d7 --date=short --no-merges --format='%ad %ae %s'
2019-04-24 fmayer@google.com Merge "Use blocking socket in client."
2019-04-24 lalitm@google.com Merge "base: Fix build (missing header)."


Created with:
  gclient setdep -r src/third_party/perfetto@6b4473dce4d7

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I77ea85f9df6f8c1a20bfc1821d9a3f3b94e7fdde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582011Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#653592}

https://swiftshader.googlesource.com/SwiftShader.git/+log/ea1b0983c7b4..3c830834002a


git log ea1b0983c7b4..3c830834002a --date=short --no-merges --format='%ad %ae %s'
2019-04-24 bclayton@google.com LLVMReactorDebugInfo: Remove REACTOR_LLVM_VERSION check


Created with:
  gclient setdep -r src/third_party/swiftshader@3c830834002a

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/130460252
TBR=swiftshader-team+autoroll@chromium.org

Change-Id: I0a85f19176d60e263f52c8b7df24180563702609
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582010Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#653591}

Glibc's system() function switched to using posix_spawn, which uses
CLONE_VFORK. Pepperflash includes a sandbox debugging check which
relies on us EPERM-ing process creation like this, rather than crashing
the process with SIGSYS.

So whitelist clone() calls, like posix_spawn, that include the flags
CLONE_VFORK and CLONE_VM.

Bug: 949312
Change-Id: I3f4b90114b2fc1d9929e3c0a85bbe8f10def3c20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568086
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653590}

Should allow luci-migration to experiment on this despite the rename.
Also removes a no-longer-necessary similar configuration for
android-marshmallow-arm64-rel's old name.

Bug: 731988
Change-Id: Ie806043618101a943f9e8fcf6b24fd85f5fc187b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580759
Auto-Submit: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653589}

This struct is no longer used in the test.

Bug: 909957
Change-Id: I517f3647778971b51283343811e928d92e595b01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579912
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653588}

The test is not failing anymore. Update the test expectation to reflect
that. See:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fthreaded%2Fexternal%2Fwpt%2Fanimation-worklet%2Fplayback-rate.https.html

Change-Id: Ibf9fa97ab202a9c34852a292bdeeb8a5eaf55ba0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582048Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653587}

Coalesces all the unwinding scenario tests into the same part of the
file.

Bug: 909957
Change-Id: I5cc7cd00dc298e1c5adf1d9ad4d1585f5495b256
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580142
Auto-Submit: Mike Wittman <wittman@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653586}

As advised in [1], after porting all uses of Foo::Create() to
MakeGarbageCollected<Foo>() in //third_party/blink/renderer/core/svg,
this CL removes the unused factory methods.

[1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ

Bug: 939691
Change-Id: I5e98359a98907fadb56915c5a23bada3e633fc3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574804
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653585}

Previously a finished animation would fire the finished event on the next animation tick.  This is not to specification, as the finished event should trigger immediately (https://drafts.csswg.org/web-animations/#finishing-an-animation-section).

The discrepancy with the spec manifested as test failures when the state of an animation is updated after finishing. In some cases, the animation no longer registers as finished at the time of the next tick and the finished event is dropped.

Bug: 772060, 772048, 771977
Change-Id: Ie4161face4e6d5ed9b07bee86fef68b718233d41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572803Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653584}

This allows us to reuse layout results when affected by clearance.

We can't do this when:
 1. The "old" clearance offset isn't equal to the layout results offset.
 2. The difference between the constraint's BFC-block-offset, and the
   clearance offset shrinks (e.g. a margin may affect the final
   position).

I'm not sure if (1) actually should be a DCHECK.

Bug: 635619
Change-Id: Ic92063882914d4da7a4b168783ec2f2af82ec1fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574836
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653583}

I suspect the rebased path is tripping up GOMA?

Change-Id: If6984fdbd4f3ac1bf673bf810ea28bd16a860175
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582043
Commit-Queue: Mike Klein <mtklein@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
Cr-Commit-Position: refs/heads/master@{#653582}

As advised in [1], after porting all uses of Foo::Create() to
MakeGarbageCollected<Foo>() in //third_party/blink/renderer/core/svg,
this CL removes the unused factory methods.

[1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ

Bug: 939691
Change-Id: I6a9d7dcc5a4c00497d35987bb91cfef69a95784a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576564
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653581}

Remove some usage of deprecated callback types in base/*. Where possible
convert to the corresponding once type, otherwise replace with the
repeating type.

Bug: 714018
Change-Id: Idb7bf334fb06a407bf65e4ffb4cc2e19dd8a5195
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572809
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653580}

Bug: 955174
Change-Id: Id6a01cb3f237a088add8062717d8354b77cefa52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577932Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653579}

We intend to launch PWA Omnibox install in 76 so update expiry to be 3
milestones later.

Bug: 907351
Change-Id: Ib6f59f1184f5a0a046a488fa2570d026cf5f69ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580987
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653578}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2695bdcbd7bb..70001899ab44


Created with:
  gclient setdep -r src-internal@70001899ab44

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=cmumford@chromium.org,gab@chromium.org,droger@chromium.org

Change-Id: I2847fdc9273c5cd29dc3d9bf3efff15e312192b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582008Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#653577}

R=pshmakov
TBR=yfriedman
BUG=None

Change-Id: I93cc93ac9fc95cc9965617e16aed38c8cee4e6e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568776
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Pavel Shmakov <pshmakov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653576}

gn check --check-generated reported a missing build
dependency and this fixes that. An example of a reported error is:

ERROR at //out/Default/gen/ui/latency/mojo/latency_info.mojom-forward.h:44:11: Can't include this header from here.
          ^----------------------
The target:
  //ui/latency/mojo:interfaces
is including a file from the target:
  //ipc:ipc

Since the header isn't actually used, the simple fix is to remove it, though that revealed some
other code that was missing includes of their own.

Bug: 938893
Change-Id: I8e2648d5e681ee9640282eab31028a102cdc96eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550467Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Auto-Submit: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#653575}

As advised in [1], this CL ports calls to Foo::Create() factory
functions to use MakeGarbageCollected<Foo> from classes in
//third_party/blink/renderer/core/svg.

[1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ

Bug: 939691
Change-Id: I12580470b68aeec1331019be33c96847592b10c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576563
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653574}

Bug: 944194
Change-Id: I9afec626d7cd98c31130360a8103ac9e13fef619
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582044
Auto-Submit: Peng Huang <penghuang@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653573}

Before this CL, this was broken if kStopSyncInPausedState was enabled:
Entering "Sync paused" would shut down the Sync machinery, but exiting
that state didn't start it up again. This CL fixes that by making
SyncAuthManager notify the SyncService when exiting "Sync paused", so
that the SyncService can then decide if it should start up again.

This CL also updates SyncAuthTest.SyncPausedState so that is passes
both with and without kStopSyncInPausedState.

Bug: 954195
Change-Id: I9412408b1c3b868a71574d1f70a49782636d8de3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581959
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653572}