- 19 Sep, 2018 40 commits
-
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/174de19776de..d39389f6ec2e git log 174de19776de..d39389f6ec2e --date=short --no-merges --format='%ad %ae %s' 2018-09-19 thestig@chromium.org Use MaybeOwned in CPDF_StreamAcc. 2018-09-19 thestig@chromium.org Roll testing/corpus/ 6cd71979b..2ddedb263 (1 commit) 2018-09-19 thestig@chromium.org Consolidate raw data processing path in CPDF_StreamAcc. 2018-09-19 thestig@chromium.org Initialize CPDF_ImageRenderer in the header. Created with: gclient setdep -r src/third_party/pdfium@d39389f6ec2e The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4d86bdde087267b626ede79285c935e583f9d6ba Reviewed-on: https://chromium-review.googlesource.com/1234970Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592568}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2a0473aeb232..299ed678d06b Created with: gclient setdep -r src-internal@299ed678d06b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I605866065940cafe7fea82bdcd9ff01e35f771d2 Reviewed-on: https://chromium-review.googlesource.com/1234819Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592567}
-
Ryan Cui authored
Revert "[SingleProcessMash] Disable ChromeNewWindowClientBrowserTest.NewWindowForActiveWindowProfileTest" This reverts commit c4baffd7. Reason for revert: Disabling the test in the source instead (https://chromium-review.googlesource.com/c/chromium/src/+/1231157) since it doesn't just fail in single_process_mash_browser_tests. Original change's description: > [SingleProcessMash] Disable ChromeNewWindowClientBrowserTest.NewWindowForActiveWindowProfileTest > > Seeing flaky failures for the test on the MSan bot. > > Bug: 884118 > Change-Id: Id2773b731b054bbecb02fd9bca8f7c00d2f5f447 > Reviewed-on: https://chromium-review.googlesource.com/1232193 > Reviewed-by: Asanka Herath <asanka@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Ryan Cui <rcui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592249} TBR=sky@chromium.org,asanka@chromium.org,rcui@chromium.org Change-Id: Idf34799791c2da559f0e4e3909d0aa54c482cd97 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 884118 Reviewed-on: https://chromium-review.googlesource.com/1234264 Commit-Queue: Ryan Cui <rcui@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#592566}
-
Reza.Zakerinasab authored
This CL: - adds "preserve" color space conversion option to ImageBitmap. - replaces sRGB with color spin color space as the source color space in ImageBitmap unit tests. - removes SkColorSpaceXform usage from ImageBitmap unit tests. Bug:842688, 774520 TBR=fserb@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I62df4c8bd0cd69b0da36dee4dd2f62ed1714d884 Reviewed-on: https://chromium-review.googlesource.com/1234017Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#592565}
-
Saman Sami authored
Resetting the fallback can result in surfaces outside of the desired range being shown on next show. Bug: 857575 Change-Id: Ic9a80bb7f0b6e963adb32ffd0e234108e323d394 Reviewed-on: https://chromium-review.googlesource.com/1226020Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#592564}
-
Jun Mukai authored
BUG=883523 TEST=local run of interactive_ui_tests / try success Change-Id: I54f81374374f83fe70441acb1634fe04e137d298 Reviewed-on: https://chromium-review.googlesource.com/1232483Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2ec817bb6bd9..d511948b9f82 git log 2ec817bb6bd9..d511948b9f82 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 jmadill@chromium.org Use FastVector in angle::Subject. 2018-09-19 jmadill@chromium.org Fix FastVector::resize when count < size. 2018-09-19 oetuaho@nvidia.com Fix trying to clear nonexistent FBO attachments 2018-09-19 jmadill@chromium.org Re-land "Add FastVector for simple dynamic vector cases." Created with: gclient setdep -r src/third_party/angle@d511948b9f82 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I98a17184bbe6bdaab39c3d2e89fd58e82897a384 Reviewed-on: https://chromium-review.googlesource.com/1234818Reviewed-by:
-
Yiming Zhou authored
Bug: 855284 Change-Id: I10e167459213a0a4acab8acaaba3b4816798f1e0 Reviewed-on: https://chromium-review.googlesource.com/1231380Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Yiming Zhou <uwyiming@google.com> Cr-Commit-Position: refs/heads/master@{#592561}
-
Shakti Sahu authored
ChromeOS download notification code currently is driven by DownloadItem. This CL decouples them from DownloadItem and makes them observer DownloadUIModel which will enable OfflineItem as well. Bug: 884968 Change-Id: I2e7c9419d174d7ab7361e5738110a690e3529a53 Reviewed-on: https://chromium-review.googlesource.com/1229510 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592560}
-
smut authored
Bug: 723130 Change-Id: I9356bf40bb925b3b78495d0fe6de213d215e5962 Reviewed-on: https://chromium-review.googlesource.com/1232890Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#592559}
-
Alexei Filippov authored
That makes the stack traces more clean thus reducing confusion during stack attribution. As a bonus less data is collected and sent. BUG=803276 Change-Id: I8d320a356594d3077feed593fe653db246bc12a6 Reviewed-on: https://chromium-review.googlesource.com/1232413 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#592558}
-
Wan-Teh Chang authored
https://aomedia.googlesource.com/aom.git/+log/67645b8f529c..f866f5ebb34b $ git log 67645b8f5..f866f5ebb --date=short --no-merges --format='%ad %ae %s' 2018-09-18 wtc Fix cmake -DENABLE_EXAMPLES=0 error. 2018-08-06 chengchen Bitmask patch 7: Optimize traversal steps. 2018-08-03 chengchen Bitmask patch 6: Minor improvement. 2018-07-30 chengchen Bitmask patch 5: Store vertical border and skip using bitmask 2018-09-18 grant.hsu Extend blk_skip to support chroma planes 2018-07-30 chengchen Bitmask patch 4: Store transform size info for vartx 2018-07-26 chengchen Bitmask patch 3: Add more lookup table entries for bitmask. 2018-09-13 anorkin Fix sending repeated random_seed in film grain 2018-09-12 tdaede Only build stats library if examples are enabled. 2018-09-17 wtc Call decoder_decode() even on invalid input data. 2018-09-12 david.barker Fix range check in half_btf() function 2018-09-17 wtc Optimize set_planes_to_neutral_grey for highbd. 2018-07-16 chengchen Bitmask patch 2: Applying filtering once bitmask is built 2018-07-20 chengchen Bitmask patch 1: Reduce u/v horizontal/vertical 2018-09-17 tomfinegan Propagate user private data when film grain enabled. 2018-09-07 umang.saini Fix 32bit build for arm target arch 8 2018-09-13 yaowu Add cmdline switch --skip-film-grain to aomdec 2018-09-17 remya.prakasan Add sse4_1 variant for highbd inv_txfm 32x32 2018-09-17 satish.suman Optimize highbd 64x64 fwd_txfm 2018-08-27 alexanderbokov Add ML-based rectangular partition pruning (...) Created with: roll-dep src/third_party/libaom/source/libaom R=tomfinegan@chromium.org,johannkoenig@google.com,jzern@google.com Bug: oss-fuzz:10151 Bug: oss-fuzz:10242 Bug: aomedia:2163 BUG: b/114621710 BUG: b/114647746 BUG: oss-fuzz:10252 Change-Id: I6aab2c5958217ea1660a26783870adb6d6810ad7 Reviewed-on: https://chromium-review.googlesource.com/1234955 Commit-Queue: Tom Finegan <tomfinegan@chromium.org> Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592557}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/647e1e79eb71..21a51b392104 git log 647e1e79eb71..21a51b392104 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 jbudorick@chromium.org gclient: set the push url to the actual repository instead of the mirror. Created with: gclient setdep -r src/third_party/depot_tools@21a51b392104 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:884434 TBR=agable@chromium.org Change-Id: I98abb8a074d679cea361e4cd7b15222567ebeade Reviewed-on: https://chromium-review.googlesource.com/1234816Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8a0014403563..a5c578ff3d46 git log 8a0014403563..a5c578ff3d46 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 brianosman@google.com Add Short4 vertex attributes, and benchmark them as 4.12 colors 2018-09-19 brianosman@google.com Load SVGs into memory before parsing 2018-09-19 brianosman@google.com Remove hacks for UShort2 texture coords 2018-09-19 mtklein@google.com always optimize third_party code Created with: gclient setdep -r src/third_party/skia@a5c578ff3d46 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Idbdbbae4fc825d6cd43d1c8370c49377a2ad6217 Reviewed-on: https://chromium-review.googlesource.com/1234959Reviewed-by:
-
David Black authored
Used to launch a specific Chrome Settings page, or top level Settings, in a new browser tab. Bug: b:115675454 Change-Id: I7bc6bf0e9b5e950e23c1ec2f4ad8b801d7b54958 Reviewed-on: https://chromium-review.googlesource.com/1226206 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#592554}
-
Wenzhao Zang authored
There're two other screensaver apps that need whitelisting. TBR=rdevlin.cronin@chromium.org Bug: 870851 Change-Id: I78de824892311edd28b3a0d71e05360304c5d562 Reviewed-on: https://chromium-review.googlesource.com/1220053 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592553}
-
Derek Cheng authored
By calling close() during contextDestroyed(), the PresentationConnection in Blink will notify the other end of the mojo message pipe via RequestClose(). Native MRPs holding the other end of the pipe (e.g. Cast MRP 2-UA mode) can then use this as a signal to clean up the presentation, instead of going through MediaRouteProvider::DetachRoute() This also fixes a bug where in 1-UA mode, the receiver connection does not receive state change to CLOSED when the controller frame navigates away. Note that PresentationService::CloseConnection() is still being called from Blink. This is still required for 1-UA mode where the other end of the pipe is not in the browser. Also, PresentationServiceImpl still performs a Reset() on frame navigation to clean up other internal states. Bug: 882690 Change-Id: I9b4ecb862c39c737b36b2d5435286fb59a3ff752 Reviewed-on: https://chromium-review.googlesource.com/1222679 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#592552}
-
Elly Fong-Jones authored
Bug: 500168 Change-Id: I16cb2daedf07be2bc255716b864f7ce2eff8df97 Reviewed-on: https://chromium-review.googlesource.com/1233935Reviewed-by:
-
Yue Cen authored
The plan is to ship the feature in M71. This CL will be merge to M70 and reverted in M71. Bug: 835029 Change-Id: I741c60ccbff2570a07fc9c3535b0acea6efa1ed8 Reviewed-on: https://chromium-review.googlesource.com/1234966Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#592550}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c57ca0ea3af6..e2e437a4c577 git log c57ca0ea3af6..e2e437a4c577 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 mortonm@chromium.org Add new modem group. Created with: gclient setdep -r src/third_party/chromite@e2e437a4c577 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie5197bead6e41d7542f388d745a9bfa11513f8b9 Reviewed-on: https://chromium-review.googlesource.com/1234958Reviewed-by:
-
Mina Almasry authored
I found a couple of reasons hard corrections were kicking in extraneously around pause/resume and start playback. For pause/resume, we were reading the vpts/apts from before the resume. So, add a delay to starting AV sync such that we reduce the chance we read a before pause/resume value. We're not in a rush to engage AV sync anyway. Also, scrub the audio pipeline for out of date mixer rendering delay or push pts. For start, I found that since current code starts playback with a timestamp in the past, we will likely drop audio at the start. This makes us more likely to underrun at the start of playback. Switch that to a timestamp slightly in the future. Also fix the CanDropAudio logic, which wasn't really kicking in before. This means that even if we need to drop audio at RestartPlaybackAt, we still don't underrun afterwards. Bug: b/115805615 Test: Manual on device, cast_media_unittests and cast_audio_backend_unittests on desktop. Change-Id: Id85e0cebc3acf6c469803e23ba649e4435c1c929 Reviewed-on: https://chromium-review.googlesource.com/1233175Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Mina Almasry <almasrymina@chromium.org> Cr-Commit-Position: refs/heads/master@{#592548}
-
Asanka Herath authored
The following tests are failing on some but not all Linux and Mac configurations: * http/tests/csspaint/invalidation-background-image.html * http/tests/csspaint/invalidation-border-image.html * http/tests/csspaint/invalidation-content-image.html Updating expectations while a fix is being worked on. Bug: 886566 Change-Id: Ic1df9c3d99d189104ee07f873561889c0e192221 Reviewed-on: https://chromium-review.googlesource.com/1234893Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#592547}
-
Asanka Herath authored
FlingControllerTest.EarlyTouchscreenFlingCancelationOnFlingStop is flaky. Bug: 886992, 836996 Change-Id: I80a732f729ee8691a18ea7948c78cb1c9eb54a01 Reviewed-on: https://chromium-review.googlesource.com/1234976Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#592546}
-
Steven Bennetts authored
This CL moves some common flag/switch wrappers into the callers to remove unnecessary dependencies on keyboard_util.h. With the upcoming Chrome/Ash separation, the wrappers cause more confusion than they improve readability. This CL also moves some keyboard_util.cc code only used in KeyboardController to that class. Bug: 843332 Change-Id: I042928bebfe4f9ea93ccb4fb7a24f8fc46f555cf Reviewed-on: https://chromium-review.googlesource.com/1226191 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#592545}
-
Dale Curtis authored
This adds an experiment where all paused preload=metadata audio and video tags avoid decoder spool up and reduce data usage until the tag becomes visible. This is done by expanding the preload=metadata suspend for videos with poster to all preload=metadata videos. It returns this status to the HTMLMediaElement via WebMediaPlayer::DidLazyLoad(), which when true causes the element to create an ElementVisibilityObserver. When the element becomes visible it calls WebMediaPlayer::OnBecameVisible(). Since the preload=metadata experiment is on by default, it just replaces that experiment with this new one. BUG=879406 TEST=new unittests added Change-Id: I9358f3fef7dbd8ed5a5db50c78b3694c0276c2d5 Reviewed-on: https://chromium-review.googlesource.com/1198342 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#592544}
-
Michael Spang authored
Add const to members that are set in the ctor and never change. Also remove the unused status field from PageFlipRequest. Bug: none Test: compile Change-Id: I8bc54acd67812d860a87fab64381c7ae0f6b7b24 Reviewed-on: https://chromium-review.googlesource.com/1234223Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592543}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e5b1844cce9d..2a0473aeb232 Created with: gclient setdep -r src-internal@2a0473aeb232 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I27e19a46686af6b275609f1f9040ebe962134a69 Reviewed-on: https://chromium-review.googlesource.com/1234815Reviewed-by:
-
Reilly Grant authored
DeviceImpl::OnOpen handles a null UsbDeviceHandle on the normal path but unconditionally closed the handle if the weak pointer to the DeviceImpl was invalidated. This change adds a null check there as well. Bug: 884145 Change-Id: Ib9e68904468320a25c4c7bc866d61728d101d4ca Reviewed-on: https://chromium-review.googlesource.com/1234365Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592541}
-
Siddhartha authored
Make the copy buffer to malloced, since 1MB could be over stack limit for sampling thread. BUG=859260 R=wittman@chromium.org Change-Id: Idc7719c79be378fec69f6a1d90b8f9300d67e132 Reviewed-on: https://chromium-review.googlesource.com/1231382 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#592540}
-
Weidong Guo authored
Changes: 1. Calculate the first available position in AppListModelUpdater for newly added item. 2. Add test coverage. Bug: 883939 Test: AppListSyncableServiceTest.FirstAvailablePosition Change-Id: Ibdd2f27455ffd0c76f45906adbc025baab1ff319 Reviewed-on: https://chromium-review.googlesource.com/1231193 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#592539}
-
David Bokan authored
Adding viewport nodes causes a performance regression so this CL turns off the paint tree update in VisualViewport if BGPT (and SPv2) are off since the nodes aren't needed. Bug: 879205 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I19060e1d487d50ac9b65ae7bdaa32dba2e5caaa7 Reviewed-on: https://chromium-review.googlesource.com/1228489Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592538}
-
Ehsan Karamad authored
The CL 1187231 implemented MimeHandlerViewFrameContainer. This is a follow-up to that CL to fix some major issues in attaching a MHVG on the browser side. The main problems and updates: 1- The test added in 1187231 was inadvertently removed in Patch 4. This caused the incorrect code to land without flagging. This CL adds the test again (test runs with MimeHandlerViewInCrossProcessFrame). 2- MimeHandlerViewGuest::WillBeginAttach was using |embedder_web_contents()| which is null at this point. 3- The newly introduced code path for attaching Guests on the browser side would end up in code paths which expected RWHVGuest. This was happening in BPG::OnWillAttachComplete leading to an invalid cast from RWHVCF to RWHVG. This turned out to cause crashes on some bots. 4- It is possible with small changes to unify the attaching code path for other GuestViews and MHVG. This CL does just that. This CL also adds a sanity DCHECK in WCViewGuest to make sure we do not instantiate an incorrect type of GuestView. Bug: 659750 Change-Id: Id9c668aa5a98a8f669f56596828cef40198ec57f Reviewed-on: https://chromium-review.googlesource.com/1225307 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592537}
-
Marijn Kruisselbrink authored
The existance of this DefaultHash implementation is potentially problematic for several reasons: - DefaultHash<scoped_refptr<T>> exists as well, making it very easy to end up with ODR violations where different translation units end up with different types for a HashSet<scoped_refptr<const SecurityOrigin>>. - It is not obvious what "equality" the hash implements, since there are at least two equally valid definitions of equality for origins ("same origin" vs "same origin-domain"). Currently no code is actually using this hash, but our upcoming DOMStorage onion souping will want a hash that implements same origin equality, so for that this also changes the implementation to implement that version of equality. Bug: 781870 Change-Id: I79d8820194b51cb81ba4bf0684e65cba575dba82 Reviewed-on: https://chromium-review.googlesource.com/1229357Reviewed-by:Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#592536}
-
Brandon Wylie authored
Bug: 882966 Change-Id: I3624b8cef4cc0cf28c300beb426ae169c3be0730 Reviewed-on: https://chromium-review.googlesource.com/1219939 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#592535}
-
Martin Robinson authored
Bug: 885093 Change-Id: I9b6c6f7635a893b10e333bd6e72765fa630f9efb Reviewed-on: https://chromium-review.googlesource.com/1233353Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#592534}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/92ef0386b8b6..582a06eb7835 git log 92ef0386b8b6..582a06eb7835 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 chiniforooshan@chromium.org Telemetry: don't fail when SF cannot find win name Created with: gclient setdep -r src/third_party/catapult@582a06eb7835 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:884999 TBR=sullivan@chromium.org Change-Id: I7ce1f90275c2422e5cb7a0325379004f8e30cc3d Reviewed-on: https://chromium-review.googlesource.com/1234957Reviewed-by:
-
Clifford Cheng authored
Sometimes the function failed to find the "close-button" because it's closed. This can be due to a recent change in telemetry. See bug for more details. Bug: 884929 Change-Id: I47af2f8e87431120d5dfebba3d25ead91d98f565 Reviewed-on: https://chromium-review.googlesource.com/1229359 Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592532}
-
Nico Weber authored
Ran `tools/clang/scripts/upload_revision.py 342523`. Bug: 880827 Change-Id: I8f747ab4a2de74a0f0b4b5a201d37e111f323077 Reviewed-on: https://chromium-review.googlesource.com/1232590Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592531}
-
Sky Malice authored
Change-Id: Ib5698fdef987ca82a67c9e2b974a20012e95f508 Reviewed-on: https://chromium-review.googlesource.com/1228298Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#592530}
-
Peter Kasting authored
Fixes tests broken in Touchable Refresh and changes them from being tested in Touchable to Touchable Refresh. Also does some other cleanups. This does not remove flags added during refresh (e.g. NTB position); those will be added separately. Bug: 814847 Change-Id: I8c31a0421c65c4cd46f287d9e67aa17645089703 Reviewed-on: https://chromium-review.googlesource.com/1232882Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#592529}
-
