- 01 Feb, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/387002d1535d..da18f31f960f git log 387002d1535d..da18f31f960f --date=short --no-merges --format='%ad %ae %s' 2019-02-01 achuith@chromium.org chromite: Update moblab docs. 2019-02-01 nednguyen@google.com portage_util: remove usages of cros_build_lib.Die Created with: gclient setdep -r src/third_party/chromite@da18f31f960f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7fd2c24834b5a1e08ad1a3110b84833f9b42d94e Reviewed-on: https://chromium-review.googlesource.com/c/1449779Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628391}
-
Mohsen Izadi authored
For viz service to run as a standalone process in multi-process mash, it should be configured to provide interface binders for drm mojo interfaces as it is where drm resides. Viz host should also be updated to bind those interfaces on the viz service. BUG=912218 Change-Id: I915df5cc01f62e10f432f108f74a9640fdfe1f60 Reviewed-on: https://chromium-review.googlesource.com/c/1425977 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#628390}
-
Eric Lawrence authored
The Trickuri URL display testing tool was designed to augment the URL Display Guidelines documentation to enable testing against the guidelines. Add a link to the tool to the guidelines doc. Change-Id: Ia1e0742ef24a729cc3ef14f2bf6a75bfe4df6779 Reviewed-on: https://chromium-review.googlesource.com/c/1448731 Auto-Submit: Eric Lawrence <elawrence@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#628389}
-
Mike Klein authored
** Sheriffs, this is a bug fix that affects most curve drawing. ** ** I've got thousands of diffs here, and probably missed a few. ** ** If we could find a way to roll forward through any breakages ** ** rather than revert this CL, I'd be very appreciative. It's ** ** going on a month now trying to get this in. ** DAA and its ilk have fundamental problems dealing with overlapping coverage. While we think about how to solve them (and if they can be solved at all), turn it off. It took me a while to find one, but fast/borders/borderRadiusDashed01.html is the smoking gun. Bug: chromium:913223, skia:6886 Change-Id: I42b6b1cec464a40017ee4e8e4f9c663bb13a11e6 Reviewed-on: https://chromium-review.googlesource.com/c/1412462 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#628388}
-
James Cook authored
Events with a location like 10.2,10.2 were truncated to 10,10 during deserialization. Bug: 924279 Test: added to events_unittests Change-Id: Ic9a408507122958ffa4f598288e5e922369532f5 Reviewed-on: https://chromium-review.googlesource.com/c/1444251Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Eric Karl authored
During teardown of GPU channels, several GLContextVirtuals may be made current and released in a row. This change makes two tweaks to avoid excessive calls to Release/MakeCurrent which were leading to hangs on ARM: - When we call ReleaseCurrent on GLContextVirtual, only release the real GL context if: a) We are releasing a real surface (need to release to clean up surface). b) We are the last virtual owner of the GL context (we need to release before final destruction of real context). - When we call SetCurrent(nullptr) on GLContext, only clear the surface / GL API if we are the real context. During normal operation GLContextVirtual always calls through the real context in ReleaseCurrent. During destruction, both will be called. Change-Id: I1db94a38943ba8df41d656b7302b026f8a885ded Reviewed-on: https://chromium-review.googlesource.com/c/1437704Reviewed-by:Antoine Labour <piman@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#628386}
-
ssid authored
The mojo message handlers are always grouped together as tasks posted by "Notify" function. To identify the root cause, add a trace event using the heap profiler tag. This only adds event to simple watcher, which seems most common. BUG=927206 Change-Id: Id17c1d6ad396c994242a5a2ab92ed1ff0df42d48 Reviewed-on: https://chromium-review.googlesource.com/c/1437727 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#628385}
-
Ian Clelland authored
This is a reland of ee0a6c8d Original change's description: > Create a virtual test suite for FeaturePolicyForSandbox > > Adds test expectations (marked with bugs) for the tests which are > currently identified as failing. > > Bug: 812381 > Change-Id: I768074cbb4dfb8447b8b809915732e2f7ce8e06c > Reviewed-on: https://chromium-review.googlesource.com/c/1440266 > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> > Commit-Queue: Ian Clelland <iclelland@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628053} New features: - Added expectations for the flakes identified by findit - Added additional expectations for flakes which match the other test suites in /http/tests/navigation and /http/tests/security Bug: 812381 Change-Id: I5848b116fbc894f87a4d5ffbcbb86ebc3cf360fb Reviewed-on: https://chromium-review.googlesource.com/c/1450036Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#628384}
-
Klaus Weidner authored
This folder is intended to contain a minimal set of small files needed to run automated tests. Currently this is just the cube-sea texture. For larger files, the intent is to use a local media folder for ad-hoc testing, or in the future use cloud storage via DEPS indirection. To save space, the image file is recompressed from the original PNG to WEBP using https://squoosh.app/ . (WebP format, effort 6, quality 75.) Bug: 923149 Change-Id: I18a89ab103a5670b49489bfe102e4a20a59a4138 Reviewed-on: https://chromium-review.googlesource.com/c/1448336Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#628383}
-
Stephen Martinis authored
Removes //infra/config/branch/cq.cfg. This has been replaced with //infra/config/global/commit-queue.cfg. Also updates presubmit checks to point to the new file. Bug: 926596 Change-Id: Iaff905119bb89bfad718a0e1376d9566777c4dc6 Reviewed-on: https://chromium-review.googlesource.com/c/1444702 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#628382}
-
jdoerrie authored
This change prepares //base for the upcoming switch of base::string16 to std::u16string. Bug: 911896 Change-Id: I01ca2d0c2634503438f4e9f3b18681d182555b40 Reviewed-on: https://chromium-review.googlesource.com/c/1437195 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Dan Elphick authored
Bug: v8:7283, v8:8562 Change-Id: I037bfb3818fdb9f92d5d9e0a8a71152ccdddade3 Reviewed-on: https://chromium-review.googlesource.com/c/1450255 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#628380}
-
Jeremy Roman authored
This code has been dead since https://chromium-review.googlesource.com/c/chromium/src/+/886442 Change-Id: I7865edc18ce2e4286df9bb8dc8d6b2320b20fa09 Reviewed-on: https://chromium-review.googlesource.com/c/1450046Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#628379}
-
Adithya Srinivasan authored
window.portalHost returns null in the portal browsing context after it has been activated. Bug: 914117 Change-Id: I2758d2bb29ad0381cff51f0c312fa88c3bacaed4 Reviewed-on: https://chromium-review.googlesource.com/c/1412792 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#628378}
-
khachatryan authored
Change-Id: I09aabce82101f84ab652f5f1aa85d8662a2265e7 Reviewed-on: https://chromium-review.googlesource.com/c/1450293Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#628377}
-
Miguel Casas authored
This CL removes |decode_using_client_picture_buffers_| and |use_reduced_number_of_allocations_| in favour of a new enum class BufferAllocationMode and associated member |buffer_allocation_mode_|, filled in a single place with verbose explanations as to why and the associated TODOs. No new functionality intended: this is purely a refactoring, hopefully leaving things clearer (but also prevents wrong uses e.g. |decode_using_client_picture_buffers_| and |use_reduced_number_of_allocations_| both true, which doesn't make sense but is hypothetically possible on ToT). Bug: 912295 Change-Id: I9b3be1cbc1314849e3693ce04196bece3b7f0ed2 Reviewed-on: https://chromium-review.googlesource.com/c/1443979 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#628376}
-
Carlos Caballero authored
Add a common interface for all tests, so that current tests can work with multiple SequenceManager backends (MockTaskRunner, MessagePump or MessageLoop) Change-Id: I6b37fe16483acf76102fa1b6b0882b9f91a0846a Reviewed-on: https://chromium-review.googlesource.com/c/1448177 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#628375}
-
Sebastien Lalancette authored
Splitting FormEventLogger implementation so that we have specialized types depending on what we're logging for (credit cards VS addresses). This allows us to get rid of is_for_credit_card_ state variable and conditions that were using it, which inherently makes the implementation more reusable for new form types in the future. Updated the unit tests (autofill_manager and autofill_metrics). Bug: 922620 Change-Id: I0971992d3c37f921fcfe32ee9666094e0ca98b4b Reviewed-on: https://chromium-review.googlesource.com/c/1430582Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#628374}
-
Sergio Villar Senin authored
The FamilyInfoFetcher was creating an AccessTokenFetcher to fetch access tokens for the primary account, and observing IdentityManager to determine when a refresh token is available for the primary account. That's exactly the use case PrimaryAccountAccessTokenFetcher was designed for. Bug: 920965 Change-Id: Iea6f47d64f2d4df170d023708ed7d3c8974caedb Reviewed-on: https://chromium-review.googlesource.com/c/1421923 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#628373}
-
Dan Elphick authored
Fixes use of deprecated Object::Get/Set V8 functions in content::GetOrCreateChromeObject by instead using the Context version and checking the return values. Bug: v8:7283, v8:8562 Change-Id: I16b147ec9f642a744b77516cf228fbd0a78f1bc3 Reviewed-on: https://chromium-review.googlesource.com/c/1447718Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#628372}
-
Etienne Pierre-doray authored
Update MayBlock timing params default values to prepare for the new scheduler configuration (blocking/non-blocking pools merged). MayBlockThresholdMicroseconds = 1000ms BlockedWorkersPollMicroseconds = 1200ms Bug: 874080 Change-Id: Icb50d1bff4062b4f823efd8701824ca469b75aa2 Reviewed-on: https://chromium-review.googlesource.com/c/1447849 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#628371}
-
Wez authored
Bug: 927469 Change-Id: I48dd013314167d8f3f3d4c3d81ea6f41f76f7f3e Reviewed-on: https://chromium-review.googlesource.com/c/1449329Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#628370}
-
Lei Zhang authored
It currently works because ipc/ipc_message_utils.h is included in many places transitively, and it unnecessarily includes base/strings/stringprintf.h. Change-Id: I8d1a17805e23eb78b4c833798eedb00312c2ed7a Reviewed-on: https://chromium-review.googlesource.com/c/1449159Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#628369}
-
Sylvain Defresne authored
Convert client of the deprecated of PrefValueMap::SetValue taking a std::unique_ptr<base::Value> to the recommended override taking a base::Value directly. The conversion is done using the following rules: - If the value is built inline using std::make_unique<base::Value> then change to just construct a base::Value directly, - If the value is built use base::Value::CreateDeepCopy(), then change to use base::Clone() which returns a base::Value instead of a std::unique_ptr<base::Value>, - If the std::unique_ptr<base::Value> is just forwarded by the caller, dcheck it is not null (the check was present in the old method implementation) and use base::Value::FromUniquePtrValue to convert the std::unique_ptr<base::Value> to a base::Value. This CL fixes uses in src/chrome/browser/chromeos/policy. This CL was uploaded by git cl split. Bug: 646113 Change-Id: I61564e348b5b52426bc6724c7a25cfdb211366cd Reviewed-on: https://chromium-review.googlesource.com/c/1446226Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#628368}
-
Nikita Podguzov authored
Bug: 814364 Change-Id: Ifc86ebbdba86868b8eca4ad3003fd3e71776c317 Reviewed-on: https://chromium-review.googlesource.com/c/1449664Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#628367}
-
Emircan Uysaler authored
This CL adds cases to allow for getDisplayMedia({video:true, audio:true}) calls. - Remove the earlier checks in blink that adds exceptions for audio requests. - Reject audio-only requests. - Set up UserMediaRequest appropriately and allow for settings in MediaStreamManager. - Add a FakeUI case to create a dummy AudioDevice. - Add unit tests and layout tests. Bug: 896333 Change-Id: I627c8ce84d752528430c4d46c0c5f472b39706d1 Reviewed-on: https://chromium-review.googlesource.com/c/1444353Reviewed-by:Guido Urdaneta <guidou@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#628366}
-
Xiaoqian Dai authored
Previously we have additional 5px on each side of the divider bar to recevie events. And now we change it to 8px. Bug: 927480 Change-Id: I9992403d892b990205f81908b9c12710dd1b0682 Reviewed-on: https://chromium-review.googlesource.com/c/1448614Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#628365}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ife7cb243b2755881bed80bd06b296a1ea7dce9d1 Reviewed-on: https://chromium-review.googlesource.com/c/1450152Reviewed-by:
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=eroman@chromium.org Bug: 925652 Change-Id: Ib20c05019d6dfefd9b8ff2d455a119f2522fc593 Reviewed-on: https://chromium-review.googlesource.com/c/1438286 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#628363}
-
Xiaoqian Dai authored
Please see the bug for the full crash stack. From the callstack, it seems the crash only happened when the system shut down while overview is open. I can't repro it locally though. Bug: 926851 Change-Id: I81b222d7cfc1a16c962c2a9a142a411f2f62b751 Reviewed-on: https://chromium-review.googlesource.com/c/1448997Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#628362}
-
Francois Doray authored
Adding answer to question asked at https://groups.google.com/a/chromium.org/d/msg/scheduler-dev/Lzcyq8FpL_c/cNk4uKeFGAAJ so that more people can find it. TBR=gab@chromium.org Change-Id: I3bd04d6fa9cb368288509002a78b98619715849d Reviewed-on: https://chromium-review.googlesource.com/c/1448693Reviewed-by:
-
Nico Weber authored
TBR=katie Bug: 927713 Change-Id: I63ef2a6f8028c721c84f2e5a00a7f8d31f64c9cd Reviewed-on: https://chromium-review.googlesource.com/c/1450234Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#628360}
-
Parastoo Geranmayeh authored
All valid profiles come before invalid ones. The frecency is used in case of tie. Bug: 899255 Change-Id: Ica7b02a95050d6ffde0fce85191166e629973aeb Reviewed-on: https://chromium-review.googlesource.com/c/1446866Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#628359}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=skyostil@chromium.org Bug: 925652 Change-Id: I431c98afc499d1d4375a520dcfc9633ad612a133 Reviewed-on: https://chromium-review.googlesource.com/c/1437800 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
-
jdoerrie authored
This change replaces PasswordFormMetricsRecorder's SetUserAction with a ComputeUserAction API. This allows for removing duplicated code between the old and new PasswordFormManager and fixes issues with metrics recording, when both versions of the form manager are active at the same time. Bug: 926902 Change-Id: I61373e88d8349fb2e52a5d89ca7b4ec6eda7a305 Reviewed-on: https://chromium-review.googlesource.com/c/1448188Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#628357}
-
Marc Treib authored
The enum had two possible values, PLAIN_TEXT and WITH_HTML, to control the style of the resulting output labels. However, WITH_HTML was only used in a case where the labels are ignored. Bug: 911153 Change-Id: I125006307dbe85954eab585ee50798c1da58467c Reviewed-on: https://chromium-review.googlesource.com/c/1449665Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#628356}
-
Fredrik Söderquist authored
TBR=eae@chromium.org Bug: 767352, 890543 Change-Id: I6202d0ba5b71baac213c24f18c388e5845e7348f Reviewed-on: https://chromium-review.googlesource.com/c/1450191 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#628355}
-
Joanmarie Diggs authored
The 'address' element was being treated as a landmark (contentinfo); it should instead be treated as a generic container. Update blink and the tests accordingly. Bug: 873118 Change-Id: I5baf1b7f5e9a94b3f9a1ef75d4ee14e3e7351567 Reviewed-on: https://chromium-review.googlesource.com/c/1448739Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Joanmarie Diggs <joanmarie.diggs@gmail.com> Cr-Commit-Position: refs/heads/master@{#628354}
-
edchin authored
TopAlignedImageView was previously only used in TabGrid. It will now also be used when adding a black/white placeholder when a tab is evicted. This CL moves the files so that it can be imported by another directory in the future. Change-Id: Idb7692f95192befafc2d0cdb0966df800a10fddc Reviewed-on: https://chromium-review.googlesource.com/c/1448520Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#628353}
-
Sylvain Defresne authored
Some tests needs to access AccountFetcherService in order to enable network fetches (as this is a pre-requisite for AccountTrackerService to send notification). As a first step toward removing those calls, IdentityTestEnvironment needs to have access to the AccountFetcherService. Update the helper API to either create or take the AccountFetcherService. Bug: 908840 Change-Id: Ib251dfc47f6390635a44eddf0fa6bfe4532e547e Reviewed-on: https://chromium-review.googlesource.com/c/1448185 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
