- 04 Feb, 2020 40 commits
-
-
Charlie Hu authored
Bug: 993790 Change-Id: Ic72e0475d6c9ea35d23fcb612d9452fcba1c8835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032164Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#738274}
-
Michael Thiessen authored
Replaces usages of java.net.URI with GURL. This change is slightly complicated as GURL and URI handle about: URLs differently, in that GURL considers everything after the about: scheme as a path instead of a host/path/etc. This is usually handled in the native code by running FixupUrl on URLs with the about: scheme to convert them into the chrome: scheme (unless they're about:blank or about:srcdoc), and this is how navigation to about:newtab works (by converting it to chrome://newtab). So in order to know if something will resolve to the NTP, we need to first fixup the URL, and then check its host/validity. Bug: 783819 Change-Id: Idf6ad46fa6ef9793a969f3a8ee721c9bb05b97a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031710 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#738273}
-
Francois Doray authored
With this CL, PageNode::IsLoading() transitions to true when data is received for a top-level navigation to a different document. It transitions to false when the page reaches an "almost idle" state, based on CPU and network quiescence, or after an absolute timeout. This definition of "loading" is considered better to drive policies, as it indicates when the page stops doing work after a navigation, rather than when the page is loading resources (it may still have a lot of Javascript to run to present useful content to the user). Change-Id: I4fc5b277933133229fde7585d6710f63e6b8244d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015820 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#738272}
-
Regan Hsu authored
"moveUp" and "moveDown" keys currently have the incorrect values, IDS_SETTINGS_LANGUAGES_LANGUAGES_ADD, and IDS_SETTINGS_LANGUAGES_LANGUAGES_LIST_ORDERING_INSTRUCTIONS respectively. This CL corrects those values to IDS_SETTINGS_LANGUAGES_LANGUAGES_LIST_MOVE_UP and IDS_SETTINGS_LANGUAGES_LANGUAGES_LIST_MOVE_DOWN respectively. Bug: 1048562 Change-Id: I115cffac1828ac068fee0260653d94b5da2a4ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036800Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738271}
-
Austin Eng authored
TBR=kbr@chromium.org Bug: 1026588 Change-Id: I6563d489eaa3ea91879e0810f8373b721e1fa75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036541Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#738270}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 182 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-08-02. Change-Id: I5abbcfcdfe89f4efdd3663b7163084d93a427216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037590 Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#738269}
-
Michael Thiessen authored
Also adds unit tests for the UrlFormatter java wrapper which didn't previously exist. Bug: 783819 Change-Id: Ib98bd5daa64a48bb06d6593185f53f49ad22b3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036730 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#738268}
-
Sam Bowen authored
Bug: 1044249 Change-Id: I163919382fd8d40a2355a8da71d72db68018e131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023864Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#738267}
-
Saman Sami authored
Add base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope to all methods in DrmThreadProxy that block. Fixed: 1047827 Change-Id: I0ff3239d85264244dd6f5a0098ee18daa3c4960e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033633 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#738266}
-
Natalie Chouinard authored
An empty public constructor should be kept for all Fragments, not just those in Settings. This change also allows us to move settings code alongside respective feature code (see bug). Bug: 1047357 Change-Id: I9e776766be4a693622150b58db5e057447118fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036872 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#738265}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/1cc95ac07c17d61bea601832bbdc1f8d13d313db..bc7e2cb92d948de5f437e5eef2b1c3ad6281bb35 Bug: none Change-Id: Iedfd6ebcd581f76c1794b3eddad2d46b701681e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028292 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#738264}
-
Lijin Shen authored
The tests are flaky on Android K & L. It shows the ntp is scrolled down on launching the activity, but the reason has not been figured out. Launching activity on blank page can prevent the startpage from being scrolled down. Bug: 1046317, 1046316, 1045729, 1045415 Change-Id: I1d14f15218ad8a1e1ceac9c0a7bbfc1d49008700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028212Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#738263}
-
Sammie Quon authored
Replaces the old three view setup which was used before we could apply rounded corners directly on layers. Tested manually on LTR and RTL on all 4 orientations. Visually no difference. Ran ui.OverviewDragWindowPerf.drag_to_snap. Not noticeable improvements on caroline, but input latency goes from 95ms to 80ms on krane. Test: added tests Bug: 1047778 Change-Id: Idff6345fb5778d2e898bc51cd76bd7eac3c1741d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033564 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#738262}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/11cc3e8ebc7e..00a610e6768c git log 11cc3e8ebc7e..00a610e6768c --date=short --first-parent --format='%ad %ae %s' 2020-02-04 tvanderlippe@chromium.org Add console uncaught promises e2etest 2020-02-04 tvanderlippe@chromium.org Add console BigInt e2etest Created with: gclient setdep -r src/third_party/devtools-frontend/src@00a610e6768c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1047671 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9636eebb47752d04bc4275160b5cbc7a2c7cd20c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037428Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738261}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d7e04a27. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm drott@chromium.org: external/wpt/css/css-text-decor foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure kojii@chromium.org: external/wpt/css/css-scoping rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I0620a3e84cd0f6a301f9d69a11bd5b0fbb4dbe98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037386Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738260}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ebf2bec1675c..2e4a40aa1bf4 git log ebf2bec1675c..2e4a40aa1bf4 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 ntfschr@chromium.org Devil: throw if app is not installed Created with: gclient setdep -r src/third_party/catapult@2e4a40aa1bf4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1047845 Tbr: rmhasan@google.com Change-Id: Ic40a666f469a4172508c2b3392eaca10f3bc6aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037418Reviewed-by:
-
Kyle Horimoto authored
Change-Id: I83b63ec5e2c94535b6b1a9a67bc0c36cb4fa6de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037322 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#738258}
-
Nate Fischer authored
This uses a public URL for the "URL:" field in the README. Apparently this is the URL which is shown by chrome://credits/ for Chrome on all platforms, so it's not helpful to link to "go/ab." This expands the README text to point to the internal guidelines for updating this dependency, which should already be more helpful than pointing at go/ab directly. Bug: 1045626 Test: tools/licenses.py scan | grep 'android_system_sdk' Test: build chrome, navigate to chrome://credits, click "homepage" link Change-Id: Id2e34ffb52dbe8e0f64c3f50ea653f9133a35871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036969 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#738257}
-
Raul Tambre authored
Since the file is now written in binary mode, newline translation is no longer a concern and is consistent across platforms. [14/39932] ACTION //chrome/browser/resources/settings:modulize(//build/toolchain/win:win_clang_x64) Traceback (most recent call last): File "../../ui/webui/resources/tools/js_modulizer.py", line 154, in <module> main(sys.argv[1:]) File "../../ui/webui/resources/tools/js_modulizer.py", line 150, in main ProcessFile(os.path.join(in_folder, f), out_folder, namespace_rewrites) File "../../ui/webui/resources/tools/js_modulizer.py", line 128, in ProcessFile f.write(unicode(l, 'utf-8')) NameError: name 'unicode' is not defined Bug: 941669 Change-Id: I7aa0aa834944e4505f9045026e3d32315740140b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033509 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#738256}
-
Avery Musbach authored
When you drag a window from the shelf and drop into overview, it shall be positioned correctly and stacked correctly. Test: ash_unittests DragWindowFromShelfControllerTest.DropsIntoOverviewAtCorrectPosition Change-Id: I198084bfe644c70de00d6824623106dff1776f63 Fixed: 1047821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032797Reviewed-by:
-
inglorion authored
This adds linker wrappers that will cause ThinLTO builds to distribute code generation using Goma. This commit only checks in the wrappers; it does not enable them. R=hans,gbiv,rnk,thakis Bug: 877722 Change-Id: I9ed766f3cf094a1591eceb4933e00d005e739c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008005 Commit-Queue: Bob Haarman <inglorion@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#738254}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3a1145d2eb00..755ff85d1885 Created with: gclient setdep -r src-internal@755ff85d1885 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1048655 Tbr: jbudorick@google.com Change-Id: I43a39e4f8737148bf99d54fb5cf6f4b7502f9213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037429Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738253}
-
Himanshu Jaju authored
Tracks the result of receiving a SharingMessage via WebRTC. Logs the result to UMA. Bug: 1021984 Change-Id: I89a87e249204bd8421ef03165f2ad23c361a0af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036001Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#738252}
-
Nicolas Ouellet-Payeur authored
This is a reland of c2b90515 TBR=rhalavati@chromium.org Original change's description: > [Traffic Annotation] Fail on CQ on C++ parsing error > > Previously, CQ would pass if extractor.py failed at parsing the C++ > declaration. With this CL, parsing errors make CQ turn red (to avoid > committing code that will make linux-annotator-rel fail). > > Also, always rerun extractor.py when there's an error to get stderr > contents. Previously, when running with --error-resilient, it wouldn't > re-run the Clang tool. This saved several minutes on CQ, but didn't > report a useful error message. Since extractor.py is _much_ faster, > the tradeoff is different: the error message is more important than > the couple of seconds saved. > > Finally: slightly improve extractor.py's error reporting when it fails > to parse the annotation declaration. This makes it more actionable and > gives better context to the CL author. > > TESTED=traffic_annotation_auditor_unittests, extractor_test.py, > annotation_tokenizer_test.py > > Bug: 1046794 > Change-Id: Id397dcfcced39fbebf72ffcdc6d6549c66c2910f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028707 > Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737039} Bug: 1046794 Change-Id: Ia7672de311a2ab32bf7d45d7f379e60a96e92d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036794 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#738251}
-
Owen Min authored
CloudReporting observers ProfileManager and few KeyedServices. It needs to be turned down before Profile system so that these observers can be removed properly. Adding a browser test to verify the issue which waits until cloud reporting fully launched and shutdown. Bug: 1047619, 1047886 Change-Id: I28620dd0f8265bb10c4139eb24bad24dcaf94ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033435Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#738250}
-
Xing Liu authored
This CL adds a few missing deps for announcement notification system. Currently there is no build failure. Check command: gn check out/Debug //chrome/browser/updates/announcement_notification Refactor that requires large code change needs to be merged after M81. Bug: 1048346 Change-Id: I7f262d646c618841614a35e5f7962becb662c3f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036915Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#738249}
-
Mohsen Izadi authored
CompositorFrameReporterTest.SubmittedDroppedFrameReportingTest calls DroppedFrame() explicitly and then terminates reporter with kPresentedFrame status. This is not what happens in production code. We just need to terminate frame with kDidNotPresentedFrame or kReplacedByNewReporter and it will take care of reporting a dropped frame. Bug: None Change-Id: I43059f31e77ec14818b856e51d24e7ea7a6c4545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037340Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#738248}
-
Daniel Cheng authored
base::Hash() is deprecated and is being replaced by base::FastHash(). The output of base::FastHash() is only fixed within the lifetime of a single process, so if the code depends on the mapping of inputs to hash outputs not changing over time, base::PersistentHash() must be used instead. Bug: 1025358 Change-Id: I88f09613aa5b099517de6079f857fbf0f6d1d50f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954453Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#738247}
-
Elly Fong-Jones authored
Before r723559 the logic was basically: if (action && (action->is_browser || action->is_page)) return !action->synthesized; if (HasOmniboxKeyword()) return true; return false; But the new logic was: if (!action) return false; if (action->is_browser || action->is_page) return !action->synthesized; return HasOmniboxKeyword(); which behaves differently when HasOmniboxKeyword() && !action: in the pre-r723559 logic that would return true but in the post-r723559 logic it returned false. This is repaired here by rewriting this function. Bug: 1047819 Change-Id: I86551a2c89ff39eedc0b9c29dcad7db50c006f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033988Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#738246}
-
Nikita Podguzov authored
Bug: 996785 Change-Id: Id013b35f0b113ef039db42980dc55d5c892035f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007280Reviewed-by:
-
Alex Chau authored
- To avoid exponential increase of metrics, only added suffix to SendMessageResult, SendAckMessageResult and MessageAckTime Bug: 1021984 Change-Id: Ia39d8410e338d58066c91e2dbdc689f65ca693f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036050Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#738244}
-
Chris Cunningham authored
Adds a test to confirm that supported=false when the provided keySystemConfig is unsupported. Ensures that the keySystemConfig is unsupported by using a bogus keysystem name. No bug; test passes. Just adding coverage. Change-Id: I9d47ab59246bc29766ae5f60903e855517fad5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035633 Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#738243}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie58d9ad6eb9b6ec18991cd125c9d90431b21f0e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037417Reviewed-by:
-
Weiliang Chen authored
If we don't have a on gpu processor set up for overlay processor on android, we don't need to clear the locks. R=rjkroege Bug: 1048041 Change-Id: Iea599d77c0a811a288760696eccf6bdbcb4743e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037313Reviewed-by:
-
Hirokazu Honda authored
Bug: 1026522 Test: Play Gav1VideoDecoder for an hour Change-Id: Ied41960243364ec3eea05fc2d7bde4fc945004c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037273 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Etienne Bergeron authored
Since Skia is used for rendering in the BrowserTest, a font should be backed by a SkTypeface. That was not the case previously since the class RenderTextMac was still used. RenderTextMac got removed here: https://chromium-review.googlesource.com/c/chromium/src/+/1902193 Bug: 1026735 Change-Id: I23a3c4b6b0d5a36304e81e0251dc0e55f6836f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028213 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#738239}
-
Jiaqi Han authored
In line with the removal of ENABLE_CAST_WAYLAND_SERVER buildflag. This reverts commit 663bb259. Bug: 1043215 Test: CQ Change-Id: I6840eaf5423d49c7d5c96f275b3461d367702146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006470Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Jiaqi Han <jiaqih@google.com> Cr-Commit-Position: refs/heads/master@{#738238}
-
Shimi Zhang authored
The usage of sResourceCache had been removed in https://codereview.chromium.org/1270793002 long time ago, but the member variable is still there, it should be removed as well. Since now there is only one ID in this class, modify the comments accordingly. Bug: None Change-Id: I58443bb6d9200ce8970d0745a110cb80a707a12a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036810Reviewed-by:
-
Marc Treib authored
TBR=ccameron@chromium.org Bug: 1048149 Change-Id: I3f2e4cde50d8786f55dbad776216deac4f4c5106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036102Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#738236}
-
Ilia Samsonov authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/306f3754a71d..10b1902d893e $ git log 306f3754a..10b1902d8 --date=short --no-merges --format='%ad %ae %s' 2020-01-21 absl-team Googletest export 2020-01-17 absl-team Googletest export 2020-01-16 absl-team Googletest export 2020-01-15 absl-team Googletest export 2020-01-15 absl-team Googletest export 2020-01-14 absl-team Googletest export 2020-01-14 absl-team Googletest export 2020-01-14 absl-team Googletest export 2020-01-10 absl-team Googletest export 2020-01-15 36923279+ivan1993br Remove exclusion of *-main and*-all targets 2020-01-12 hilmanbeyri Use IsReadableTypeName IsReadableTypeName in OfType function in gmock-matchers_test.cc 2020-01-12 hilmanbeyri fix unit test failure on NoShortCircuitOnFailure and DetectsFlakyShortCircuit when GTEST_HAS_RTTI is 1 2020-01-09 absl-team Googletest export 2020-01-09 absl-team Googletest export 2020-01-07 absl-team Googletest export 2020-01-07 absl-team Googletest export Created with: roll-dep src/third_party/googletest/src This CL uses the internal placeholder GTEST_CUSTOM_TEMPDIR_FUNCTION_ to use an available path for temp directory. Change-Id: I9ca9bd1d599d9737a228b43e50b5caadfff5229c Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel,mac_optional_gpu_tests_rel Change-Id: I9ca9bd1d599d9737a228b43e50b5caadfff5229c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023674Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#738235}
-
