- 09 Nov, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0e30faf062f7..9eff30af501c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iabcd8f8f844f347654132403267a9250e68c30c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526505Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825340}
-
Tanmoy Mollik authored
The sign in API uses CoreAccountInfo. So in the long run its better to use CoreAccountInfo for helper methods that interact with sign in API. This cl refactors SyncTestRule so that the methods to add account and toggle sync states return CoreAccountInfo. Bug: 1135510, 1117006 Change-Id: I333f9dd87b093d781311a7ee286c04f274ee13ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523112 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#825339}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9eff30af501c..0bec1380d03d 2020-11-09 taylori@google.com Merge "perfetto-ui: Keep slice selection on marking" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9d8513906420fe39cc95f155b6234a2f9867a153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526724Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825338}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/46f5f4386f7c..40c5e53e7bba 2020-11-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 612ded0654a0 to 4ed9d3498dcf (2 revisions) 2020-11-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 87451c55aa8b to 670ffea9d61b (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I1eb8377811385e944baa215c84f67a70694dbe22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526368Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825337}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f2eb30ce3c37..ec45b51785af 2020-11-09 aerotwist@chromium.org Prevent resizing of Vitals lane 2020-11-09 janscheffler@chromium.org [WebAuthn] Fix focus on Authenticator name 2020-11-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-09 sigurds@chromium.org Also remember empty field in Application > Storage 2020-11-09 szuend@chromium.org TypeScript-ify profiler/ProfilesPanel.js 2020-11-09 changhaohan@chromium.org Avoid re-defining custom elements: CSSAngleEditor, CSSAngleSwatch 2020-11-09 sigurds@chromium.org Allow extra text in FrameDetailsView to get wrapped If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1057090,chromium:1146936,chromium:1146985 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9f8422c69abc9b1e6965ad7e8a29af812e9046f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526721Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825336}
-
Dominique Fauteux-Chapleau authored
This adds the ruleId field in triggered rules for DLP events, which seems to have been omitted by mistake. Change-Id: I468704163e49c1853ea4ba8b7f5432ddc53f933f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521244Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#825335}
-
Gyuyoung Kim authored
This CL replaces all uses of blink::Manifest::ShareTarget::Enctype with blink::mojom::ManifestShareTarget_Enctype in order to reduce type conversion between them. Bug: 919392 Change-Id: Ifc173da74d8679f00cf4bb39e4c05ef5b1103fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522832 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#825334}
-
Colin Blundell authored
This patch extends WebLayer to package and index the subresource filter's unindexed ruleset data that is currently pulled into the tree at gclient sync. To do so it does the following: - Packages that data and its manifest as compressed resources in the app - Has WebLayer kick off indexing as part of startup, using the subresource filter component's recently-added ability to read the unindexed ruleset data from a resource in the ResourceBundle and obtaining the version of the data from the manifest We note the following: - The compressed unindexed data is ~70 KB. The uncompressed data is ~300 KB. Both of these will slowly grow over time. - RulesetService short-circuits out of indexing the data if the content version has not changed from that of the last-indexed version (saved in prefs), so this operation will have an impact on startup only when the unindexed ruleset data changes (which will happen at maximum only once with every weblayer app update, and in practice presumably less often than that). Nonetheless, to limit impact on startup in that case we post the indexing as a BEST_EFFORT task from the startup flow. BEST_EFFORT tasks are guaranteed to executee in a reasonable delay assuming that the app isn't closed. At this point in time Chrome is continuing to use the component updater; using of the in-tree subresource filter data is done *only* by WebLayer. Bug: 1116095 Binary-Size: 40K increase due to packaging compressed ruleset data Change-Id: Ifeffd6d8fcd223a9783020a97e246dafc69c4276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469562Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#825333}
-
Nick Diego Yamane authored
This CL extracts the drag icon surface class from DragDropOperation. It can be null and there is no need to create a SurfaceTreeHost for it in such case. This is not possible currently, because DragDropOperation inherits from SurfaceTreeHost. This CL extracts it into an internal class and uses composition (instead of inheritance) to create the IconSurface only when needed. This patch does not cause behavioral changes. Bug: 1102946 Change-Id: If7497cbe436ef8bdb5fb3a80a184c5ac136732db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311127 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#825332}
-
arthursonzogni authored
This struct was content/public exposed and included by many. This was unused, so it shouldn't be exposed at all. I also need to mojoify DidCommitProvisionalLoadParams and this was its parent struct. Squashing it into its unique child struct helps. R=nasko@chromium.org,blundell@chromium.org Bug: 1145888 Change-Id: I1d6d7035389b25b22bf8393a1e8b87b5773919ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522079Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#825331}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b01fdf67..63061fa2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib1d0fe861b818daa62fec93421d07f06b3cd2491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526502Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825330}
-
Guido Urdaneta authored
This reverts commit 8bd07a6c. Reason for revert: This revert was incorrect and breaks the build. Original change's description: > Revert "Move base/test/bind_test_util.h to base/test/bind.h" > > This reverts commit a4493a6f. > > Reason for revert: This CL breaks internal builds (e.g. /chrome/browser/media/kaleidoscope/internal/kaleidoscope_browsertest.cc). > > Original change's description: > > Move base/test/bind_test_util.h to base/test/bind.h > > > > Stop relying on us to remember arcane file names when writing tests, > > and repeating the directory hierarchy into the file name. > > > > R=dcheng@chromium.org > > TBR= > > NOPRESUBMIT=true > > > > Change-Id: I49c951162939c7dcef44883bee740f94b2f49e09 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523099 > > Commit-Queue: danakj <danakj@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#825145} > > TBR=danakj@chromium.org,dcheng@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: If165b8443662baa564895e994ea0d772348e6da6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526102 > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825328} TBR=danakj@chromium.org,dcheng@chromium.org,antrim@chromium.org # Not skipping CQ checks because this is a reland. NOPRESUBMIT=true NOTREECHECK=true No-Try: True Change-Id: I6a8c0c8bbb1c8f87cc7f2df7a8b3388971292975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526683 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#825329}
-
Denis Kuznetsov [CET] authored
This reverts commit a4493a6f. Reason for revert: This CL breaks internal builds (e.g. /chrome/browser/media/kaleidoscope/internal/kaleidoscope_browsertest.cc). Original change's description: > Move base/test/bind_test_util.h to base/test/bind.h > > Stop relying on us to remember arcane file names when writing tests, > and repeating the directory hierarchy into the file name. > > R=dcheng@chromium.org > TBR= > NOPRESUBMIT=true > > Change-Id: I49c951162939c7dcef44883bee740f94b2f49e09 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523099 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825145} TBR=danakj@chromium.org,dcheng@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: If165b8443662baa564895e994ea0d772348e6da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526102Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#825328}
-
Fabian Sommer authored
Users who log in with a security token (smart card) can be required to keep their smart card inserted at all times. If they remove their smart card, they are logged out or the session will be locked. This behavior is controlled by two policies SecurityTokenSessionBehavior and SecurityTokenSessionNotificationSeconds. This CL adds UI for this: A notification that informs the user they are about to be logged out unless they re-insert their smart card. The UI will be wired up with the controller for this behavior in a follow-up CL. Bug: 1131450 Change-Id: Ifc16c5720ab8da4b5a1678db6d06ed8ce321dc57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480082Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#825327}
-
Rakina Zata Amni authored
We should queue all the data read from bytes_consumer_ and send them later when the ResponseBodyLoader resumes. This is needed to support handling network requests while a page is in the back-forward cache. Note that other sources of data (that will call DidReceiveData) are out of scope and will trigger bfcache eviction. See doc: https://docs.google.com/document/d/1KmiwSOD3Kr3Etjrl8xqMra3QrL7s4Rl7EQJ5s1Wxc0Y/edit# Bug: 1137682 Change-Id: Iaef4bdea95392bf8ef0a8885bc6774c3e85d4fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519347 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#825326}
-
Danila Kuzmin authored
When the weak PIN is allowed, we don't need to show the warning message to user. But when the policy is unset we still show it. Bug: b/168498866 Change-Id: I56571851ca43144b2e05f31978814d0b9c384b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490040Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#825325}
-
Matt Jones authored
Bug: 1070281 Change-Id: I19100a2ab284f430ce50247bb62e85352fb8343f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521283 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#825324}
-
Wojciech Dzierżanowski authored
Follow up on https://chromium-review.googlesource.com/c/chromium/src/+/2470525 by moving the remaining fullscreen tests to PictureInPictureContentBrowserTest. The focus is on the video element state transitions rather than the PiP UI. This also improves testing stability: Even though these tests are not marked as flaky, they do fail from time to time when run locally. Last but not least, fullscreen as implemented in Content Shell is less obtrusive than Chrome's full-fledged fullscreen when running tests, so this improves the developer's experience. Bug: 1138168 Change-Id: I51adf3541f8a8ab74ac0f7259e29efaa024b14ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511252 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#825323}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9290b6b5. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I1311638bdd29b180595a3493d199a0065cfc639f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526201Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825322}
-
Jan Wilken Dörrie authored
This change adds a PasswordGenerationType parameter to PasswordManagerClient::GeneratePassword(). This allows to track the type of the generation more precisely and fixes a bug in metrics recording where automatic generation was logged as manual instead when existing credentials were present. TBR=dcheng Bug: 846694, 918846 Change-Id: I06a065926a1f4dc94fd72b3b96199c799587a9b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520998 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#825321}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0e30faf062f7..9eff30af501c 2020-11-09 lalitm@google.com Merge "Handle erroneous cases in Frame lifecycle phases" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib3912dbb84822c043ce9090d17ce10f3323c634c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526374Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825320}
-
Denis Kuznetsov authored
This CL removes supervised users-specific Authenticator and UserFlow classes, to simplify further work on refining LoginDisplayHost APIs. TBR=treib@chromium.org Bug: 866790 Change-Id: I151e2d273ba57fac989b1fcd87923d30f9851cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517440Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#825319}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e42e853638c4..f2eb30ce3c37 2020-11-09 karntino.c.areros@gmail.com Prevent auto-adding 'px' within CSS calc() 2020-11-09 changhaohan@chromium.org Refactor CSSAngle for more modularity 2020-11-09 jacktfranklin@chromium.org Change component custom events to kebab case 2020-11-09 aerotwist@chromium.org [unit test] Import more of front_end/sources 2020-11-09 sigurds@chromium.org Remove enclosingNodeOrSelfWithNodeName from Node's prototype 2020-11-09 alexrudenko@chromium.org Add align-items: center icon 2020-11-09 sigurds@chromium.org Expose COEP info for dedicated workers in frame tree 2020-11-09 sigurds@chromium.org Display description in console.table if preview is not available. 2020-11-09 szuend@chromium.org Convert MarkdownIssueDescription.js to TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1051466,chromium:1057090,chromium:1126178,chromium:1139945,chromium:1145972 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9815fd5b03e658909f378868737f25cd1793d15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526366Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825318}
-
Nohemi Fernandez authored
This patch gives us the ability to switch between infobar titles, either with "Sign in as [fullname]" or "Sign in to Chrome", depending on final UX decisions. Bug: 1145592 Change-Id: Ifba41e4aa025ec51d80e76ec79015ace375be103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526061 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#825317}
-
Ilya Nikolaevskiy authored
This CL makes all the relevant tracks/capturers to return a feedback callback upon connection to the source or starting the capture. The call chain results in VideoCaptureImpl method being plumbed to the client as a callback. This is the first step for removing VideoFrameFeedback from the media::VideoFrame. Follow-up CLs will introduce the callbacks to mirroring service (which is a second user of feedback mechanism) and would remove VideoFrameFeedback member from media::VideoFrame. Bug: chromium:1134073 Change-Id: I61dfc8449e69ad53f3fc6610d8cfbf4cdb6e4441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489644 Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#825316}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I135b5c7b7d8852cf66364762987840d69adc7d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526480Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#825315}
-
Denis Kuznetsov authored
Bug: 1144159 Change-Id: Iaaf65a1b3b228155344aaeb316f1682591496730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519973 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825314}
-
Alexander Lapshenkov authored
Use explicit scope qualification in alias declaration. Error example: -c ../../ui/accessibility/platform/inspect/tree_formatter.cc -o obj/ui/accessibility/platform/platform/tree_formatter.o In file included from ../../ui/accessibility/platform/inspect/tree_formatter.cc:5: ../../ui/accessibility/platform/inspect/tree_formatter.h:26:40: error: declaration of ‘using AXTreeSelector = struct ui::AXTreeSelector’ [-fpermissive] using AXTreeSelector = AXTreeSelector; Bug: 819294 Change-Id: Ic604b34def922d5f6e9f5181cb2052433282c6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524535Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#825313}
-
Viktor Semeniuk authored
This CL introduces Hash Affiliation Fetcher, that makes a request to Google endpoint to get the affiliations and groups for requested facets. Instead of sending facet URLs in a plain text it uses SHA-256 to compute a hash and eventually sends just a 16-bit short hash prefix represented by uint64_t. Bug: 1108279 Change-Id: I3a4b64c10bdd998dcf7081eec92d70b2431baef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440502 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#825312}
-
Christoph Schwering authored
This CL replaces the usage of the form's name (<form>'s name or id attribute) and Autofill::unique_name() in the refill logic with unique form renderer IDs, if the feature AutofillRefillWithRendererIds. Bug: 896689, 1114787 Change-Id: Ib21b838f9dc5f31ac30087e347d7e1b0171aff58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235600 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#825311}
-
arthursonzogni authored
They were differing for the 'ftps' scheme. This was handled by blink/, but not for url/. Chrome never supported the 'ftps', so I chose to remove it on one side instead of adding it on the other. There is a new fuzzer checking an origin stays SameOrigin with itself after a round trip inside blink: third_party/blink/renderer/platform/weborigin/security_origin_fuzzer.cc Bug: 888079 Change-Id: Idf8813e03449461c4d22d4f5ede662cb58ef185f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509754 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#825310}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/22679f90..b01fdf67 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I367a8892515e1e7eeb5772590ed9e4fd2e5f2a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525843Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825309}
-
Polina Bondarenko authored
BUG=none TEST=none Change-Id: I9d883019c615bb2319e9f7f1dc5d8e5e1dae8bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526063Reviewed-by:
Oleksandr Peletskyi <peletskyi@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#825308}
-
Eric Willigers authored
We implement a BlobReaderClient to receive the shared blob and store it as a file. Files are stored in a WebShare directory under CrosDisksClient GetArchiveMountPoint(). File shares larger than 50MB (kMaxSharedFileBytes) are rejected. Bug: 1110119, 1132202 Change-Id: Ia5eb134b1286ee73f3a95146c63156412cbf8c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522276 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#825307}
-
Nico Weber authored
Ran `./tools/clang/scripts/upload_revision.py 118c3f3cf268002d1356253bac3cf5300f054d43`. Bug: 1146453 Change-Id: I6c80be9ea8318a5da291eaa6c9ccf8b281e1b0e6 Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chromium/try:linux-chromeos-dbg Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:mac-arm64-rel,mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:win-asan,win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521253Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#825306}
-
Henrik Boström authored
This wires up the use of SampleBufferTransformer inside the capturer behind flags that are disabled by default. With this CL we only convert to NV12 (we never rescale). Note that NV12 -> NV12 triggers a fast-path that returns the input camera pixel buffer, so this does not cause a copy. Flags added: - InCaptureConvertToNv12: Configures the transformer optimally. This means pixel transfer when you have a pixel buffer, libyuv when you have an MJPEG sample buffer. - kInCaptureConvertToNv12WithPixelTransfer: Transform using pixel transfer. Used for testing, will not be shipped. - kInCaptureConvertToNv12WithLibyuv: Transform using libyuv. Used for testing, will not be shipped. There is currently an issue obtaining the color space of CVPixelBufferPool-created pixel buffers. Until this is resolved, we hardcode the color space to kColorSpaceRec709Apple which avoids color space parsing in all processes. Bug: chromium:1132299 Change-Id: I733ceebb50db0a337c542434ac9f146ba120732a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518978 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#825305}
-
Henrik Boström authored
This is a reland of be3eeb5b On "Mac ASan 64 Tests (1)", the assertion that the second pixel buffer's address will be identical to the first one does not hold. This assertion was unnecessary anyway, so it is removed. With this re-land, the IOSurface recycling uses EXPECT_EQ with IOSurfaceGetID() instead. Original change's description: > [macOS] PixelBufferPool: Test retaining IOSurface, not CVPixelBuffer. > > Pixel buffers originating from a CVPixelBufferPool are recycled when > no longer in use, previously only tested by releasing the last pixel > buffer reference and not touching the IOSurface. > > This CL tests what happens when we are retaining not references to the > pixel buffer, but references to a pixel buffer's IOSurface or > incrementing its use count. > > Outcome: > - Retaining references (base::ScopedCFTypeRef<IOSurfaceRef>) to an > IOSurface does NOT prevent recycling. > - Retaining use count (IOSurfaceIncrementUseCount) to an IOSurface DOES > prevent recycling. > > This behavior is now documented in pixel_buffer_pool_mac.h. > > Bug: chromium:1132299 > Change-Id: Ibdcd3752a4467bc495eba4b543ecd73da1b2f41f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520829 > Commit-Queue: Markus Handell <handellm@google.com> > Reviewed-by: Markus Handell <handellm@google.com> > Cr-Commit-Position: refs/heads/master@{#824814} TBR=handellm@google.com Bug: chromium:1132299 Change-Id: Ibe924d3f3ffaaca69262e9cd436c60d05e3ea2b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521623 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#825304}
-
Yifan Luo authored
`sanitize` as a DOMString to Fragment API need to go through Trusted Types. Bug: 1116418 Change-Id: Icf73ff9f7a8f115d0f9f6e32ae9673c7475691e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506046 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#825303}
-
Thiemo Nagel authored
I'm not working on this codebase anymore. Bug: none Change-Id: I8b677a6fe89cf0b53307fb787a3470d8408a3025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526101Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Auto-Submit: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#825302}
-
Koji Ishii authored
This reverts commit 2493e000. Reason for revert: Hit test regression at crbug.com/1146797 Original change's description: > Avoid falling back to legacy if |CanTraversePhysicalFragments| > > When painting and hit-testing NG fragments, > |NGBoxFragmentPainter| falls back to |LayoutObject| at the BFC > boundary, because we already have a logic in |LayoutObject| > to switch painters for NG and legacy. > > This patch changes to do so only when |!CanTraverse|, because > |LayoutObject| cannot handle block fragmented NG objects. > > This patch eliminates |CurrentFragment| from > |LayoutNGBlockFlowMixin::Paint| by making sure it is not block > fragmented. > > Also changes |HitTestChildBoxFragment| so that it can handle > atomically-painted objects in NG code path. Due to the change > in |FragmentRequiresLegacyFallback|, such objects go to NG > code path without going through |LayoutObject|. > > Bug: 1061423, 829028 > Change-Id: Ife31d6dcd209668a489243b1158112dac44fc273 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515429 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824316} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org,mstensho@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1146797, 1146935, 829028, 1061423 Change-Id: Id228899a56bbcdd118a860e8e73ecb18a9b0d96b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525882 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#825301}
-