GitLab

BUG=

Review URL: https://codereview.chromium.org/253723004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266692 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Breaks ash_unittests FullscreenWindow 

VideoDetectorTest.FullscreenWindow (run #1):
[ RUN      ] VideoDetectorTest.FullscreenWindow
[21122:21122:0428/162209:675210655:WARNING:cras_audio_handler.cc(472)] Audio input allowed by policy, sets input id=0x0 mute=false
[21122:21122:0428/162209:675210697:WARNING:cras_audio_handler.cc(508)] SetInputMuteInternal sets active input device id=0x0 mute=0
[21122:21122:0428/162209:675210737:WARNING:cras_audio_handler.cc(429)] SetupAudioInputState for active device id=0x2715 mute=0
[21122:21122:0428/162209:675210757:WARNING:cras_audio_handler.cc(508)] SetInputMuteInternal sets active input device id=0x2715 mute=0
Xlib:  extension "RANDR" missing on display ":9".
Xlib:  extension "RANDR" missing on display ":9".
[21122:21122:0428/162209:675250984:FATAL:window_observer.cc(18)] Check failed: 0 == observing_ (0 vs. 1)

Original issue's description:
> Adds back some debugging code
> 
> We're getting another crash that looks like an observer is being
> destroyed before removing itself.
> 
> BUG=365364
> TEST=none
> R=flackr@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266681

TBR=flackr@chromium.org,sky@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=365364

Review URL: https://codereview.chromium.org/252963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266691 0039d316-1c4b-4281-b951-d872f2087c98

Specifically, when the bubble is in 'customize' mode, the UI to change
the setting of a permission (allow/deny) will be a drop-down menu rather
than a checkbox.

BUG=None

Review URL: https://codereview.chromium.org/242443005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266689 0039d316-1c4b-4281-b951-d872f2087c98

The async readback case can be hard to follow with existing traces. Add an async
lifetime trace for each valid CopyOutputRequest, making clear both the lifetime
and frequency of such requests.

BUG=321624

Review URL: https://codereview.chromium.org/239183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266688 0039d316-1c4b-4281-b951-d872f2087c98

To see this is fixed by
https://codereview.chromium.org/245443004/

BUG=346799
TBR=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/205243014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266687 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338626

Review URL: https://codereview.chromium.org/256813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266686 0039d316-1c4b-4281-b951-d872f2087c98

This should improve main thread throughput in cases
where we are deferring the BeginMainFrame, but don't
really need to because the swap ack will come back
before the impl thread needs to draw anyway.

BUG=311213

Review URL: https://codereview.chromium.org/222023010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266685 0039d316-1c4b-4281-b951-d872f2087c98

R=wtc@chromium.org

Review URL: https://codereview.chromium.org/255783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266684 0039d316-1c4b-4281-b951-d872f2087c98

Mac Tests (dbg) failing for PrintPreviewTest.TaskManagerNewPrintPreview
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%281%29/builds/23012


> [Mac] Allow fullscreen transitions while constrained windows are open.
> 
> r166410 disabled the browser from entering fullscreen mode when any one
> tab has a constrained window open (e.g., Print dialog).  However, this
> is inconsistent with the behavior on all other desktop platforms.  This
> change removes the restriction.
> 
> Landing on behalf of miu@chromium.org manually, as to make a branch cut.
> 
> BUG=366567,146451
> TEST=Repro steps in bug 366567 (easier to understand from the multiple demo videos).  Also, manual testing of browser transition into and out of fullscreen before/after a print dialog is open.
> R=avi@chromium.org, sky@chromium.org
> 
> Review URL: https://codereview.chromium.org/253493005

TBR=avi@chromium.org

Review URL: https://codereview.chromium.org/252693007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266683 0039d316-1c4b-4281-b951-d872f2087c98

We're getting another crash that looks like an observer is being
destroyed before removing itself.

BUG=365364
TEST=none
R=flackr@chromium.org

Review URL: https://codereview.chromium.org/257023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266681 0039d316-1c4b-4281-b951-d872f2087c98

For a target //foo/bar:bar this adds the additional phony rules: "foo/bar:bar" and "foo/bar" to build.ninja. This is on top of the phony rules "bar" which will exist for all targets with a unique name "bar". This allows one to disambiguate targets with different paths but the same short name.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/247663006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266680 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/256093006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266679 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
Test=None, internal test only change.

Review URL: https://codereview.chromium.org/259793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266678 0039d316-1c4b-4281-b951-d872f2087c98

This requires https://codereview.chromium.org/235933013/.

BUG=108012

Review URL: https://codereview.chromium.org/240003010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266677 0039d316-1c4b-4281-b951-d872f2087c98

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/253863004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266676 0039d316-1c4b-4281-b951-d872f2087c98

Debug:

$ gn gen out/Debug_gn --args=is_debug=true
$ ninja -C out/Debug_gn metrics

Release:

$ gn gen out/Release_gn --args=is_debug=false
$ ninja -C out/Release_gn metrics

BUG=None
TEST=see above.
R=brettw@chromium.org
TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/255413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266675 0039d316-1c4b-4281-b951-d872f2087c98

The thumb position of a scrollbar is dependant on the scroll offsets of all
scrollable layers from the scrollbar's designated scroll layer up to its
container layer. It also needs to know about geometry changes in its
scroll and container layers. This CL revises the mechanism that registers
a scrollbar to receive notifications to include all intervening scrollable
layers.

BUG=346393

Review URL: https://codereview.chromium.org/254643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266674 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361550

Review URL: https://codereview.chromium.org/246523006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266673 0039d316-1c4b-4281-b951-d872f2087c98

It's unclear to me why we ever did this. Although we don't have an explanation,
it could have something to do with the false-positive pinning reports.

BUG=339907

Review URL: https://codereview.chromium.org/259753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266672 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=NativeWidgetAuraTest.TestPropertiesWhenAddedToLayout
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266386

Review URL: https://codereview.chromium.org/251733004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266671 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Ensure that modal dialogs from subframes can be cleaned up correctly. (https://codereview.chromium.org/255543009/)

Reason for revert:
Causes leaks:

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/2046/steps/browser_tests/logs/SadTabCancelsSubframeDialogs

Direct leak of 48 byte(s) in 1 object(s) allocated from:
    #0 0x56973b in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
    #1 0x52464ce in IPC::SyncMessage::GenerateReply(IPC::Message const*) ipc/ipc_sync_message.cc:99
    #2 0x9f6ec47 in Tuple4 ipc/ipc_message_utils.h:877
    #3 0x9f6ec47 in bool FrameHostMsg_RunJavaScriptMessage::DispatchDelayReply\u003Ccontent::RenderFrameHostImpl, void (content::RenderFrameHostImpl::*)(std::basic_string\u003Cunsigned short, base::string16_char_traits, std::allocator\u003Cunsigned short> > const&, std::basic_string\u003Cunsigned short, base::string16_char_traits, std::allocator\u003Cunsigned short> > const&, GURL const&, content::JavaScriptMessageType, IPC::Message*)>(IPC::Message const*, content::RenderFrameHostImpl*, void (content::RenderFrameHostImpl::*)(std::basic_string\u003Cunsigned short, base::string16_char_traits, std::allocator\u003Cunsigned short> > const&, std::basic_string\u003Cunsigned short, base::string16_char_traits, std::allocator\u003Cunsigned short> > const&, GURL const&, content::JavaScriptMessageType, IPC::Message*)) content/common/frame_messages.h:545
    #4 0x9f6b9d3 in content::RenderFrameHostImpl::OnMessageReceived(IPC::Message const&) content/browser/frame_host/render_frame_host_impl.cc:287
    #5 0xa1185d9 in content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const&) content/browser/renderer_host/render_process_host_impl.cc:1346
    #6 0x5239eec in IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&) ipc/ipc_channel_proxy.cc:269
    #7 0x3256fbf in Run base/callback.h:401
    #8 0x3256fbf in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:450
    #9 0x3258e35 in DeferOrRunPendingTask base/message_loop/message_loop.cc:462
    #10 0x3258e35 in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:576
    #11 0x32fab87 in base::MessagePumpGlib::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_glib.cc:270
    #12 0x3290314 in base::RunLoop::Run() base/run_loop.cc:49
    #13 0xc55c305 in content::RunThisRunLoop(base::RunLoop*) content/public/test/test_utils.cc:103
    #14 0xc55e252 in operator-> content/public/test/test_utils.cc:165
    #15 0xc55e252 in content::WindowedNotificationObserver::Wait() content/public/test/test_utils.cc:225
    #16 0x31af7c1 in ui_test_utils::WaitForAppModalDialog() chrome/test/base/ui_test_utils.cc:342
    #17 0x19c1ed8 in BrowserTest_SadTabCancelsSubframeDialogs_Test::RunTestOnMainThread() chrome/browser/ui/browser_browsertest.cc:585
    #18 0x31996b8 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:419


Original issue's description:
> Ensure that modal dialogs from subframes can be cleaned up correctly.
> 
> BUG=366510
> TEST=See bug comment 7 for repro steps.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266638

TBR=avi@chromium.org,sky@chromium.org,creis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=366510

Review URL: https://codereview.chromium.org/257863004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266669 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266668 0039d316-1c4b-4281-b951-d872f2087c98

This bug was uncovered by trying to use the Logitech 
C920 in the bots (see but). C920 has a new pixel 
format not in the list [1]. Since "unsupported" is
anyway no good pixel format, it is skipped in
CreateCapabilityMap() if it's enumerated.

It's also skipped in GetDeviceSupportedFormats().

BUG=360512


[1] https://code.google.com/p/chromium/codesearch#chromium/src/media/video/capture/win/video_capture_device_win.cc&q=video_capture_device_win&sq=package:chromium&l=189

Review URL: https://codereview.chromium.org/260053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266664 0039d316-1c4b-4281-b951-d872f2087c98

Implement overscroll support for the virtual keyboard.  Instead of resizing windows to prevent occlusion by the virtual keyboard, the inner viewport is resized to extend the vertical scroll range.

BUG=242933

Review URL: https://codereview.chromium.org/195793004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266662 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265357

R=blundell@chromium.org, jochen@chromium.org

Review URL: https://codereview.chromium.org/241323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266661 0039d316-1c4b-4281-b951-d872f2087c98

This CLs adds trace events for ChildProcessLauncher::start() and
ChildServiceConnection::bind(), improving visibility of the service
startup events in traces.

BUG=363121
R=yfriedman@chromium.org

Review URL: https://codereview.chromium.org/258953008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266660 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam@chromium.org, bruening@chromium.org
BUG=42043

Review URL: https://codereview.chromium.org/254813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266659 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Caused tons of uninitialized reads:

http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%282%29/builds/39582

{
<insert_a_suppression_name_here>
Memcheck:Uninitialized
fun:_ZN11color_utils12SkColorToHSLEjPNS_3HSLE
fun:_ZN11color_utils12_GLOBAL__N_115LumaInvertColorEj
fun:_ZN11color_utils16GetReadableColorEjj
fun:_ZN5views5Label17RecalculateColorsEv
fun:_ZN5views5Label15SetEnabledColorEj
fun:_ZN14message_center12BoundedLabel9SetColorsEjj
fun:_ZN14message_center16NotificationViewC1EPNS_23MessageCenterControllerERKNS_12NotificationE
fun:_ZN14message_center16NotificationView6CreateEPNS_23MessageCenterControllerERKNS_12NotificationEb
fun:_ZN14message_center17MessageCenterView17AddNotificationAtERKNS_12NotificationEi
fun:_ZN14message_center17MessageCenterView16SetNotificationsERKSt3setIPNS_12NotificationENS_30ComparePriorityTimestampSerialESaIS3_EE
fun:_ZN14message_center21MessageCenterViewTest5SetUpEv
}

etc

Original issue's description:
> retry r266042:
> ----------------------
> Automatically call OnNativeThemeChanged when a widget is added to a hierarchy
> with a widget.
> 
> Split off from https://codereview.chromium.org/245863002/
> 
> BUG=347832
> (tangentially)
> ----------------------
> 
> original review: https://codereview.chromium.org/248073005/
> changes: updated views unit tests
> 
> R=sky@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266622

TBR=sky@chromium.org,msw@chromium.org,estade@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=347832

Review URL: https://codereview.chromium.org/259073004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266658 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=364678
TBR=miket

Review URL: https://codereview.chromium.org/249913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266655 0039d316-1c4b-4281-b951-d872f2087c98

Re-land: cc: Enable impl-side painting by default on all platforms where threaded compositing is used.

BUG=169282

Review URL: https://codereview.chromium.org/242803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266654 0039d316-1c4b-4281-b951-d872f2087c98

r166410 disabled the browser from entering fullscreen mode when any one
tab has a constrained window open (e.g., Print dialog).  However, this
is inconsistent with the behavior on all other desktop platforms.  This
change removes the restriction.

Landing on behalf of miu@chromium.org manually, as to make a branch cut.

BUG=366567,146451
TEST=Repro steps in bug 366567 (easier to understand from the multiple demo videos).  Also, manual testing of browser transition into and out of fullscreen before/after a print dialog is open.
R=avi@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/253493005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266653 0039d316-1c4b-4281-b951-d872f2087c98

Reland "GestureRecognizerTest tests both Aura and Unified Gesture Detectors."

This is in preparation of landing the unified GR
(see https://codereview.chromium.org/251543003/).

There are some cases where behavior differs in minor ways.

This is sometimes dealt with by increasing the test's margin of error
(for instance, slop handling is slightly different, so we now
exceed the slop more thoroughly).

This is sometimes dealt with by ignoring the test if the test is
run with the unified GR.

BUG=332418

Review URL: https://codereview.chromium.org/252833005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266652 0039d316-1c4b-4281-b951-d872f2087c98

Supports Compose key with XIM and makes .XCompose settings effective with Linux Aura build.

BUG=351230,360388
TEST=Done manually.  Tested with GTK_IM_MODULE=xim XMODIFIERS=@im=none and ~/.XCompose with custom contents.
R=erg@chromium.org, sadrul@chromium.org

Review URL: https://codereview.chromium.org/243143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266651 0039d316-1c4b-4281-b951-d872f2087c98

> Allow anyone to change components_tests.gyp.
> 
> Review URL: https://codereview.chromium.org/241323003

TBR=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/256153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266650 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354046,354458

Review URL: https://codereview.chromium.org/259843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266649 0039d316-1c4b-4281-b951-d872f2087c98

While not observed on Linux, running on OSX appears to be much
flakier. Calls to StreamListenSocket::Send are non-blocking writes,
so a single read for multiple writes sometimes did not execute as
expected.

R=rsleevi@chromium.org
BUG=365067

Review URL: https://codereview.chromium.org/245563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266647 0039d316-1c4b-4281-b951-d872f2087c98

Software delegated rendering uses one fd per tile, so with a bunch of tiles that means it can run out of fds. If it seems close to hitting the limit the browser should throw away old frames to avoid this from happening.

BUG=362603
TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/258053008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266646 0039d316-1c4b-4281-b951-d872f2087c98

Previously function declarations needed to be added manually because of 
build errors on Windows when including the City.h file.  Now, with the
build errors fixed, use the proper includes everywhere.

BUG=353157

Review URL: https://codereview.chromium.org/246013008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266645 0039d316-1c4b-4281-b951-d872f2087c98

Removes a DCHECK in SyncBackendHostImpl that would trigger if we tried
to register to observe protocol events (ie. open the about:sync page)
before initialization was complete.  This DCHECK was unnecessary, since
there should be no harm in registering an observer before the sync
backend is initialized.  Allowing early registration makes the protocol
logs useful for debugging more kinds of issues.

BUG=365806

Review URL: https://codereview.chromium.org/254563005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266643 0039d316-1c4b-4281-b951-d872f2087c98

This fixes Aura builds (such as Ozone) which compile with use_aura=1 and
toolkit_views=0.

TBR=ben@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/250923014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266641 0039d316-1c4b-4281-b951-d872f2087c98