- 19 Nov, 2020 40 commits
-
-
Rushan Suleymanov authored
Bug: None Change-Id: Ie7b1a0a016d1b63a71ca313f6e7054246e056c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547022 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#829195}
-
Monica Basta authored
This CL adds the generic colored avatar to the avatar icons shown on 'chrome://settings/manageProfile' that is only shown for local profile (No GAIA account). It also fixes the bug where no selected is shown when the user is using the GAIA avatar as the chrome avatar. In a future CL, |kProfileUsingDefaultAvatar, kProfileUsingGAIAAvatar| prefs will be deleted. The |ManageProfileHandler| should not rely on these prefs. Fixed: 1149539 Change-Id: I9cbce03e62efb20a6c466eac9c7e32d1cbc93f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542062 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#829194}
-
Findit authored
This reverts commit e13a069e. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 829053 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZTEzYTA2OWUyZmNmZmU3OWM4MmRlNTAzMmEwMzVhMDRjNDIwMmZkMgw Sample Failed Build: https://ci.chromium.org/b/8863210065181297712 Sample Failed Step: services_unittests on (none) GPU on Mac on Mac-10.13.6 Sample Flaky Test: CoreLocationProviderTest.ShouldUseCallbackTest Original change's description: > fallback to Network Provider if wifi is turned off > > If Wifi is disabled Core Location does not work. In this case we will > fallback to the Network Location Provider which can use the IP address > to get an much less precise location. > > Bug: 1135766 > Change-Id: I3f5fa8e78fbb34bcec36dbd6eeb0e6adc06c64c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453437 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: James Hollyer <jameshollyer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829053} Change-Id: Iecd1cf5b4e3a36fdac2b11d5c52754fab8772c31 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1135766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549832 Cr-Commit-Position: refs/heads/master@{#829193}
-
Swapnil authored
There are many browsertest related to search related polices such as DefaultSearchProvider related policy and ForceGoogleSafeSearch policy. This CL splits them to new files. Bug: 1148743 Change-Id: Iba18f2e1ce08fbded6b112ee07d683405ca0a653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545522 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#829192}
-
Greg Thompson authored
The histogram had the wrong type, making its interpretation non-obvious. BUG=1149463 R=ydago@chromium.org Change-Id: I394db672d96da3c9f32e4434ae7b57016aabe5c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543385 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829191}
-
Shik Chen authored
The i18n json files are now generated in subdirectories for platform app and SWA. Bug: b/172879638 Test: cca deploy Change-Id: I404b42b2afdca4eb4a628bb49c44365dc7b21741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549381 Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#829190}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8d63a7fc4924..c151f873e4ab 2020-11-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 45b78e7b to 62214500 (493 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I6c359a9e7e44367f40aa521f8fa2f52442482aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549282Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829189}
-
Benoit Lize authored
Always enable thread cache statistics. Bug: 998048 Change-Id: I6cc5ac2e248baf19582c7170537a94e6292daf5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544570Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#829188}
-
Roman Sorokin authored
During Kiosk app launch we might need to configure network. This is guarded by the owner authentication (in case of consumer kiosk). Before this CL it used WebUI AccountPicker screen. This CL moves it to the current User pod screen implementation Bug: 1071779 Change-Id: Iaa1665e8d588d4df0beb5459365159a8292c08f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540983 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#829187}
-
Maria Kazinova authored
This is needed to properly record PasswordManager.SuccessfulSubmissionIndicatorEvent metric for this type of submission. Bug: 1146373, 1150780 Change-Id: I426746ed0fabadf553cc04cf7143b0c370015ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541764 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#829186}
-
Bret Sepulveda authored
As a prerequisite to landing cr/339683181. Bug: 1134294 Change-Id: I95a0774957c5ba1cae28faad5916865f50e5a8d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510054 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#829185}
-
arthursonzogni authored
It was previous reset once per navigations, including the same-document ones. This moves it toward DidCommitNewDocument(); Bug: 1113294 Change-Id: I7a947d9b693fd1380da54996e60431642f4cdde1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538212 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#829184}
-
chrome://flags#disable-idle-sockets-close-on-memory-pressurePavol Marko authored
This adds a chromeos-specific flag for the feature added in CL:TODO. When the feature is enabled, idle connections will not be closed on memory pressure. Bug: 1150526 Change-Id: If9d2063c30c7ede5039941f1764e5b769a0facab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547295 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#829183}
-
Roman Sorokin authored
Fixed: 1116058 Change-Id: Icb6ccd0f0f781efeee01473bcfd1e8a56784d2c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544662 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#829182}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a3d1e7c68c67..1f8ea587c2e2 2020-11-19 alexrudenko@chromium.org Enable TypeScript for TimelineController.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1275d8b150f92c123330f89c9d715b665087a81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549802Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ce207be41fd6..dad44f4d824e 2020-11-19 jiawei.shao@intel.com Skip SwapchainTests/SwitchPresentMode on Linux Intel Vulkan drivers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: I41b746695da2ffd1ff96cc8fc616665f6e9003d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549801Reviewed-by:
-
Mirko Bonadei authored
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/6907d995c797..7990ca64c616 $ git log 6907d995c..7990ca64c --date=short --no-merges --format='%ad %ae %s' 2020-11-19 mbonadei Roll libsrtp to 94ac00d5ac..860492290f. Created with: roll-dep src/third_party/libsrtp Bug: None Change-Id: I00c808561eb6f37feef0beaf358300a29890a85e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549602Reviewed-by:
Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#829179}
-
Shik Chen authored
The binding generation process was changed a bit in https://crrev.com/c/2451589. Bug: b/172879638 Test: cca deploy Change-Id: Ife59e5064bb4ee9226043e4783d5ee71328a00a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548593Reviewed-by:
-
Rohit Agarwal authored
Incognito CCT is currently restricted to be used only from 1P context. However, this also restricts the use for testers to test Incognito CCT via a 3P app. This CL uses feature flag kCCTIncognitoAvailableToThirdParty to allow 3P apps to be able to open Incognito CCT. The flag is disabled by default. Bug: 1150360 Change-Id: I2b9d3e51f90eda8e5cd86dac3317e746e1d8d91f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544974Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#829177}
-
Nicholas Verne authored
In most cases we remove the (Beta). Otherwise we replace with "Linux development environment". Bug: 1140370 Change-Id: I156ca81b989d3f50f8119f62c8f4a89c6362a383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508102 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#829176}
-
Przemek Pietrzkiewicz authored
This patch: - fixes a comment which I think meant kCloneAll where it says kEmpty - makes the single arg constructor explicit Bug: None Change-Id: Id0fb554a3caf06cb2d655fb06a8307cfedc2595a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547302Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Przemek Pietrzkiewicz <ppi@chromium.org> Cr-Commit-Position: refs/heads/master@{#829175}
-
Ryo Hashimoto authored
BUG=b:171408795 TEST=Launch Play Store Change-Id: I9bff72a850d74bfb226f14ca3a90afca325ad29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540047 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#829174}
-
Jaeyong Bae authored
This patch changes the code to return empty string for CSSStyleDeclaration.cssText. Discussion at: https://github.com/w3c/csswg-drafts/issues/1033 Makes tests pass: external/wpt/css/cssom/cssstyledeclaration-csstext.html Bug: 1146888 Change-Id: Ibca415b7606d2cc5110ca633c87a77fac3e74ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546305Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#829173}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3a578ae35233..16973d613fed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I49d18b5d093ddbae00b8f0c2c19b3b9db2d8bd45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549841Reviewed-by:
-
Joe DeBlasio authored
This CL updates the field trial testing config to match the final stage of the MIX-DL rollout on both android and desktop platforms. Strictly speaking, we'll briefly hit a slightly different configuration in Android first, but this is the configuration that is higher risk, the equivalent config has been tested on Desktop, and the configurations don't change the code paths exercised by the field trial testing anyway. Bug: 960819 Change-Id: I251ba5c20a30ab6532d48a22e8e6ed8eb0fee1d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548310 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Moe Ahmadi authored
Canary experiment: cl/339288320 Beta experiment: cl/342939379 Bug: 1136654, 1136649 Change-Id: I447848638b80bf645de919b62ac14a5d499a55c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547920 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Rohit Agarwal authored
This CL removes the deprecated method and update the call site to use the overload WebContentsFactory#createWebContents on profile instead. Bug: 1149861 Change-Id: Id5ed7b30646bbd520127280daeae342eb02eff42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543351 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#829169}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1f2fcddd3963..671914c28e82 2020-11-18 greg@lunarg.com Fix buffer oob instrumentation for matrix refs (#4025) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com,kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com,kainino@google.com Change-Id: I4c7e2d7d054f22e1395a3e4052f3a059d3000478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549461Reviewed-by:
-
anina koehler authored
This cl removes the mapping between extension ID and window title for the login-screen extension and uses the existing behavior feature instead. Bug: 1145126 Change-Id: I86bef81b140f5b9aa51fa9a87d8053e85d2ff7d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527024 Commit-Queue: Anina Koehler <aninak@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#829167}
-
arthursonzogni authored
Fix https://crbug.com/1147567 and add a regression test. This is meant to be merged back into M88 beta. No new navigations should start in a non current frame. There is a DCHECK and a DumpWithoutCrashing. It was triggered in M88. What happened: - Start with nested documents: A(B(C)). - C adds a beforeunload handler. - B starts a navigation, waiting for C. - The WebContents is closed, deleting C, then B, and then A. By deleting C, the navigations in B can begin, but this happen in the middle of destructing B. This is fixed by putting the code responsible for continuing the navigation in a new task. This is indeed the current behavior for the second part of the "if" already. This patch just generalize it to both clauses. A lot of things can be done to improve the architecture here, but this patch is meant to be merged into M88, so it should stay short to minimize the change. Bug: 1147567 Fixed: 1147567 Change-Id: I980c7da56b9f02b2644ebcb9a9401637848d9c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544967Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#829166}
-
Andres Olivares authored
crrev.com/c/2536371 disables a layout test on DevTools console to allow for a change on DevTools' public API to roll. Since the change has been rolled already, this enables the test again and updates it to the new API. Bug: chromium:1011811 Change-Id: I092b4aa82e90fa0926eb9de9b24b028e13156847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547304 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Andres Olivares <andoli@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#829165}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2d31db0b3751..3a578ae35233 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia28c06486037dec00458a8e50dc283d468349661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548358Reviewed-by:
-
Shubham Aggarwal authored
Migrate uses of the relevant set_* functions on the sql::Database object to use the new DatabaseOptions constructor instead. This change should have no intended behavioral effect. Bug: 1126968 Change-Id: Iaafca49a4b5440fce538d6918a0f136074ff9c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548276Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#829163}
-
Aya ElAttar authored
- Changed the toasts shown for clipboard blocked pastes to bubbles according to the new mocks. - Moved all the clipboard notifications related functions to dlp_clipboard_notification_helper.h/.cc Bug: 1148224, 1131670 Change-Id: I69a99b1a99d08cbc6ea47852d3ce6a3a7fdace66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532564 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#829162}
-
Pavol Marko authored
Adds a chrome Feature to disable closing idle sockets on memory pressure. This only applies to Profile NetworkContexts. Bug: 1150526 Test: new browser test Change-Id: I0e4f18d8faa4f365bdd7dc404003e147ca47aa8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547723Reviewed-by:
-
Rakina Zata Amni authored
NavigationRequest::CreateForCommit currently only needs a few parts of DidCommitProvisionalLoad_Params to create a NavigationRequest. To aid our removal of DidCommitProvisionalLoad_Params, we should make clear which ones we actually need. This CL also removes some dependencies that we don't actually need (e.g. method), and kills renderers that try to send a non-initial-commit about:blank navigation that the browser doesn't know about (the browser doesn't have a NavigationRequest for that navigation). For more context: - navigation-dev thread: https://groups.google.com/a/chromium.org/g/navigation-dev/c/8BsDvk-1gCU/m/-lrIxA1wCAAJ - NavigationRequest creation at DidCommit cases: https://docs.google.com/document/d/1UjdxiDJ3sgVDbp0CZpsSntdwAYNMSfc2qajX4nzXfLY/edit - DidCommit params removal plan: https://docs.google.com/document/d/18FeFEnfH_hTeGH7b_qkIto8pGtxdU54msnPlWo-qldA/edit Bug: 131832, 1133115 Change-Id: If23861e2473c5d7968859fc701f40f34f0248e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475093 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#829160}
-
Joel Hockey authored
Not all paths in a VM can be mapped to a path in the host. Paths in crostini homedir and /mnt/chromeos are fine. E.g. /mnt/chromeos/MyFiles/file => <cyrptohome>/MyFiles/file. But /etc/mime.types is not accessible to the host and cannot be mapped to a valid host path, so we will map it as 'vmfile:termina:/etc/mime.types'. If the drop target is the crostini container, we will do the reverse mapping and provide file:///etc/mime.types, but if we fail to do the reverse mapping for the drop target (e.g. drop target is arc or Plugin VM), we will clear the path from the drop data. Since chrome accesses OSExchangeData directly without allowing exo to do any reverse mapping, chrome will attempt to use a path such as file:///vmfile:termina:/etc/mime.types which is intended to fail. Bug: 1144138 Bug: 1146319 Change-Id: I91c62b5183f054311cba2ef474dda0f12766db83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546677Reviewed-by:
Jason Lin <lxj@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#829159}
-
Morten Stenshorne authored
https://chromium-review.googlesource.com/c/chromium/src/+/2523426 adds things to third_party/eigen3 , not third_party/eigen, so this was most likely a typo. Bug: 1121333 Change-Id: I2cd34e88026142df479d7573dbf63cecf8f0d501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549301Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#829158}
-
Fredrik Söderqvist authored
This abstracts away most of the accesses to the Page object, reducing the amount of boilerplate a bit. It'll also make it easier to transition away from the current Page/Document setup to allow sharing some code with SVG resource documents. Also add a LayoutRoot() for additional simplification. Bug: 109212 Change-Id: I7db0e29cbe28cc31c1f1df0546a3266abf6141e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544970Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#829157}
-
Mihai Sardarescu authored
The Gaia ID present in the CHROME_CONNECTED is only used for Google Drive and Docs to auto-enable offline mode. However this feature is not available on Chrome iOS, so we should stop including the Gaia ID in the CHROME_CONNECTED cookie. Bug: 1149943 Change-Id: Iffdbff19a43180922e2a184879a2922ed0d731e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543152 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
