GitLab

Revert of Updated expected_deps_{i386,x86_64} to match actual deps. (https://codereview.chromium.org/148583013/)

Reason for revert:
Suspected of breaking the Official builds.

Original issue's description:
> Updated expected_deps_{i386,x86_64} to match actual deps.
> 
> Dependencies added in the range 247500-247514.  I suspect 247509, a
> blink roll.
> 
> BUG=None
> NOTRY=true
> NOTREECHECKS=true
> TBR=phajdan.jr@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247567

TBR=phajdan.jr@chromium.org,shess@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/149203005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247609 0039d316-1c4b-4281-b951-d872f2087c98

I've added icon files for audio player at r247591, but their permissions are 755 and it is wrong. This patch fix them to 644.

TBR=yoshiki@chromium.org
BUG=none
TEST=none

Review URL: https://codereview.chromium.org/130803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247608 0039d316-1c4b-4281-b951-d872f2087c98

Before https://codereview.chromium.org/149103002/, chrome/android's default
target was 'All', so no behavior change. After that lands, the default target
is 'all', so the bots will build a few more targets (17 translation units more,
at the moment).

Together with the change linked above, this might enable the removal of
|android_app_target|.

BUG=none
R=yfriedman@chromium.org

Review URL: https://codereview.chromium.org/149213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247607 0039d316-1c4b-4281-b951-d872f2087c98

To reduce the chattiness of Google Now, localStorage.debug_mode for Google Now
and showConsoleLogOutput for unit tests will control when console.log actually
outputs to the console.

BUG=338239
TEST=By default, there will be no console.log output. When
localStorage.debug_mode is true in Google Now or showConsoleLogOutput is set
to true in unit tests, console.log output will occur.

Review URL: https://codereview.chromium.org/145353010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247606 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247605 0039d316-1c4b-4281-b951-d872f2087c98

Have sideloaded extensions pull data from the webstore (a la inline install) in
order to give the users a better idea of what extension they are installing.

Images worth 1000 words: http://imgur.com/zlexZeb,VljPXLz,WzT2ZOc#0

XIB changes:
* rename 'app/nibs/ExtensionInstallPromptInline.xib' to 'app/nibs/ExtensionInstallPromptWebstoreData', since the same prompt is now used for inline prompts and for sideloaded extensions when webstore data is available.

BUG=323063

Review URL: https://codereview.chromium.org/145153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247604 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=165884:165981&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/139903016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247603 0039d316-1c4b-4281-b951-d872f2087c98

For the longest time, the sync integration tests have relied on methods
that wait for sync cycle completion by polling various internal fields
in the sync session snapshot. These methods are brittle and rely on
internal state, which is not ideal.

This cl is a first step towards eliminating the use of internal state to
detect sync completion. It does the following:

1) Removes the methods IsDataSynced, IsFullySynced, IsDataSyncedImpl,
   AwaitDataSyncCompletion and AwaitFullSyncCompletion
2) Adds a method AwaitSyncSetupCompletion which waits until a client is
   ready to push local changes to the server.
3) Adds a method AwaitCommitActivityCompletion which waits until a client
   no longer has data to commit and its progress markers are updated.
4) Updates call sites to use the new methods.

BUG=94990,97780,323380
TEST=sync_integration_tests
R=rlarocque@chromium.org

Review URL: https://codereview.chromium.org/148723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247599 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334876

Review URL: https://codereview.chromium.org/139763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247598 0039d316-1c4b-4281-b951-d872f2087c98

Adding a dialog which explains that the multi user session has ended because a user policy has changed.

BUG=314930
TEST=manual

Review URL: https://codereview.chromium.org/149173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247597 0039d316-1c4b-4281-b951-d872f2087c98

A fileSystem opened by chrome.fileSystem API is passable to a pepper plugin[1],
but currently we cannot open any files with CREATE/TRUNCATE flag under the
filesystem in plugin-side because the filesystem doesn't have sufficient file
permissions (CREATE_OVERWRITE_FILE_PERMISSION is missing).

To fix that, this change calls GrantCreateReadWriteFileSystem() for the
filesystem instead of GrantCreateFileForFileSystem().

(NOTE) This change works fine only when choosing a directory by the API, and
the same issue still happens when choosing a file. I'll address the case in
a separate CL.

[1] http://crbug.com/177017


BUG=336160
TEST=manual (open a file with CREATE and/or TRUNCATE flag under the passed filesystem in plugin)

Review URL: https://codereview.chromium.org/146283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247596 0039d316-1c4b-4281-b951-d872f2087c98

Local printing URL parameter names do not match those in the privet spec. Fix
this so they do match it.

BUG=338868

Review URL: https://codereview.chromium.org/148183014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247595 0039d316-1c4b-4281-b951-d872f2087c98

We hit an issue where the server protocol was updated on 10/29 to send an additional tag was not part of the original spec.  This caused all Chrome clients across all versions to simultaneously think that the server was failing to send a valid response and send an increased number of pings to the server.
    
This CL rewrites the Java parser to be more robust to random changes to the XML as a precursor to the C++ reimplementation (which is still a long ways out).  The code also gets moved upstream so that we can get it reviewed easier.

BUG=181323
TEST=ResponseParserTest

Review URL: https://codereview.chromium.org/67313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247594 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/137723008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247593 0039d316-1c4b-4281-b951-d872f2087c98

SenderId can be either integer obtained from developer dashboard or
email. Android chrome invalidations uses email.
Fix double escaping so that registration server accepts senderId.

Review URL: https://codereview.chromium.org/148153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247592 0039d316-1c4b-4281-b951-d872f2087c98

This patch has only images. The code of new audio player will be committed separately.

The images are copied from
https://code.google.com/p/chromium/issues/detail?id=273308#c13

BUG=273308
TEST=none
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/145423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247591 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes an incorrect assumption in
PasswordAutofillAgentTest.InlineAutocomplete. Previously, this code assumed
that one trip through the event loop was sufficient to ensure that style was
recalcuated. After we move recalc style to be triggered by
requestAnimationFrame, this assumption will no longer be valid. This CL changes
the test to explicitly recalc style by calling WebView::layout.

Unfortunately, we cannot simply call WebView::layout in straight-line code
because this test does some of its work off the event loop. Instead, we need to
schedule the call to layout after we schedule the other async work.

BUG=337617
R=gcasto@chromium.org

Review URL: https://codereview.chromium.org/136003013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247590 0039d316-1c4b-4281-b951-d872f2087c98

We still need to pass RWHVGuest::SelectionChanged() call to platform_view_.
This broke while adding IME support, this function doesn't seem to be required for IME (made sure by running BrowserPluginHostTest.InputMethod).

Wrote a browser_test to catch the regression.

BUG=331722
Test=Open a <webview> in a chrome app. Select some text. Observe that "Look up in dictionary" and "Speech=>Start Speaking" features work.

Review URL: https://codereview.chromium.org/148433007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247589 0039d316-1c4b-4281-b951-d872f2087c98

> Add the viewer toolbar to the PDF extension.
> 
> BUG=303491
> R=arv@chromium.org, ganetsky@chromium.org
> 
> Review URL: https://codereview.chromium.org/110723007

TBR=raymes@google.com

Review URL: https://codereview.chromium.org/135183012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247588 0039d316-1c4b-4281-b951-d872f2087c98

So we can see if we're hitting the timeout, how long requests take, etc.

BUG=302816

Review URL: https://codereview.chromium.org/148573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247587 0039d316-1c4b-4281-b951-d872f2087c98

(See https://code.google.com/p/gyp/source/detail?r=1846 for
how GYP deals with this.)

BUG=82385

Review URL: https://codereview.chromium.org/147083011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247586 0039d316-1c4b-4281-b951-d872f2087c98

This is a sideeffect of the fake WS_VSCROLL and WS_HSCROLL styles added to the window and us hiding the scrollbars
during sizing operations.

Bug does not exist on Windows 8. On Windows 7 hovering near the bottom right portion of the window where the vertical
scrollbar would be returns HTBOTTOMRIGHT instead of HTVSCROLL or HTHSCROLL which we already handle. This eventually results
in non client mouse messages like WM_NCMOUSEMOVE/WM_NCMOUSEDOWN being sent to the RWHA window which are ignored.

Attempted fix is to check in WM_NCHITTEST if the mouse coordinates are in the bottom portion of the window using metrics
like SM_CXVSCROLL/SM_CYVSCROLL/SM_CXSIZEFRAME/SM_CYSIZEFRAME and if yes convert the hittest code to HTCLIENT.

BUG=335487
R=sky@chromium.org, sky

Review URL: https://codereview.chromium.org/145513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247584 0039d316-1c4b-4281-b951-d872f2087c98

BUG=324859

Review URL: https://codereview.chromium.org/142863006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247583 0039d316-1c4b-4281-b951-d872f2087c98

The new trace event will include time to setup gpu canvas.

BUG=334492

Review URL: https://codereview.chromium.org/132743007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247582 0039d316-1c4b-4281-b951-d872f2087c98

The previous patch had a bug. Instead of modelItem.entry, entry was used, which was always undefined.

TEST=Tested manually.
BUG=337575

Review URL: https://codereview.chromium.org/143653014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247581 0039d316-1c4b-4281-b951-d872f2087c98

Bookmark apps can currently get square icons. This CL rounds the icons
when displaying them in the app launcher.

BUG=315632

Review URL: https://codereview.chromium.org/135533006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247580 0039d316-1c4b-4281-b951-d872f2087c98

BUG=303491
R=arv@chromium.org, ganetsky@chromium.org

Review URL: https://codereview.chromium.org/110723007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247578 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247574 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ganetsky@chromium.org

Review URL: https://codereview.chromium.org/146693013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247573 0039d316-1c4b-4281-b951-d872f2087c98

In BrowserMainLoop::ShutdownThreadsAndCleanUp(), we explicitly call
a new ZygoteHostImpl::TearDownAfterLastChild API to notify the Zygote
to exit after its last child died.

The notification is to simply close the IPC channel to the Zygote.
Before this patch, this would happen implicitly when the browser process
died.

To implement this, we add a lightweight child tracking mechanism to ZygoteHostImpl.

BUG=334345
R=piman@chromium.org

Review URL: https://codereview.chromium.org/148443006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247572 0039d316-1c4b-4281-b951-d872f2087c98

If targets shouldn't be part of the android build, they should be conditional
in gyp instead.

Removing this line leads to 17 more files being compiled and one more binary
(printing_unittests) being linked on the open source bots, and there are no
build errors.

(An internal build of the 'all' target is also successful, and it builds only
183 additional edges too, which add about 1 minute / 5% to build time.)

BUG=330631
NOTRY=true

Review URL: https://codereview.chromium.org/149103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247571 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338787
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/149063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247570 0039d316-1c4b-4281-b951-d872f2087c98

This is part of a long-running background task to remove the remaining
uses of the unchecked IPC_ENUM_TRAITS() macro.

BUG=246708

Review URL: https://codereview.chromium.org/149033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247569 0039d316-1c4b-4281-b951-d872f2087c98

Currently the FocusController is destroyed after the root
window. FocusController may use
DesktopNativeWidgetAura::content_window_. Since the FocusController is
destroyed after content_window_ it is entirely possible for
FocusController to attempt to use content_window_ after it's been
destroyed.

This patch destroys FocusController before the root.

BUG=314118
TEST=covered by test
R=ben@chromium.org

Review URL: https://codereview.chromium.org/148883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247568 0039d316-1c4b-4281-b951-d872f2087c98

Dependencies added in the range 247500-247514.  I suspect 247509, a
blink roll.

BUG=None
NOTRY=true
NOTREECHECKS=true
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/148583013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247567 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334202
R=pfeldman

Review URL: https://codereview.chromium.org/148463009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247566 0039d316-1c4b-4281-b951-d872f2087c98

This should fixe the issues seen in the bug, and includes some cleanup
in prep for syncing folders.

BUG=338520
TBR=jamescook@chromium.org for ash_shell.cc

Review URL: https://codereview.chromium.org/148403007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247565 0039d316-1c4b-4281-b951-d872f2087c98

This test assumes that spinning the event loop is sufficient to trigger
asynchronous style recalculation. After we move style recalculation to be
triggered off requestAnimationFrame, this assumption will no longer be valid.
This CL removes this assumption by triggering layout explicitly

R=fsamuel@chromium.org
BUG=337617

Review URL: https://codereview.chromium.org/148153013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247563 0039d316-1c4b-4281-b951-d872f2087c98

BUG=305652,223859

Review URL: https://codereview.chromium.org/148153011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247562 0039d316-1c4b-4281-b951-d872f2087c98

- RelativeFileSystemPath (also called VirtualPath) is the path appended
in the filesystem URL, after .../external/. So it looks like
"drive-xxx/root/foo/bar" or "Downloads-xxx/foo/bar".
Note that in the Drive case, it begins with the mount point name,
that differs from profile to profile.

- DrivePath is the path in the hierarchy we manage in drive::ResourceMetadata.
It is like "drive/root/foo/bar" and always begins with "drive".

Every path comes from drive::FileSystem is in DrivePath.
Every path that will be the part of FileSystem API must be in RelativeFileSystemPath.
We need proper conversion for the bridging codes.

BUG=337095

Review URL: https://codereview.chromium.org/147993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247561 0039d316-1c4b-4281-b951-d872f2087c98