- 15 May, 2019 40 commits
-
-
yilkal authored
Bug: 951212 Change-Id: Ie69a2cd77aaa9d169d102cd3582a6d1902306001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610501Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#660091}
-
khmel@chromium.org authored
More dev working on this now and this might be good to distribute review loading. TEST=N/A BUG=N/A Change-Id: I86bfaad24cf5b3cdb207b90f3f72e4a83db9ead5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613886Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#660090}
-
Avi Drissman authored
This reverts commit e7d59816. Reason for revert: breaks portals, https://crbug.com/963617 Original change's description: > Handle race of SwapIn() and browser destroying the speculative MainFrame > > When WebContentsImpl destroys, it deletes the speculative main frame, > but the renderer may have taken ownership of it already, and the notice > of such action is in flight to the browser still. This leads to DCHECKs > failing in the renderer. So inform the FrameMsg_Delete IPC what the > intention of the browser is, there are 3 modes: > > - Deleting a non-main frame. This is the common case. These frames are > all owned by the browser so it's all good, no races. > - Deleting a speculative main frame at shutdown. This is the race we > address here. > - Deleting a speculative main frame because it's no longer needed. This > race is not handled by this CL but we CHECK() it explicitly now instead > of letting the renderer continue with a missing RenderFrame that it > expects to be present until it crashes somewhere random later. > > R=avi@chromium.org, dcheng@chromium.org > > Bug: 957858, 838348 > Change-Id: I2110bdaf8b116df48037f69db6cb992fa3796e29 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594834 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660025} TBR=avi@chromium.org,danakj@chromium.org,dcheng@chromium.org Change-Id: Ie15494cf92b443b91178df0953bb2d15a76cb886 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 957858, 838348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614317Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#660089}
-
Jun Cai authored
This CL implements the content settings UI for Bluetooth scanning API on desktop: 1. Adds CONTENT_SETTINGS_TYPE_BLUETOOTH_SCANNING for navigator.bluetooth.requestLEScan(). It is similar to USB and serial guard permission in the page info and site settings UIs since it can not be set to "Allow," only "Ask" or "Block." 2. Displays Bluetooth scanning permission in the page info dialog. 3. Adds a new entry for Bluetooth scanning permissions in chrome://settings/content. 4. Shows Bluetooth scanning permission in chrome://settings/content/bluetoothScanning. 5. The default setting for Bluetooth scanning permission can also be set on a per-site basis. I uploaded some screenshots of the above content settings UI in the issue link. Bug: 960454 Change-Id: Icf09b559153baa14f6a89ab78e2244407def44c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598722 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#660088}
-
Dominic Battre authored
TBR=vasilii@chromium.org Bug: 961196 Change-Id: I9c2ad9593c5a8d504256d79a30c0630dacd63844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612915 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#660087}
-
Etienne Bergeron authored
The call to wcslen on a StringPiece is incorrect. There is no guarantee that the string is NUL terminated. As stated on crbug/624905: "Problem is that gfx::RenderTextHarfBuzz::ShapeRun is asking for fallback for an empty string but claims it's of length 1. This confuses DirectWrite and it crashes. Can easily work around the crash by checking for empty string, but still need to investigate why gfx::RenderTextHarfBuzz::ShapeRun is getting confused." The reason of the code was to avoid a broken case with ShapeRuns. The empty string is no longer accepted in any GetFallbackFont(...) Bug: 624905 Change-Id: I32e2583c0b87084ece549bf18b611ed7ae8f8c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612045 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#660086}
-
Tim Song authored
TEST=updated unit test fails without fix BUG=938733 Change-Id: I84cb2c71848bb4b51ad511d53f5ed2bb59e2fd10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504838 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#660085}
-
Steve Kobes authored
This REF has been stable (launched) since crrev.com/631893, and is no longer needed. Bug: 581518 Change-Id: I8fe7971e1afc273abe473748c5289e73233c66d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610213Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#660084}
-
Denis Kuznetsov authored
Change-Id: I5f52faf19dc0acedb78f0ef0d7568090cbbc3c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611877 Auto-Submit: Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#660083}
-
Daniele Castagna authored
When we migrated GpuMemoryBufferHandle to the new shared memory API we didn't take into account that the previous SharedMemoryHandle would not enforce the size of the shared memory region stayed the same, while UnsafeSharedMemoryRegion does. Before using UnsafeSharedMemoryRegion we could pass the handle, ignore shm_pool_resize and map to an offset that is out of the original size we created the pool with. This breaks with UnsafeSharedMemoryRegion that checks the region we're mapping is contained in size. This CL implements shm_pool_resize, adding protocol checks and recreating UnsafeSharedMemoryRegion with the proper new size. Bug: 961155 Change-Id: I443feca90ad332c40cb74f8a76182a20a565d7a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608800 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#660082}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7581ff73754e..666290a263b8 git log 7581ff73754e..666290a263b8 --date=short --no-merges --format='%ad %ae %s' 2019-05-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision eacdc75a..7991984f (659866:659976) Created with: gclient setdep -r src/third_party/webrtc@666290a263b8 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I16de98428b84577de876635f583fd72af640e342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614017Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660081}
-
John Lee authored
Bug: 960358 Change-Id: I13c9709b101a5247a65a6d801a7b11647ade74bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613880Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#660080}
-
Vladimir Levin authored
This patch ensures that when we force the update on a display locked element, we prefer using exclusive ancestors (ie still skip the subtree walk), unless self layout was prevented. If self layout is not prevented, then we shouldn't need to unlock the element as all of the updates on it would normally happen anyway. R=chrishtr@chromium.org, rakina@chromium.org Bug: 954063 Change-Id: Ie41598c80fe6364c9f0b7758b59505d4af35e3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613369Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#660079}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2d3b9260f308..a16f28fc23a4 git log 2d3b9260f308..a16f28fc23a4 --date=short --no-merges --format='%ad %ae %s' 2019-05-15 jbudorick@chromium.org Roll mac_toolchain to pick up -verbose. Created with: gclient setdep -r src/third_party/depot_tools@a16f28fc23a4 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:962920 TBR=agable@chromium.org Change-Id: I1fe3306329d36d26c43bd98a5ffc9605376f42bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613661Reviewed-by:
-
Victor Hugo Vianna Silva authored
Prefactoring step for making FaviconSource and RecentTabsSubMenuModel share the same code for favicon retrieval. We request first from local storage and then from sync in case of failure. We no longer rely on the fact that the tab is local or not. This order of operations is the one currently used in FaviconSource. Bug: 955475 Change-Id: I02ed5615ae462b916a09b3d0dd85dea39d88a680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609849 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#660077}
-
Allen Bauer authored
Follow-up to https://crrev.com/c/1610082 TBR=pkasting@chromium.org TBR=reveman@chromium.org TBR=halliwell@chromium.org Change-Id: I9bf6e68a776143e4aa56943dc8768a778c4ab078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611863 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#660076}
-
Robert Flack authored
In preparation for removing the composited ElementId set, look up composited element existence through the PaintArtifactCompositor which can directly consult the LayerTreeHost for which it has created the layer list and property trees. Bug: 961686 Change-Id: I13786d3b7a15118f67efd9186491e0da5987e533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610304Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Peter Mayo <petermayo@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#660075}
-
Cliff Smolinsky authored
When building chrome with is_chrome_branded=true there are additional binaries that are linked in. These additional binaries cause failures in the delayloads_unittests and violate the requirements of the user32 delayloads change. This change adds the two violations to the delayload list (since neither are required to be statically linked). This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1551709. Bug: 963048 Change-Id: I0e09fd0ec7062e75dd3277fb1d7441d90e8e3068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612701Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#660074}
-
Robert Ogden authored
Several small changes as discussed offline: * Uses a delayed, low priority post task for DB query * Uses GetPagesWithCriteria * Adds an integration test Bug: 914577 Change-Id: I5fe7b403c8e00d82d807bcfbc2e75508b647f69d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601418 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#660073}
-
Javier Fernandez authored
The 'white-space: break-spaces' feature, when used in combination with 'overfow-wrap: break-word' may allow breaking before the first space after a word. However, we should avoid it if there are previous opportunities, like white spaces. The 'word-break: break-all' feature allows breaking a word at any letter. Since the goal of this feature is produce the longest line as possible, these additional opportunities must be prioritized over any previous white space. Bug: 952254 Change-Id: I0b1c31219c0009c7050084dd552317342ec25b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613177Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#660072}
-
Rohit Rao authored
ChromeEarlGrey is now a macro that saves the caller's file and line number, then invokes a helper method that is defined on ChromeEarlGreyImpl. ChromeEarlGreyImpl inherits from BaseEGTestHelperImpl and can be used to provide useful line numbers when helpers encounter errors. No test code is changed in this CL. Individual helper calls can be converted to the new assertion style incrementally, in followup CLs. BUG=922813 Change-Id: I77dbcf84d95de0ac06184f7dd96ffffd8ce68ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612441 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#660071}
-
Eugene But authored
RequestTrackerImpl was needed when Chrome used UIWebView. Bug: 585700 Change-Id: I755e6377bc05c4f7018cad2fe6ff2c79e6b5d8c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601665 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#660070}
-
Hwanseung Lee authored
it improves code readability and avoids uninitialized members. because it makes more simple constructor. and if a class have many constructors, it not need to initialize all members at each constructors. Bug: None Change-Id: I81ed538ee026ce7a6a96ca6c9673c2847b580d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611424 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Suman Kancherla authored
Bug: 962744 Change-Id: I99b6a2574e3adb42bf8967cd181c490bc4f5107a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611846 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#660068}
-
wutao authored
If embedded Assistant Ui is opened from kLauncherSearchResult, do not show the conversation starter suggestion chips. Bug: b/132442518 Test: manual Change-Id: I871485afaca0d140dc87b029ddab6b99a9312a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610500Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#660067}
-
Xiyuan Xia authored
Ensure GamepadDataFetcherManager is created on UI thread so that GamepadPlatformDataFetcherLinux::Factory is created with UI thread as expected. Bug: 962884 Change-Id: I2ff3f70baa8df332b43d080340ec1ffc573b015f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613376Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#660066}
-
Xiyuan Xia authored
Bug: 962884 Change-Id: Ib8b3b177bb6ab94e11ea7d2db9b52721c442a142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613370Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#660065}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a664b953817c..a2d9e64b410f git log a664b953817c..a2d9e64b410f --date=short --no-merges --format='%ad %ae %s' 2019-05-15 tsepez@chromium.org Fix RemoveSelfIfParented() for RetainedTreeNode<>. 2019-05-15 tsepez@chromium.org Rename CFX_FontCache::GetCachedFace() to GetFaceCache() 2019-05-15 thestig@chromium.org Add a test case that exercises DrawCosmeticLine(). 2019-05-15 thestig@chromium.org Add a .in file for tagged_alt_text.pdf. Created with: gclient setdep -r src/third_party/pdfium@a2d9e64b410f The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: If94cb100dc67a9862d09e2aeb939f2ebc881fdf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613639Reviewed-by:
-
Javier Ernesto Flores Robles authored
This creates a non modal presenter useful to present any view controller above other view controller in a non modal style. Allowing any interaction outside the presented view controller. The animation in is a fade in and scale down, while the animation out is just a fade out. R=kkhorimoto@chromium.org Bug: 959736 Change-Id: I41bd66577217ea8bb39e1b3944d9527f426b26e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602650 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#660063}
-
Weiliang Chen authored
SkiaRenderer's goal is to be visually matching, but does not aim for pixel perfect. Rebaseline some tests results to reflect this: compositing/lots-of-img-layers.html css3/filters/effect-blur-hw.html media/video-layer-crash.html transforms/3d/point-mapping/3d-point-mapping-deep.html virtual/exotic-color-space/images/color-profile-layer-filter.html Bug: 954328 Change-Id: I1f16bd5c0e8d66a728e90e2fcedef473c7327dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602674Reviewed-by:
-
Matt Menke authored
The browser process NetLog doesn't work when the network service is enabled, which is now the default state. This is needed to remove the useless in-process NetLog from Chrome. ServiceDiscoveryClientMdns() should presumably be modified to use the network service to create UDP sockets for it, at some point, which will make it start using the functional NetLog in the network service, conveniently. Bug: 767450 Change-Id: Id101f8046062cb9b9d823aaa89c8c4372eb07258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612094Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#660061}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/945d1e538c62..9b2633e294de git log 945d1e538c62..9b2633e294de --date=short --no-merges --format='%ad %ae %s' 2019-05-15 mtklein@google.com manually register codecs in DM 2019-05-15 bsalomon@google.com Get EGLimage functions out of GrGLInterface. Created with: gclient setdep -r src/third_party/skia@9b2633e294de The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: I778785d65d006aad655384b336750adc67c46909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613598Reviewed-by:
-
Monica Basta authored
Added "Gaia cookies state" in signin-internals which can be in three states. 1- Blocked, if "Allow sites to save and read cookie data (recommended)" is unchecked. 2- Cleared on exit, if the user checked "Keep local data only until you quit your browser" or added "accounts.google.com" to the "Clear on exit" section. 3- Allowed, if none of the above. Sync can be paused due to other reasons, which are trivial to find by checking Tokens request status from the signin-internals page. Bug: 942451 Change-Id: I965f27a667bf77ff169245664d271ccaf4309155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599608Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@google.com> Cr-Commit-Position: refs/heads/master@{#660059}
-
Mark Pearson authored
i.e., allows counting of home button uses that lead to places besides, say, the new tab page. Right now all home button uses are logged as a user action "Home" and it's a pain to try to figure out based on other UMA histograms whether the home button leads to the new tab page or some web page. This makes it easier. Bug: 953445 Change-Id: I2ad455af3b6bd8884813186a1f54ebaa244b2c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609973Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#660058}
-
Eric Roman authored
The copy in third_party is unused, as .vypthon is already pulling in version 0.7 used by the test server. TBR: rogerta@chromium.org,skyostil@chromium.org,raymes@chromium.org Change-Id: I417a3c3ac581b5b9cfe37d23bbc1ada6515730ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611621 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#660057}
-
Denis Kuznetsov authored
TBR=bartfab@chromium.org TBR=atwilson@chromium.org Change-Id: I1a5b19902797ecb3c7944c7623d0f93abb5a52ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611611Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
Currently, WebTextCheckingCompletion instances are managed manually, making them prone to leaks. This CL changes them to be managed by std::unique_ptr to specify the ownership clearly and prevent them from being leaked. Bug: 962610 Change-Id: I37cee0747f3491fc9a622cf387274487cf765f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610491Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#660055}
-
Daniel Rubery authored
For users with "Make searches and browsing better" enabled, we will share non-allowlisted URLs with Safe Browsing in real-time, to avoid the propagation delay with blocklist-based approaches. BUG=963165 Change-Id: I2c204946ce816a21b7ff4b0f72978f46d180e6d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611308 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#660054}
-
Mohamed Amir Yosef authored
This CL add some CHECKs for debugging purpose to detect cases when duplicate tombstones are tracked in the bookmarks tracker. Bug: 963469 Change-Id: I2f0c23c5ece50264e9a7f07f2cf8abd956ff72d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613182Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#660053}
-
Caroline Rising authored
Tab hover cards should appear immediately when keyboard focus is on either the tab or the tab's close button. This cl makes Tab a view observer of its close button and triggers hover cards when either the tab or the close button takes focus. Tab hover cards previously were hidden on any key event, this cl adds a check to avoid hiding hover cards on key events when the tab strip is keyboard focused. This also hides the hover cards on any mouse click since during keyboard navigation the mouse can be outside the tab strip where mouse events were previously captured. Bug: 963537 Change-Id: Ia5889e22c3ce29996956c56e84b7e2d54cd51396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612220Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#660052}
-
