- 04 May, 2018 40 commits
-
-
Robert Ma authored
When running WPT in web_tests, test names are more like URLs instead of file paths (to be precise, the part of a test name after external/wpt is a WPT URL), because WPT can generate multiple tests (variations) for a single test file (e.g. .any.js, ?run_type). Therefore, when asking questions like "is a test slow?", we need to find the manifest item for that test by URL instead of by file path; whereas if we want to know if a file in external/wpt is a test file, we find the manifest item(s) for that file by file path. This CL separates the two types of manifest queries, and chooses the correct one for each call site. Besides, unit tests are improved to cover the WPT variations (.any.js & ?run_type). Bug: 831975, 800570 Change-Id: I230d5ec7df06b7df1387da1b93788d6cae55d153 Reviewed-on: https://chromium-review.googlesource.com/1043160 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#556043}
-
jonross authored
Previously it was found that virtual/video-surface-layer/media/color-profile-video-seek-filter.html was flaky on Windows. It has now become flaky on Linux as well. This updates the test expectations for the test to include Linux. TEST=virtual/video-surface-layer/media/color-profile-video-seek-filter.html TBR=treib@chromium.org Bug: 839833 825733 Change-Id: I16cc78b71aa104f30252ea23a7cc276c52cbfa1c Reviewed-on: https://chromium-review.googlesource.com/1044286Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#556042}
-
Ned Nguyen authored
NOTRY=true TBR=eyaich@chromium.org Bug: 836446 Change-Id: Id47c16c1231fac76cf7f07bf8aa4f9bd7b5a1067 Reviewed-on: https://chromium-review.googlesource.com/1044307Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#556041}
-
gogerald authored
This CL also enables localhost on Desktop for debug. This is the counter part of the desktop CL, https://chromium-review.googlesource.com/c/chromium/src/+/1012451 Test: 1), go to 'https://rsolomakhin.github.io/pr/bob/' 2), click 'buy' button 3), choose 'personal bobpay' from 'https://gogerald.github.io' 4), click 'PAY' 5), login if necessary (any more than five characters name and passowrd). 6), click 'Navigate to http page' 7), the window should close, the payment request dialog is shown to allow users choose different payment method. Bug: 828431 Change-Id: I0bbe5e97d364f7cd172ae7cfc43962dd314398e2 Reviewed-on: https://chromium-review.googlesource.com/1031056Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#556040}
-
jonross authored
The test benchmarks/system_health_smoke_test/SystemHealthBenchmarkSmokeTest/system_health/memory_desktop/browse:news:reddit is flaky. While the cause is being investigated I am disabling it to help with the trybots TEST=benchmarks/system_health_smoke_test/SystemHealthBenchmarkSmokeTest/system_health/memory_desktop/browse:news:reddit TBR=perezju@chromium.org NOTRY=true # test are covered by PRESUBMIT Bug: 789041 Change-Id: I2dde56c0fb64f71821b94f2072463bf85ca745e0 Reviewed-on: https://chromium-review.googlesource.com/1044108Reviewed-by:
-
Steve Kobes authored
Bug: 823365 Change-Id: I29537cc8d749eb426a9ae5624789b95b34121b13 Reviewed-on: https://chromium-review.googlesource.com/1042802Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#556038}
-
Jinsuk Kim authored
Embedders have to do a bit convoluted initialization for SelectionPopupController (its action mode callback to be set requires a helper instance from the SPC itself). This CL makes it simpler by delegating the helper initialization to action mode callback constructor. |ceateContentViewCore| in Tab.java, For instance: From: SelectionPopupController controller = SelectionPopupController.fromWebContents(webContents); ChromeActionModeCallback actionModeCallback = new ChromeActionModeCallback(this, controller.getActionModeCallbackHelper()); controller.setActionModeCallback(actionModeCallback); SelectionPopupController.fromWebContents(webContents) setActionModeCallback(new ChromeActionModeCallback(this, webContents)); to: Change-Id: Ifec52ce2c1f9446f47de72295be1abc5e1c361d7 Reviewed-on: https://chromium-review.googlesource.com/1029757Reviewed-by:Ted Choc <tedchoc@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#556037}
-
Vadim Petrov authored
Part 1: Refactoring and improve background filters shaders. Bug: 613233 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I93c7ecf0933f6c7095bfc94d0d404097b6e1a384 Reviewed-on: https://chromium-review.googlesource.com/899350 Commit-Queue: Vadim Petrov <lof84@yandex-team.ru> Reviewed-by:
Stephen White <senorblanco@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#556036}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cfcbf96b..ac9b5ca0 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I8cd20e38126579cdda5f46189046d44c96815cda Reviewed-on: https://chromium-review.googlesource.com/1043692Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#556035}
-
Raphael Kubo da Costa authored
This fixes the build with libstdc++ after a4c19797 ("Shatter partition_alloc.h into smaller files"). In file included from ../../base/allocator/partition_allocator/partition_bucket.h:11:0, from ../../base/allocator/partition_allocator/partition_bucket.cc:5: ../../base/allocator/partition_allocator/partition_alloc_constants.h:140:53: error: ‘CHAR_BIT’ was not declared in this scope static const size_t kBitsPerSizeT = sizeof(void*) * CHAR_BIT; ^~~~~~~~ ../../base/allocator/partition_allocator/partition_alloc_constants.h:140:53: note: suggested alternative: ‘WCHAR_MIN’ static const size_t kBitsPerSizeT = sizeof(void*) * CHAR_BIT; ^~~~~~~~ WCHAR_MIN Bug: 819294 Change-Id: Ie61cd7a1b55adf77e1f584bd5447ac11b6980b02 Reviewed-on: https://chromium-review.googlesource.com/1043748Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#556034}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d8a189fca3cd..5226b777edee $ git log d8a189fca..5226b777e --date=short --no-merges --format='%ad %ae %s' 2018-05-03 ethannicholas fix for SPIR-V sk_in definition which was upsetting Intel NUC Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I5e41c49c321193f51399b7ce39cfb870102dc166 Reviewed-on: https://chromium-review.googlesource.com/1043662Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556033}
-
Friedrich Horschig authored
This CL introduces the sheet that can replace the keyboard if triggered by the keyboard accessory. Beyond showing or hiding, it has no functionality yet. The next steps will introduce the layout for passwords as started in https://crrev.com/c/951588. The latter CL is deprecated with this CL. The minimalist root component only simplifies testing at this point. Bug: 811747 Change-Id: I2aaa2b5c3fbf782866301125f5a81307165efbfe Reviewed-on: https://chromium-review.googlesource.com/1030551 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#556032}
-
Karl Wiberg authored
It's about to become mandatory. Bug: webrtc:9062 Change-Id: I430f9af008bb1e41c435ac0bcb06fd45645d26b5 Reviewed-on: https://chromium-review.googlesource.com/1044104Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Karl Wiberg <kwiberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#556031}
-
Rayan Kanso authored
I was getting build errors when using ImplementedAs on a dictionary and referencing it from another dictionary idl file. The file referencing the ImplementedAs dictionary wasn't using the ImplementedAs value. Bug: 839782 Change-Id: I3c3f91cecf9d6be0b33a7d990a32aabe2a48eefc Reviewed-on: https://chromium-review.googlesource.com/1042710 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556030}
-
https://chromium.googlesource.com/angle/angle.git/+log/7a8fe15682f3..983460e6cd51 $ git log 7a8fe1568..983460e6c --date=short --no-merges --format='%ad %ae %s' 2018-05-02 oetuaho Rewrite repeated assignments to swizzled vectors on NVIDIA Created with: roll-dep src/third_party/angle BUG=chromium:798117 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I795f13f9b18a037065b9a1dcbe9419f3b99e2b06 Reviewed-on: https://chromium-review.googlesource.com/1043661Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556029}
-
Bence Béky authored
This is necessary to avoid creating a DefaultClientSocketFactory, which is a leaky singleton and therefore would hold a reference to ScopedTaskEnvironment's reference counted MockTimeTaskRunner forever, thus preventing the creating of another ScopedTaskEnvironment. This is prework for https://crrev.com/c/1037405. Bug: 791831 Change-Id: Iba9e17cc51d7002318f3a27d694b3d9230f36d4e Reviewed-on: https://chromium-review.googlesource.com/1037324Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#556028}
-
Marc Treib authored
This reverts commit 79b28587. Reason for revert: performance-return-real-time.js fails on MSAN: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/ Original change's description: > Using non-override time in InspectorPerformanceAgent.cpp. > > Right now the InspectorPerformanceAgent returns incorrect performance metrics > (such as LayoutDuration, ScriptDuration, etc.) if there is an time override in > place. The InspectorPerformanceAgent needs to return real time elapsed. > > Per offline discussion with Pavel(pfeldman@), the reason we don't expose the > non-override time API in the web platform (<blink>/platform/time.h) is that time > override is to abstract the web platform from the time. The web platform should > just deal with time and not know about whether the time is overridden. Exposing > the non-override time API in the very core part of blink will leak the override > aspect and hence compromising the whole design > > BUG: 830033 > Change-Id: If3140892ac60bc853ef5f98f7b478a98ae332806 > Reviewed-on: https://chromium-review.googlesource.com/988833 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Commit-Queue: Johnny Ding <jnd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556012} TBR=dgozman@chromium.org,jnd@chromium.org,haraken@chromium.org,pfeldman@chromium.org,jochen@chromium.org Change-Id: Ic6f8feb1c77147e8b18fad12a95b1761cd13c2a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1044145Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#556027}
-
Marc Treib authored
This reverts commit fd8a3a1f. Reason for revert: The depended-on CL has been relanded as https://crrev.com/c/1030451 Original change's description: > Revert "Sync: Use IdentityManager instead of SigninManager" > > This reverts commit aab57914. > > Reason for revert: Depends on crrev.com/c/1025898 which was reverted > > Original change's description: > > Sync: Use IdentityManager instead of SigninManager > > > > This CL migrates ProfileSyncService to IdentityManager for getting > > info on the primary account. This includes switching from > > SigninManagerBase::Observer to IdentityManager::Observer. > > The only remaining use of SigninManager within PSS it to call > > SignOut() which isn't exposed by IdentityManager yet. > > > > Bug: 825190 > > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > > Change-Id: Icf9398d63794cab03cb559adba5c767e18c31c0a > > Reviewed-on: https://chromium-review.googlesource.com/983914 > > Commit-Queue: Marc Treib <treib@chromium.org> > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#553973} > > TBR=blundell@chromium.org,treib@chromium.org,mastiz@chromium.org > > Change-Id: Ib40dbff0f1c8e5fba95cb9881681361abec5aeec > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 825190, 837201 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Reviewed-on: https://chromium-review.googlesource.com/1030372 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553997} TBR=blundell@chromium.org,treib@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 825190, 837201 Change-Id: If6858f033ac8390acfc904379afbf9726a6301c2 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1043885Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#556026}
-
Marc Treib authored
TBR=wangxianzhu@chromium.org Bug: 839734 Change-Id: Ic35abab341a46e52d2586f2f5515bf0701f96fec Reviewed-on: https://chromium-review.googlesource.com/1043985Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/70f3bb06..cfcbf96b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I0f0142146ed2d894be39511968bbfac7b401a53c Reviewed-on: https://chromium-review.googlesource.com/1043690Reviewed-by:
-
Antonio Gomes authored
Driven by CL for prior to a major rename (fetcher -> loader). BUG=none Change-Id: Idcb01dfa92f32b055472f5d98632197d8ecf0dc3 Reviewed-on: https://chromium-review.googlesource.com/1043286Reviewed-by:
-
Marc Treib authored
TBR=hubbe@chromium.org Bug: 177163, 427730 Change-Id: I02ea53b381d3bf053b1ed8247c8d86704329a32b Reviewed-on: https://chromium-review.googlesource.com/1043905Reviewed-by:
-
Kevin Marshall authored
System logs are included by default, unless they are deliberately switched off by using the --no-system-logs flag. -v now turns on DEBUG level logging and enables verbose mode for SSH. Bug: 839662 Change-Id: I286dd33e3c76864154a98a9e4c07af49b036ec09 Reviewed-on: https://chromium-review.googlesource.com/1043453Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#556021}
-
https://chromium.googlesource.com/angle/angle.git/+log/41e59f55a4d2..7a8fe15682f3 $ git log 41e59f55a..7a8fe1568 --date=short --no-merges --format='%ad %ae %s' 2018-04-28 jiawei.shao ES31: Add link validation on MAX_COMBINED_SHADER_OUTPUT_RESOURCES Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I2669eccf1f1556e8fb8709cb05bb8afb75dca1f7 Reviewed-on: https://chromium-review.googlesource.com/1043652 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Sungguk Lim authored
Use std::unique_ptr instead of deprecated linked_ptr Bug: 556939 Change-Id: Ifb89741b5815b388961a67aebf6d1f7cf07d7b7d Reviewed-on: https://chromium-review.googlesource.com/1040325Reviewed-by:
-
Marc Treib authored
Both in SitePerProcessHitTestBrowserTest and in SitePerProcessHighDPIHitTestBrowserTest. TBR=mcnee@chromium.org Bug: 833380 Change-Id: I5469e74827a6daaff72b6c85b2095866f91b601a Reviewed-on: https://chromium-review.googlesource.com/1043869Reviewed-by:
-
Marc Treib authored
Original CL: https://crrev.com/c/1025898 Revert: https://crrev.com/c/1030150 Patchset 1 contains the original CL. What's changed from there is to set up the primary account without providing a refresh token (like the tests did before this change). Original change's description: > Revert "Migrate Arc unit tests to IdentityManager" > > This reverts commit 1e3550d5. > > Reason for revert: Failing tests, see crbug.com/837201 > > Original change's description: > > Migrate Arc unit tests to IdentityManager > > > > identity::IdentityManager is the new API that replaces SigninManager[Base]. > > > > This includes ArcTermsOfServiceDefaultNegotiatorTest and ArcSupportHostTest. > > > > Bug: 825190, 731023 > > Change-Id: I316c90c6d278e52d723468d63bc21cd288b2642b > > Reviewed-on: https://chromium-review.googlesource.com/1025898 > > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > > Commit-Queue: Marc Treib <treib@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#553949} > > TBR=yusukes@chromium.org,treib@chromium.org > > Change-Id: Iba9649631ec8633c0b89b867a60e89d3d63a01ad > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 825190, 731023, 837201 > Reviewed-on: https://chromium-review.googlesource.com/1030150 > Reviewed-by: Max Morin <maxmorin@chromium.org> > Commit-Queue: Max Morin <maxmorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553979} Bug: 825190, 731023, 837201 Change-Id: I83753ba9036eb9f93ba32c74302dbd151b03c0bf Reviewed-on: https://chromium-review.googlesource.com/1030451Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#556017}
-
Tim Schumann authored
This is a follow-up to https://chromium-review.googlesource.com/1030177 Bug: 832019 Change-Id: I9c473fa5c81fd918cb203d6ae18dd5aeea04e68a Reviewed-on: https://chromium-review.googlesource.com/1042705 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
-
Marc Treib authored
It fails with the leak detector. The version without the "virtual/video-surface-layer/" prefix was already being skipped. TBR=mlamouri@chromium.org Bug: 838128 Change-Id: Icb4e898e9c24c20b94cd5bfb51042b65e1ace7d4 Reviewed-on: https://chromium-review.googlesource.com/1043865Reviewed-by:
-
vitaliii authored
This CL just disables a DCHECK for commit-only types. Please see the bug for explanation why this is safe to do. This is not the optimal solution and we should look into persisting ModelTypeState with initial_sync_done set to true and making commit-only types to diverge less from non commit-only ones. Bug: 837257 Change-Id: Ia917de973a43e28a7b6de2e2337f42199da5e44e Reviewed-on: https://chromium-review.googlesource.com/1042192 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8642bcc3248f..8672346ad7ce $ git log 8642bcc32..8672346ad --date=short --no-merges --format='%ad %ae %s' 2018-04-26 bpastene Add the chromeos/OWNERS file to the ChromeLKGM committer's checkout. 2018-04-25 philipchen cheza: Add release and paladin builder configs Created with: roll-dep src/third_party/chromite BUG=chromium:None The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7c0cee4658c38f33dd2eb4ac1e0b972a2bbee97b Reviewed-on: https://chromium-review.googlesource.com/1043607Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556013}
-
Johnny(Jianning) Ding authored
Right now the InspectorPerformanceAgent returns incorrect performance metrics (such as LayoutDuration, ScriptDuration, etc.) if there is an time override in place. The InspectorPerformanceAgent needs to return real time elapsed. Per offline discussion with Pavel(pfeldman@), the reason we don't expose the non-override time API in the web platform (<blink>/platform/time.h) is that time override is to abstract the web platform from the time. The web platform should just deal with time and not know about whether the time is overridden. Exposing the non-override time API in the very core part of blink will leak the override aspect and hence compromising the whole design BUG: 830033 Change-Id: If3140892ac60bc853ef5f98f7b478a98ae332806 Reviewed-on: https://chromium-review.googlesource.com/988833Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Johnny Ding <jnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#556012}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/068949a8..70f3bb06 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I7a7192fe3054a51a1b4845de5ee7c13118185110 Reviewed-on: https://chromium-review.googlesource.com/1043685Reviewed-by:
-
Sean Kau authored
CupsPrinterManager now outlives CupsPrintersHandler so the observer needs to be removed when it is destructed. Bug: 839501 Change-Id: If4c7b38ad7e80be5032095c24456ca16bee1f005 Reviewed-on: https://chromium-review.googlesource.com/1043061Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#556010}
-
Marc Treib authored
This reverts commit 6c3cc295. Reason for revert: ResourceCoordinatorRenderProcessProbeBrowserTest.TrackAndMeasureActiveRenderProcesses fails on Mac Asan 64: https://ci.chromium.org/buildbot/chromium.memory/Mac%20ASan%2064%20Tests%20%281%29/40456 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FMac_ASan_64_Tests__1_%2F40456%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FResourceCoordinatorRenderProcessProbeBrowserTest.TrackAndMeasureActiveRenderProcesses%2F0 ../../chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc:171: Failure Expected: (0u) != (measurement->private_footprint_kb), actual: 0 vs 0 Original change's description: > RC: Add memory measurement to render process probe. > > Bug: 755840 > Change-Id: I96af63e817abe9bdefb0916da4d652e97c620a2c > Reviewed-on: https://chromium-review.googlesource.com/1037631 > Commit-Queue: Chris Hamilton <chrisha@chromium.org> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555844} TBR=chrisha@chromium.org,fdoray@chromium.org,erikchen@chromium.org,siggi@chromium.org Change-Id: If2e102252f43c0b62b6a539e0df7793ee05281bc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 755840 Reviewed-on: https://chromium-review.googlesource.com/1043805Reviewed-by:
-
Marc Treib authored
This reverts commit 1cf6caff. Reason for revert: KeyAccessibilityEnablerTest.TwoVolumeKeyDown fails on MSan: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/6993 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_ChromiumOS_MSan_Tests%2F6993%2F%2B%2Frecipes%2Fsteps%2Fash_unittests%2F0%2Flogs%2FKeyAccessibilityEnablerTest.TwoVolumeKeyDown%2F0 Original change's description: > Initial support for Spoken Feedback tablet toggle > > Bug: 839154 > Change-Id: Iebceacd23dde5275c72d4fb6afecedb3dab75396 > Reviewed-on: https://chromium-review.googlesource.com/1035207 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555874} TBR=derat@chromium.org,dtseng@chromium.org Change-Id: I26606c63bf4033b3d177093787a909b31f3d2a38 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839154 Reviewed-on: https://chromium-review.googlesource.com/1043785Reviewed-by:
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=warx@google.com Change-Id: I5490d3410c674b065908698a3928bb09c9217df0 Reviewed-on: https://chromium-review.googlesource.com/1043688Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#556007}
-
Tommy Steimel authored
This CL increases the padding on the modern media controls buttons and timeline in order to give larger tap targets. This CL also sets the z-index on the timeline in order to fix an issue where clicking above the timeline wouldn't properly scrub. TBR=mlamouri@chromium.org Bug: 839082, 827537, 817303 Change-Id: I87cb5867d6dde55dee4fc5caa252933163c50ddf Reviewed-on: https://chromium-review.googlesource.com/1043249Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#556006}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I7c2e6129e28ca9fef2527859ea923e0f298d524d Reviewed-on: https://chromium-review.googlesource.com/1043651 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556005}
-
Trent Apted authored
r545332 preserved the omnibox font size of 14 for default user OS configurations but inadvertently started applying scaling logic used for dialog text that the omnibox text field never used. It is 14pt. Always. Revert to the old behaviour. Importantly, the way the size delta was being captured would fail to shrink a font that was too large to fit, if that delta came from user settings rather than font metrics alone. Bug: 831340, 838065 Change-Id: I1d4a296fa717694bfe77c14d2590d10d0d9c6e9f Reviewed-on: https://chromium-review.googlesource.com/1041390 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#556004}
-
