GitLab

This CL removes the limit on the number of lines used to display the
current version in the settings.

Bug: 899700
Change-Id: Iab412b30c2e32f5212a05d8b799fdc4cd9777859
Reviewed-on: https://chromium-review.googlesource.com/c/1307439Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603995}

- SMB file sharing can still be disable through managed policies.

Bug: chromium:896414
Test: end-to-end
Change-Id: I4158249d14812a7e28a775af54cc6ed4ee35714f
Reviewed-on: https://chromium-review.googlesource.com/c/1297640
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603994}

The glob statement in copy_trusted_certificate doesn't catch any
simulators like I expect it to; I add a bunch of temporary logging
so that I can figure out where it is failing. This only affects my
WPR tests.

Change-Id: I58e26deb41988d5a9ca2f75b090495aad99303f3
Reviewed-on: https://chromium-review.googlesource.com/c/1308574Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: ericale <ericale@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603993}

Walking the ancestry during layout to figure out what size to use
doesn't work in LayoutNG. Use the provided override size instead.

Modified one test so that it would fail without this fix.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Iac990aed33355ecd49d68cc51bd355d2139f3dcb
Reviewed-on: https://chromium-review.googlesource.com/c/1307393Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603992}

Disable tests on Mac10.12 and Win7

Bug: 899890, 891427, 626703
Change-Id: Iaf47b38dcf45f5fce734325450609a10a9c5d712
Tbr: masonfreed@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1308413
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603991}

This is useful for debugging.

Bug: None
Change-Id: I8e6260f09b3c17f0a9952739387f70a431571011
Reviewed-on: https://chromium-review.googlesource.com/c/1308013
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603990}

This is a temporary code addition to help root-cause a rather elusive
crash (see crbug for discussion). It: 1) adds extra checking of the
AudioBus that, writing to, causes write access violations on Windows;
and 2) adds crash key strings to expose lifecycle/event state leading up
to the crash.

Bug: 888478
Change-Id: Ie7866e69081623cac9833e59d0aaadf1671ad248
Reviewed-on: https://chromium-review.googlesource.com/c/1306656
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603989}

This reverts commit 199a6044.

Reason for revert: NativeAppWindowCocoaBrowserTest.HideShowWithAppWithShim failed on Mac10.12
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/16328

Original change's description:
> MacPWAs: Decouple AppShimHost and AppShimHostBootstrap
> 
> Update AppShimHandler::OnShimLaunch to take a AppShimHostBootstrap,
> and use that to create an AppShimHost, rather than having the
> caller create the AppShimHost.
> * Have the method for AppShimHost creation be in the
>   AppShimHandler::Delegate class for overriding in tests.
> * This sets us up to have the AppShimHost be created before the app shim
>   process has completed launching (and thereby be able to queue up
>   creating windows in the app shim process).
> 
> Add to AppShimHandler::Host's public interface an OnBootstrapConnected
> function, where the AppShimHandler::Host takes ownership of the app
> shim process.
> * This is currently always called immediately after the AppShimHost's
>   creation, but that will change in the next patch.
> 
> Make the tests rely more heavily on the real classes instead of fake
> stubs. In particular, I plan to remove AppShimHandler::Host as an
> abstract interface because the tests cover much more ground when run on
> the real test (and the one real implementation, AppShimHost, has no
> other public methods).
> 
> Make one subtle change in the tests. In the event of a duplicate app
> launch, the app's windows will be focused by the existing AppShimHost,
> because we don't create an AppShimHost in the event of any failure. This
> has the same user-visible behavior (because the windows being focused
> are the same).
> 
> Bug: 896917
> Change-Id: Ideea05d00edc1bf4c11825e70ad44229b1174724
> Reviewed-on: https://chromium-review.googlesource.com/c/1305889
> Commit-Queue: ccameron <ccameron@chromium.org>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603821}

TBR=ccameron@chromium.org,dominickn@chromium.org

Change-Id: I1e60835172d2eac0e402b4de142d16e1edf54dc9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 896917
Reviewed-on: https://chromium-review.googlesource.com/c/1308664Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603988}

This change adds a feature, EnableGpuRasterizationViewportRestriction,
which, when disabled, allows us to enable GPU raster for all content
independent of the viewport trigger.

TBR=chrishtr@chromium.org, as pdr has reviewed, but owns the .h but not .cc part of features.*

Bug: 899399
Change-Id: I986d6e40d93f149cb2d5fc11758ca8b3f0bc1a89
Reviewed-on: https://chromium-review.googlesource.com/c/1303397
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603987}

In our previous CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1066630
We fixed the problem where an element with transform animation and
fill-mode being 'forward' or 'both' should be containing block. This
CL adds test to ensure that the style has IsStackingContext = true in
those cases.

Bug: 764783
Change-Id: Ib110c52f3afd5f68028569c528145162b4c48ed1
Reviewed-on: https://chromium-review.googlesource.com/c/1299203Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603986}

base/files/file_win.cc(276,40):  error: non-constant-expression cannot
be narrowed from type 'int' to 'BOOLEAN' (aka 'unsigned char') in initializer list

Bug: 893460
Change-Id: Iab503865c0478c36d70fb8b7b9def152f70cfb7f
Reviewed-on: https://chromium-review.googlesource.com/c/1301576Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603985}

https://android.googlesource.com/platform/external/perfetto.git/+log/dfe69cae695e..2bc2ea919048


git log dfe69cae695e..2bc2ea919048 --date=short --no-merges --format='%ad %ae %s'
2018-10-30 fmayer@google.com Merge "Bump libunwindstack version."


Created with:
  gclient setdep -r src/third_party/perfetto@2bc2ea919048

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I4b4191f6a6e92b1adea58070c22782d4bda64412
Reviewed-on: https://chromium-review.googlesource.com/c/1308175Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603984}

This change adds memory footprint information for Arc processes into the
chrome task manager. ArcProcessService requests a global dump from
Android, and upon receipt provides it to the task manager (through
ArcProcessTaskProvider)

BUG=799538
TEST=Manual, compared memory footprint in task manager to top

Change-Id: I5e10ba05e28185de750b6deb2f46d9227d4cc751
Reviewed-on: https://chromium-review.googlesource.com/c/1263335
Commit-Queue: Willie Koomson <wvk@google.com>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603983}

This reverts commit 491ed062.

Reason for revert: webkit_unit_tests failure:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/11027

Original change's description:
> [DevTools] Merge InspectorSession and DevToolsAgent::Session
> 
> These are not needed as separate entities anymore, after making
> workers reuse DevToolsAgent::Session. We merge them into a single
> DevToolsSession class.
> 
> Bug: 775132
> Change-Id: I213de7e33c5b7ce12d4f58e1b2daa363ad563b12
> Reviewed-on: https://chromium-review.googlesource.com/c/1282207
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603869}

TBR=dgozman@chromium.org,caseq@chromium.org

Change-Id: Iac3edc4bcd3d97e8ed67c5c35249ffd72c2ef1fc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 775132
Reviewed-on: https://chromium-review.googlesource.com/c/1308659Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603982}

This reverts commit 49c25ee7.

Reason for revert: The original CL doesn't have the desired effects.

Original change's description:
> Disable flaky chromedriver test
> 
> Disable the following test:
> SessionHandlingTest.testGetSessions
> SessionHandlingTest.testQuitASessionMoreThanOnce
> SupportIPv4AndIPv6.testSupportIPv4AndIPv6
> ZChromeStartRetryCountTest.testChromeStartRetryCount
> 
> Bug: 899919
> Change-Id: I4fdebcce8d0784f4a03d740fe75cad489e7cc2f1
> Tbr: johnchen@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/c/1307594
> Reviewed-by: Owen Min <zmin@chromium.org>
> Commit-Queue: Owen Min <zmin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603893}

TBR=zmin@chromium.org,johnchen@chromium.org

Change-Id: Ia4d948632cb8141de5a8214569432e066ab7ab90
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 899919
Reviewed-on: https://chromium-review.googlesource.com/c/1308655Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603981}

https://skia.googlesource.com/skia.git/+log/52a715455181..f5973509ec68


git log 52a715455181..f5973509ec68 --date=short --no-merges --format='%ad %ae %s'
2018-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 3420dcb0cff1..7cba6be85a14 (1 commits)
2018-10-30 mtklein@google.com Revert "replace SkNVRefCnt with SkRefCnt"
2018-10-30 michaelludwig@google.com Pull out sksl emission logic for per-edge aa from GrTextureOp
2018-10-30 jvanverth@google.com Replace use of SkYUVSizeInfo with SkYUVASizeInfo


Created with:
  gclient setdep -r src/third_party/skia@f5973509ec68

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@chromium.org

Change-Id: I707155110ea18460bcf3e430dc1bb72b0262759a
Reviewed-on: https://chromium-review.googlesource.com/c/1307879Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603980}

On certain devices, enabling face detection will trigger tuning
to provide better exposure around the face area. So expose
this configuration to allow an application to enable it if
it wants to.

Currently, this is only supported by Android Camera2 driver.

Bug: b/110420728
Test: Build
Change-Id: I6a512740a0bc06fb1b6f6352dd2f65ce6830bf02
Reviewed-on: https://chromium-review.googlesource.com/c/1110268
Commit-Queue: Peter Qiu <zqiu@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603979}

Since the OpenTab commands needs to know if the Tab should be open in
Incognito or not, we should send the current BrowserState to the VC
so it gets this information.

Conversely all other services depend on the OriginalBrowserState, so we
make sure to use this one for those.

Bug: 895341
Change-Id: Idd7439a81432ec87d201e76d7fd60abec2615bbf
Reviewed-on: https://chromium-review.googlesource.com/c/1299928Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603978}

LocationBarModel is a much more accurate name for this class than
ToolbarModel.

We didn't use OmniboxModel because it may be confused with
OmniboxEditModel.

TBR=sky@chromium.org

Bug: 898347
Change-Id: I845e36fc58e4f8f4b951b83379bb355a4d718e9d
Reviewed-on: https://chromium-review.googlesource.com/c/1306837
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603977}

//third_party/abseil-cpp is currently excluded from
gn check because of a couple of dependency fails. This patch
tries to fix those.

Most complicated is the dependency to gmock. The code does
include "gmock/gmock.h" which gn will see as a dependency on
//third_party/googletest:gmock.

Bug: 898837
Change-Id: I2c1d33935511e790e1343cb59db11908cf4fab15
Reviewed-on: https://chromium-review.googlesource.com/c/1307497
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603976}

Change-Id: I2e8fc39df1a4a94a59e19cdab6ff1e96bcf292a9
Reviewed-on: https://chromium-review.googlesource.com/c/1306473
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603975}

This CL updates the SelectVideoTrackAdapterSettings() function to allow
configuring VideoTrackAdapters with rescaling disabled.

This is in preparation for supporting the resizeMode constrainable
property in getUserMedia().

Drive-by: Fix CONTENT_EXPORT style in header.

Bug: 854980
Change-Id: Ib9c0d33d14d45382ac38af091b0bc3f59b6f90f9
Reviewed-on: https://chromium-review.googlesource.com/c/1286817
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603974}

Bug: 879261
Change-Id: I5513a889df874bef4157245d7ad7454e79777cfa
Reviewed-on: https://chromium-review.googlesource.com/c/1211669Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603973}

Change-Id: I60d5a327f7f0ad22dccdbdcbe15dbfaf89f98918
Reviewed-on: https://chromium-review.googlesource.com/c/1302493Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603972}

This is a precursor to have AR and VR be in separate dynamic feature
modules.

Bug: 837965
Change-Id: I0fb15971db49b858d808f78d93b77a72819cad8c
Reviewed-on: https://chromium-review.googlesource.com/c/1298238
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603971}

This CL was reverted since it depends on a CL that introduced MSAN issues.
Relanding as it is after the MSAN issues have been addressed.

Origianal description:
crrev.com/c/1300235 introduced the option to lower the quality of backdrop
filters.

This CL lowers the quality of the backdrop blur one the shelf and the
applist shield.

In this way the texture allocations needed to apply the filter by cc will
be significantly smaller/faster and applying the filter itself will also
be faster on the GPU.

Bug: 897369
Change-Id: Id56368bbdb18b9e7ec3a284e79ab76c04ec3bf8e
TBR: oshima@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1308036Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603970}

So that in Payments server side logging/metrics we know which source
the request comes from. For normal Chrome Upstream, we default this
field to UNKNOWN.

Bug: 897998
Change-Id: I39e614fe0cd8747fb26e41e8da77dab574cd0f4e
Reviewed-on: https://chromium-review.googlesource.com/c/1306776Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603969}

Known issues:
 * Browser and renderer main threads are still using GLES2Interface instead
   of RasterInterface.
 * RasterDecoder still needs GLContext when --enable-vulkan flag is used.

Bug: 838899
Change-Id: Id70bb41995b357846c15bc106cd3addfe527ad53
Reviewed-on: https://chromium-review.googlesource.com/c/1298336
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603968}

When network service runs out of process, it uses a privileged
process similar to the GPU process. The network process needs
access to AndroidNetworkLibrary, which was not in the main dex.
This was causing many failures when running tests with network
service turned on on KitKat devices, see example failures:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-kitkat-arm-rel/113359

The failures are throwing a ClassNotFoundException for
AndroidNetworkLibrary.

Bug: 827531
Change-Id: I9003a8469719e06cb5a05482d5b7cf24980a32b0
Reviewed-on: https://chromium-review.googlesource.com/c/1306344Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603967}

Notable changes:
 - Removed NavigationManager usage from SadTabView
 - Removed Dispatcher usage from SadTabView
 - Reload the page via dispatcher instead of navigation manager
 - Renamed SadTabView's delegate from actionDelegate to delegate
   (because there is just one delegate)
 - Updated delegate names to match Coding Guidelines for Cocoa

This refactoring will allow to create SadTabViewController to be
presented from SadTabCoordinator. SadTabCoordinator will be a new
class owned by BVC, and created with BrowserContainerViewController
as baseViewController. All new code will be written behind the flag.

The refactoring is needed, because in New Architecture view
controllers are not suppose to have model code.

Change-Id: If98f6d4af9c87a0274b717b266f94f71956b79a0
Reviewed-on: https://chromium-review.googlesource.com/c/1306351Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603966}

resource_map_source generates a map looking like

  { "IDR_FOO", IDR_FOO }

while resource_file_map_source generations a map looking like

  { "path/to/resource", IDR_FOO }

The latter currently doesn't work for files that contain variable references
in their name (e.g. ${root_gen_dir}).

The mojo code just needs any unique string identifier, so just use
resource_map_source instead.

No intended behavior change.

Bug: 899437
Change-Id: Ifc72086bd3b26997fb29d7d43306ba790a2c4e73
Reviewed-on: https://chromium-review.googlesource.com/c/1307937Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603965}

Bug: 898676
Change-Id: Id2c15af3c517ceffe919d5baa1955c00392c9307
Reviewed-on: https://chromium-review.googlesource.com/c/1298302Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Bruno Santos <brunoad@google.com>
Cr-Commit-Position: refs/heads/master@{#603964}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/15a8883b4d7d..f8b5a7154479


Created with:
  gclient setdep -r src-internal@f8b5a7154479

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ibab164d2b57577c5339f346d679d8946cb75eb74
Reviewed-on: https://chromium-review.googlesource.com/c/1307880Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603963}

We don't need to expose a MessageLoop from base::Thread --
task_runner() is enough to post tasks and other functionality
can be accessed via base::MessageLoopCurrent::Get when on the

R=gab@chromium.org
TBR=gab@chromium.org
BUG=891670,668707

Change-Id: I88996daa956f4a5e2dffda6fe31a9ee8102746eb
Reviewed-on: https://chromium-review.googlesource.com/c/1301437Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603962}

https://pdfium.googlesource.com/pdfium.git/+log/05e43638cd37..98bc0ce5c15f


git log 05e43638cd37..98bc0ce5c15f --date=short --no-merges --format='%ad %ae %s'
2018-10-30 tsepez@chromium.org Test util.scand() from javascript


Created with:
  gclient setdep -r src/third_party/pdfium@98bc0ce5c15f

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I0615f754dc180e14a186cd364e06318522c43c68
Reviewed-on: https://chromium-review.googlesource.com/c/1307878Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603961}

When network service is enabled, it is possible for ServiceManager
to launch network service without the browser process. This will cause
a crash in ChromeContentBrowserClient::OnNetworkServiceDataUseUpdate().
This CL fixes the issue by making ChromeDataUsemeasurement a singleton
for network service. Also it fixes a bunch of BrowserThread checks
as BrowserThread will not be available when browser process isn't created.

BUG=898970

Change-Id: I8638239c62a852374f52d5832d86558f4c4bef19
Reviewed-on: https://chromium-review.googlesource.com/c/1303180Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603960}

crrev.com/c/1099564 disabled the Pixel_OffscreenCanvasAccelerated2D*
tests, correctly increasing the version in pixel_test_pages.py.
These tests seem to be passing according to [1], so let's try
and reenable them.

[1] http://chromium-browser-gpu-tests.commondatastorage.googleapis.com/view_test_results.html?868948046954e7d06d97eb10544ea3b27b320953_android_marshmallow_arm64_rel_telemetry

CQ-DEPEND=CL:1303097

Bug: 805031
Change-Id: Ie6b48fde0a03fefbbff185de1818e3105192f5f3
Reviewed-on: https://chromium-review.googlesource.com/c/1303097Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603959}

This is a folow-up for the rename of TaskPriority::BACKGROUND to
TaskPriority::BEST_EFFORT in
https://chromium-review.googlesource.com/1153461.

Bug: 831835
Change-Id: Ia99f3a923622de37cb92490879d2a7b9b6b4f153
Reviewed-on: https://chromium-review.googlesource.com/c/1307673Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603958}

Currently, temporary files in the FileAnalyzer unit tests are written
wherever the tests were invoked from. This CL writes them to a temporary
directory so that 1) we have write permission, and 2) we clean up after
ourselves.

Bug: 900021
Change-Id: Ia5390c6444c96a70e736f33b3091c73e3ad97516
Reviewed-on: https://chromium-review.googlesource.com/c/1306661Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603957}

Bug: 899324
Test: none
Change-Id: I9f632473636f6a6df3e2528a957adadda006a176
Reviewed-on: https://chromium-review.googlesource.com/c/1307236Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603956}