- 12 Sep, 2020 23 commits
-
-
Josh Simmons authored
These heartbeat metrics are still useful. Bug: 1125777 Change-Id: Idedb4c86cd667565d85ff55c314a8d5a8489efef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401816Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#806422}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/32eb03a1fbe2..5c8aa5cd05ae 2020-09-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 86121ae2..9d73c26f (806200:806356) 2020-09-11 jleconte@webrtc.org Remove uppercase after number on gtest names. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6b0245a41614c03164b65be7c62c1f044d61ce79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406976Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806421}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/970bf5ad2cd0..a1e15498cd2d 2020-09-11 norberg@google.com Xcode 12b3 (and later) emits arm64e binaries; try that architecture. 2020-09-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-09-11 gbeaty@chromium.org Handle failures in the bot_update script. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1103236 Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: Idf4caf8972aee38b8a1fe619feefdc410058d8d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406897Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806420}
-
Shrek Shao authored
TBR=kbr@chromium.org Bug: 1127541 Change-Id: Iecab32b2bb40726246bc6856aab482f850e2e9ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406842Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#806419}
-
Darwin Huang authored
OSExchangeData::SetDownloadFileInfo is no longer used anywhere, so remove it. The function it calls, OSExchangeDataProvider::SetDownloadFileInfo[1], is still used. Refactoring change only, so no functional changes expected. [1]: https://source.chromium.org/chromium/chromium/src/+/master:ui/base/dragdrop/os_exchange_data_provider.h;l=93;drc=c741e070dbfcc33b2369e7a5131be87c7b21bb99 Change-Id: I623c86eca682450a8c02d3d46dda0b80e4852252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404538 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#806418}
-
Jeremy Roman authored
They have been identical since UTF-32 support was removed three years ago: https://chromium-review.googlesource.com/c/chromium/src/+/559995/ Bug: 417850 Change-Id: I9db2a9a8a94d18732e8c45caaaffc443ab387f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401341 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#806417}
-
Ken MacKay authored
Bug: internal b/168149351 Test: cast_audio_backend_unittests Change-Id: I4172e243bc514888d127f56c8dfa83e83f9d60ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407057Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#806416}
-
Gang Wu authored
Share icon looks taller than other icons in action bar, so update a new share icon for action bar. Bug: 1127473 Change-Id: I5b22d852f86896a78e56560d7f151afce6e0a6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406680Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#806415}
-
Jazz Xu authored
This CL add MediaNotificationBackground interface and create MediaNotificationBackgroundAshImpl for CrOS implementation. Bug: 1126711 Change-Id: I8c452fe2ccba16f436b9f3844091c62aa8e148e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401313 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#806414}
-
Erik Staab authored
Goes with https://crrev.com/c/2406459 on the build side. Bug: 1117252 Change-Id: I10c876ddfc442a10cc8b1f26392e1ddc17182b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406682 Commit-Queue: Erik Staab <estaab@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#806413}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9eb848ae8218..582c5a9a84ac 2020-09-11 csmartdalton@google.com Fix assert on tessellated stroke join type If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: Id195de19885ded5e3463d5aa72e07b2e3bda8c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406895Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806412}
-
Yusuke Sato authored
This CL depends on the following CLs: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2380431 https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/2378806 https://chrome-internal-review.googlesource.com/c/chromeos/overlays/project-cheets-private/+/3238221 Diff from the original: None. This CL is safe to reland as-is because go/lkgm was updated past 13439.0.0. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2380733 BUG=b:166314117 BUG=chromium:1123901 TEST=arc.Boot.vm still passes, arcvm-adbd runs Change-Id: I828323a877128ae32283110d709c85ceb72e96c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404874 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#806411}
-
Josh Simmons authored
This also sets mUserInteracted = true in a couple places where it was not being set previously. I believe the intention of the bool and the INFOBAR_DECLINE metric is to track the number of immediate closes of the infobar, but please let me know if this isn't the case. Bug: 1123180 Change-Id: Ia8bd867575b7d242554cec8336a31aa5ead714e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388777 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#806410}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7870cf3f0a34..bca88739adb7 2020-09-11 jmadill@chromium.org Add a perf test that cycles through many VBOs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Iab471f2724fe26c388580465e17c764c6a3eec28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406747Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806409}
-
James Zern authored
picks up a couple ubsan fixes 24 commits: https://chromium.googlesource.com/webm/libwebp/+log/0fa56f3..55a080 Bug: skia:10693 Test: layout tests, blink unittests Change-Id: I3d7bc625f27b15a4ea09cebb26042b75be30f8cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406679 Commit-Queue: Urvang Joshi <urvang@chromium.org> Reviewed-by:
Urvang Joshi <urvang@chromium.org> Cr-Commit-Position: refs/heads/master@{#806408}
-
Owen Min authored
When manifest type allowlist policy is set, GetExtensionInstallStatus() function always returns blocked-by-policy when there is no manifest type information. However, it should actually skip the manifest type check. Add a test to verify the fix. Also add a test to verify we can handle similar situation for permission set. Bug: 1124669 Change-Id: I9727222688177a7beb386e5dc473ef21e766ce8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392442Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#806407}
-
Raphael Kubo da Costa authored
VS Code 1.49 introduced a new setting called editor.formatOnSaveMode that makes Format On Save only format modified lines rather than the entire file: https://code.visualstudio.com/updates/v1_49#_only-format-modified-text Add a commented out optional setting that enables that. Change-Id: I13f3e0eb345c065737fd4dffc413cdd9df8689e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404345 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#806406}
-
mwakizaka authored
After running chromedriver with Android Chrome, there will be a listening port not being cleaned up. This commit addresses the issue by calling `adb forward --remove` call. Bug: chromedriver:2421 Change-Id: I606aab3154bc7e5a7cf587de5fd82c9894d1bec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385036Reviewed-by:
Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#806405}
-
Mei Liang authored
After crrev.com/c/2314557, |mOverviewModeController| can be null depends on the stage of Chrome initialization. ChromeNextTabPolicySupplier is created before the OverviewModeController is instantiated, thus the OverviewModeController in that class is always null. and it always returns the HIERARCHICAL policy and messes up the next tab logic in TabModelImpl. This CL fixes the issue by using the ObservableSupplier to supply the OverviewModeController, so by the time Chrome finishes its initialization the ChromeNextTabPolicySupplier would have a valid OverviewModeController. Bug: 1124227 Change-Id: I5123487ba13cf6797e281df1ab834322dd2ef39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404458Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#806404}
-
Markus Handell authored
Recently a few changes (crrev.com/c/2391767 and crrev.com/c/2399238) entered the AVFoundation capturer, and it's better if these are controlled by a new base::Feature instead of raw changes, because 1) More evolution is expected, 2) We had one regression introduced (crbug.com/1124884#c7). 3) Additionally, this change enables A/B testing in a few months. The change introduces a new feature kMacNextGenerationCapturer controlling which implementation (default: new capturer) is in use by the system. The change also dupes the current _mac-suffixed capturer into a new _legacy-suffixed variant. In future CLs, last weeks evolution to the _mac capturer will be reverted inside the _legacy variant. Bug: chromium:1126690 Change-Id: I972663eef38623c9a76e0b2424e048bc24fc7093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401168 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#806403}
-
Xing Liu authored
When there are multiple scheduled downloads in different tabs, always show the scheduled infobar in the latest tab instead of the first tab. Also tweaked the delay, that 2 scheduled download must show inside a 12 seconds window to have the multiple scheduled string shown. Bug: 1123924 Change-Id: I9b9de9d484871b94c2a3e2c4a60dad31950e29d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401404 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#806402}
-
David Bienvenu authored
A little other miscellaneous cleanup, no functional changes. Bug: 1010217 Change-Id: I9d1c56723c0de2293c06c810fa7175cbf5031f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393633Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#806401}
-
Brian Salomon authored
The decoder can choose either if both are available. Bug: skia:10632 Change-Id: Ia089845f7b16354fe20d34762ee41aa24c0a5f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405440 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#806400}
-
- 11 Sep, 2020 17 commits
-
-
Shrek Shao authored
Bug: 1122394 Change-Id: I724673e312a2e4c93ced178adb532323860cc263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406606Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#806399}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ef8507d106ad..32eb03a1fbe2 2020-09-11 deadbeef@webrtc.org Get rid of NetworkMonitorBase helper class. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib0ac3c685f5e36dff3ea3367afc1821a893a3f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406751Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806398}
-
Ayu Ishii authored
This updates get() to return a TypeError if called with no options or empty options. Details of this decision can be found at https://github.com/WICG/cookie-store/issues/94. Bug: 1124073 Change-Id: I3bae610cc6f5d4f46e392d968f7ae82a08bcbab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404412 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#806397}
-
Brian Salomon authored
Bug: skia:10632 Change-Id: I66625bcf31c69df65f104d7abe6cd2508c0a2f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405899 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#806396}
-
Adrienne Walker authored
As I'm adding a 4th file stream reader unittest, I thought I would combine all of the similar-but-not-exactly-the-same sets of file stream reader unittests. This is one behavior difference between all of the file stream readers, so I thought I would clean it up first. This return value is how file system file stream reader and local file stream reader behave when seeking past the end. Change-Id: Ife39c7c82b8aee161dd26aa67e001c09e93d30ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406703 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#806395}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8ed34138a32b..c62a79d55ed7 2020-09-11 andoli@chromium.org [ts] Typecheck css_overview/CSSOverviewSidebarPanel.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2eb9b2f4c1d2f380b4d1508d9e405edb9b254118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406746Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806394}
-
Will Cassella authored
This CL adds two additional feature flags for controlling decoder selection: `DisableNonPlatformVideoDecoders` and `DisableNonPlatformAudioDecoders`. These change the predicate DecoderSelector uses to skip any non-platform decoders, regardless of config resolution. This is primarily useful for testing platform decoders without worrying about fallback. Bug: 1119939 Change-Id: I25191207f65b0da0fc0220133ebf6f383c9dc5d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388272 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#806393}
-
Daniel Hosseinian authored
When the active page changes, scroll the thumbnail into the visible area of the thumbnail bar. Bug: 652400 Change-Id: I6333a66b88202b7dabcb1a0f287b3fbee2d3b701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404564 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#806392}
-
Anders Hartvoll Ruud authored
This CL implements support for element-based offsets in the CSS API. In order to make parsing as painless as possible, the code that consumes a selector(<id-selector>) has been moved from at_rule_descriptor_parser to a separate function in css_parsing_utils (ConsumeSelectorFunction). This makes it possible to reuse that code for parsing element-based offsets. Note that the drive-by removal of the ConsumeWhitespace() call at the beginning of ConsumeScrollOffset is just to align with the convention that whitespace should be consumed _before_ a Consume* function is called. Bug: 1102788, 1074052 Change-Id: I8caa3caa4fe1efe05b4d451c989e10bb9f67267c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391072 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#806391}
-
Sky Malice authored
Bug: 1127502 Change-Id: I28cccaca3666f409f1c266f6319a064b33871946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406185Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#806390}
-
Josiah K authored
AX-Relnotes: N/A Change-Id: I12f3a7b7a4ca94adddb166c8c3f0eaa1ecc1a533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405513 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#806389}
-
Sophey Dong authored
Also removes URL from the screenshot share so they will share properly as image-only shares, and removes the distinction between screenshot and regular shares. Bug: 1123862 Change-Id: Icc763397da04eed96e5d63e09e0a42170fa195c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393008 Commit-Queue: Sophey Dong <sophey@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#806388}
-
Daniel Hosseinian authored
Change the color of the thumbnail of the active page. This CL sets the plumbing for a thumbnail to know it is active. More styling will be added after the painting of the thumbnails is implemented. Bug: 652400 Change-Id: Ib3cd864b13c6a97a46acb6b938ddcd5b1412e570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402438 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#806387}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/83ba93022571..9eb848ae8218 2020-09-11 brianosman@google.com Give SwitchCase it's own Statement::Kind value 2020-09-11 bungeman@google.com Add SkFILEStream constructor which takes a size. 2020-09-11 bungeman@google.com Refactor SkFILEStream for clarity. 2020-09-11 johnstiles@google.com Fix warning in Flutter. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: Ic43923560cb3499989bdb3e04960e62666392b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406743Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806386}
-
Hiroki Nakagawa authored
This CL passes optimization guide hints for DelayCompetingLowPriorityRequests from LocalFrame to ResourceLoadScheduler. Bug: 1112515 Change-Id: I6637aa13cc27b01a4c96edb980e6646b76446202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397116Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#806385}
-
Clark DuVall authored
This metric was not previously recorded on Android because startup_metric_utils::RecordStartupProcessCreationTime was never called. We can use Process.getStartUptimeMillis() to get this value. Bug: 1126301 Change-Id: Ic94be3635389c4a3c9b5e0f870b9d3290767a530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402209 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#806384}
-
Eugene But authored
Chrome relies on prefs::kLastSessionExitedCleanly pref to verify that browsing session has ended exited cleanly as oppose to app crash. The assumption is that prefs::kLastSessionExitedCleanly pref is always flushed and crash detection logic won't work correctly if assumption is not correct. This CL adds a temporary Stability.iOS.UTE.MobileSessionAppState histogram to verify the assumption. The value of the histogram should always be ActiveUTE or ActiveXTE. Any other value indicates that prefs were not properly flushed. Bug: None Change-Id: I09d407d645f05a41179a9e1faee54f0cf294ef40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399769Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#806383}
-