- 24 Jul, 2018 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium b140af05. With Chromium commits locally applied on WPT: 4bd63c29 "webrtc wpt: close RTCPeerConnection in generateAnswer helper" 9f17ab2f "Refactoring XR mojo interfaces" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21666 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: Ia2b83e713246779aa75818735667cbe17592ae57 Reviewed-on: https://chromium-review.googlesource.com/1148805 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#577702}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/315f94a09617..36b2059cae7f git log 315f94a09617..36b2059cae7f --date=short --no-merges --format='%ad %ae %s' 2018-07-24 hnakashima@chromium.org Fix UAF in CPDFSDK_Widget::GetMixXFAWidget(). Created with: gclient setdep -r src/third_party/pdfium@36b2059cae7f The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:860697 TBR=dsinclair@chromium.org Change-Id: I226f5ba0eb56c7773a902ea3c44f30dbe867bf52 Reviewed-on: https://chromium-review.googlesource.com/1148608Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577701}
-
Devlin Cronin authored
It seems that ChromeExtensionsClient::Init() is taking a non-trivial amount of time (see linked bug). Add UMA so that we can track it, and measure any future improvements. Bug: 847237 Change-Id: I1b86dd9a8f2a7500841f253580a9e6d64c9f4d45 Reviewed-on: https://chromium-review.googlesource.com/1142617Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577700}
-
Nate Fischer authored
No change to production logic. Before this CL, locally compiled APKs will have a versionName attribute equal to "Developer Build". This CL changes public Chrome and WebView targets to use the real chromium version number from version.gni. This affects ChromePublic, ChromeModernPublic, MonochromePublic, and SystemWebView. Downstream targets will be addressed in a follow-up CL. R=agrieve@chromium.org, torne@chromium.org chrome_modern_public_apk, monochrome_public_apk) and run `aapt dump badging` on each APK and grep for 'versionName'. Bug: 866739 Test: Build APKs (system_webview_apk, chrome_public_apk, Change-Id: I4e1ab22a2d646ef996a84dd79b015754549bf6ad Reviewed-on: https://chromium-review.googlesource.com/1147871 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:Richard Coles <torne@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#577699}
-
Oksana Zhuravlova authored
Change-Id: Ic544f6b27243a0342aab51ed3fb8a6f809c4a2cc Reviewed-on: https://chromium-review.googlesource.com/1148609Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#577698}
-
Moe Ahmadi authored
screenshot: https://drive.google.com/open?id=1td8sD7YO_VwIlY8WTW5xRc4es7bOslxu Bug: 860526 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9d2f1a589d9ae1bb5bac45c04ceb973f88385a84 Reviewed-on: https://chromium-review.googlesource.com/1145484 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577697}
-
Sunny Sachanandani authored
IsActiveTree() indirectly calls active_tree_.get() in LayerTreeHostImpl. Since std::unique_ptr::reset() nulls out its ptr before deleting the owned object, IsActiveTree() will always be false, and the swap promises will always be broken with ACTIVATION_FAILS. This causes LayerTreeHostTestSwapPromiseDuringCommit to fail when the wait for main frame or commit condition is removed from LayerTreeTest::EndTest(). R=danakj BUG=703263 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3819f76ab8f576c80faccf8db3ecd7ddb9b5954d Reviewed-on: https://chromium-review.googlesource.com/1145920Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#577696}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/68844342e7b7..17fb50f21647 git log 68844342e7b7..17fb50f21647 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 yueherngl@google.com rammus: add new paladin 2018-07-24 vapier@chromium.org cbuildbot: fuzzer: stop processing Chrome stages 2018-07-24 dgarrett@google.com gen_luci_scheduler: Add branched build config support. Created with: gclient setdep -r src/third_party/chromite@17fb50f21647 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Iec8c0d9a4c45f7c216edc01bc296c7265358b320 Reviewed-on: https://chromium-review.googlesource.com/1148606Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577695}
-
Quan Nguyen authored
This button will launch the signin-trouble help app in a future CL. Bug: 863620 Change-Id: Ib6c3cf0179375502f7a5cde5a877c59d76ee73e8 Reviewed-on: https://chromium-review.googlesource.com/1145770 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#577694}
-
Annie Sullivan authored
Bug: 867103 Change-Id: I4130ebfd255a7db799d7a572ddc307267e4edbb7 TBR: charliea@chromium.org NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/1148988Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#577693}
-
Muyuan Li authored
Bug: None Test: Manual Change-Id: I7a9968bb3b421ef26cc90dd68b063e514e3f4094 Reviewed-on: https://chromium-review.googlesource.com/1147502 Commit-Queue: Muyuan Li <muyuanli@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#577692}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d269b0e87d1e..e0ae2989b096 git log d269b0e87d1e..e0ae2989b096 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 benjhayden@chromium.org Add a new ReportTemplate system. 2018-07-24 simonhatch@chromium.org Disable a bunch of pylint warnings. 2018-07-24 nastasoiuf@google.com Initial implementation Created with: gclient setdep -r src/third_party/catapult@e0ae2989b096 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866260 TBR=sullivan@chromium.org Change-Id: I7f71d7246cfd6312d73d4ef4dac17b1c3c6af864 Reviewed-on: https://chromium-review.googlesource.com/1147917Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577691}
-
Gang Wu authored
this CL revert part of https://chromium-review.googlesource.com/c/chromium/src/+/1119234, add LoadAllJournalKeys back and remove LoadAllJournals. Misunderstood the feed host API definition, right now, the API is /** Asynchronously retrieve a list of all current journals */ void getAllJournals(Consumer<Result<List<String>>> consumer); I think we should update it to /** Asynchronously retrieve a list of all current journals' names. */ I will create another bug for this. Bug: 828938 Change-Id: I752fd75d4d4c35c924a4189f754cb393c4d88e1f Reviewed-on: https://chromium-review.googlesource.com/1146067 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#577690}
-
Devlin Cronin authored
The test files for the chrome://extensions page had the 'extension_' prefix (e.g., extension_item_test.js). This is unnecessary, and just makes folks have to type more. Remove it (e.g., item_test.js). This CL only moves files and updates the references in cr_extensions_browsertest.js. Bug: None Change-Id: I028b79830e956aa7ddd89241f8a0335a13d41e23 Reviewed-on: https://chromium-review.googlesource.com/1148552Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577689}
-
Ian Kilpatrick authored
This is a relatively large change to how BFC offset resolving works. In summary: - The BFC line_offset is always calculated. This allows text-indent, etc to be handled inside the inline layout algorithm for empty line-boxes. - THE BFC block_offset is changed to being optional, and we split there offsets out in the NGLayoutResults. This patch doesn't update any documentation, which will occur in a follow up. This also allows us to break the dependency on margin calculation, and constraint space construction, e.g. 1) Create constraint space for margin calculation. 2) Calculate margins. 3) Create constraint space for child layout. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I065aef8b3a66f383256c99b6bdc08191d2481727 Reviewed-on: https://chromium-review.googlesource.com/1144427 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#577688}
-
Marcin Wiacek authored
Change-Id: I7a5297201257fffe5dd89d2b9704d58fa72d463d Reviewed-on: https://chromium-review.googlesource.com/1146187Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#577687}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e09e6ef947d7..d4c16b131f68 git log e09e6ef947d7..d4c16b131f68 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 emircan@webrtc.org Extract color space from H264 decoder Created with: gclient setdep -r src/third_party/webrtc@d4c16b131f68 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If06926b5f6f3025d0c39f0f818307024a04880e4 Reviewed-on: https://chromium-review.googlesource.com/1148602Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577686}
-
Oksana Zhuravlova authored
The last call of SampleGamepads() was removed from PepperPluginInstanceImpl since PepperPluginInstanceImpl::Sample() should not be called. Bug: 855308 Change-Id: I4c88bd5cbae5ec7413ddf32826486c740690b15f Reviewed-on: https://chromium-review.googlesource.com/1147612 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#577685}
-
Peter Kvitek authored
Inspecting protocol log is a great way to analyze what's going on under the hood of a test and should be instantly available. Change-Id: I238499f50074cc1eb6b6666ecc19b2fce17ddbe6 Reviewed-on: https://chromium-review.googlesource.com/1147752Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#577684}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/43ee74f7bd72..b1589ae6be41 git log 43ee74f7bd72..b1589ae6be41 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 dproy@google.com Merge "Extract TraceViewer and introduce ScrollingTrackDisplay" 2018-07-24 dproy@google.com Extract TraceViewer and introduce ScrollingTrackDisplay 2018-07-24 treehugger-gerrit@google.com Merge "trace_processor: add utid to the sched slice table." 2018-07-24 taylori@google.com trace_processor: add utid to the sched slice table. Created with: gclient setdep -r src/third_party/perfetto@b1589ae6be41 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iea7a4cc67bac7aa370da18f96164cfb03bec019f Reviewed-on: https://chromium-review.googlesource.com/1148605 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577683}
-
Ned Nguyen authored
In this first attempt, we retry upload the whole perf dashboard data (JSONnizable) for any recoverable error. Subsequent CL may improve this further by splitting up the perf dashboard data to small parts and only try to reupload the parts which the upload failed. This CL also increase the expiration of the oath token generated for each perf benchmark's data to 30 minutes (used to be 1 minutes by default) Bug: 864565 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: If4cb959cc62c5da3baa4a36a5ae91c10ca6d4d02 Reviewed-on: https://chromium-review.googlesource.com/1148228 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#577682}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/06235df9ff91..ddd6e8746851 git log 06235df9ff91..ddd6e8746851 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 jmadill@chromium.org Vulkan: Suppress 3 failing blit tests on Pixel 2. Created with: gclient setdep -r src/third_party/angle@ddd6e8746851 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I80ab5a032e4ce8b54f968d63ecc0ff8e255da3dd Reviewed-on: https://chromium-review.googlesource.com/1147956Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577681}
-
Xing Liu authored
The CL changes the gear icon to use the material asset. Bug: 864867 Change-Id: I8f37ec3c15a7173b703d88be7a1a7770398eb83b Reviewed-on: https://chromium-review.googlesource.com/1148892Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#577680}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/aebc9e5205dc..fa95e2a7489d git log aebc9e5205dc..fa95e2a7489d --date=short --no-merges --format='%ad %ae %s' 2018-07-24 thomasanderson@chromium.org Revert "Reland "Trigger a buildbot cycle on client.nacl.toolchain"" Created with: gclient setdep -r src/native_client@fa95e2a7489d The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=mseaborn@chromium.org Change-Id: Ic8df81877221d9f2148f7cb6b45f16490da5f86b Reviewed-on: https://chromium-review.googlesource.com/1147916Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577679}
-
Annie Sullivan authored
Bug: 867066, 867068, 867072, 867075, 867079 Change-Id: Icfc04b761cd6cf43480385f5c838bfb69c039931 TBR: charliea@chromium.org NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/1148945Reviewed-by:
-
Philip Rogers authored
Backdrop filters are not supported today. This patch makes this clear in the BlinkGenPropertyTrees expectations file so folks do not spend time fixing the tests. Bug: 854189 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I206c40841c9a1992d122206073afa10dd0953625 Reviewed-on: https://chromium-review.googlesource.com/1148896Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577677}
-
Oystein Eftevaag authored
BackgroundTracingManagerImpl::GenerateMetadataDict was checking IsAllowedFinalization() which blocks every preemptive report from getting this metadata added, as it sets a 7-week cooldown on new reports just prior to this. R=etienneb@chromium.org Change-Id: I3bc44958a304397e4eb6a2db66432ec45454d6f0 Reviewed-on: https://chromium-review.googlesource.com/1148776Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#577676}
-
Quan Nguyen authored
Bug: 863620 Change-Id: I2d9cef017c3c8c4c2feee99bc4f6913baf11c320 Reviewed-on: https://chromium-review.googlesource.com/1145686 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6a4e60bb8f49..642c7b758944 git log 6a4e60bb8f49..642c7b758944 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-24 ethannicholas@google.com fixed geometry shaders when canUseFragCoord is false 2018-07-24 caryclark@skia.org handle failing pathop tests Created with: gclient setdep -r src/third_party/skia@642c7b758944 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:859705 TBR=benjaminwagner@chromium.org Change-Id: Id2d15a495b85a2c515b0c84b3ca1cd2993fff570 Reviewed-on: https://chromium-review.googlesource.com/1147915Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577674}
-
Oriol Brufau authored
[css-logical] Replace uses of webkit-prefixed logical properties with standard ones in /chrome/browser/ Bug 850000 added standard logical properties and aliased prefixed ones to them. The prefixed properties are still used in various places, but the standard ones should be used instead. This patch replaces all the uses in /chrome/browser/. This should fix bug 866783, resulting from a previous replacement of prefixed properties only in /ui/webui/, because /chrome/ still uses prefixed properties and the inconsistency broke some CSS mixins. Spec: https://drafts.csswg.org/css-logical/#box BUG=862141 Change-Id: I73837ed67359b332dfe354d8902a6eff7ed7fede Reviewed-on: https://chromium-review.googlesource.com/1148579Reviewed-by:
-
Ryan Hamilton authored
Extract QuicServerSessionBasePeer to its own file so that GfeQuicServerSessionPeer does not need to be a friend of QuicServerSessionBase. Change-Id: I8d0b2743f903f3fdfaa06346a9f006fccf78e622 Reviewed-on: https://chromium-review.googlesource.com/1148688Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#577672}
-
Edward Jung authored
Bug: 846473 Change-Id: I11e7e6c52cb158c4d2c815cbfab81f0f596317e5 Reviewed-on: https://chromium-review.googlesource.com/1127024 Commit-Queue: Edward Jung <edwardjung@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#577671}
-
David Quiroz Marin authored
Some fonts do not set values for all baselines (hanging, ideographic), and in those cases we're setting 0, which is a valid value. This new interface getBaselines(), returns a dictionary with the set baselines and their values. Bug: 277215 Change-Id: Ie94c74d1c95c7205ed47acaed589ae965f0e32f6 Reviewed-on: https://chromium-review.googlesource.com/1141084Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: David Quiroz Marin <davidqu@chromium.org> Cr-Commit-Position: refs/heads/master@{#577670}
-
karandeepb authored
This CL removes the unused method Warning::CreateNetworkConflictWarning. It seems to have been introduced in r167673 without any usages. BUG=111700 Change-Id: I4f209bbcabafd0f19203f970dab8341c97a256eb Reviewed-on: https://chromium-review.googlesource.com/1148170Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#577669}
-
Fady Samuel authored
This reverts commit 7dc41be6. Reason for revert: activation_dependencies() can change while iterating on updating deadlines or activating late surfaces. Original change's description: > Surface Synchronization: Simplify SurfaceDependencyTracker > > Prior to this CL, SurfaceDependencyTracker read activation_dependencies > from the pending CompositorFrame's CompositorFrameMetadata. This meant > that it had to look up already resolved dependencies. It's more efficient > to use the remaining dependencies set tracked in Surface directly. The code > is also more compact and easier to read. > > Bug: 672962 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Change-Id: I97acf5637fd92eaa6485f15601582dc75dd69c35 > Reviewed-on: https://chromium-review.googlesource.com/1148226 > Reviewed-by: Saman Sami <samans@chromium.org> > Commit-Queue: Fady Samuel <fsamuel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577544} TBR=fsamuel@chromium.org,kylechar@chromium.org,samans@chromium.org Change-Id: I1f3ef525f1de8fab329d86507269ee26b6239675 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1148607Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#577668}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c9f1234b1982..315f94a09617 git log c9f1234b1982..315f94a09617 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 tsepez@chromium.org Rename JS_{METHOD,PROP} to JSE_{METHOD,PROP} Created with: gclient setdep -r src/third_party/pdfium@315f94a09617 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I6f56ba1a620c7f5af48ff1733c44eeb9e5096729 Reviewed-on: https://chromium-review.googlesource.com/1147914Reviewed-by:
-
Robert Sesek authored
This will eventually allow us to remove all XIB files after MacViewsBrowser is fully launched. This also now instantiates and leaks the AppController directly, rather than it being a top-level object in the NIB. Bug: 832676 Change-Id: I1c8ebdff45a92d4aee0f2a8b253274c03a76611c Reviewed-on: https://chromium-review.googlesource.com/1147157 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
Takumi Fujimoto authored
Disable the "Stop" button after it's clicked, so that the user doesn't click on it repeatedly. The button becomes enabled again when there is a model update, or if the user clicks on a sink. When the stop button is clicked for a sink, the sink enters DISCONNECTING state for that dialog, until its route is removed. Bug: 848975 Change-Id: I0acde957053a445fce6bb24cdb54c5e30dd45587 Reviewed-on: https://chromium-review.googlesource.com/1123326 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577665}
-
Rune Lillesveen authored
Pseudo elements match the features of its originating element. We were pushing the selector filter too early causing fast rejection glitches when matching selectors for pseudo elements. Change-Id: I04bc1d7e681ecd6c851bdb3820a9950003e0821d Reviewed-on: https://chromium-review.googlesource.com/1148201 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#577664}
-
Sergey Ulanov authored
Now ContextProvider will run Context process with --disable-gpu. GPU process doesn't work correctly on Fuchsia yet. Bug: 850743, 867052 Change-Id: Ifde22a36beb69f187be07b7fd075a0f8d807bcdf Reviewed-on: https://chromium-review.googlesource.com/1147550 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#577663}
-
