- 29 Nov, 2017 40 commits
-
-
Julien Isorce authored
Introduced recently by https://chromium-review.googlesource.com/756711 "Wrap X11 headers in ui/gfx/x/x11.h" Build error 1: media/gpu/vaapi/vaapi_tfp_picture.cc: error use of undeclared identifier 'RootWindow'; did you mean 'XRootWindow'? x_pixmap_ = XCreatePixmap(x_display_, RootWindow(x_display_, screen), Build error 2: In file included from ../../media/gpu/vaapi_video_decode_accelerator_unittest.cc:14: error: expected unqualified-id /usr/include/X11/X.h:115:30: note: expanded from macro 'None' Bug: 782184 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1b1ecf39baee160e1778e5cdd596426a63e4e054 Reviewed-on: https://chromium-review.googlesource.com/788111Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Cr-Commit-Position: refs/heads/master@{#520205}
-
James Zern authored
BUG=788275 Change-Id: Ied2077ce95dd3a0eb1d97ebf5f063c1da4975025 Reviewed-on: https://chromium-review.googlesource.com/792633 Commit-Queue: James Zern <jzern@google.com> Reviewed-by:
James Zern <jzern@google.com> Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Cr-Commit-Position: refs/heads/master@{#520204}
-
Tommy Steimel authored
Bug: 787743, 785711, 782134 Change-Id: I77fe9a7192697ebe82734231ae709c2094b57b62 Reviewed-on: https://chromium-review.googlesource.com/791813 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#520203}
-
edchin authored
This CL removes -rootViewController in geolocation in an alert that says "Get a better Google experience in Chrome based on your location". Using -rootViewController breaks when presenting the BVC since it is no longer the rootViewController. While we would like to remove TopPresentedViewController() as well as rootViewController, this alert is a special case where the alert can be presented above any window. In the future, this may be replaced by the OverlayService. Bug: 785316 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I26832f3aeaf9eefdbb9a8296e05ac5676438cc1b Reviewed-on: https://chromium-review.googlesource.com/791503 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#520202}
-
Michael Thiessen authored
*sigh*. On some devices running Android O, a window animation that fades between a stale frame and the current frame run when the activity is shown. This leads to 2D UI being shown when entering VR, which is bad. To avoid this, we cancel our animation that keeps the activity hidden only after the Window animation has completed. Bug: 774755 Change-Id: Idbb08bc9d72ff862d1eafc5c0fb952b287a942dd Reviewed-on: https://chromium-review.googlesource.com/797294Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#520201}
-
jdoerrie authored
Prior to this change visible passwords were bound to a specific row in the list of passwords. This led to bugs when the list changed, e.g. when adding or deleting a password, or changing the list of passwords with a search filter. This change fixes this by grouping the password and the UiEntry into a newly introduced typedef. Bug: 786312, 771126 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I25751d6a20b315290f2c52cc76946f85c413405f Reviewed-on: https://chromium-review.googlesource.com/779179Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#520200}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/c5bfbbc86903..81d3bd9213f4 $ git log c5bfbbc86..81d3bd921 --date=short --no-merges --format='%ad %ae %s' 2017-11-28 benjhayden Fix "View Options" dropdown in trace viewer. 2017-11-28 rmcilroy [Metrics] Avoid collecting sub-group events in RuntimeStatsMetric. Created with: roll-dep src/third_party/catapult BUG=786988 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Iec704d0f260deb823313dd427b4d2bfb14c034b7 Reviewed-on: https://chromium-review.googlesource.com/797472 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520199}
-
Nate Chapin authored
There's no additional functionality for DocumentResourceClient. Just use the base class. Bug: 789198 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ied4815fbba70bb6b7e4e856d654c9d2d6035e446 Reviewed-on: https://chromium-review.googlesource.com/792000 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#520198}
-
Vaclav Brozek authored
If the user tries to view or copy passwords in Chrome on Android, the settings page asks them to reauthenticate. The explanation on the reauthentication screen is currently confusing, telling the user that they need to reauthenticate to "continue setting up [their] phone". This CL changes that message to mirror better the user's original intention, mentioning copying or viewing as appropriate. The change has no test. While the instrumentation tests are able to trigger the reauthentication screen, there seems to be no way to read UI elements on that, because it is being rendered by Android and not by Chrome. Bug: 788749 Change-Id: I06c25c837606aa427cb5cb6db39e8e3fbeb5aa07 Reviewed-on: https://chromium-review.googlesource.com/796630 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#520197}
-
Ken Buchanan authored
Currently all RenderFrameImpls call RegisterRenderFrame on the RenderView, and additionally, out-of-process iframe RFIs call it on the RenderWidgets that they own. This is incorrect for local child frames of OOPIFs, because they need to register with the OOPIF's RenderWidget also. This patch corrects and simplifies RenderFrameImpl widget registration, making all of them register with their associated widgets after their WebFrame is created, and unregister just before their WebFrame is destroyed. Bug: 770622 Change-Id: I51be01147d3a810bf6e6c0214150b3714ea1c181 Reviewed-on: https://chromium-review.googlesource.com/791071 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#520196}
-
Tom Sepez authored
Adds a discussion about the need for client-side checks, and corrects the description of parameters to match the current code. Change-Id: I6687c4c6ce12296ccb2ebfebe98e46a75afb8d64 Reviewed-on: https://chromium-review.googlesource.com/797372Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#520195}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c1a3627c..c03152cb Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I2cd61e1976d94a667fa15f68f5bb441af468fd33 Reviewed-on: https://chromium-review.googlesource.com/796934Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#520194}
-
John Budorick authored
Bug: 782848 No-Equivalent-Builders: true Change-Id: I0b47af0f0c24f64811105a7d03ba8d893c443ec0 Reviewed-on: https://chromium-review.googlesource.com/795358 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#520193}
-
Dominik Laskowski authored
This CL cleans up verbose Skia calls in anticipation of more operations on regions in a future CL. It also fixes a no-op due to calling SkRegion::intersects instead of SkRegion::op with kIntersect_Op. Bug: b:67384524 Test: exo_unittests Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ic6059c3e844831ebe5053ded74096e5b0ff86bf8 Reviewed-on: https://chromium-review.googlesource.com/794373 Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#520192}
-
Philip Rogers authored
LocalFrameView::ScrollContentsSlowPath had an invalidation for iframes but this invalidation was already handled will full invalidation. This patch removes this extra invalidation. This makes the root layer scrolling (RLS) and non-RLS expectations match because this extra invalidation was not issued for RLS. Bug: 781419 Change-Id: I2e6bf51682e24b2e2dfa8b56abffa7665ab2bcf4 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Reviewed-on: https://chromium-review.googlesource.com/795183Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#520191}
-
Ashley Enstad authored
There seem to be some issues with run_multiple_telemetry_benchmarks_as_googletest that we haven't quite worked out yet. In the meantime, let's switch this builder back to the singular version that all the other bots are running to be consistent. This will allow us to use the OBBS bot to test the new merge script BUG=chromium:758630 Change-Id: I325614d42a48d4ceb838a4f2d3e9d492b2584b37 Reviewed-on: https://chromium-review.googlesource.com/796510Reviewed-by:
Emily Hanley <eyaich@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#520190}
-
Sidney San Martín authored
Telling the status bubble to orderFront: without adding it as a child of the browser window caused Chrome to unhide (e.g. if the bubble appeared due to background network activity when Chrome was hidden with cmd+H). Just adding it as a child is enough to show it, and doesn't trigger this problem, so remove -orderFront:. Bug: 783521 Change-Id: Ic2c94b0d90d43771a95774e010ad1799feeb8b32 Reviewed-on: https://chromium-review.googlesource.com/782665 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#520189}
-
Elliot Glaysher authored
This changes ash::WindowState to use the aura::Window property that tracks the same thing instead of storing its own state which gets updated from the Window. Bug: 640371 Change-Id: Ia7d3744844fc21a5f437ecd5376d839933b50c65 Reviewed-on: https://chromium-review.googlesource.com/794831 Commit-Queue: Elliot Glaysher <erg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#520188}
-
Matt Reynolds authored
When a MFi gamepad is disconnected, we find the slot it was assigned and clear out its associated data. There is a DCHECK in DeviceRemove that asserts the associated data was found before clearing it. However, if the gamepad was not assigned a slot (for instance, because there were no slots available when the gamepad was connected, or because it the gamepad is blacklisted from enumeration) then the DCHECK fails. Instead, it should ignore the removed device if no associated data was found. This CL also fixes a bug where a slot is still assigned for blacklisted devices. To correct this, the blacklist check is moved above where the slot is assigned. BUG=775268 Change-Id: I65659bc0bf9e9568ea428242ed14604cb7fddb3d Reviewed-on: https://chromium-review.googlesource.com/754083Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#520187}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/8793942c5c7f4a46dcadea3a686c50f2b1c312ed..fc9c67599d9bdeb2e0467085133b81a8e28f77a4 BUG=none Change-Id: Idcd57f5713a84d83f12ae09244e92bc90f264910 Reviewed-on: https://chromium-review.googlesource.com/795233 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#520186}
-
Devlin Cronin authored
DataDeleter::StartDeleting takes a callback to be fired when the deletion is done or scheduled, but no callers use this. Additionally, the callback is making life difficult for a cookies interface refactor. Remove the callback from DataDeleter::StartDeleting(). Since this was the only use of the callback in StoragePartition::ClearDataForOrigin(), remove the callback from that interface as well. Bug: 721395, 787563 TBR=michaelbai@chromium.org (android_webview) Change-Id: I6e90a4275703d4e356beee11f445ee4c9deaa720 Reviewed-on: https://chromium-review.googlesource.com/790754 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#520185}
-
James Zern authored
NOTRY=true NOPRESUBMIT=true (trying to resolve split identity for OWNER approval) Bug: Change-Id: I2c8a9c10a8faef9c633cd9fa0c5b59166b8a5914 Reviewed-on: https://chromium-review.googlesource.com/795017 Commit-Queue: James Zern <jzern@google.com> Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Cr-Commit-Position: refs/heads/master@{#520184}
-
danakj authored
When the browser process sees that gpu compositing is off, it spawns the renderer with --disable-gpu-compositing so that it does not try to set up gpu compositing, then fall back to software, making wasted work. With viz this branch was being skipped since the ImageTransportFactory was not doing anything useful yet. Now that it is, we can query it the same way as we do in non-viz, since it watches the authoritative compositing mode, and checks the command line on startup itself. R=kylechar@chromium.org, piman@chromium.org Bug: 730660 Change-Id: Ibb4a4879f0fe78fa801144f4e7af6635722529f0 Reviewed-on: https://chromium-review.googlesource.com/794910 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#520183}
-
Dave Tapuska authored
The test was not waiting for the frame to have focus before sending the paste event. If there is no focused frame the Paste event gets discarded and the test times out. BUG=789428 Change-Id: I3fb39eb4f38d3156b3844cdb0d708d595d7eb74d Reviewed-on: https://chromium-review.googlesource.com/797432 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#520182}
-
Robert Hogan authored
Bug: 702927 Change-Id: Ifeaa89a292e96bb66a26507ab85cf4e3a81d42c4 Reviewed-on: https://chromium-review.googlesource.com/786014 Commit-Queue: Robert Hogan <robhogan@gmail.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#520181}
-
Luis Hector Chavez authored
This change completely deprecates base::Callback/base::Closure in components/arc. This also adds a PRESUBMIT.py check to avoid introducing new base::{Callback,Closure,Bind} in components/arc as well as chrome/browser/chromeos/arc. Even though there are still instances of base::Bind() in */arc/*, the PRESUBMIT.py checker only warns about touched lines, which should allow us to gradually migrate. Bug: 714018 Test: git cl try Change-Id: I7d36f83869513d1a1e0a71bfa898c25ee78b5fa6 Reviewed-on: https://chromium-review.googlesource.com/794307 Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#520180}
-
Bill Orr authored
Change-Id: If9e9d590cc59d9af204eb3a3f8bf975173ed00de Reviewed-on: https://chromium-review.googlesource.com/794309Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#520179}
-
Xianzhu Wang authored
Previously there were too much repeated output during no-op document lifecycle updates (e.g. when moving mouse in the document). Now log only when the output has changed. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I911be0b3078c923e72131a7091b895449a67bfc5 Reviewed-on: https://chromium-review.googlesource.com/794833Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#520178}
-
Robert Sesek authored
Forgetting to test compilation on Android {arm,arm64,x86,x64,mips} has repeatedly caused internal/downstream breakages in the past. This should add a modicum of sanity. Change-Id: Ibc43d4f118c0ccfa532240d00b2f799722df9700 Reviewed-on: https://chromium-review.googlesource.com/797332Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#520177}
-
Adrian Elder authored
This API is intended for use by an app to read "WebRTC Logs" files generated for debug purposes on devices within Google. I initially proposed making it purely read-only to prevent contention with the creation and writing to audio debug files; however, the app can restrict itself to acting on files that the aec dump process has finished with (as indicated by getting a callback from startAudioDebugRecordings/stopAudioDebugRecordings). While a low volume of debug recordings would eventually be cleaned up after 5 days and a reboot (per WebRtcLogUtil::DeleteOldWebRtcLogFilesForAllProfiles), the needed frequency and volume of recordings would be more flexible if the app could clean up files it generated. Bug: 775961 Change-Id: I8492b0619ee1c98737f0248190d68a1e3bee5bca Reviewed-on: https://chromium-review.googlesource.com/795671Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Adrian Elder <aelder@chromium.org> Cr-Commit-Position: refs/heads/master@{#520176}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/1ff9b7ffa653..7829b7048d5c $ git log 1ff9b7ffa..7829b7048 --date=short --no-merges --format='%ad %ae %s' 2017-11-29 vtsyrklevich [CFI] Enable type generalization for LCMS Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I77d48526f4798f1f6ac785ab2bea642df50a7276 Reviewed-on: https://chromium-review.googlesource.com/796913 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520175}
-
Mircea Trofin authored
Use ScriptState::ForCurrentRealm in static methods, instead of ForRelevantRealm(). Bug: chromium:788453 Change-Id: I63bd25e3f5a4e8d7cbaff945da8df0d71aa65527 Reviewed-on: https://chromium-review.googlesource.com/795096 Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#520174}
-
John Z Wu authored
Includes unit test. Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie224a70867a1e6113b5d58eeb870b17bc23d7d98 Reviewed-on: https://chromium-review.googlesource.com/794411 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#520173}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/935a35bce4ca..329c5a6d826b $ git log 935a35bce..329c5a6d8 --date=short --no-merges --format='%ad %ae %s' 2017-11-29 jvanverth Bundle resources and skps directories into iOS app. 2017-11-29 rmistry Exclude URLs only for some page sets 2017-11-28 benjaminwagner Temporarily add Ubuntu IntelHD4400 jobs. 2017-11-29 bsalomon Revert "Revert "Make PathGeoBuilder use consistent iterators."" Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: Iaac049b0fe96a57ae38fdd92dc6ad2269e89b8e2 Reviewed-on: https://chromium-review.googlesource.com/797113Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520172}
-
Xianzhu Wang authored
This is a reland of f01abd36 The original patch failed on Windows bots because there was no "/tmp" directory. This new patch saves the generated layers-overlay.html in the results directory (existence ensured). Original change's description: > Update paint/invalidation/repaint-overlay/layers-overlay.html > > It is generated by a python test case > (TestRepaintOverlay.test_generate_repaint_overlay_html). > I should have updated it when changing repaint_overlay.py. > > Updated the test to fail and print a message if the file needs an > update. > > Bug: 789272 > Change-Id: I2e6ba6573788177dfbc09d2bd4d3d80023d4b21f > Reviewed-on: https://chromium-review.googlesource.com/794875 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519912} TBR=pdr@chromium.org Bug: 789272 Change-Id: I17de00b123520be148bba4aacd923f21d3f18e9c Reviewed-on: https://chromium-review.googlesource.com/797110Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#520171}
-
Lei Zhang authored
Split it into version specific upgrade functions. Also fix nits in the unit test and elsewhere in components/drive. Change-Id: Ifda20a32115bcd006addaf0801c09512142fa15c Reviewed-on: https://chromium-review.googlesource.com/786630Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#520170}
-
Sergey Berezin authored
This reverts commit 30ff548c. Reason for revert: A-lab devices still have no internet connectivity, causing them to become "unavailable". Original change's description: > [iOS] Re-enable test 'testNetworkConnection' in device_check_egtest.mm > > Since we are beginning to run external URL test again, and labs now has > wifi. We need to re-enable the wifi checker test for swarming_cron use. > > Bug: 763582 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I261b46c63c63160bfae49590fae9248f5d8ffdab > Reviewed-on: https://chromium-review.googlesource.com/794341 > Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519867} TBR=sergeyberezin@chromium.org,baxley@chromium.org,liaoyuke@chromium.org,huangml@chromium.org,shenghuazhang@chromium.org Change-Id: I13642410635d4abf7cc91d3539d6a06236317370 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 763582 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/797490Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#520169}
-
John Z Wu authored
Removing suggestions will remove the underlying autofill data from which it originated. It is possible to remove both autocomplete suggestions as well as profile data for addresses and credit cards. This method will be covered with integration tests in follow up CLs. Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I53a273eed33024e42c89b85cd10dd718cea00884 Reviewed-on: https://chromium-review.googlesource.com/792256Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#520168}
-
Caleb Rouleau authored
Bug: 785554 Change-Id: Ia73174808a48a942bcb2d893c60944f94efc6c4c Reviewed-on: https://chromium-review.googlesource.com/784124Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#520167}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/b0b1ce2c6e90..c5bfbbc86903 $ git log b0b1ce2c6..c5bfbbc86 --date=short --no-merges --format='%ad %ae %s' 2017-11-29 yfriedman Remove left over references to 'work chrome' Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I8dca3d97e50f3d97aa5ec4baf7461bfa59be264a Reviewed-on: https://chromium-review.googlesource.com/796914 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520166}
-