- 27 Feb, 2019 40 commits
-
-
David 'Digit' Turner authored
This CL removes an odd but obsolete feature to the Chromium linker, which added a 16 MiB guard region when loading a given native library. This was done a long time ago when our build system used to process 'regular' shared libraries generated by the linker, in order to compress relocations inside it using a custom scheme. Said relocations were later uncompressed / processed at load time through a static C++ initializer. The main drawback of this scheme was that it modified the correspondance between virtual addresses in the ELF files, and their actual mapped location. This created all kind of chaos for tools like Breakpad, and the guard region was added to mitigate the issue. This custom compression scheme has been completely discarded, in favor of adding the necessary machinery to the linker itself, in order to directly generate shared libraries with the right compressed relocations (which are of course supported by the crazy linker), without any virtual / mapping address space discrepancies. As such, this trick is no longer needed, simplifying our code. This will also make it considerably easier to implementing android_dlopen_ext() in the crazy linker. BUG=504410,936001 R=pasko@chromium.org, agrieve@chromium.org, cjgrant@chromium.org Change-Id: I5a38b952442160072f0e24f48289f41f0269cdc6 Reviewed-on: https://chromium-review.googlesource.com/c/1491271Reviewed-by:
David Turner <digit@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#636071}
-
Kevin Bailey authored
We believe that we're still seeing issues with setting new fields in a protobuf storing information about metrics. This CL reverts setting those fields, and one problematic place where we set a related boolean. OmniboxEventProto.IsKeywordSuggestion - per suggestion OmniboxEventProto.InKeywordMode - per navigation OmniboxEventProto.KeywordModeEntryMethod - if previous field true Original CL: 1351452 Bug: 934316 Change-Id: I099bec55826cb663dee449673a16f4ff1890e2da Reviewed-on: https://chromium-review.googlesource.com/c/1481732Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#636070}
-
Xianzhu Wang authored
Use reftest-wait to avoid the test finishing too early. Change-Id: I2f568e1b4fe55eccec9f07012d7c7f8f6b66fd15 Reviewed-on: https://chromium-review.googlesource.com/c/1491135 Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#636069}
-
Richard Knoll authored
Bug: 891339 Change-Id: I76dc38e26dd359c656e16910dfb1d317e2f64528 Reviewed-on: https://chromium-review.googlesource.com/c/1470691 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#636068}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5450dc0a9c83..617f4eb4e5b7 git log 5450dc0a9c83..617f4eb4e5b7 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 primiano@google.com Merge "Make Producer.CreateTraceWriter thread-safe" 2019-02-27 hjd@google.com perfetto-ui: Unify track and track group borders 2019-02-27 hjd@google.com perfetto-ui: Remove 'Tracks' header panel Created with: gclient setdep -r src/third_party/perfetto@617f4eb4e5b7 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib53566536d684e1cde9a19a2e84717a1d7d732be Reviewed-on: https://chromium-review.googlesource.com/c/1491763Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636067}
-
Jordan Demeulenaere authored
Change-Id: I81198806879df502bc3eb1b7522330c3c4a82805 Reviewed-on: https://chromium-review.googlesource.com/c/1491553 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#636066}
-
Varun Khaneja authored
R=drubery Bug: 934060 Change-Id: Id95aeeead0dc3c5e60bf837d1bc8222385633471 Reviewed-on: https://chromium-review.googlesource.com/c/1490905 Auto-Submit: Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#636065}
-
Gauthier Ambard authored
Bug: 739844 Change-Id: Icf443d02de9567e9f7aacfc04141551337fe8fbb Reviewed-on: https://chromium-review.googlesource.com/c/1488926 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#636064}
-
Matt Menke authored
These tests were in http_proxy_client_socket_pool_unittest.cc. Since the HttpProxyClientSocketPool has since been removed, they need a new home. This CL moves them in with most of the other socket tagging tests, in TransportClientSocketPool's unit test file. This is part of an effort to flatten the socket pools. https://docs.google.com/document/d/1g0EA4iDqaDhNXA_mq-YK3SlSX-xRkoKvZetAQqdRrxM/edit Bug: 472729 Change-Id: Ibf5a26aef732108cb5e1cfedcaf92811387091e3 Reviewed-on: https://chromium-review.googlesource.com/c/1471910 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#636063}
-
Fredrik Söderquist authored
Replace const SVGComputedStyle* with const SVGComputedStyle& as the argument to the Diff*, InheritFrom and CopyNonInheritedFromCached methods. Change-Id: I79c14a39c09089882857fcbe61f4578c18cdd5ac Reviewed-on: https://chromium-review.googlesource.com/c/1491655Reviewed-by:
-
Roman Sorokin authored
- Reloads client_state file every time - Added possibility to save state keys for clients - LocalPolicyTestServer provides function to store configuration file I'm gonna introduce LocalPolicyTestServerMixin in the next CL Bug: 934224 Change-Id: I7960159b5db8c62e2515f8cedccd469e66a4192e Reviewed-on: https://chromium-review.googlesource.com/c/1482459 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#636061}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ff84d8a900d4..cc61a2caa270 git log ff84d8a900d4..cc61a2caa270 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@cc61a2caa270 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I175655299d62488535da86204e850b30662752c4 Reviewed-on: https://chromium-review.googlesource.com/c/1491761Reviewed-by:
-
Katie D authored
Bug: 905419 Change-Id: I3ef77b79942eba2e3e49775cd8195789f0554cf5 Reviewed-on: https://chromium-review.googlesource.com/c/1490446Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#636059}
-
chrome://flagsRob Schonberger authored
retry of submitted CL https://chromium-review.googlesource.com/c/chromium/src/+/1484391. Bug: 911427 Change-Id: Iedc7fde60fd412f3e8f9e548fd6ada85e693fcb4 Reviewed-on: https://chromium-review.googlesource.com/c/1490357Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#636058}
-
Tommy Martino authored
Change-Id: I8736851478dc42f877295ecf3c17c98389d63e9e Reviewed-on: https://chromium-review.googlesource.com/c/1490112Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#636057}
-
Miguel Casas authored
ToT WebmMuxer supports Opus with >2 channels. This configuration is never actually used (because AudioMediaStreams in Chrome don't support it [1]) and can cause a write after bounds (see bug). This CL removes the guilty code by not supporting >2 channels audio. [1] https://chromium.googlesource.com/chromium/src/+/HEAD/third_party/blink/renderer/modules/mediarecorder/README.md#can-record-stereo Bug: 930035 Change-Id: I964c66bc660e76ee152563804c63276643f4acd6 Reviewed-on: https://chromium-review.googlesource.com/c/1489185 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#636056}
-
Sky Malice authored
Bug: 936155 Change-Id: I13d30f3a8d3893e2e27b696797f09cc5c5643495 Reviewed-on: https://chromium-review.googlesource.com/c/1490733 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#636055}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bbe224bbe87b..0c952caaabe0 Created with: gclient setdep -r src-internal@0c952caaabe0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id7d53d5928abf8e7d52816c7475b51c5ed804748 Reviewed-on: https://chromium-review.googlesource.com/c/1491759Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636054}
-
Wei-Yin Chen (陳威尹) authored
ThumbnailCache::DecompressThumbnailFromFile() was originally used in Hera. After Hera was unlaunched, it has been unused until repurposed for TabGridLayoutAndroid feature. Grid layout needs to read the thumbnail and show it in the tab switcher, so the priority should be increased to USER_VISIBLE. Bug: 930929 Change-Id: I203a0e01331e2b0153e0b0c92221880e8779b2a9 Reviewed-on: https://chromium-review.googlesource.com/c/1487776Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#636053}
-
Donn Denman authored
Enables the Ephemeral Tab, aka "Sneak peek" context menu item, to our testing configuration. BUG=894619 Change-Id: I9ed3499fa74cc8124641524e79b6a0976ba7eb6b Reviewed-on: https://chromium-review.googlesource.com/c/1368586Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
Olivier Robin authored
Due to crbug.com/892612, the AutofillDriver can live longer than the webFrame. As a consequence, it is not possible to store the frame pointer and the WebFrame must be retrieved using the frame ID before each use. Bug: 935003 Change-Id: I5462907be5d7d2f70900c135af16ac3e774fae16 Reviewed-on: https://chromium-review.googlesource.com/c/1488791Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#636051}
-
Michael Lippautz authored
Tbr: jochen@chromium.org Bug: 843903 Change-Id: Iadcfb46bdda3692b3b8717176c2ef992f83ba472 Reviewed-on: https://chromium-review.googlesource.com/c/1491653 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Meredith Lane authored
Clusterfuzz identified a null pointer dereference in ComputedAccessibleNode. The local frame is requested from the document reference stored on the element, which can be null. BUG=919310 Change-Id: I9deb28a0dea042ffc96dba7ce8ddd9efeeab2bd8 Reviewed-on: https://chromium-review.googlesource.com/c/1457696 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
Josh Nohle authored
Implements the client end of the CryptAuth v2 Enrollment protocol, which consists of two request/response interactions with the CryptAuth servers: 1a) SyncKeysRequest: Contains the names of key bundles used by us--the client--as well as the handles and metadata of any existing keys in those key bundles. General metadata about the local device, such as hardware and feature support, is also included. Even if new key bundles are not being enrolled and no metadata is being changed, the Enrollment protocol requires periodic check-ins with the CryptAuth server. 1b) SyncKeysResponse: The response from CryptAuth includes instructions about what existing keys should be active, inactive, or deleted altogether. It also provides information about what new keys, if any, should be generated and added to one of the key bundles listed in the request. Aside from key instructions, a client directive is returned, which provides paramaters related to scheduling the next check-in with the server. 2a) EnrollKeysRequest: The second request in the Enrollment protocol is only necessary if the client needs to enroll new keys, as denoted in the SyncKeysResponse. The request contains information such as the material of the new public key (if it is an asymmetric key) and necessary proof for verifying that we indeed possess the private or symmetric key. 2b) EnrollKeysResponse: We simply view this response as an indication that the EnrollKeysRequest was sucessful. The enrollment flow is triggered on construction, and when the enrollment attempt finishes--successfully or not--the |callback| is invoked. Bug: 899080 Change-Id: I3bb662677b21247180e96dc96bf6eea7c4af25df Reviewed-on: https://chromium-review.googlesource.com/c/1464966 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#636048}
-
Kyle Milka authored
After https://crrev.com/c/1468786 InstantUITestBase is only used by InstantExtendedTest. Eliminate the base class and move the functionality. Bug: 791066 Change-Id: I700b0efddf0167a780e0637fe41b270e3c2abbf8 Reviewed-on: https://chromium-review.googlesource.com/c/1490215 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#636047}
-
Ross McIlroy authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1481336 support was added for clearing the ThinLTO cache in order to address a bug in LLVM when disabling outlining. However this caused problems with the bots where linking was happening at the same time. As such, remove this step and remove the ability to change the whether outlining is enabled as a gn flag. BUG=chromium:931297,chromium:935985 Change-Id: I53a33f0178346697842d3f14428d4a8b82dd2409 Reviewed-on: https://chromium-review.googlesource.com/c/1491435Reviewed-by:
-
Olivier Robin authored
WebFrame destructor can lead to calling callbacks that will try to access the WebFrame via GetFrameWithId. This leads to reentrancy problem on the std::map. Remove the WebFrame from the map before destroying it. Bug: 935000 Change-Id: I458cef209d509dd0c61acdb3b9da01cf301d49c1 Reviewed-on: https://chromium-review.googlesource.com/c/1488732Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#636045}
-
Rayan Kanso authored
The observer class should either inherit from base::CheckedObserver, or use the `Unchecked` property when accessing the observers from the list. The provided example is in a half-way state that doesn't work, so I updated it to the recommended method (using CheckedObserver). Change-Id: I3062e7d6829240c1ffefbe6ae5a9444e238b4529 Reviewed-on: https://chromium-review.googlesource.com/c/1491811 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#636044}
-
David Bokan authored
WebView has an API to allow it to take a snapshot of all the content in the page. This wasn't implemented in BlinkGenPropertyTrees. The fix here is simple: avoid adding a clip node for the main LayoutView if !MainFrameClipsContent is set. Bug: 934244 Change-Id: I8d2f4448d1acc2d1ca0ba7d251bac12e8e471a3e Reviewed-on: https://chromium-review.googlesource.com/c/1491131 Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
-
Fredrik Söderquist authored
Like for "normal" strokes, this avoids computing the stroke shape during layout. Bug: 435097 Change-Id: I4927e11e78fbdb78d3275a5c661027185ef18161 Reviewed-on: https://chromium-review.googlesource.com/c/1491411Reviewed-by:
-
Jeremy Roman authored
DowncastTraits<RemoteFrame>::AllowFrom may be given a non-RemoteFrame as its argument (its job is to determine that), so the parameter is properly called "frame". DowncastTraits<RootFrameViewport>::AllowFrom used to be a macro and so escaped the style rewrite that should have given it a hacker_case name, "scrollable_area". Bug: 891908 Change-Id: Ibce0b9a6e047241810baa17d33c072bf423a6023 Reviewed-on: https://chromium-review.googlesource.com/c/1491793 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#636041}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b2c5023c9c1f..af5d1865b721 git log b2c5023c9c1f..af5d1865b721 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 cwallez@chromium.org DawnTest: Use last adapter on Metal 2019-02-27 brandon1.jones@intel.com Add ValidateCanRecordCommands to Debug Marker APIs Created with: gclient setdep -r src/third_party/dawn@af5d1865b721 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I6096eb116b3497957344c656d45a382d6b5ccaec Reviewed-on: https://chromium-review.googlesource.com/c/1491755Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/be28670fe2bf..fe34723a55ec git log be28670fe2bf..fe34723a55ec --date=short --no-merges --format='%ad %ae %s' 2019-02-27 sergiyb@chromium.org Add gerrit.abandon_change command Created with: gclient setdep -r src/third_party/depot_tools@fe34723a55ec The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:935715 TBR=agable@chromium.org Change-Id: Iedff05e604b78773d9921469775055629e0c9ea7 Reviewed-on: https://chromium-review.googlesource.com/c/1491758Reviewed-by:
-
Ehsan Karamad authored
When a frame is navigated to a mime-type related to MimeHandlerView, an HTMLDocument is created by injecting an HTML string in the response. The HTML string is in nature similar to PluginDocument, and similar to the PluginDocument it should resepct the background color associated with the plugin (obtained from WebPluginInfo). This CL changes the HTML string so that it uses the correct color. TBR=wjmaclean@chromium.org Bug: 659750 Change-Id: Iaf3f0e3ed95cd1de2d7450cdbc6317216629f320 Reviewed-on: https://chromium-review.googlesource.com/c/1487187Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#636038}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/db42ed299a4e..1a7a4afd139e git log db42ed299a4e..1a7a4afd139e --date=short --no-merges --format='%ad %ae %s' 2019-02-27 titovartem@google.com Fix encoded image data injectors. 2019-02-27 ilnik@webrtc.org Fix video_loopback tool with different TL numbers in simulcast streams 2019-02-27 mbonadei@webrtc.org Fix more -Wextra-semi. 2019-02-27 artit@webrtc.org Remove iOS 9 support from mb config Created with: gclient setdep -r src/third_party/webrtc@1a7a4afd139e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:926235 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icc2a13f08578ed68e605b7a4c6d7bb0616a5708d Reviewed-on: https://chromium-review.googlesource.com/c/1491753Reviewed-by:
-
Richard Knoll authored
Bug: 891339 Change-Id: I6d1df509fd7725da90f78c3063cedec9a5479189 Reviewed-on: https://chromium-review.googlesource.com/c/1470235 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Antonio Gomes authored
This CL removes the DowncastTraits implementation in shadow_root.h that is actually used to upcasts (ie cast from a sub to a base class). In this case an implicit cast is enough. However, in this particular case the explicit cast was needed because it is used within a ternary c++ operator, a ? b : c. In this case, b and c must be of compabitle types, otherwise the compiler complains. This came out while discussing [1]. [1] https://crrev.com/c/1481473/2/third_party/blink/renderer/core/dom/shadow_root.h#39 BUG=891908 Change-Id: I824cb4a6847cd762ad262cb79ef71ed2c2fec231 Reviewed-on: https://chromium-review.googlesource.com/c/1491831Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#636035}
-
Mugdha Lakhani authored
sending any pending Background Sync events, before exiting the background task that woke up the browser. Bug: 924490 Change-Id: Id63b2d9edeb6e9255dff616ea06f02c9f77cc0d3 Reviewed-on: https://chromium-review.googlesource.com/c/1477707 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#636034}
-
Edin Kadric authored
See associated bug for design doc and screen recording showing the new control. This CL gets us most of the way there, but there are still things to do in subsequent CLs before we start using this control: - I only tested this on Mac for now. I will add support for other OSes later. - The accessibility isn't quite right. It says to select with control+option+space, but that doesn't work. I noticed that it doesn't work for the regular Combobox either, so I will fix it for both in a later CL. Bug: 923660 Change-Id: I8e959e068af23491a842c4bc0fa9661cbd2869dd Reviewed-on: https://chromium-review.googlesource.com/c/1466186 Commit-Queue: Edin Kadric <edinkadric@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#636033}
-
rbpotter authored
- Move pages and scaling tests into the test files for these tests - Simplify pages test, to only validate changing the dropdown, since the rest of this test is duplicating other tests. - Add and modify utility methods for setting dropdowns/inputs and use in pages/scaling tests and elsewhere - Split pages tests into interactive_ui_tests and browser_tests more clearly, and remove duplicates. Change-Id: I6a1cce70d5b222f843badfbe8a8508ebcb309b16 Reviewed-on: https://chromium-review.googlesource.com/c/1487147 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#636032}
-
