GitLab

Without this, the notification could get grouped with one of the other
types of Chrome notifications.

BUG=675961

Review-Url: https://codereview.chromium.org/2618733003
Cr-Commit-Position: refs/heads/master@{#441955}

BUG=660907
TEST=StyleRelatedMainThreadScrollingReasonTest.ClipPathTest;
StyleRelatedMainThreadScrollingReasonTest.ClipTest;
StyleRelatedMainThreadScrollingReasonTest.BorderRadiusTest
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2613743002
Cr-Commit-Position: refs/heads/master@{#441954}

updatePaintProperties -> prePaint
synchronizedPaint -> paint
synchronizedPaintRecursively -> paintGraphicsLayerRecursively

Review-Url: https://codereview.chromium.org/2613983002
Cr-Commit-Position: refs/heads/master@{#441953}

NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2620513002
Cr-Commit-Position: refs/heads/master@{#441952}

When the BrowserScheduler/RedirectHistoryService experiment is disabled,
HistoryService uses a dedicated thread for backend operations. This thread
is joined when the HistoryService is deleted.

When the BrowserScheduler/RedirectHistoryService experiment is enabled,
HistoryService uses a TaskScheduler sequence for backend operations.
These tasks can run after the HistoryService has been deleted.

History backend tasks access databases in the profile directory. A crash
occurs if these accesses occur after the profile directory has been deleted.
To prevent this from happening in ProfileBrowserTest.*., this CL adds code to
flush TaskScheduler before deleting the profile directory.

BUG=661143, 676714

Review-Url: https://codereview.chromium.org/2611053003
Cr-Commit-Position: refs/heads/master@{#441951}

Revert of [Android] Disable system_health.common_mobile on nexus 7 devices. (patchset #1 id:1 of https://codereview.chromium.org/2611753005/ )

Reason for revert:
Didn't fix.

Original issue's description:
> [Android] Disable system_health.common_mobile on nexus 7 devices.
>
> BUG=667470
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
>
> Review-Url: https://codereview.chromium.org/2611753005
> Cr-Commit-Position: refs/heads/master@{#441690}
> Committed: https://chromium.googlesource.com/chromium/src/+/a73420c80a6038860cc35d1d6f1498c963ba2b52

TBR=nednguyen@google.com,sullivan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=667470

Review-Url: https://codereview.chromium.org/2618013002
Cr-Commit-Position: refs/heads/master@{#441950}

We're deprecating the default constructor of Supplement.

This CL also refactors PagePopupSupplement to make the implementation
closer to other supplement implementations.

BUG=610176

Review-Url: https://codereview.chromium.org/2617113003
Cr-Commit-Position: refs/heads/master@{#441949}

BUG=NONE

Review-Url: https://codereview.chromium.org/2610103003
Cr-Commit-Position: refs/heads/master@{#441948}

This patch removes indexed_db_messages.h and makes
IndexedDBDispatcherHost no longer a BrowserMessageFilter.

Handling the special case of a channel close during a DB open operation
does not seem to be necessary as long as we ensure that the database
handle does not get stuck in a closed Mojo pipe so the logic (and test
for it) have been removed.

BUG=627484

Review-Url: https://codereview.chromium.org/2601163002
Cr-Commit-Position: refs/heads/master@{#441947}

* Delete some one-line helper functions.
* Provide some more default method implementations in class Group.

BUG=659631

Review-Url: https://codereview.chromium.org/2616953002
Cr-Commit-Position: refs/heads/master@{#441946}

ExceptionState should not be ignored in production code unless you have
a strong reason to do so. However, people have abused IGNORE_EXCEPTION
and ignored ExceptionState that should not be ignored...

To discourage further mis-usage, this CL renames IGNORE_EXCEPTION to
IGNORE_EXCEPTION_FOR_TESTING.

BUG=670619

Review-Url: https://codereview.chromium.org/2615953003
Cr-Commit-Position: refs/heads/master@{#441945}

BUG=675561

Review-Url: https://codereview.chromium.org/2618703004
Cr-Commit-Position: refs/heads/master@{#441944}

This is one of the steps to deprecate the default constructor of Supplement.

BUG=610176

Review-Url: https://codereview.chromium.org/2614143002
Cr-Commit-Position: refs/heads/master@{#441943}

BUG=674509

Review-Url: https://codereview.chromium.org/2610323003
Cr-Commit-Position: refs/heads/master@{#441942}

Continuation of cl/2615613005, updating module page_test to legacy_page_test.

BUG=678600
TBR=bustamante

Review-Url: https://codereview.chromium.org/2614123003
Cr-Commit-Position: refs/heads/master@{#441941}

No changes other than modifying includes and appropriately forward
declaring the class.

BUG=625684
TBR=girard@chromium.org, clamy@chromium.org, jochen@chromium.org

Review-Url: https://codereview.chromium.org/2590273002
Cr-Commit-Position: refs/heads/master@{#441940}

This change adds the header and the Order Summary section to the
Payment Sheet in the Payment Request dialog. Both sheets still need
many tweaks and extra features but this is the first step towards the
dialog actually looking like the design specs.

Mocks here:

https://folio.googleplex.com/chrome-ux/mocks/329-future-web-pay/latest/desktop#

A screenshot of the Payment Sheet is here:

https://drive.google.com/file/d/0B-DVbqI3huZGREpIaE5yMDZjZzA/view?usp=sharing

A screenshot of the Order Summary shown when clicking the Order Summary
row is here:

https://drive.google.com/file/d/0B-DVbqI3huZGM0F0cC1sS2xLTWs/view?usp=sharing

BUG=676112

Review-Url: https://codereview.chromium.org/2592833002
Cr-Commit-Position: refs/heads/master@{#441939}

https://skia.googlesource.com/skia.git/+log/b38db9a48db0..f80f115dd5ae

$ git log b38db9a48..f80f115dd --date=short --no-merges --format='%ad %ae %s'
2017-01-06 kjlubick Be able to fuzz a directory of input

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=csmartdalton@google.com

Review-Url: https://codereview.chromium.org/2619553002
Cr-Commit-Position: refs/heads/master@{#441938}

This reverts commit c5f4d723.

Reason for revert:
Broke Mac trunk of official.desktop.continuous builder (https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac%20trunk/builds/44193/steps/compile/logs/stdio)

TBR=pkasting@chromium.org,pastarmovj@chromium.org
BUG=678919

Review-Url: https://codereview.chromium.org/2618913002
Cr-Commit-Position: refs/heads/master@{#441937}

Roll material_components_ios to v19.0.0 (079c1c9a) and
material_roboto_font_loader_ios to v1.1.1 (e9b8647).

Add a workaround to allow compilation of material_roboto_font_loader_ios
until upstream fixes the incorrect #import path (see [1] for tupstream issue).

[1]: https://github.com/material-foundation/material-roboto-font-loader-ios/issues/6

BUG=673904

Review-Url: https://codereview.chromium.org/2618583004
Cr-Commit-Position: refs/heads/master@{#441936}

* Adds the first test for RecentTabsPage.
* Extracts RecentlyClosedTabManager interface from RecentlyClosedBridge to enable injection of a fake in tests.
* Deletes a bunch of one-line helper functions.
* Minor cleanups like using diamond operators and restricting visibility.

BUG=659631

Review-Url: https://codereview.chromium.org/2610143002
Cr-Commit-Position: refs/heads/master@{#441935}

The file was never added to the build and is now hopelessly out of date.
Other parts of the code exercise AutofillAddress sufficiently anyway.

BUG=672196

Review-Url: https://codereview.chromium.org/2563523002
Cr-Commit-Position: refs/heads/master@{#441934}

Chrome shouldn't be started for ARC++ Kiosk sessions.
However, if it's not started at all before "kSilentLaunch" check,
then bottom bar is shown.
Starting Chrome silently avoid it and shows only blank wallpaper until app is started.

As in future dedicated ARC++ Kiosk initialization flow with Splash Screen will be added,
the issue should pass away together with it, but we need temporary fix for M56 launch.

BUG=676185
TEST=Manual, Start ARC++ Kiosk sessions.

Review-Url: https://codereview.chromium.org/2604813002
Cr-Commit-Position: refs/heads/master@{#441933}

As ARC++ kiosk should always be running during the ARC++ kiosk session,
it make sense to restart it when there is notification that the task was closed.
However, it won't restart the app if some preconditions are not yet satisfied,
e.g. policy is not compliant, app is not ready.

BUG=676825
TEST=Manual, Run Kiosk on ARC++ device

Review-Url: https://codereview.chromium.org/2599333002
Cr-Commit-Position: refs/heads/master@{#441932}

The infrastructure of async_test LayoutTests was changed recently, and
one effect is that an assert inside an event listener will cause the
test to time out instead of returning the error. This makes the test
much more difficult to debug failures. Additionally, promise_test is just
nicer when it's easy to return a promise.

This CL updates the existing budget tests which run in service workers to
use promise_test. It also cleans up a bit of style.

BUG=617971

Review-Url: https://codereview.chromium.org/2600733002
Cr-Commit-Position: refs/heads/master@{#441931}

BUG=676820

Review-Url: https://codereview.chromium.org/2616933004
Cr-Commit-Position: refs/heads/master@{#441930}

If there is an untriggered idle task when the document is gone, it
introduces memory leak because IdleRequestCallbackWrapper keeps a
reference to the ScriptedIdleTaskController, making it live longer
than the document.

This patch fixes the issue by letting IdleRequestCallbackWrapper
store a WeakPersistent instead.

BUG=595155

Review-Url: https://codereview.chromium.org/2618893002
Cr-Commit-Position: refs/heads/master@{#441929}

The Reading List Collection View does not need to be reloaded for every change.
This CL reloads it only if some changes occurred.

BUG=677924

Review-Url: https://codereview.chromium.org/2609173002
Cr-Commit-Position: refs/heads/master@{#441928}

Sync Encryption screen now listens to sync changes and reloads itself
when necessary. This ensures modifications to the passphrase (done by
the Sync Encryption Passphrase screen) are reflected in the UI.

BUG=678609

Review-Url: https://codereview.chromium.org/2610403003
Cr-Commit-Position: refs/heads/master@{#441927}

Reload will delete Pending Item so altering it and reload will reload
the lastCommittedItem.
If there is a pending item, stop loading and trigger a new navigation.

BUG=678293

Review-Url: https://codereview.chromium.org/2610953002
Cr-Commit-Position: refs/heads/master@{#441926}

Browser actions will be reordered in a future change.

BUG=648558, 648563, 673362

Review-Url: https://codereview.chromium.org/2607533004
Cr-Commit-Position: refs/heads/master@{#441925}

It's not needed. ContextClient is used to detect if a frame is detached,
but we can check it with scriptState->contextIsValid().

BUG=610176

Review-Url: https://codereview.chromium.org/2614943003
Cr-Commit-Position: refs/heads/master@{#441924}

This class is only used for the RecentTabsPage.

BUG=659631

Review-Url: https://codereview.chromium.org/2612243002
Cr-Commit-Position: refs/heads/master@{#441923}

We're deprecating the default constructor of Supplement.

BUG=610176

Review-Url: https://codereview.chromium.org/2619543002
Cr-Commit-Position: refs/heads/master@{#441922}

Moves the test code out of RangeCheck. Reorders range comparisons and
removes bitfields to avoid a GCC constexpr bug. Removes some custom
optimizations that are no longer necessary after the restructuring.

TBR=tsepez

Review-Url: https://codereview.chromium.org/2614073002
Cr-Commit-Position: refs/heads/master@{#441921}

We're deprecating the default constructor of Supplement.

BUG=610176

Review-Url: https://codereview.chromium.org/2615713006
Cr-Commit-Position: refs/heads/master@{#441920}

There are crash reports that |m_resource| is broken in
ResourceLoader::didReceiveResponse. It is strange as ResourceLoader::m_resource
is constant after its construction. To investigate the issue, this CL adds some
CHECKs in ResourceLoader.

BUG=675947
R=tyoshino@chromium.org

Review-Url: https://codereview.chromium.org/2619513002
Cr-Commit-Position: refs/heads/master@{#441919}

If we pass in ScriptState to DOMWindowSpeechSynthesis::speechSynthesis,
DOMWindowSpeechSynthesis doesn't need to observe ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2618613006
Cr-Commit-Position: refs/heads/master@{#441918}

When dismissing a suggestion through the context menu, it is possible
that by the time the animation ends, we navigated away from the NTP
and it got destroyed, resulting in an NPE. We now exit early when
that is the case.

This CL also reverts the ineffective tentative fix from
https://codereview.chromium.org/2553163002

BUG=668945

Review-Url: https://codereview.chromium.org/2614753002
Cr-Commit-Position: refs/heads/master@{#441917}

BUG=673904
R=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2610423002
Cr-Commit-Position: refs/heads/master@{#441916}