- 22 Jun, 2017 40 commits
-
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/9a25eded6f4a..7726a581626b $ git log 9a25eded6..7726a5816 --date=short --no-merges --format='%ad %ae %s' 2017-06-22 palmer Add a |gGeneralPartitionAllocator| and use it in the |FX_*Alloc| wrappers. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I9324a223ffe921ec90f2507899f08463bd6c9b93 Reviewed-on: https://chromium-review.googlesource.com/544619 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#481633}
-
Sorin Jianu authored
The idea here is that for the Chrome Recovery component, there is a payload that must be run to repair the Omaha updater, when the updater is broken. This payload is an EXE file, which is enclosed in a CRX container. The signing keys for this CRX must be injected in the code, so that we the test code can work. Bug: 687231 Change-Id: I0b6b894da4a2ca65e2a157d88d7167a10051a860 Reviewed-on: https://chromium-review.googlesource.com/542095Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#481632}
-
Charles Harrison authored
This patch adds a "Learn more" link to the expanded infobar, which will send users to a Chrome help page about the feature. The page is not currently implemented, so until M61 hits stable the link will be broken and just land on the support home page. Bug: 689992 Change-Id: If7d85ad643ce872a48fb7538967886ffebd5fe8d Reviewed-on: https://chromium-review.googlesource.com/541519Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Dan Alcantara <dfalcantara@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#481631}
-
alemate authored
BUG=709244 Review-Url: https://codereview.chromium.org/2952903002 Cr-Commit-Position: refs/heads/master@{#481630}
-
eakuefner authored
This CL deletes the old, now-unused version of the WebRTC stats metric. This metric has long since been ported to TBMv2, and this version uses a library from Catapult that has been moved, so it is blocking the deletion of a shim. BUG=catapult:#3612 Review-Url: https://codereview.chromium.org/2950373002 Cr-Commit-Position: refs/heads/master@{#481629}
-
Nicolas Capens authored
This enables running Chrome OS without using the GPU by specifying --use-gl=swiftshader on the command line. BUG=swiftshader:67 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1a1bf2bc088353f63bee6ad94de47c38a4979262 Reviewed-on: https://chromium-review.googlesource.com/543555Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nicolas Capens <nicolascapens@google.com> Cr-Commit-Position: refs/heads/master@{#481628}
-
Eric Holk authored
https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/29e4a2c5d..7a65a4734 $ git log 29e4a2c5d..7a65a4734 --date=short --no-merges --format='%ad %ae %s' 2017-06-21 eholk@chromium.org Fix asan builds 2017-06-19 eholk@chromium.org Add first chance exception handler API Bug: v8:5277, chromium:722585 Change-Id: Iccfcdef2d7e5d31cc811619764631a5add720aa2 Reviewed-on: https://chromium-review.googlesource.com/541842 Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#481627}
-
scottmg authored
Revert of Show Play Store rating and price in app list (patchset #5 id:80001 of https://codereview.chromium.org/2949733002/ ) Reason for revert: dbg cros failed to compile, unfortunately i guess that's not on the cq :/ log here: https://luci-milo.appspot.com/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Builder%20%28dbg%29/88671 Original issue's description: > Show Play Store rating and price in app list > > 1. Provide interfaces in app_list::SearchResult to set price and rating > for instant and play store apps based on specs. > 2. Change the layouts of SearchResultTileItemListView and > SearchResultTileItemView to show price and rating properly based on > specs. > > Specifications: > https://screenshot.googleplex.com/AFQ5HnrMYch > https://screenshot.googleplex.com/0opcNunaJrZ > > The screenshot: https://screenshot.googleplex.com/Kv0xzOVZLqs > > BUG=734841 > > Review-Url: https://codereview.chromium.org/2949733002 > Cr-Commit-Position: refs/heads/master@{#481618} > Committed: https://chromium.googlesource.com/chromium/src/+/63ddedc4cd3f0a35990b14b618b5415d1a9baeba TBR=hejq@chromium.org,xiyuan@chromium.org,warx@chromium.org,weidongg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=734841 Review-Url: https://codereview.chromium.org/2947313003 Cr-Commit-Position: refs/heads/master@{#481626}
-
benwells authored
There is no reason to restrict use of these icons when bookmark apps are disabled. BUG=735926 Review-Url: https://codereview.chromium.org/2954473003 Cr-Commit-Position: refs/heads/master@{#481625}
-
dcastagna authored
VideoLayerImpl is appending StreamVideoDrawQuads on CrOS. StreamVideoDrawQuads should be used on Android since almost all its features are supported by TextureDrawQuad. The only difference is that StreamVideoDrawQuad calls glUniformMatrix4fvStreamTextureMatrixCHROMIUM before drawing, that just sets a uniform matrix on CrOS. This CL makes sure VideoLayerImpl produces StreamVideoDrawQuads only on Android. BUG=702750 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2763223003 Cr-Original-Commit-Position: refs/heads/master@{#460547} Committed: https://chromium.googlesource.com/chromium/src/+/517d0115d3c435383f79a0b730b6514a6cc97f44 Review-Url: https://codereview.chromium.org/2763223003 Cr-Commit-Position: refs/heads/master@{#481624}
-
yzshen authored
The mojom("foo") GN template now only marks generated mojom.js files as data deps for the "foo_js_data_deps" target. So it is no longer an issue. For example, now $grep '\.mojom\.js' out/Debug/gen/content/test/content_unittests_apk.native.runtimedeps | wc -l 2 (The two mojom.js files are from //mojo/public/js/bindings, which is going to be removed soon.) BUG=603212 Review-Url: https://codereview.chromium.org/2952223002 Cr-Commit-Position: refs/heads/master@{#481623}
-
Cathy Li authored
Bug: 734753 Change-Id: I3117309c60791fe58dff39331434bd207e52a843 Reviewed-on: https://chromium-review.googlesource.com/540575 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#481622}
-
khorimoto authored
With this change, Tether networks in the networking UI (i.e., settings and quick settings) are sorted in the same order that the Tether component prioritizes them when performing a host scan. The sorting rules are as follows: (1) The device which has most recently sent a successful ConnectTetheringResponse is always at the front of the queue. (2) Devices which have most recently sent a successful TetherAvailabilityResponse are next in the order, as long as they do not violate the first rule. (3) All other devices are left in the order they are passed. This CL also updates the GetNetworkListByType() logic in NetworkStateHandler; after this change, all connected/connecting networks are listed before non-active networks, and Wi-Fi networks associated with Tether networks are no longer returned since they are supposed to be obscured behind their associated Tether networks. BUG=672263,729796,729801 Review-Url: https://codereview.chromium.org/2945643002 Cr-Commit-Position: refs/heads/master@{#481621}
-
agrieve authored
Makes -keep of Fragments scoped to preferences package and removes no-longer-necessary -dontwarn for play services. Tested that this does not change classes.dex whatsoever. BUG=622023 Review-Url: https://codereview.chromium.org/2951243002 Cr-Commit-Position: refs/heads/master@{#481620}
-
agrieve authored
Plan to enable the flag in chrome_apk_tmpl in a follow-up. BUG=691733 Review-Url: https://codereview.chromium.org/2948083003 Cr-Commit-Position: refs/heads/master@{#481619}
-
weidongg authored
1. Provide interfaces in app_list::SearchResult to set price and rating for instant and play store apps based on specs. 2. Change the layouts of SearchResultTileItemListView and SearchResultTileItemView to show price and rating properly based on specs. Specifications: https://screenshot.googleplex.com/AFQ5HnrMYch https://screenshot.googleplex.com/0opcNunaJrZ The screenshot: https://screenshot.googleplex.com/Kv0xzOVZLqs BUG=734841 Review-Url: https://codereview.chromium.org/2949733002 Cr-Commit-Position: refs/heads/master@{#481618}
-
warx authored
Changes: As title: stop forcing off display when powerd reports SuspendDone for convertible/tablet device. There can be edge case that "system suspends with backlights forced off, and then user presses power button, which will resume system, but this power button event is not delivered to Chrome. When powerd reports SuspendDone, we can do stopping forcing off anyway to prevent this kind of edge case. R=derat@chromium.org BUG=735291 TEST=added test coverage TabletPowerButtonControllerTest.SuspendDoneStopsForcingOff Review-Url: https://codereview.chromium.org/2946233003 Cr-Commit-Position: refs/heads/master@{#481617}
-
alito authored
This CL hooks up the Chrome Cleaner dialog, the reproter runner, and the settings page showing the current state of the Cleaner. BUG=728136 Review-Url: https://codereview.chromium.org/2940043002 Cr-Commit-Position: refs/heads/master@{#481616}
-
Scott Graham authored
In porting base to Fuchsia, ObserverListThreadSafeTest.CrossThreadObserver was sometimes crashing. This appears to be due to different thread scheduling, but was an all-platforms bug. Fix that by waiting for ThreadMains to start. Additionally, .CrossThreadNotifications wasn't working as intended because the "true" it passed into the utility function was ignored. (This has always been wrong: https://codereview.chromium.org/7353) Also, two Adder objects were unnecessarily created; remove them. Bug: 706592, 735603 Change-Id: I1be4a825d05b1a46cbf554b6cd3b4c91410d4b76 Reviewed-on: https://chromium-review.googlesource.com/544176 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#481615}
-
alito authored
The ProfileResetter object in the SettingsResetter class needs to be kept alive until its reset operation has been completed, otherwise the SettingsResetter object could be destroyed before it has had a chance to untag profiles that were already reset. This is now done by keeping a vector of ProfileResetter objects until the SettingsResetter class is deleted. Review-Url: https://codereview.chromium.org/2952883002 Cr-Commit-Position: refs/heads/master@{#481614}
-
jonross authored
We can now run the mash version of ash_unittests via ash_unittests --mash The mash_unittests target brings in a redundant set of tests via ash:common_unittets. This change removes that import. There are still some ash/mus specific tests in this test suite, however they rely on additional setup work which is not yet available in ash_unittests --mash TEST=mash_unittests BUG=729810 Review-Url: https://codereview.chromium.org/2947303003 Cr-Commit-Position: refs/heads/master@{#481613}
-
Xianzhu Wang authored
Similar to display item raster invalidation within paint chunks, this CL implements raster invalidation of paint chunks within cc layers. Invalidate the bounds of the chunk if the chunk appeared, disappeared or changed order. TODO: invalidate chunk if paint properties changed. BUG=510908 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4f8d75a57bddec1c0a3a7672a0236952ab937448 Reviewed-on: https://chromium-review.googlesource.com/538602 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#481612}
-
Weiyong Yao authored
Currently when using multiple sources specified in DesktopCaptureSource the window picker will always display the Desktop option first, followed by window, followed by tabs. An app might want to promote another type of sharing. So let the ordering in the DesktopCaptureSource array determine the ordering of the picker tabs. Bug: 728866 Change-Id: I582db0d6066c59fe92505a1e9dc45ee090366279 Reviewed-on: https://chromium-review.googlesource.com/524038Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Qiang Chen <qiangchen@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#481611}
-
Yuly Novikov authored
https://chromium.googlesource.com/angle/angle.git/+log/12b0b39..579d8c7 BUG=chromium:727671,728226,chromium:682815,731089,chromium:697758 TBR=jmadill@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Iccc5538b77641dce7ecfb9adb25930b9d916806b Reviewed-on: https://chromium-review.googlesource.com/545056Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#481610}
-
AJ Ortega authored
Remove erroneous <obsolete> tags. I thought I could mark a metric obsolete without obsoleting its suffixes, but that isn't true. Bug: 733697 Change-Id: If4a0c22fa5fa202e19ca357d3c84b41d69654b08 Reviewed-on: https://chromium-review.googlesource.com/544175Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: AJ Ortega <ajo@chromium.org> Cr-Commit-Position: refs/heads/master@{#481609}
-
xiaohuic authored
Add new tween type SLOW_OUT_LINEAR_IN and use it for the end animation. BUG=b:35624617 TEST=build and flash locally, saw the animation changes Review-Url: https://codereview.chromium.org/2947843005 Cr-Commit-Position: refs/heads/master@{#481608}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/76def89024c6..a857866b281f $ git log 76def8902..a857866b2 --date=short --no-merges --format='%ad %ae %s' 2017-06-22 erikchen Make tracing/extras and tracing/extras/symbolizer into modules. Created with: roll-dep src/third_party/catapult BUG=734852 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia275b1a5dc830f7a6a05dfab2743ead4d9af5ff9 Reviewed-on: https://chromium-review.googlesource.com/545079 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#481607}
-
petewil authored
BUG=699313 Review-Url: https://codereview.chromium.org/2903383003 Cr-Commit-Position: refs/heads/master@{#481606}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/2e5eaf022e93..eb64b9b201d0 $ git log 2e5eaf022..eb64b9b20 --date=short --no-merges --format='%ad %ae %s' 2017-06-22 herb Replace variant system with arena Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: I92aa5be452b3702bba17fa2cfb426a0f3a4b8d9f Reviewed-on: https://chromium-review.googlesource.com/544759Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#481605}
-
Xianzhu Wang authored
In the following scenario: <paint-chunk-property-state id="a"> chunk a <paint-chunk-property-state id="b"> chunk b </paint-chunk-property-state> the trailing chunk </paint-chunk-property-state> As we can't use "a" as the id of the trailing chunk, previously we treated such chunks as uncacheable. Now use the id of the first display item as the id of the trailing chunk. If we did not skip cache for the display item, then we can still cache the chunk to issue proper raster invalidations instead of forced full raster invalidation for uncacheable chunks. BUG=732609 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I346a4840941f4d7519415e9fd0b2c7c8e18d17a5 Reviewed-on: https://chromium-review.googlesource.com/540661Reviewed-by:
Chris harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#481604}
-
kumarniranjan authored
This logic was added in an attempt to resolve incompatibilities with autoupdate_EndToEndTest, but it was not successful. This commit is mainly a revert of https://codereview.chromium.org/2894783003/ However, it preserves some useful functionality such as unit tests. BUG=chromium:710716 BUG=b:34385702 TEST=unit test Review-Url: https://codereview.chromium.org/2952083002 Cr-Commit-Position: refs/heads/master@{#481603}
-
justincarlson authored
Take 2. The previous version of this patch broke the debug build. This has been fixed in this version. This change factors out a PrinterDetector interface and associated Observer class. The Cups USB printer detector now implements this external interface, and the PrinterDiscoverer class is re-expressed as a generic PrinterDetectorInterface implementation that combines the results of subsystem-specific printer detectors. This change also adds unit tests for the new CombiningPrinterDetector class used to provide discovery functionality. BUG=588234 Review-Url: https://codereview.chromium.org/2945303005 Cr-Commit-Position: refs/heads/master@{#481602}
-
inglorion authored
32-bit Clang builds of blink_core with debug information have grown too large for incremental linking. This CL disables incremental linking for that combination so that builds will succeed. BUG=560475 Change-Id: I865db8b8449117a5c6ef074aa43b5311d06b8ed9 Reviewed-on: https://chromium-review.googlesource.com/538058 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#481601}
-
Scott Graham authored
Removes the attempted manual in-process printing of stack traces in favour of letting the system crashlogger print one to stdout and then filtering that in the run script to get file/line info. It does not yet resolve kernel/system symbols, only those in the test binary, but I think that's OK for now. (I started trying to do this all in-process https://chromium-review.googlesource.com/c/544108/1/base/debug/stack_trace_fuchsia.cc but it was getting out of hand, and there was still quite a lot more code required. Using the system one for debug backtraces seems better anyway.) Example output: https://gist.github.com/sgraham/d9d332de986c1caa5dc2644ab9c5191a Bug: 706592 Change-Id: Ic5e6241544d4e38b46db04d4c29f584f316c26b5 Reviewed-on: https://chromium-review.googlesource.com/544109Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#481600}
-
juncai authored
Revert of Refactor DeviceMotionEventPump to use //device/generic_sensor instead of //device/sensors (patchset #13 id:240001 of https://codereview.chromium.org/2896583005/ ) Reason for revert: Need to figure out some issues related to this CL on Android and Mac. Original issue's description: > Refactor DeviceMotionEventPump to use //device/generic_sensor instead of //device/sensors > > //device/generic_sensors already has all the sensors that can be used > to implement the DeviceOrientation event: > https://w3c.github.io/deviceorientation/spec-source-orientation.html > > Currently, //content/renderer/device_sensors uses sensors from > //device/sensors as its backend, and this is one of the CLs that refactor > //content/renderer/device_sensors to use sensors from > //device/generic_sensor as the backend and removes //device/sensors. > > This CL refactors DeviceMotionEvent to use sensors from //device/generic_sensor. > > The issue page contains the design doc link for this change. > > BUG=721427 > > Review-Url: https://codereview.chromium.org/2896583005 > Cr-Commit-Position: refs/heads/master@{#480934} > Committed: https://chromium.googlesource.com/chromium/src/+/687e6a76c9d634404eb93643ab900596a77958fd TBR=reillyg@chromium.org,timvolodine@chromium.org,jam@chromium.org,scheib@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=721427 Review-Url: https://codereview.chromium.org/2948253002 Cr-Commit-Position: refs/heads/master@{#481599}
-
Nathan Parker authored
Make it match the design doc (go/phishguard) and the code. Change-Id: I12a60716ce36d69ff2722b87f1ad439046888af2 Reviewed-on: https://chromium-review.googlesource.com/540095Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#481598}
-
Vladislav Kaznacheev authored
BUG=b:62844057 TEST=Manual: check the icons in the stylus menu and on the shelf Change-Id: Ib71657c2b1356cf432d4ddf17228d812240ad2fa Reviewed-on: https://chromium-review.googlesource.com/544216Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#481597}
-
Tommy Nyquist authored
The FeatureEngagementTracker backend currently tracks the result of a trigger-request as a histogram through SUCCESS and FAILURE (in addition to the failure reason in the case of a failure). However, that makes it hard to track whether the user did in fact follow the guidelines and performed the expected action even though that action is tracked, since there is no user action recorded for if the triggering was successful, only for whether a triggering might have occured. This CL adds two more user actions; for when IPH triggered, and for when it did not trigger. BUG=735261 Change-Id: I65cc5f50c78ecb807feb467311b708d05a5dbcc6 Reviewed-on: https://chromium-review.googlesource.com/541923Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#481596}
-
Charles Harrison authored
This patch also updates the smart UI time-to-reset to 24 hours, from 30 minutes. The shorter time is not necessary since all the permission work is completed. Bug: 689487 Change-Id: I42624747400078c8329881f9cc0326609ce36e7b Reviewed-on: https://chromium-review.googlesource.com/544316 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#481595}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/e17011dc1f5d..9a25eded6f4a $ git log e17011dc1..9a25eded6 --date=short --no-merges --format='%ad %ae %s' 2017-06-22 thestig Clean up includes in testing/test_support.h Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Iad0dced84a9b7ae4f76d4f491f1a176098203cff Reviewed-on: https://chromium-review.googlesource.com/544539 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#481594}
-