- 23 Mar, 2020 40 commits
-
-
Rainhard Findling authored
* On safety check changes, the iron-a11y-announcer reads out the changes to screen readers. * The currently announced changes include: safety check started, and safety check completed. * DD: http://shortn/_uEauSbBMVy Bug: 1015841 Change-Id: I5ebd7f45e5b6fd0254b26448efcf317b894443f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109693 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#752457}
-
Robbie McElrath authored
This method abstracts a call to //chrome's PrefServiceBridge, which is the //chrome/browser/settings module's only //chrome reference. Putting that call behind a ManagedPreferenceDelegate method will let us componentize //chrome/browser/settings so it can be reused by WebLayer. This CL also adds a ChromeManagedPreferenceDelegate that contains a default Chrome-specific implementation of the method. Bug: 1058597 Change-Id: Ie172ce80be19ab41ef20c3b4f13438315e6e0e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106842 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#752456}
-
ckitagawa authored
This CL handles link clicking for Paint Previews. The C++ hit testing was hooked up in a previous CL. This CL implements the Java side by propagating the URL to an endpoint that understands URLs and knows how to handle them e.g. loading the link in a Tab. Bug: 1061434 Change-Id: If7b4e1bc6f5a8f6df290f99c5d8cf3acdf934191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110528 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#752455}
-
Olivier Robin authored
There is no callback when a webstate will be deactivated. Dismiss the omnibox on the old webstate when switching. Bug: 1059225, 1062628 Change-Id: I4120b576e4104bc00b9e474369019e37e875347a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107595Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#752454}
-
Peng Huang authored
getenv("DISPLAY") may return nullptr if env DISPLAY doesn't exist. And constructing std::string with nullptr is not allowed. Fix the problem by checking return value of getenv("DISPLAY") Bug: None Change-Id: I1bf3db40b52af0d8741b585e2eb297e2019977ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113815Reviewed-by:Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#752453}
-
Hailey Wang authored
Add a check in background tab loading policy to ensure all PageNodes are tabs. Bug: 1059341 Change-Id: Ib741bb49a4fe462b9b80c5f4a66b9133d234e7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108638 Commit-Queue: Hailey Wang <haileywang@google.com> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#752452}
-
Clemens Arbesser authored
If the date was not set, the calendar was supposed to fall back to the current date, but a wrong if statement prevented this. Bug: b/145043394 Change-Id: I1e2e18e400c1634418e521db20f5bda1a368616f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106846 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#752451}
-
Clemens Arbesser authored
Also extended the SetText interaction to also apply to the new text input widget. Bug: b/145043394 Change-Id: I64aeb87459df266479961320b445c1e19621fd9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111297 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c32c5dd61e17..8d1f72852e98 git log c32c5dd61e17..8d1f72852e98 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 ilnik@webrtc.org [VP9 decoder] react to incorrect pixel format in the bitstream 2020-03-23 titovartem@google.com Use real video duration instead of test duration. Created with: gclient setdep -r src/third_party/webrtc@8d1f72852e98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1063490 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3b07a5f259aee4f76b9bc4df9e5d311f3d98f37a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115497Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752449}
-
Sadrul Chowdhury authored
This reverts commit f79b470a. Reason for revert: build failures on perf bots: https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/167605 Original change's description: > Enable resource_sizes_trichrome_google on chromium.perf > > Bug: 1059928 > Change-Id: I321f38615ea64c3a9577ea5516e199ece6bb9b4b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112232 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752443} TBR=agrieve@chromium.org,crouleau@chromium.org,jbudorick@chromium.org Change-Id: I46adb2675413b6f14faa897ec379479003396949 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1059928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115872Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#752448}
-
Tanmoy Mollik authored
Methods from ProfileSyncService should be called from the UI thread. However its subclass FakeProfileSyncService sets and gets some sync states without checking if its on the UI thread or not. This cl calls syncStateChanged inside setEngineInitialized() and setPassphraseRequiredForPreferredDataTypes(). Also assert these set and their corresponding isSet methods are run on UI thread. Bug: 1056677 Change-Id: I2b41c88c054a1abe9591021abf3476d3b754b972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080232 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#752447}
-
Matt Jones authored
This patch converts the previously view-based TabObscuringHandler to be token based instead, removing the explicit view requirement. Now features can obscure tabs without needing to expose what should otherwise be internal details. Bug: 1062099 Change-Id: I469a1fa03802518899293997f8de2a32aba9b8f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107426 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#752446}
-
Stephen McGruer authored
On Chromium CI, this occasionally dips above 6s and times out. Looks like its just a bit slow, not hanging entirely, so giving it more time to finish seems ok. Bug: 1042848 Change-Id: I23f35308a546936c719ba8d1fae0fe9a6708ab8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115790 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#752445}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/22d73d15e778..95b77b44a8a8 git log 22d73d15e778..95b77b44a8a8 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 bclayton@google.com Merge changes I2b7adc3c,I5873dfa8 Created with: gclient setdep -r src/third_party/swiftshader@95b77b44a8a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I150be8af5b298a02a9d01bb15790d005f693cc0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115501Reviewed-by:
-
Andrew Grieve authored
Bug: 1059928 Change-Id: I321f38615ea64c3a9577ea5516e199ece6bb9b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112232Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#752443}
-
Stephen McGruer authored
On Chromium CI, this occasionally dips above 6s and times out. Looks like its just a bit slow, not hanging entirely, so giving it more time to finish seems ok. Bug: 1047068 Change-Id: Ifd986d3f7324e20e954f0e5da9e7a993aba6b2e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115553Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
-
Tomasz Śniatowski authored
Relax a regex to catch Log.e("log message", ..) as a bad/missing TAG instead of silently accepting it. Also add a rough TAG-change detection regex to try and make changes that only touch a TAG also run the checks. Adjust tests to match. Bug: 1063573 Change-Id: I6a5c302d581aa76ebfc86a286e6048412641f4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113572 Auto-Submit: Tomasz Śniatowski <tsniatowski@vewd.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#752441}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f04f21a5c913..59e7496d4e83 git log f04f21a5c913..59e7496d4e83 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 borenet@google.com [infra] Move logic about skps/images/etc into gen_tasks Created with: gclient setdep -r src/third_party/skia@59e7496d4e83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I6a08977dde73cb998ec3d98b30eee9d019dd326f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115500Reviewed-by:
-
Dominic Farolino authored
R=jbudorick@chromium.org Bug: 1043679 Change-Id: I1b7bbc3f6b0dd3f38501d509bd3e1dba2c9e9bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115070Reviewed-by:
-
arthursonzogni authored
The "allow" directive doesn't exist anymore in CSP. It has been removed and replaced by "default-src". However, it was still used in several tests. Using an ignored directive caused some tests like: directive-parsing-multiple-headers.html to test nothing. This patch replaces "allow" by "default-src" in web_tests/ One exception is the test checking a warning is displayed when "allow" is used: [...]/contentSecurityPolicy/source-list-parsing-deprecated.html This one is kept. Bug: 1063830 Change-Id: I2342a6e419a1844cd09e6219adc91a0c02a5fa37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115542 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#752438}
-
Stephen McGruer authored
TBR=robertma@chromium.org Bug: 1051773 Change-Id: Id5812fb43b86444831ce3bd2fce14aa13917cf92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115552Reviewed-by:
-
Stephen McGruer authored
On Chromium CI, this occasionally dips above 6s and times out. Looks like its just a bit slow, not hanging entirely, so giving it more time to finish seems ok. Bug: 1062694 Change-Id: Ie928edc1babe02a90402f99ee3c79aee0cb251c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110520 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Hopeful fix for incremental builds sometimes not regenerating .pak files. Bug: 1039881 Change-Id: Idebee305f259aa0ab9ec112b7e6d22b6dd0897be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113810 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#752435}
-
Stephen McGruer authored
On Chromium CI, this occasionally dips above 6s and times out. Looks like its just a bit slow, not hanging entirely, so giving it more time to finish seems ok. Note that the other worklet csp tests are already marked as slow. Bug: 1059253 Change-Id: I757eb010793d9bff798caf997cb29087481d3467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112510 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
-
ckitagawa authored
TabbedPaintPreviewPlayer glues PlayerManager to PaintPreviewTabService to create a class that manages per-tab display of PaintPreviews. This results in some cascading refactorings: - PaintPreviewTabService now caches a list of captures such that HasCaptureForTab() synchronous for quick checks. - URL is passed to PlayerManager on initialization and propagated to ensure that the proto URL matches the URL currently shown in the Tab. As a follow-up it may be worth making this optional? - Propagate some failures to the Java layer. Bug: 1062383 Change-Id: Iafb5913b00732c1078a6a492e828988cbbca6324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106118 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
-
Robert Ma authored
Rebaseline, and delete the expectation line. Fixed: 953153 Change-Id: I71f9889ff8ba17d826e8d98e983d8f6cb6c3ec25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112958 Auto-Submit: Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
-
Peng Huang authored
In theory, FindMemoryTypeIndex() may return invalid memory type index, so the return value should be checked. Bug: None Change-Id: I64b214ae91dd358ae8a990d7c7eef225f7d350b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114585 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
-
Aaron Leventhal authored
Calling Document::UpdateStyleAndLayoutTree() can cause keyframe animations to update, and send the document life cycle to an earlier, unsafe stage. There is no need to call this before getting the computed style, as layout is already clean. Bug: 1025740 Change-Id: Ibcda5b1890886254ac3d25024784a3e8e3daa88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113671Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#752430}
-
sandromaggi authored
Before this change only /search was allowed, now all Google subdomains are supported. Bug: b/152027637 Change-Id: I3aeafbc16f6984cc9ed7710adbfd2680c3b2a9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112555Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#752429}
-
Greg Thompson authored
The mini_installer_tests suite sometimes suffers failures caused by state left on a machine by previous runs of this or other tests. This change adds new processing to the force_clean mode of RunCleanCommand that interprets expectations in the 'clean' state as directives to put the machine into that state. This should reduce flakes caused by previous tests. In particular: - The abstract Verifier class and VerifierRunner have been collapsed into a generic property_walker that traverses a property dictionary and dispatches to type-specific verification functions. property_walker.Verify replaces VerifierRunner.VerifyAll. - property_walker.Clean is introduced, which walks a property dict and dispatches to type-specific clean function. - The guts of the {file,process,registry} verifiers are now in type-specific "operations" files. - Each of the {file,process,registry} operations files now has a Clean operation. Big thanks to zmin@chromium.org who started this effort in https://codereview.chromium.org/2747023002/. BUG=698997,1059314 Change-Id: I8c249e4bcffaae280aa4d877c5da8224dac11df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111178 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#752428}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ce427e7174b8..8cb91971a35b Created with: gclient setdep -r src-internal@8cb91971a35b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie22817ab89082c1166b0395ae9672739e93af51e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115494Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752427}
-
Mugdha Lakhani authored
Several classes inherit from PageInfoUI and create a PageInfo object, which needs a pointer to a PageInfoUI object in turn to be constructed. This CL removes all usage of PageInfoUI from PageInfo's constructor by adding a SetUiAndInit method on PageInfo. This eliminates a potential source of crashes wherein PageInfo calls into PageInfoUI (concretely, the PageInfoUI subclass) from its constructor, the latter tries to access its PageInfo member, and that member is null precisely because it is in the process of being set. There is no behavioral change, as all creation sites of PageInfo now call its InitializeUIState() method immediately after constructing it. One detail: Prior to this change, |security_level_| wasn't set in the PageInfo constructor's initialization list but was rather set via the call to ComputeUIInputs() that occurs in the constructor. With this CL |security_level_| *needs* to be set in the initialization list as that passed-in value is used as input to ComputeUIInputs(), which is now called from InitializeUIState(). Bug: 1052375 Change-Id: I61143f3bdc4e02097d4c27db7f46bfab2355f934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105296 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#752426}
-
Miguel Casas authored
This test-only flag allows for bypassing the picker UI for screen/ window/tab capture selection. It's used in browsertests [1], and it's needed for ChromeOS Tast tests (see bug), however in real machines the name of the capture device is not just "Entire screen", but "Built-in display" [2], or includes e.g. the server IP:port in the case of window/tab. This CL relaxes the flag by making the parameter a substring of the to-be-allowed capture source, so that e.g. "display" will cover all possible display names etc. [1] https://source.chromium.org/search?q=kAutoSelectDesktopCaptureSource&sq= [2] https://source.chromium.org/chromium/chromium/src/+/master:ui/strings/ui_strings.grd;l=1028;bpv=0;bpt=0 Bug: 1063449 Change-Id: I73f41352482839df792fd3a048d989f32fe62768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113410 Auto-Submit: Miguel Casas <mcasas@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#752425}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d67bef80..bc540552 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I58b0e8d8009e88c1157a5427fb9360753db8bbb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115571Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752424}
-
Jan Wilken Dörrie authored
This change implements handling not being able to obtain a plaintext password from the backend for the compromised credential edit dialog. Fixed: 1063560 Change-Id: Id8d22c9e3ea4b96b0063ef7772147a09d687272e Bug: 1063560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115330 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#752423}
-
Sean Harrison authored
This was originally going to go under the recent cookies section, but since that was removed it has now been added underneath the other toggles on the page, in a similar position to where it was on the previous cookies page. Bug: 1032584 Change-Id: I34ffc45a35b52ecbdf08916c2873f02ff7277cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107867 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#752422}
-
Clemens Arbesser authored
Bug: b/145043394 Change-Id: I524af3118581c046a746a34d2b77a9ec5b2f7ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111673 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c591f1048c69..c41827fa748d git log c591f1048c69..c41827fa748d --date=short --first-parent --format='%ad %ae %s' 2020-03-23 sigurds@chromium.org [issues] Factor out common affected resource view functionality 2020-03-23 eric.rannaud@gmail.com [devtools] No detailed CPU samples of JavaScript program recorded on Linux Created with: gclient setdep -r src/third_party/devtools-frontend/src@c41827fa748d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1055871 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8d02bd44e8e8a3c37cf9cc011d0cc617f8250dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115490Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/be36db1024ce..c32c5dd61e17 git log be36db1024ce..c32c5dd61e17 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 jonaso@webrtc.org Add terelius as OWNER in call/ 2020-03-21 alexhenrie24@gmail.com Fix bad frees in error paths of WebRtcAecm_Create 2020-03-21 hta@webrtc.org Refactor ssl_stream_adapter API to show object ownership 2020-03-20 peah@webrtc.org Ensured that all files in APM are using the webrtc namespace Created with: gclient setdep -r src/third_party/webrtc@c32c5dd61e17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5c849b3f3c3f185004ee6d397d301f1e94dcce8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115492Reviewed-by:
-
Aaron Leventhal authored
Even though dump w/o crash is not a real crash, it skews the crash data analysis. Bug: 1063308 Change-Id: I55d16beffe8a4fcef5e505d923a755e0481d3aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113685Reviewed-by:
-
