- 19 Jun, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/23c845754ce8..42f585a5ad09 2020-06-19 mathias@chromium.org Fix `-theme-preserve` styles 2020-06-19 yangguo@chromium.org Allow COMMON_OWNERS to review BUILD.gn 2020-06-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I80b8f2fdf3aae38a0a7c20c1f2e27d1f97e5dab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253897Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780324}
-
Olivier Robin authored
When resuming session, open a normal tab even if the previous active browser was incognito. Bug: 1095592 Change-Id: I77cf1939cc210b081deff8dd5cb8f987191200b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252804 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#780323}
-
Jonathan Mengedoht authored
Bug: 927473 Change-Id: I251f368f1b1db2c121105172827c69bf05cd6eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224870 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#780322}
-
Andrew Grieve authored
Bug: 1096987 Change-Id: I90c94ff848965c219054202c3dd3a319c8d14df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254078 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#780321}
-
Victor Hugo Vianna Silva authored
This CL adds metrics to record whether the moving flow was explicitly triggered by the user on Settings, or after they used a profile store password in a form. Bug: 1063852 Change-Id: Ia4af24b09c636fb02c17d92c7a7f3c4ff25cfb7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249935 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#780320}
-
Ulan Degenbaev authored
The existing implementation measures memory usage of the main JS agent and reports URLs of the JS realms in the agent. The algorithm for mapping a JS realm to its reported URL walks the frame tree upwards to find the top-most cross-origin frame. The algorithm incorrectly assumed that all frames the path are local frames since the realms are local. This does not hold in the ABA case, where the main origin A embeds an iframe from origin B that in turn embeds an iframe from origin A. In such a case, the main JS realm and the grandchild realm are in the same JS agent and their frames are local. However, the child frame B is a remote frame. This CL fixes the algorithm to work both with local and remote frames. The URL of a remote frame can no longer be fetched from its document. Instead, it is fetched from the src attribute of the owner iframe element. This aligns with the upcoming spec and fixes the leak of post-server-redirect URLs. The CL also removes LocalFrame::FirstUrlCrossOriginToParent that is no longer needed. Bug: 1093880,1084999 Change-Id: I7a57a17701448d0fe210a66c7bdb8c0229fa5149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246175 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#780319}
-
Shubham Aggarwal authored
As per issue 78507, we are looking to add support for SQLite databases to use Write-ahead logging (https://www.sqlite.org/wal.html) mode in Chromium. WAL mode should give us significant performance gains across almost all use-cases. This change is a first step towards achieving this. It adds opt-in support to enable WAL mode for a database connection and perform a checkpoint. It also adds a feature flag to enable WAL mode for all databases by default to investigate its feasibility and impact on performance. Bug: 78507 Change-Id: I7fc5edcc39b50d2a13755d587cf342bded1af60a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095927 Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com> Reviewed-by:
Brandon Maslen <brandm@microsoft.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#780318}
-
Xianzhu Wang authored
When a frame is unthrottled, it may have pending visual update, and its descendant frames may skip throttling status update because their viewport intersection update may access dirty geometry of the ancestor frame. Previously in the case, the descendant frames might not have the flag of needing viewport intersection update set for the next document lifecycle update, and would fail to unthrottle. To ensure the descendant frames will be correctly unthrottled, now call SetIntersectionObservationState() when a frame is unthrottled. Bug: 1054644 Change-Id: Ifbb4db8cdcee58b9690937bb1f0ee311d1cb4bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252030 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#780317}
-
Shervin Oloumi authored
Updates the summary for Cryptohome's EvkkEncryptionType metric, making it more descriptive. Bug: 817430 Test: pretty_print.py and validate_format.py passes Change-Id: I5439f1b7acbf0d0dbfc7dd5d0c164bb888197418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253222 Auto-Submit: Shervin Oloumi <enlightened@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#780316}
-
Devlin Cronin authored
set_icon.js checked the `self` variable to determine whether the script was running in a ServiceWorker (such as a ServiceWorker-backed extension). However, this is unsafe because, unlike `window`, `self` can be overwritten by other script. If an extension specified a value for `self`, that would be used instead - and would subsequently crash if the value didn't support the `in` operator (i.e., wasn't an Object). When this happened, the custom bindings would fail to register any hooks. This, then, would result in API calls to browserAction.setIcon() in passing the arguments directly to the browser-side handling. When this happened, the browser would classify it as a bad message (because it didn't undergo the expected argument modifications), and would kill the renderer. Fix this by adding a native binding to return whether the script is running in a ServiceWorker context. Add a regression test. Bug: 1087948 Change-Id: I1bb593af735dec6d7a2a25050e62677f23c23dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253284Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780315}
-
Andrew Grieve authored
This reverts commit 44a03014. Reason for reland: Wasn't the culprit (see bug) Original change's description: > Revert "Android: Define paths to expectation files in leaf targets" > > This reverts commit 4a914f21. > > Reason for revert: Build failure in https://ci.chromium.org/p/chrome/builders/ci/arm64-unpublished-builder and https://ci.chromium.org/p/chrome/builders/official/android-arm-official-next > > Possible reason might be renaming //chrome/android:monochrome_public_bundle__base_libs_and_assets_expectations and //chrome/android:trichrome_chrome_bundle__base_libs_and_assets_expectations > > Original change's description: > > Android: Define paths to expectation files in leaf targets > > > > This is easier to follow then deriving it in the templates. > > > > Also changes webview expectations apk->bundle > > > > Bug: 1095654 > > Change-Id: I5952ee9a660e4f32b22ef4100fea2f231d9eb96d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245880 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Richard Coles <torne@chromium.org> > > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#780157} > > TBR=torne@chromium.org,agrieve@chromium.org,mheikal@chromium.org > > Change-Id: I8ef314098ae3949d21fc885b885b467314f6d695 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1096987 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252344 > Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org> > Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780271} TBR=torne@chromium.org,agrieve@chromium.org,mheikal@chromium.org,triploblastic@chromium.org No-Presubmit: true Bug: 1096987 Change-Id: I67937a8b09d9ecca0be3356ae17fc517c8be5ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254438Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#780314}
-
Sahel Sharify authored
This cl contains the following changes: 1-PaymentRequestUpdateDetails can have null shippingOptions/modifiers The cl modifies the TypeConverter to check for null arrays before passing them to Arrays.asList 2-changePaymentMethod/changeShipping[Address|Option] from PaymentDetailsUpdateService should get the binder's calling uid before posting the task to the browser's UI thread. Bug: 1026667 Change-Id: I94aaf4caa0d3b08db89993b0450cd3baf7b77a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252199Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#780313}
-
Hans Wennborg authored
The ASan runtime started calling it after https://github.com/llvm/llvm-project/commit/6b4aeec94afc3626c19ed93dea5d158fbea29732 Bug: 1097067 Change-Id: Ifb37700e5385158cf957c987018f1a9561cc0cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254318 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#780312}
-
Thomas Tellier authored
This CL reintroduces the submit button on the login / lock screen password textfield and disable the login display password button feature by default, by putting it under a feature flag. Bug: 1090319 Change-Id: I521a19262726f7c0566d824b0efe5aa1c9abb7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247826 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#780311}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592560372-5e1e91918016f52d8aaeea816d2c59deb0aa5d08.profdata to chrome-win64-master-1592568001-645f451bc013d681af722dc2b85e4992534cb0fa.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I599d140a53e9aead7b21b3b47fdda93a958f88e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253891Reviewed-by:
-
Andy Paicu authored
TBR=garrick@chromium.org Bug: 1097021 Change-Id: I88623210e697f595ee03e1226abaac743d6b971e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254139Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780309}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/62fea391fa99..6e722f2eaa58 2020-06-19 apodtele@gmail.com [base] Rework d1180b5f9598 until further notice. 2020-06-19 sebras@gmail.com [cff, cid] Fix segfaults in case of error (#58621). 2020-06-19 wl@gnu.org [base] Fix UBSAN error. 2020-06-19 wl@gnu.org [woff2] Fix segfault. 2020-06-19 svenevs.dev@gmail.com [sfnt] Support Intel compilers. 2020-06-19 sebras@gmail.com [base] Fix memory leak (#58611). 2020-06-19 sebras@gmail.com [cff] Fix memory leak (#58610). 2020-06-19 wl@gnu.org * src/cff/cffload.c (cff_index_get_pointers): Rename `t' to `tbl'. 2020-06-19 sebras@gmail.com [cff] Free table upon error allocating other data (#58609). 2020-06-17 wl@gnu.org woff2tags.h: Fix copyright year. 2020-06-13 wl@gnu.org Remove redundant inclusion of `ft2build.h'. 2020-06-08 david@freetype.org Make macros for header file names optional. 2020-06-02 wl@gnu.org * src/sfnt/ttcmap.c (tt_face_build_cmaps): Trace number of cmaps. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ida9cedae09810da765b1d8fd71c567c390bb57b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253887Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#780308}
-
Clemens Arbesser authored
Note that users may enable/disable a11y at any time, which is why the service has to update the state correspondingly. Bug: b/158989900 Change-Id: Ie4e58f3b8ece6df2c176c1b63820dd2a143789f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245702Reviewed-by:
Luca Hunkeler <hluca@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#780307}
-
Majid Valipour authored
Changes: - Fix regex to accept very short otp code: #(.[]+) -> #([]+) - Add tests to ensure we reject forbidden host characters - Add additional tests around number of spaces expected Followup patch will allow host to accept unicode. Change-Id: I7cbeabe31edd9c9ead7ae78425c8760f9c78ce9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248071 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Sam Goto <goto@chromium.org> Cr-Commit-Position: refs/heads/master@{#780306}
-
Oriol Brufau authored
::marker pseudo-elements are currently behind the CSSMarkerPseudoElement runtime flag. I plan to ship them soon, but without support for nested pseudo-elements (::before::marker and ::after::marker), since that would require more work in the style resolver. That's what Firefox did too. So this patch hides them behind CSSMarkerNestedPseudoElement, which implies CSSMarkerPseudoElement. In order to make it easier to check whether a pseudo-element should be exposed (e.g. in devtools or getComputedStyle), this patch adds a static PseudoElement::IsWebExposed method which takes care of doing the proper checks. Right now it's just for ::marker, but it can also be useful for future tree-abiding pseudo-elements like ::file-selector-button. Bug: 457718 Change-Id: Idf764855cca62e0776463346af04e4f2bcc53040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250103 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#780305}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d64d998b9f1f..b93c9d1a5342 2020-06-19 lalitm@google.com Merge "ui: revamp quantization for cpu and userspace slices" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1a514bab55739facd7e84142650f36e459a820ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253889Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592560372-e09cb0657078c6c75bd738f91c59baf5eafe0404.profdata to chrome-win32-master-1592568001-0b6b26a9a978d83410a95ed47a0a1a3dcdc59066.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib70cf954f0c3ba7f90459af0e1a0e39a15a19790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253888Reviewed-by:
-
Xi Han authored
Bug: 1097069 Change-Id: I5becd0a8850c8eff6dcbb3bc5e55af656dac35fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254060Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#780302}
-
Sigurdur Asgeirsson authored
There's no need to represent this as a map on the wire and it creates complications in the mojo bindings for upcoming CLs. Bug: 1080672 Change-Id: I20cfe281d5dbb752bd5b376e45f6d1e1aff98852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250790Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#780301}
-
Sigurdur Asgeirsson authored
Bug: 1096543 Change-Id: I87a723e23fe4454eb54704f3bd6b35f5085c63d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252692Reviewed-by:
-
Miguel Casas authored
Hw VP8 Encoding on Intel Gen9.5 devices is disabled for Celeron/Pentium SKUs but sadly it seems that the same GPU hang is observed in Core devices (b/139695266, b/158696760). This CL extends the current blacklisting to all devices with a Gen9.5 GPU, so that said hang can be _temporarily_ avoided. It also refactors a bit the code to identify if a given SoC has a GPU of either Gen9 or Gen9.5. Bug: b:158655609, b:139695266 Change-Id: Id4ebf705e2949fe0715480be0428215d9eae4c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253158Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#780299}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/889563cbeb36..75c9c5bd26ae 2020-06-19 johnstiles@google.com Add unit tests for untested SkString APIs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1092743 Tbr: djsollen@google.com Change-Id: I21bd96caf32f48344ca4fa4f9fc272f251e99701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253886Reviewed-by:
-
Victor Hugo Vianna Silva authored
This is a reland of a4a3a1a6 Reason for reland: The upstream CL had missing .js extensions in some imports and this caused failures when the new dialog started being used. We also use this CL to add flush() calls after click() calls that make synchronous checks in passwords_section_test, similar to crrev.com/c/2252138. TBR=aee@chromium.org Original change's description: > [b4p/Settings] Display removal dialog > > This CL starts displaying the dialog from crrev.com/c/2248180. Moreover, > RemovePasswordBehavior is deprecated. The more elaborate logic of > removing different copies of a password can live directly in the dialog, > while PasswordsListHandler can use simple logic for the case when a > single copy must be removed. In particular, it felt strange that > PasswordListItem has this Polymer behavior but never used any of its > functionalities (it was PasswordsListHandler that used it instead). > > We also use the occasion to fix an aspect of crrev.com/c/2235850. If > the entry is moved, there's no element to reset the focus to, so the > focusWithoutInk() call is removed. The same is done for removal dialog. > > Bug: 1049141 > Change-Id: I06fe35b8bd14ee27873b6a56849e755c02cbc1bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246157 > Commit-Queue: Victor Vianna <victorvianna@google.com> > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779757} Change-Id: I9ef5016f8f183b36002801663bc91c0d961b7d58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253743 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#780297}
-
Jan Krcal authored
This CL removes behavior of profile menu in tests that is not checked by the click tests (i.e. the various actions that happen after clicking the menu items). This CL is a speculative fix for high flakiness of ProfileMenuClickTests. The flakiness has multiple root causes, none of which seems specific to profile menu / the test code. The hope is based on the fact that many of the actions in the user menu are expensive (loading guest mode and opening another browser) and thus increase the risk of flakiness. Bug: 1021930 Change-Id: I0f24a1f18ce8d3029daef44e2bc96b95eef81ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247642 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#780296}
-
Kramer Ge authored
SkiaRenderer SkiaOutputDeviceBufferQueue inserts a GpuFence when scheduling primary plane as an overlay. This fence is inserted after the gl commands for compositing. GbmSurfacelessWayland should use this fence when available. Inserting another fence is necessary. Change-Id: I5ec29019bd8917bdd3ea6e3f10e2d8f1327144f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252467Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Auto-Submit: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#780295}
-
Andy Paicu authored
TBR=aee@chromium.org Bug: 1097035 Change-Id: Icf4bb82a640a86f7bfd3cfd1b38512ec791ce8b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253751Reviewed-by:
-
Maciej Malinowski authored
GraphProcessor and GlobalDumpGraph will be moved from Chromium to the Perfetto repository. This patch adds some scary notes at the top of the header files to inform that those files will be removed from the Chromium repository. See crbug.com/1095982 for more details. Bug: 1095982 Change-Id: Id4bf3b4d0f7577fe60f9a65089969f639d3e70bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252044Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#780293}
-
Ricardo Quesada authored
This CL adds timestamps in GamepadDelegate, including a mock test. These timestamps are needed in Wayland-server. Also, this CL replaces the NowInMilliseconds() that is present in wayland-server with the newly passed timestamp. Additionally, this CL adds some missing headers reported by "git cl lint" BUG=1096608 TEST=exo_unittests --gtest_filter=GamingSeatTest.* Change-Id: I41951926b14d6c400902ec77413089c577f23af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252946 Commit-Queue: Ricardo Quesada <ricardoq@chromium.org> Auto-Submit: Ricardo Quesada <ricardoq@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#780292}
-
Stepan Khapugin authored
1. Fix a bug when a blocking UI will show multiple times, but only dismiss once, therefore leaving the scene blocked. 2. Fix a bug when the active scenes are not immediately obscured by the overlay. Ideally we might not want to show this overlay unless the user tries to interact with the scene, and initially I hoped to make it so by observing when the scene becomes active; turns out multiple scenes can be active at once. We might want to revisit it later. Bug: 1096062, 1092824, Change-Id: I978aa855d141e9ba5aa34f7b034a5f284a82ff25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249959 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Avi Drissman authored
If a WebContents performs a UI-sensitive action (such as showing a dialog or popup), we want to drop fullscreen from all related WebContentses, and to prevent those WebContentses from gaining fullscreen until the UI-sensitive situation is over. Currently the search for related WebContentses is achieved by walking up the opener and outer chains, but that misses related WebContentses that are down those chains. These are one-directional chains that aren't easily walked in the other direction. This is fixed with two changes. First, we keep a list of WebContentses that are in fullscreen, which can then be searched to determine if they are down the chain from the affected WebContents. Second, when a request comes in to go fullscreen, we not only check if the WebContents is prohibited from entering fullscreen, but we now also check if one of the WebContentses up the chain is prohibited. Bug: 1090835 Change-Id: I031e2e0a9ff79b387543a22ec3d643ab468d4d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249090 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#780290}
-
Andy Paicu authored
TBR=dmurph@chromium.org Bug: 1097050 Change-Id: Ia5c9c5fd02f813b1c01e01a0b05009dd5f969266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253853Reviewed-by:
-
Andy Paicu authored
TBR=arthursonzogni@chromium.org Bug: 1097060 Change-Id: Ic873cfd8030d8ef0b25604b638edd895355353be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252808Reviewed-by:
-
Alexander Surkov authored
Bug: 1096512 Change-Id: I15c797578815ee2d706cf2311cdb2ec722fcb67e AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252602 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#780287}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3340bd2d130c..23c845754ce8 2020-06-19 wolfi@chromium.org [Issues] Do not show issues banner in console again after interaction 2020-06-19 mathias@chromium.org Fix stylelint-config-standard issues in animation/animationTimeline.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I27fd23df348679619d2dfdd7e2a2e595bdcf8eca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253883Reviewed-by:
-
Denis Kuznetsov authored
Bug: 981472 Change-Id: If149ecb5692c7f2e468cf50f91f85552272f1798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238835 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
