- 31 Oct, 2019 40 commits
-
-
Charlie Harrison authored
Currently, we hide the item from the tab switcher, but direct navigations still navigate to the chromeos page. This CL handles the direct navigation case. Bug: 957005 Change-Id: I4d55b064557879f45f6df510d042e2c78424993a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893139 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#711323}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9de9e749612a..f7d8b0be4542 git log 9de9e749612a..f7d8b0be4542 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 seanabraham@chromium.org chromeos_config: make glados and chell noncritical Created with: gclient setdep -r src/third_party/chromite@f7d8b0be4542 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I3a156d35f2a150efb9a80b5a820208424799d5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893534Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711322}
-
Sammie Quon authored
It was disabled because causing a regression. Switches it up a bit to instead create a smaller widget which draws its own blurred WallpaperView, which is then scaled before being faded in. The widget is kept alive for the duration of overview. Test: manual Bug: 1012829 Change-Id: I0b132a52c2ea26ffddd6b6537ab4062b80960e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876873 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#711321}
-
Arnaud Mandy authored
Bug: 1018705 Change-Id: Idfa6a9e4a71e0d5d38ddb4cdd775d0a7a094dca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883572Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#711320}
-
Lindsay Pasricha authored
Bug: 1019670 Change-Id: I25fe4796d411b4104952814707de31fe4fefce70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893751Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#711319}
-
Natalie Chouinard authored
Bug: 1016957 Change-Id: I420d6b265926ddc870b6d0b672b427f7317d6560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891932 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#711318}
-
Xiaohan Wang authored
This function is used in many places unrelated to MediaLog. Also add a stream operator to make logging PipelineStatus easier. Change-Id: Ie0300b048f87d2fc8ac96dce9b6c8d5f8765ca54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891792Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711317}
-
Yi Gu authored
Tested locally and didn't see the crash mentioned in crbug.com/545547. Bug: 545547 Change-Id: If15dbe23c39ea64905d7227b7097bb40c13af916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767052Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711316}
-
minch authored
Bug: 1002733 Change-Id: I5fb541119dc56f98b70358fc68b70b5fe110a43b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888102Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#711315}
-
Lily Chen authored
Bug: 1018919 Change-Id: I7f8ab0ce175824bc65473d44e2d4774cc3d96f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891335Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#711314}
-
Carlos IL authored
SafeBrowsingControllerClient will now be required by webview. This CL moves it to components and adds a ChromeControllerClient subclass to handle the Chrome specific logic (related to hosted apps). This also moves the SafeBrowsingBlockingPage::CommandReceived method to BaseBlockingPage Bug: 1018808 Change-Id: I548b3f9421cfac439f7431cb6d59528c1d165322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884273Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#711313}
-
Alex Cooper authored
Bug: 960132 Change-Id: I5a867f3a3b70095edafe6478e9503ef03e0fc726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890987 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#711312}
-
Caleb Rouleau authored
This reverts commit 9867b18b. Reason for revert: This causes unexpected behavior per Ross's comment on https://chromium-review.googlesource.com/c/catapult/+/1874453 . I will reland this once I fix Telemetry. Original change's description: > [Telemetry] Provide abridged story sets for rendering and system health. > > Note that this will have no impact on what is currently running > on the waterfall because all benchmarks are labeled as > abridged: False right now. > > This change is now possible because: > > 1. Pinpoint was taught to use the --run-full-story-set flag by > https://chromium-review.googlesource.com/c/catapult/+/1874451 > > 2. benchmark_smoke_unittest.py was fixed: > https://chromium-review.googlesource.com/c/chromium/src/+/1874821 > > Note that system_health_smoke_test.py is fixed as part of this > change. > I tested this fix by running > /run_tests benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/load:game > and seeing that the stories, a mix of health_check stories > and stories without the health_check tag were all run. > > Bug: 965158 > Change-Id: I42ca28543155536da62d9b02d9bf31d8eb311ac3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687783 > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711017} TBR=sadrul@chromium.org,perezju@chromium.org,crouleau@chromium.org Change-Id: I9e7ae496ef48ed00bcf2a8d67df42c577d3162d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 965158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893738Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#711311}
-
Mario Sanchez Prada authored
Convert the remaining bits referencing the PushVideoStreamSubscription mojo interface (from video_capture service) using the old APIs to the new mojo types, and adapt unit tests. Bug: 955171 Change-Id: Ic1b588835553340a22272d3f4ac43b79ce3f0ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886614 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#711310}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/159b417c9827..fb075d558d6d git log 159b417c9827..fb075d558d6d --date=short --no-merges --format='%ad %ae %s' 2019-10-31 minyue@webrtc.org Removing unused Opus wrapper API: WebRTCOpus_DecodePlc. 2019-10-31 peah@webrtc.org Reland "Refactoring of the noise suppressor and adding true multichannel support" Created with: gclient setdep -r src/third_party/webrtc@fb075d558d6d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:b/143344262 Change-Id: I45e86468803b97b484359ce81d16049776deffd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893397Reviewed-by:
-
Yusuke Sato authored
Previously ConciergeClient used the longer timeout only for StartVm method call because starting Termina VM could take up to 150 seconds, but it was insufficient. Since Concierge runs various VM operations on its D-Bus thread directly, Chrome cannot talk to Concierge while Concierge is starting up the VM. For example, if Chrome calls StartArcVm or SetVmCpuRestriction while Concierge is processing StartVm, the call could take up to 150 seconds to return. For this reason, most Concierge methods need to have the long timeout value. This CL also works as a temporary fix for b/142144405 although we need a real fix later. BUG=b:142144405 TEST=arc.Boot TEST=start ARCVM and crostini, kill off Chrome browser process to restart it while session_manager is stopping all VMs, verify restarted Chrome is able to restart ARCVM without D-Bus timeout Change-Id: Ic1d78a347509ed46be8f36f74c5d09db9932d52e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892424 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#711308}
-
Kevin Bailey authored
Adds a binary flag to enable not counting submatches (tab switch and pedal suggestions) towards the total suggestions shown. This will tend to expand the list of suggestions, but it will allow showing diverse suggestions that would have been kicked out due to showing higher dedicated row submatches. Bug: 995935 Change-Id: Ief727ef29d202d0f05ec5d34bcc32caa7fd19aa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885210 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#711307}
-
Ken Rockot authored
There are a bunch of clients using SafeJsonParser to decode JSON through the Data Decoder service. This CL converts them to use the new DataDecoder helper object in //components/data_decoder, which does not depend on Service Manager APIs like Connector. Bug: 977637 Change-Id: Id06d3180a1a61b3c89b1f261d561260c2807991d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879824Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#711306}
-
Matt Jones authored
This patch moves the public APIs out of the BottomSheet in preparation for making the sheet package protected. Bug: 986310, 1002277 Change-Id: Ibd9ec005975ed73dcd3883a442259ce2ab576b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891115Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#711305}
-
Maksim Moskvitin authored
In case SyncEngine initialization failed, DoShutdown() is called after DoDestroySyncManager() and crashes if USS implementation of Nigori is enabled. It's safe to not disconnect and stop Nigori in this case, because it's never connected and started before SyncEngine initialization succeeded. Bug: 1019956 Change-Id: Iba7a7385d87fd000f9c3e3eb55cbc3be513dd58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893152 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#711304}
-
Sean Kau authored
We've noticed that some printers don't understand all the attributes we are requesting and replying with subsitute-ok. In this case, we probably cannot setup the printer as autoconf but can still perform make and model matching. I noticed that ipp-version-supported isn't required in IPP 1.0 but is in 1.1. So, we're assuming that if ipp-version-supported is missing, it's a 1.0 printer. In the past, this was recorded as a failed setup. Bug: chromium:1013821 Change-Id: Id3d7d471e5f9d5cc336ce3fed41f2b1f1a0880a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891765Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#711303}
-
Natalie Chouinard authored
Bug: 1016957 Change-Id: I39013d322b6927fee2052b203473cbd081f4a179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890655 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#711302}
-
David Benjamin authored
Historically, ClientCertStoreChromeOS lived in //net and depended on the CrOS NSS profile logic in //crypto. To reduce the dependency on that mess, https://codereview.chromium.org/663583006 extracted the filtering logic into a separate ClientCertFilterChromeOS in //chrome, indirected via a CertFilter interface. This was done in preparation for https://codereview.chromium.org/419013003/, which was since abandoned (although the initialization still needs cleanup, per https://crbug.com/1018972). It also left the ClientCertFilterChromeOS logic entirely untested. Since then, ClientCertStoreChromeOS has moved into //chrome, so we no longer need the indirection. Fold it back in and test the user profile logic directly to restore ClientCertFilterChromeOS's test coverage. This is done preparation for work on https://crbug.com/1011576, which will affect this code somewhat. This moves the pre-NSS-3.30 workaround for importing ECDSA keys from ssl_platform_key_nss_unittest.cc to cert_test_util_nss.cc so it works for all callers of ImportSensitiveKeyFromFile. Bug: 1011576 Change-Id: I26ae5d610b8b7e443c18ca1314d16129a8f52350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888312 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#711301}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/287957ea..3bcc30e4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifda0f56408e92d5a7173c7f95cfd278b03401339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893292Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711300}
-
Kevin McNee authored
Tbr: bmcquade@chromium.org Bug: 1020182 Change-Id: Ice2171c180637bcb9cc601ea889d6ac782526c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893140Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#711299}
-
Arthur Hemery authored
Found a logic issue with the NavigationSimulator. CommitSameDocument expects browser initiated same document navigation to be in a started state and have the same_document_ flag set. The flag is set at commit time so it is logically impossible. Just go through regular Commit() in this case. Change-Id: Id71d99311661f3e82a473267048ed84c1b63e3e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724074Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#711298}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aae0b57ab143..dbd554ed9e86 Created with: gclient setdep -r src-internal@dbd554ed9e86 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ic19daf588521a8d6979d92c17d24004cbd317f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893401Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711297}
-
David Benjamin authored
The current_time > expiry branch ends in a continue, so we don't need to check current_time <= expiry. Bug: none Change-Id: Ib34895a1098e8f0ae296b0a8ffd8ccf07d40649f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891236 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#711296}
-
Etienne Bergeron authored
ICU parsing (grapheme) will be used by the TextItemize and need to be initialized. Running: crash-3e6400c066a0fc4e1652349294b22b87b9b9dd35 [1030/172842.831069:FATAL:break_iterator.cc(77)] Check failed: false. ubrk_open failed for type 2 with error 2 ================================================================= ==211878==ERROR: AddressSanitizer: ABRT on unknown address 0x2e61100033ba6 (pc 0x7f158a533cfb bp 0x7ffebc185cf0 sp 0x7ffebc185a90 T0) SCARINESS: 10 (signal) #0 0x7f158a533cfa in raise (/lib/x86_64-linux-gnu/libc.so.6+0x36cfa) #1 0x7f1594f60153 in base::debug::BreakDebugger() base/debug/debugger_posix.cc:331:3 #2 0x7f1594628d0d in logging::LogMessage::~LogMessage() base/logging.cc:956:7 #3 0x7f158c07b6ab in base::i18n::BreakIterator::Init() base/i18n/break_iterator.cc:77:7 #4 0x7f1595809bdd in gfx::RenderText::GetLineBreaks() ui/gfx/render_text.cc:1302:29 #5 0x7f1595889e82 in gfx::RenderTextHarfBuzz::EnsureLayout() ui/gfx/render_text_harfbuzz.cc:1758:24 #6 0x7f15957f9105 in gfx::RenderText::Draw(gfx::Canvas*) ui/gfx/render_text.cc:869:3 #7 0x5619787fc3e0 in LLVMFuzzerTestOneInput ui/gfx/render_text_api_fuzzer.cc:198:22 #8 0x5619788a14eb in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) third_party/libFuzzer/src/FuzzerLoop.cpp:553:15 #9 0x561978849dfc in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) third_party/libFuzzer/src/FuzzerDriver.cpp:292:6 #10 0x561978851a25 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) third_party/libFuzzer/src/FuzzerDriver.cpp:775:9 #11 0x5619788cb358 in main third_party/libFuzzer/src/FuzzerMain.cpp:19:10 #12 0x7f158a52052a in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x23 Bug: 1019913 Change-Id: I47a84779eb259b10471c345e7e93f214d644b74d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893354Reviewed-by:Abhishek Arya <inferno@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#711295}
-
Natalie Chouinard authored
Migrate kBlockThirdPartyCookies to use PrefServiceBridge generic methods, making use of the pref.h enum to expose it to Java. Bug: 1016957 Change-Id: I34de6292fb7bf43b88a85686d354c3685cbcdf51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890654Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#711294}
-
Jonathan Freed authored
Change-Id: Ie69a9619bfd00112a0d2f46f0df573af3a8c3d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873404Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#711293}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b094d526c20b..5d67bf6590f8 git log b094d526c20b..5d67bf6590f8 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 eseckler@google.com Merge "processor: Don't override system process/thread names with Chrome's" 2019-10-31 lalitm@google.com trace_processor: switch SparseVector to use RowMap instead of BitVector 2019-10-31 lalitm@google.com Merge "trace_processor: improve filter performance by iterating over col rowmaps" Created with: gclient setdep -r src/third_party/perfetto@5d67bf6590f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627 Change-Id: I37575d94eeb99f9455b34cb297c5e405085694d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893396Reviewed-by:
-
Armando Miraglia authored
TBR=toyoshim@chromium.org Bug: 1020185 Change-Id: I951ed9e3ab7d4d90d9a1c0a3ee75f1578a1abe62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893285Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#711291}
-
Mohamed Abdelhalim authored
Re-enables unit tests for android, since there were many changes done lately around it, and they are now green again. Bug: 970815 Change-Id: I83cc16212974a2c3452fd3cc19b276800f38b03b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893155Reviewed-by:
-
Ulan Degenbaev authored
Revert "Remove DOMDataStore::WrappedReference and hold TraceWrapperV8Reference directly in ephemeron map." This reverts commit 481fb0c1. Reason for revert: speculative revert for crbug.com/1019839 Original change's description: > Remove DOMDataStore::WrappedReference and hold TraceWrapperV8Reference directly in ephemeron map. > > Change-Id: I6ef8b0098a795dc550037306e7b972ea907b0fc1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884285 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710616} TBR=jbroman@chromium.org,haraken@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Iba339b519f2aa602773ceb79c95948c1cffdcbdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893282Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#711289}
-
Tim Volodine authored
In this patch: - Add SafeBrowsingService and its implementation for managing initialization and ownership of safebrowsing related objects, such as database manager, ui manager and safebrowsing context. This also includes proper threading and startup of the database manager. - Move some functionality and ownership from ContentBrowserClient to SafeBrowsingService for better decoupling and less code complexity. - Add user agent and user data path for safebrowsing network context. - Make safebrowsing android only for now. - Update build files. BUG=1015809 Change-Id: I8f83c62538bafe81479cb9fe40f065022e1699d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888033Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#711288}
-
Greg Thompson authored
ScopedTempDirs must outlive anything that holds file(s) open within them; otherwise, they are unable to delete their backing directories. BUG=546640 Change-Id: I38da1876e033b9408b5957596311e5dd82b04083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891419 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
-
Andrew Grieve authored
And mention @RemovableInRelease and @CheckDiscard Change-Id: I0de0fa818af5910bd4147985f6cee21da3c34ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890844 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
-
Rayan Kanso authored
Grab address info in the contacts fetcher task, and pipe down to the address provider to create a mojo address object. Bug: 1016870 Change-Id: I4d0580f0c27cbaef813cb2374b010ad182cb64d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879240Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Mike Wittman authored
Change-Id: I97297e52bf4288ef3edc52993c7ff4f911327e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890988 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#711284}
-
