- 19 Mar, 2020 40 commits
-
-
Xi Han authored
In this CL, we split classes used in Instant Start into the following way: Dependencies of native is removed from the constructors into an initWithNaive() method. This refactoring involves: - Inheritance chain from LayoutManagerChromePhone to LayoutManager - StartSurface* - Coordinators and Mediators for Tab management. Note: this CL doesn't create LayoutManagerChromePhone in pre-native, but defers some code from creation to initialization. We could like to see nothing breaks due to these changes. Bug: 1041865 Change-Id: If85137c4bd63d89d92f4a9ed0929c0a52175be2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999001 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#751805}
-
danakj authored
This library provides access to RenderFrameImpl things but WebFrameTestProxy is-a RenderFrameImpl and can be used instead. R=creis@chromium.org Bug: 866140 Change-Id: Iefdeef8de4fa70966119ac026f7be1b5c592a918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110071Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#751804}
-
Brandon Wylie authored
Bug: 1060382 Change-Id: If8022bfe71c9a8c8f70a4de37153e1c7ad028d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106742Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#751803}
-
Dave Tapuska authored
It isn't necessary to run BeginFrame and all of the UpdateVisualState code. This should make it easier to move LayerTreeView into blink. Change-Id: Iefb0caffc6cdc38db10352b50404afebb8120dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110512Reviewed-by:
-
David Tseng authored
Test: browser_tests --gtest_filter=ChromeVoxBrailleTableTest.* Bug: b/150635270 Change-Id: I8cb685af0fc84f913711f0b2e4d0e5744669db9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109821Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#751801}
-
bttk authored
Bug: 1048429 Change-Id: Ie52fceeea3c246e2dc24a3c8475babf64c840cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076414 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Auto-Submit: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#751800}
-
Maciek Kumorek authored
The adopters of the updater project should be able to change the guids of the COM service exposed by the updater.exe to prevent conflicts when services are installed on the same machine. To make it easier to deal with conflicts, we want the UUIDs to be defined outside of the .IDL. This change allows for compile-time defines expressed in GN to be passed to the midl.exe compiler. Change-Id: I6764d1625fb01635c8426d3634ff6fcd7561ae27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094711 Commit-Queue: Maciek Kumorek <makumo@microsoft.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#751799}
-
Jesse Schettler authored
Fix the name of ShouldFetchCrosHealthData() to align with similar function names (e.g. FetchCrosHealthdData()). Bug: 1063109 Change-Id: I444c44204b09f9c2d5f113bbb9faa5045325ead4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110680 Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#751798}
-
Roman Sorokin authored
Bug: 1063001, 1047175 Change-Id: I294c672607b0428b68c9f42cffca9f6d017c3691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108513Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751797}
-
Joshua Pawlicki authored
Bug: 1063064 Change-Id: Ib757f4273daf5136d39e3353c998faa2d0ce09dd Fixed: 1063064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110688 Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751796}
-
Daniel Rubery authored
This field is being used on the server side in cl/301451451. Change-Id: I4fc7932a20b51354541886e42b833ad73344a4fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110211 Auto-Submit: Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#751795}
-
Aran Gilman authored
This allows for safer and easier passing of values between the renderer and browser processes. Some minor cleanup of replacing empty constructors/destructors with "= default" is also included in this CL. Bug: 1016615 Change-Id: I0bd922c9a541abf63edc296099ebfa0b8e8413a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103133Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#751794}
-
danakj authored
It is tracking if ReadyToCommitNavigation happened first, which is true iff the RenderFrame was a provisional frame and is being swapped in. For same document navigations, ReadyToCommitNavigation would not have happened. The DidCommitProvisionalLoad() method already receives the flag for is_same_document_navigation which can be used for this purpose instead. When it's false, we should move focus to the main frame. R=avi@chromium.org Bug: 866140 Change-Id: Ida170bb699fe3f53c43bd3163c16aa4d2e307e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110170 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Ian Prest authored
In this scenario, the x & y attributes are baked into both the the content-rect of the <foreignObject> (as passed to the clipper), *and* the transform. As a result, any x & y offsets were being double-applied to a <clipPath> that used clipPathUnits="objectBoundingBox". We modify |ReferenceBoxForEffects| so that it removes the unnecessary transformation from the reference box when it's called on an SVG foreign object. Bug: 1009222 Change-Id: Ifc009eb84d46d49c7840e2903d44a90502d6b51d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101320 Commit-Queue: Ian Prest <iapres@microsoft.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#751792}
-
Dominic Mazzoni authored
The DumpAccessibilityTree tests generate an output text file and diff the results against an expected file. Previously, the way that the algorithm handled files of different lengths was by adding an end-of-file sentinel to the end. This resulted in that sentinel getting checked in, which was just confusing. Fix this by modifying the DiffLines helper function to properly compare files that don't have the same number of lines. Add full unit tests for DiffLines so we can be confident it works. Continue to LOG the end-of-file sentinel, because it's needed by running rebase_dump_accessibility_tree_test.py to parse actual output files from remote logs. Bug: none Change-Id: If1bcef063822fd5786acaeff9133c05d5fc5b065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109458Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
Adam Ettenberger authored
It was inconsistent to not always check for "ignored but included in tree" changes in the same place as "ignored" changes. Both are checked here, for example here: https://cs.chromium.org/chromium/src/third_party/blink/renderer/modules/accessibility/ax_object.cc?q=ax_object.cc&sq=package:chromium&l=965 Bug: None Change-Id: Id43b414eb7665866d0822bf95ee4b3e0605f6604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107605 Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#751790}
-
Fredrik Söderqvist authored
These setters have only one caller (SVGResources::BuildResources), which null-checks these already, so no need to do it again. Replace with DCHECKs. Change-Id: Ia61537ca39c792b00502b3e1e41823bf2fa87b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108736 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#751789}
-
James Cook authored
* Add real localized text. * Make text grey via "secondary" text styling. * Retitle "Turn on" and "Turn off" buttons per latest UX spec. https://screenshot.googleplex.com/RzQAQfbvwqC Bug: 1013466 Change-Id: Ibae11cf543479c2038252525282bf6c4511a11f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108098 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#751788}
-
siashah authored
Also, remove the ExpirationDateFixFlow flag as it is enabled by default. Bug: 1062629 Change-Id: Iaa44f743153fc4465a511a18ba98cc10624eb8e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109475Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#751787}
-
nancy authored
When Chrome apps, e.g. google photos, change the open method from windows to tabs, the app_id could be changed, because extensions might get the app_id from tab, and then get the app_id from URL. If both the Chrome app and web app are installed, extensions might get the web app app_id based on the URL, so when the tab is active or inactive, check the instance for the window first. If there is an app_id, reuse that app_id, otherwise, get the app_id from extensions. BUG=1011235 Change-Id: Ia0a396b9d5ebe9eac713d867359d941276f83011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106991Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#751786}
-
Ana Salazar authored
Make AppListController methods for getting app list visibility display aware. They're used by shelf to determine shelf background properties (e.g. background type) which may differ by display, so global app list visibility does not work for that case. Better handles display change in AppListPresenterImpl::ToggleAppList. It tapping home button on the display where app list is not shown now dismisses app list if visible on another display, and also show the app list on the target screen (instead of requiring two taps, as is the case today). Makes ToggleAppList dismiss the app list on another display immediately, so the display visibility change happens before the new app list visibility starts changing. BUG=1060686 Change-Id: I1dfb2f7ce0c11c1fc166d9fc61794c48b4379ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109332 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
-
Patrick Monette authored
Also changed CallOnGraphAndReplyWithResult to be static. Bug: 1013127 Change-Id: I99e7b0d54714efb73181ba5cc6bcec015bb1058c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107901Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#751784}
-
Nina Satragno authored
Move the code that used to be on the internal repository to the chromium repository. The code is unchanged except for the following: * There is no more need for Fido2ApiHandlerInternal, so that logic is moved to Fido2ApiHandler. * We no longer use AppHooks to acquire the API handler. Embedders interested in implementing WebAuthn on android no longer have to implement those bits. I also added a TODO to remove the ApiHooks entry point. We can't remove it until we clean the downstream repository. * IsUVPAA is unconditionally delegated to FIDO GMS Core. * The minimum GMS Core APK version has been bumped to support the current FIDO GMS Core version (18.1), and the constant is now centralized to Fido2ApiHandler. * Tests won't run if the bot has an old GMS core version instead of waiting to set up and then doing nothing. This patch increases the chromium binary size by ~65kb and the method count by ~530. After the downstream code is cleaned up, the chrome binary size will decrease by ~55kb and method count by ~430. The ~10kb, ~100 method count difference is caused by the updated FIDO2 library that is being used in this patch. Fixed: 1059401 Change-Id: I940d80ccf1610545d6801cd9d337b2b14e973459 Binary-Size: 55kb temporary, 10kb unavoidable. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095414 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#751783}
-
Mathias Bynens authored
This patch removes back-end support for simulating the following vision deficiencies: - achromatomaly - deuteranomaly - protanomaly - tritanomaly As captured in our documentation ([1]), the abovementioned vision deficiencies represent a broad spectrum, ranging from a slightly reduced sensitivity to (for example) red light (in the case of protanomaly) to a more severe lack of sensitivity to red light. However, our built-in simulation presets can only represent a single point on this spectrum. As Ian Hamilton points out [2], despite our docs, this could give the false impression that most people with protanomaly see in the way that our simulation indicates. The most extreme form, i.e. the complete inability to perceive red light, is protanopia instead of protanomaly. Being able to simulate protanopia is sufficient; designing for protanopia means you’re accessible to any severity of protanomaly anyway. The same goes for the other vision deficiencies. With this patch, the list of vision deficiencies DevTools can simulate becomes: - blurred vision - achromatopsia - deuteranopia - protanopia - tritanopia Note that for blurred vision, the same logic applies: not everyone with blurred vision sees in exactly the way DevTools indicates. However, since blurred vision is a much more commonly-known vision deficiency, the potential for confusion is lessened. [1]: https://developers.google.com/web/updates/2020/03/devtools#vision-deficiencies [2]: https://twitter.com/ianhamilton_/status/1237704178497130496 Related patches: - DevTools UI CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2109751 - Documentation patch: https://github.com/google/WebFundamentals/pull/8569 Bug: chromium:1003700 Change-Id: Ib3d753874830b9cea17c18c6ac0baa064bbd9c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109754Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#751782}
-
Stephen McGruer authored
On Chromium CI, this occasionally dips above 6s and times out. Looks like its just a bit slow, not hanging entirely, so giving it more time to finish seems ok. Bug: 1062762 Change-Id: I8ff780462676a0aadaaa0d0193509dae7e36bf4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110672Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#751781}
-
Li Lin authored
Histogram recorded to understand user's interactions with Quick Answers consent: * QuickAnswers.Consent - How many times user has seens the consent before. * QuickAnswers.Consent.Duration.[Interaction Type] - How long user has seens the consent before the interaction. * QuickAnswers.Consent.Impression.[Interaction Type] - How many times user has seens the consent before the interaction. The interaction type is one of the following: * Accept - click on the "Got it" button. * ManageSettings - click on the "Manage settings" button. * Dismiss - the consent is dismissed. Bug: b/151112171 Test: Manual Change-Id: I29dedf999bc0f1560d5fce4707eba5229d4cde88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100937 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Dave Tapuska authored
The idl tests were failing because the definition order was wrong. Change-Id: Iac210d6c0b211c49a78749c8dfd2a94be76c9a45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110078Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#751779}
-
Evan Stade authored
Bug: none Change-Id: I2d087cef6278cf12d03149ae9d80c51d806437ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018591 Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#751778}
-
Peter Wen authored
See go/faster-javac for a detailed analysis of why turbine was chosen to speed up our java builds. The current implementation is an initial implementation that can be further optimized. It already gives savings of 10-30% of our java incremental builds depending on the target in question (see go/project-turbo for timing details). This implementation does remove some of the benefits of the previous way that java_library_impl was implemented, namely when a target's .interface.jar file changes, it no longer short-circuits dependent targets from being built since we now use group(target_name). This is arguably more correct as prebuilts depend on javac jars directly. In the future (after the androidx migration and other build improvements) this can be improved by having prebuilts depend on the interface jars instead. Original CL: https://crrev.com/c/2105415 Fixed jacoco instrument not having header deps. Bug: 1056299, 1062704 Change-Id: I9a6c3242a04c6c57bb3c8f5bb7542c5a4301d1b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110431Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
-
Nicolás Peña Moreno authored
Bug: 1062984, 1063079 Change-Id: I04c06d75d05836b2c1dbced3a9a1d9385349d2ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110510Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#751776}
-
Marc Treib authored
The tests make sure that the updates end up in the right store(s). Bug: 1058339, 1012203 Change-Id: I958e9510845fc909fbce89cb573f29b0b4c19b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109759 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#751775}
-
Istiaque Ahmed authored
The callsites were dereferencing return value of ParseJsonDeprecated anyway, so make it use non-deprecated ParseJson. Bug: 932873 Test: Unit test cleanup, no behavior change. Change-Id: I80fd06bc3ecfa39d0f5cad9cb88631e685bc122c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108004 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#751774}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a38e20e4b435..7daf31d8029b git log a38e20e4b435..7daf31d8029b --date=short --first-parent --format='%ad %ae %s' 2020-03-19 m.maiya@samsung.com Vulkan: Use device local memory for conversion buffers that can be converted with the GPU 2020-03-19 jmadill@chromium.org Vulkan: Remove public FramebufferVk::getFramebuffer. 2020-03-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 25ede1ced679..18d3896a15fc (2 commits) 2020-03-19 jian.li@arm.com Skip some tests on Mali because of a known issue Created with: gclient setdep -r src/third_party/angle@7daf31d8029b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: Ice4432b86cc578f92b8200ae1c0d9a06c19eafd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110041Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751773}
-
Xiaohui Chen authored
Bug: None Test: CQ Change-Id: I64ba530176aa572cd6a2433c15176d0842738f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109235 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#751772}
-
Peng Huang authored
For remote desktop environment, vkEnumeratePhysicalDevices() will fail to get any available GPU. In this case, we should fallback to GL instead of continuing using Vulkan. Bug: 1062696 Change-Id: I610a62364cb7ca9120451edfec1ef3f97f0a8d53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110080 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#751771}
-
Juanmi Huertas authored
As the ImageLayerBridge::MakeAccelerated only accept an accelerated resource, we should not need the fallback mechanism here, so the create method can be replaced only by a CreateSharedImageProvider in GPU mode. Bug: 1035589 Change-Id: Iff8adc008332532312f5b809f44e378cb7bab192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108800Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#751770}
-
Joshua Pawlicki authored
Bug: 1062285 Change-Id: I0f9d1f97e77dc446a7a622b24c693a285efafef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110810 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
-
Nohemi Fernandez authored
In some instances it may be confusing how the navigation controller should be initialized in the ChromeCoordinator. To avoid confusion about who should be setting this parameter set to readonly in ChromeCoordinator and update the relevant constructors. Bug: 971989 Change-Id: If2ee713d074e0c9b7168a4f472c2fb20dc2ed6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107866Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#751768}
-
Joshua Pawlicki authored
Bug: 1062285 Change-Id: I0680058bc3e35ae0bf5d2e19e114899b0e71b65f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106487 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
-
Eugene But authored
This reverts commit 5e72b886. Reason for revert: Fix was landed Original change's description: > [iOS][Sheriff] Disable UrlWithSpecialSuffixNavigation > > TBR=eugenebut@chromium.org > > Bug: 1063015 > Change-Id: Ic74d8e26f365daad546ce35b210b1d856d8d7225 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110021 > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751707} TBR=javierrobles@chromium.org Change-Id: I96e394b03c322cbfc0a12e422ff2ead0f4f7e99d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1063015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110514Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#751766}
-
