GitLab

Revert 113591 - Revert 113579 - Content settings: allow scripts on interstitial pages even if JavaScript is blocked.


BUG=104700
TEST=ChromeRenderViewTest.ContentSettingsInterstitialPages


Review URL: http://codereview.chromium.org/8773035

TBR=marja@chromium.org
Review URL: http://codereview.chromium.org/8889008

TBR=dgozman@chromium.org
Review URL: http://codereview.chromium.org/8873015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113594 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106709
TEST=none


Review URL: http://codereview.chromium.org/8848001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113593 0039d316-1c4b-4281-b951-d872f2087c98

Additionally, downloaded profile image is no more saved to file every time it is downloaded after login.

BUG=chromium-os:23684
TEST=Manual: see bug description

Review URL: http://codereview.chromium.org/8822015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113592 0039d316-1c4b-4281-b951-d872f2087c98

Revert 113579 - Content settings: allow scripts on interstitial pages even if JavaScript is blocked.


BUG=104700
TEST=ChromeRenderViewTest.ContentSettingsInterstitialPages


Review URL: http://codereview.chromium.org/8773035

TBR=marja@chromium.org
Review URL: http://codereview.chromium.org/8889008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113591 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104291
TEST={ChromeAppCacheServiceTest, DOMStorageTest, IndexedDBBrowserTest, DatabaseTrackerTest}.SaveSessionState


Review URL: http://codereview.chromium.org/8820009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113590 0039d316-1c4b-4281-b951-d872f2087c98

Also, improve the comment and add a link to the bug
BUG=106829
TBR=cbentzel
Review URL: http://codereview.chromium.org/8889006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113587 0039d316-1c4b-4281-b951-d872f2087c98

The new name would be more consistent since other functions that return a Unicode code point use ui::GetCharacterXXX. For example, keyboard_code_conversion.h has ui::GetCharacterFromKeyCode.

BUG=None
TEST=ran try


Review URL: http://codereview.chromium.org/8802002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113586 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None.
TEST=Manual.


Review URL: http://codereview.chromium.org/8851001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113585 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113582 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104700
TEST=ChromeRenderViewTest.ContentSettingsInterstitialPages


Review URL: http://codereview.chromium.org/8773035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113579 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8659002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113578 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101399
TEST= Navigate inside the avatar menu using keyboard.
Tab key and down arrow key to navigate forward.
Shift-Tab key and up arrow key to navigate backward.
Enter key to open/edit a profile.

Review URL: http://codereview.chromium.org/8834010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113577 0039d316-1c4b-4281-b951-d872f2087c98

We should instead use the new ui::InputMethodIBus implementation.

BUG=97261
TEST=try


Review URL: http://codereview.chromium.org/8800002

TBR=yusukes@chromium.org
Review URL: http://codereview.chromium.org/8890004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113576 0039d316-1c4b-4281-b951-d872f2087c98

SQL_FROM_HERE cannot be used in places where the corresponding SQL statement is
not unique.

BUG=NONE
TEST=NONE


Review URL: http://codereview.chromium.org/8856005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113575 0039d316-1c4b-4281-b951-d872f2087c98

We should instead use the new ui::InputMethodIBus implementation.

BUG=97261
TEST=try


Review URL: http://codereview.chromium.org/8800002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113574 0039d316-1c4b-4281-b951-d872f2087c98

Also added a little hack to make session_manager restart chrome.

BUG=chromium-os:23763
TEST=All pyautos/autotests still work

Review URL: http://codereview.chromium.org/8852002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113573 0039d316-1c4b-4281-b951-d872f2087c98

This will allow for IME/omnibox coordination, as the omnibox can observe when
the candidate window is open.

Currently, there is no distinction between the suggest window and candidate
window in these events, but it can be changed later.

BUG=chromium-os:17763
TEST=


Review URL: http://codereview.chromium.org/8840002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113572 0039d316-1c4b-4281-b951-d872f2087c98

This is a temporary solution for Lion key-repeat + popup issue.
When Pepper IME API is exposed to NaCl apps, each apps should
set the text input type apporpriately.

BUG=chromium:102808
TEST=Run any NaCl app on Lion and hold 'a' key for a while to see the variant selector popup will not show up.


Review URL: http://codereview.chromium.org/8815008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113571 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106665
TEST=see bug.

Review URL: http://codereview.chromium.org/8872008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113570 0039d316-1c4b-4281-b951-d872f2087c98

replace with add/remove

BUG=102610
TEST=manual (for those strings I actually know how to trigger)


Review URL: http://codereview.chromium.org/8835003

TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/8872009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113569 0039d316-1c4b-4281-b951-d872f2087c98

replace with add/remove

BUG=102610
TEST=manual (for those strings I actually know how to trigger)


Review URL: http://codereview.chromium.org/8835003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113568 0039d316-1c4b-4281-b951-d872f2087c98

Sub chunks for kDownloadWhiteList are just a bunch of
(add_chunk_number, prefix) pairs, with no leading host/count.

Additionally, shift the buffer-overrun checks before the buffer is
overrun rather than after, and add DCHECKs to make sure this is
honored.

BUG=106165


Review URL: http://codereview.chromium.org/8873004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113566 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST='ObfuscatedFileUtilTest.TestDirectoryTimestamp'


Review URL: http://codereview.chromium.org/8728029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113565 0039d316-1c4b-4281-b951-d872f2087c98

BUG=62897
Review URL: http://codereview.chromium.org/8773032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113564 0039d316-1c4b-4281-b951-d872f2087c98

This CL brings the PPB_Var new shared implementation (from r113491) in to compliance with the new naming convention introduced at r113428. I didn't want to do add any more complexity to that in-flight CL, so I'm doing the rename here.

BUG=None
TEST=N/A


Review URL: http://codereview.chromium.org/8870002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113563 0039d316-1c4b-4281-b951-d872f2087c98

Revert 110505 - Report ERR_CONTENT_LENGTH_MISMATCH when the count of bytes received doesn't match Content-Length.

This used to be reported as ERR_CONNECTION_CLOSED. Unfortunately, there are a number of misconfigured servers on the web which report a Content-Length completely divorced from reality. Other browsers display whatever data was received without reporting errors in this case, and Chrome now does the same.

An earlier CL simply removed error reporting for this case. However, some uses may want to still treat this like an error (such as URLFetcher), or could eventually treat the case as an error and recover (such as downloads).

Data received will be populated in the disk cache as a truncated entry, if the server advertises byte range support.

WebURLLoaderImpl ignores this for all async and sync resource loads. At some point it may want to selectively do this based on content type.

Downloads ignore the error, but no longer ignore ERR_CONNECTION_CLOSED.

Other uses will treat this like an error.

BUG=52847
TEST=Manually, go to a site that advertises a large content-length and closes the connection before writing so many bytes, and notice that the page now displays.

Automatic: HttpNetworkTransactionTest.LargeContentLengthThenClose, URLRequestTestHttp.GetZippedTest


Review URL: http://codereview.chromium.org/8496016

TBR=cbentzel@chromium.org

Review URL: http://codereview.chromium.org/8863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113562 0039d316-1c4b-4281-b951-d872f2087c98

The URL is always included in the pingback now, so this whitelist checking can happen on the server.  Also, mark this and the ClientPhishingRequest.hash_prefix field as OBSOLETE in the protocol buffer file.

BUG=none
TEST=updated ClientSideDetectionServiceTest


Review URL: http://codereview.chromium.org/8854004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113561 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105117
TEST=None


Review URL: http://codereview.chromium.org/8835005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113560 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106596
TEST=NaCl SDK Hello World C example builds and runs successfully.
TBR=noelallen1

Review URL: http://codereview.chromium.org/8883008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113557 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/8824002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113556 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8879003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113555 0039d316-1c4b-4281-b951-d872f2087c98

after style markup, introduced by r107746.

BUG=106355
TEST=see bug for repro


Review URL: http://codereview.chromium.org/8824018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113554 0039d316-1c4b-4281-b951-d872f2087c98

Disabled timer to support full screen detection on Linux as we don't need it there.

BUG=102731
TEST=Manual steps in the bug report.


Review URL: http://codereview.chromium.org/8824019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113553 0039d316-1c4b-4281-b951-d872f2087c98

We special case the nigori node because even though it is considered an
"encrypted type", not all nigori node changes require valid encryption
(ex: sync_tabs).

BUG=106619
TEST=none.


Review URL: http://codereview.chromium.org/8856007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113550 0039d316-1c4b-4281-b951-d872f2087c98

Speculation is that the signal isn't using our autoexpiring Signals().

BUG=106768
TEST=see bug


Review URL: http://codereview.chromium.org/8866005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113549 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113548 0039d316-1c4b-4281-b951-d872f2087c98

ANGLE commit message for 905:

'Guard against releasing NULL textures.

ANGLEBUG=265
TRAC #19196
Signed-off-by: Daniel Koch
Author: Nicolas Capens'

This should fix the referenced bug.

BUG=106748

Review URL: http://codereview.chromium.org/8862006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113547 0039d316-1c4b-4281-b951-d872f2087c98

This has no effect until the next clang roll. On linux, only 64bit is supported for now.

BUG=none
TEST=`clang -faddress-sanitizier test.c` works. Running the generated a.out reports memory errors if test.c contained any.
TBR=kcc

Review URL: http://codereview.chromium.org/8852008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113546 0039d316-1c4b-4281-b951-d872f2087c98

Rename the name to describe its role more precisely
Actual value ("settings.accessibility") is not changed

BUG=None
TEST=build success


Review URL: http://codereview.chromium.org/8800033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113545 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8865007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113544 0039d316-1c4b-4281-b951-d872f2087c98