Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 07 Mar, 2018 2 commits
    • Tien-Ren Chen's avatar
      [Blink] Clean-up CompositingInputsUpdater · 6fa454ab
      Tien-Ren Chen authored 
      This CL does some light clean-up to CompositingInputsUpdater.
It is for aesthetic improvement only and should not change behavior.

1. Move AncestorDependentCompositingInputs computation to its own helper
   function.
2. Remove CompositingInputsUpdater::AncestorInfo::has_ancestor_with_clip_path
   which is unused.
3. Add shorthand variable layout_object = layer->GetLayoutObject().

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I745a392b80adedef278fa5ad45436b2c652bf37d
Reviewed-on: https://chromium-review.googlesource.com/950008
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541248}
      6fa454ab
    • Brian Sheedy's avatar
      Revert "Reland "Exclude unused java classes from gvr_common_java aar"" · 1ee268df
      Brian Sheedy authored 
      This reverts commit 03667272.

Reason for revert: Causing crashes of unknown origin on K https://chromium-swarm.appspot.com/task?id=3c16a11a3d0f5b10&refresh=10&show_raw=1 (occurred with original CL as well)

Original change's description:
> Reland "Exclude unused java classes from gvr_common_java aar"
> 
> This reverts commit f04d3bde.
> 
> Original change's description:
> > Revert "Exclude unused java classes from gvr_common_java aar"
> > 
> > This reverts commit dbc48ca4.
> > 
> > Reason for revert: Getting NoClassDefFoundError on Nougat https://chromium-swarm.appspot.com/task?id=3c01bdd86290b710&refresh=10&show_raw=1
> > 
> > Original change's description:
> > > Exclude unused java classes from gvr_common_java aar
> > > 
> > > As far as I can tell this filters the rest of the unused java classes.
> > > 
> > > Please revert this CL if you see ClassNotFound Exceptions.
> > > 
> > > diagnose_bloat summary:
> > > MonochromePublic.apk_Breakdown (-4,097 bytes)
> > >     +1,731 bytes Zip Overhead
> > >         -1 bytes Package metadata size
> > >     -5,827 bytes Java code size
> > > MonochromePublic.apk_Specifics
> > >    -15,137 bytes normalized apk size
> > >    -11,040 bytes main dex size
> > > 
> > > Bug: 944791
> > > Change-Id: I53219489d0289655a72405ab1e06cbeeb065d4f4
> > > Reviewed-on: https://chromium-review.googlesource.com/944791
> > > Reviewed-by: Brandon Jones <bajones@chromium.org>
> > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#540549}
> > 
> > TBR=mthiesse@chromium.org,bajones@chromium.org
> > 
> > Change-Id: I1b4b8c2d4acaaa9eafde507ceeb32293a164ac2b
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 944791
> > Reviewed-on: https://chromium-review.googlesource.com/946653
> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#540672}
> 
> TBR=mthiesse@chromium.org,bajones@chromium.org,bsheedy@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 944791
> Change-Id: I17e5095e0298d20bdd3876473e673f4ed5f07e5c
> Reviewed-on: https://chromium-review.googlesource.com/951826
> Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541236}

TBR=mthiesse@chromium.org,bajones@chromium.org,bsheedy@chromium.org

Change-Id: I97a0f25703d4ebf80b357a8f63d4399c1fcfbb3f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 944791
Reviewed-on: https://chromium-review.googlesource.com/951972Reviewed-by: default avatarBrian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541247}
      1ee268df
  3. 06 Mar, 2018 38 commits