- 16 May, 2019 40 commits
-
-
François Degros authored
Bug: 778674 Change-Id: I9e78661b34f5726855a933db61c6434adc2df2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614726 Commit-Queue: François Degros <fdegros@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#660642}
-
Gyuyoung Kim authored
As the first step to deprecate WTF::CString, the bug has suggested replacing EXPECT_STREQ with EXPECT_EQ. This CL replaces EXPECTED_STREQ with EXPECT_EQ in the cases of both converting WTF::String to const char* to use EXPECTE_STREQ and the expected string is ASCII. Bug: 950077 Change-Id: I9724b09dffb160c787af3085afcba0c1b6724de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614827Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#660641}
-
tby authored
The hashed logging launch recorder uses an enum to describe which UI component a launch happened from. This is duplicated between AppListLaunchRecorder and the new ChromeOSAppListLaunchEvent proto. This CL deletes the enum in AppListLaunchRecorder and uses the one in ChromeOSAppListLaunchEvent instead. Bug: 951287 Change-Id: Ia156370360ae44d66c7ab22314374e71c4213dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614639Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#660640}
-
Jun Mukai authored
Bug: 958467 Test: trybot Change-Id: Iff7b729900f06d7d8931daea3bfec1bdc85cc2fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614638Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#660639}
-
Scott Violet authored
The first attempt was reverted as the test was flaky. After talking with Oshima I decided to take the simpler route of removing all the code, hence no test. You can diff between patchset 1 and 4 to see the difference, but given I'm now removing it all, that may not be as interesting. BUG=958213 TEST=covered by tests TBR=tsepez@chromium.org Change-Id: Id3f88c9b4b76762dd31f2d402b57bd3c9757f750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615379 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#660638}
-
John Budorick authored
Deterministic Linux (dbg) is trying to share machines with the 32-core chromium.clang builders by setting auto_builder_dimension:NO. Unfortunately, this means it can steal *any* arbitrary 32-core ubuntu-14.04 machine in pool:luci.chromium.ci, not just the chromium.clang ones -- see e.g. https://chromium-swarm.appspot.com/task?id=44d11ba4bdc5cf10, where it stole Linux Builder (dbg)(32)'s single machine. This CL switches all users of luci-chromium-ci-trusty-32 bots to the builderless configuration, which will allow them to share without stealing from builders with dedicated machines. It also switches the other chromium.clang bots and Deterministic Linux to builderless for consistency. crrev.com/i/1304878 handles the infra-side change. Bug: 963224 Change-Id: Ied19c52042a1a757153e144e3fccfc81486cb7f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612855 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#660637}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d2a2433c7a57..908d73f65ad9 git log d2a2433c7a57..908d73f65ad9 --date=short --no-merges --format='%ad %ae %s' 2019-05-16 thestig@chromium.org Temporarily disable EOL policy for .in files. 2019-05-16 tsepez@chromium.org Tidy static/global usage in BC_ReedSolomonGF256.cpp Created with: gclient setdep -r src/third_party/pdfium@908d73f65ad9 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: I0345bb03e8c0090b4edb26fe6e74a4dfa38841db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616061Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660636}
-
Jun Mukai authored
TBR=sky@chromium.org, afakhry@chromium.org Bug: 958197 Test: build Change-Id: Ie871518604b9ed74f7cb8a3f1a6bd34d2b7aefc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615597Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#660635}
-
Luciano Pacheco authored
|cr.define| used for this element doesn't support inheritance properly [1], so to make the inheritance work with |cr.define| parent element |cr.ui.MenuButton| added a static |decorate| method which is called by the rest of |cr| framework and in this method inject back the prototype in the same way it happens in the |cr.ui.define| [2]. [1] - https://cs.chromium.org/chromium/src/ui/webui/resources/js/cr.js?l=269-281 [2] - https://cs.chromium.org/chromium/src/ui/webui/resources/js/cr/ui.js?l=97-100 Test: Manually checked that the component is working in addition to normal integration tests Bug: 778674 Change-Id: I9531c517c6a31b01e23fb42c3d8aec70081b8712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614725 Commit-Queue: François Degros <fdegros@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#660634}
-
Kevin Marshall authored
Implements a component which receives API bindings from the Agent and injects them into the current Cast application, and connects ports pushed from the Cast application to the Agent. Modifies CastComponent to only trigger NamedMessagePortConnector port injection once a page is fully loaded. Bug: 953958 Change-Id: I11f7a64bf5b0db4bfd341ea8b6b1ffb03c5b2ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601563 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#660633}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/67c4781f205b..4a8e975fb266 Created with: gclient setdep -r src-internal@4a8e975fb266 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: Ic53022e2fb4fcd04e151d0887a3f7ea2756ed725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615526Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660632}
-
Robert Liao authored
BUG= TBR=sky@chromium.org Change-Id: Idbe0b2ff95fb7e429f02c72a0086a849b32e4f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612226Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#660631}
-
Xiyuan Xia authored
Bug: 958134 Change-Id: Ia18083676fee8253408538b02a667f546fae0ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614289Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#660630}
-
John Abd-El-Malek authored
The problem was that NetworkConnectionNotifier was created by the in-process Network Service. BrowserMainLoop then tries to create it again which isn't supported as it's a singleton. Fix this by adding similar logic to BrowsrMainLoop as in Network Service, which is to only create it if it's not already created. Since BrowserMainLoop may not own the object in all cases, mark the methods that ChromeOS needs to call on NetworkChangeNotifierPosix as static as, similar to how the public methods on NetworkChangeNotifier are static. Bug: 962479 Change-Id: Icb6d0053d445778e6d8b1ee75233f435257ba935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613721 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#660629}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f0792ce4107c..fe57f6252fbd git log f0792ce4107c..fe57f6252fbd --date=short --no-merges --format='%ad %ae %s' 2019-05-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0d85f6ad..64564f7a (660414:660541) Created with: gclient setdep -r src/third_party/webrtc@fe57f6252fbd The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia23e12423056d571c99e44e4e054bf37c21f7c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615985Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660628}
-
Alex Cooper authored
This adds the XRInputSourcesChangeEvent type and updates the code to fire an event of that type rather than of the XRSessionEvent type, this requires tracking added/removed input sources when processing updates. This change also guarantees updates the ordering of inputsourceschange events and select events, particularly for sub-frame selects or when an input source shows up with it's primary input already pressed. The required ordering for a transient clicked input source (e.g. voice select) is: 1) inputsourceschange (with the new source in added) 2) selectstart 3) select 4) selectend 5) inputsourceschange (with the new source removed) This change also adds relevant tests for these two scenarios. Bug: 963011,962745 Change-Id: Idcdeee69a4bbfad344151026f9b468a48b93097a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614693 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#660627}
-
Daniel Libby authored
This reverts commit 7e329171. Reason for revert: reverting original change this was based on due to regressions Original change's description: > Log SCROLLBAR LatencyInfo's for main thread injected scrolls > > Note: based on crrev.com/1595296 > > When scroll gestures are injected during the handling of an input on > the main thread, we want to dispatch the scroll gesture with the > LatencyInfo information from the original input event, but with a > different type. This allows the end to end latency metrics to be > computed correctly and classified separately as a specific type of > scroll (not just, e.g. as mouse latency). > > Bug: 954007 > Change-Id: I725eaa46f21883aff08ab209d73dc5d0398a85db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603342 > Commit-Queue: Daniel Libby <dlibby@microsoft.com> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659630} TBR=bokan@chromium.org,tdresser@chromium.org,dlibby@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 954007 Change-Id: I7573642387e973a37bd20fda2eb1267a92e6f97e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614447Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#660626}
-
Tommy Martino authored
This CL adds the CreditCardAccessoryController class, the class in C++ land responsible for communicating with the PersonalDataManager and propagating the results to the Manual Filling controller (and, thus, to the Java frontend). Change-Id: Icffa6d2f9d8c140de31e18d92f747a090645a37f Bug: 902425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599927 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#660625}
-
Dale Curtis authored
Updates dav1d to upstream/master and uses the new frame_size_limit to enforce Chrome's pre-existing canvas size limit. Hopefully this should help avoid fuzzer OOM. https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/d400361524ce..fc3777b44c04 $ git log d40036152..fc3777b44 --date=short --no-merges --format='%ad %ae %s' 2019-04-25 dalecurtis Fix unused function warning on parse_proc_cpuinfo() for Android 2019-05-16 gramner Use size_t for the msac window size 2019-05-14 martin arm64: msac: Add handwritten versions of msac_decode_bool functions 2019-05-15 martin arm64: msac: Fix a typo in a comment 2019-05-14 gramner x86-64: Add msac_decode_bool and msac_decode_bool_adapt asm 2019-05-14 me Add dav1d logo 2019-05-14 gramner x86-64: Add msac_decode_bool_equi asm 2019-05-10 gramner Add a hard upper frame size limit on 32-bit systems 2019-05-10 gramner Add an option to limit the maximum frame size 2019-05-12 jamrial obu: add missing break to the default case of a switch statement 2019-05-12 jamrial obu: don't abort on unknown OBUs 2019-05-11 jb Update NEWS and version for 0.3.1 2019-05-11 martin tools: Add a cast to silence an MSVC warning 2019-05-09 gramner build: Group asm files per instruction set 2019-05-09 gramner Add __attribute__((cold)) to rarely used functions Created with: roll-dep src/third_party/dav1d/libdav1d BUG=948617 TBR=chcunningham Change-Id: Iff852dda12ffc511e8ef551713f04a4791300c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614449Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#660624}
-
Sven Zheng authored
The target will be added to an internal bot to run on CI. This target is for pixel testing for desktop ui. Bug: chromium:958242 Change-Id: I390d2507a5c0abeedb95458132fe9913ae0a98fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614150 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#660623}
-
Sharon Yang authored
Fuchsia is changing zx_clock_get to be able to report errors. This is a phase of the transition to use the new zx_clock_get_new function. Also replace zx_clock_get(ZX_CLOCK_MONOTONIC) with zx_clock_get_monotonic(). Bug: 963956 Change-Id: I8d67cbbe0290050763c14161d6e0bf4d08344053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615495Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#660622}
-
Christian Biesinger authored
Instead of calling Layout in both ConstructAndAppendFlexItem and ComputeInnerFlexBaseSize, only call it once in ConstructAndAppendFlexItem. This has the side-effect that the scrollbar size can't change after we compute it in ConstructAndAppendFlexItem, thus avoiding a check failure. This will also avoid double layouts if UpdateBlockChildDirtyBits triggers a layout. The change to MainAxisContentExtentForChildIncludingScrollbar is a followup to https://chromium-review.googlesource.com/c/chromium/src/+/1548326; this now made a test fail without that change but I should have made the change back then. R=dgrogan@chromium.org Bug: 963137 Change-Id: I28691c5e9d30d8425f16efcc95d2430098ca11f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614058 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#660621}
-
Dale Curtis authored
Appears to be causing some jank and we have enough data already. BUG=928562,964018 TEST=cq R=bcwhite Change-Id: I71e14829bc131c2c5552390711db2e457585cac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615883 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#660620}
-
Maksim Ivanov authored
Remove the "continueUrl" parameter from the cr.login.Authenticator's load() method, and remove associated code. This parameter has been unused since crrev.com/c/1605419. Bug: 470893 Test: existing tests, manual test: checking that OOBE enrollment, OOBE login, adding a new user on Chrome OS and desktop platforms work Change-Id: Ic6dfd663f22fc792fe6da2c7102f0f2548b769e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604274Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#660619}
-
Cathy Li authored
Also make sure that "All apps" icon is in the center when there are no other tiles. Bug: 962749 Change-Id: If8032326baa0a5747af1d9c6380a8e7b3b4969a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614626Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#660618}
-
liberato@chromium.org authored
In preparation for adding a pool of SharedImages, this CL moves most parts of VideoFrame creation to the MCVD thread. There aren't supposed to be any functional changes. The only thing that might differ slightly is that a scoped refptr to |texture_owner| is now being sent MCVD => GPU => MCVD thread, while before it was going MCVD => GPU only. While TextureOwner is DeleteOnSequence, so it's okay to drop it on any thread, the small change in lifetime might do something because threads are weird. Otherwise, almost everything is identical, just refactored. Change-Id: Ia0f5ecf393a886e8bc1a0572cbe494f26a9a236b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612600 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#660617}
-
Robert Liao authored
This allows ObserverList checking for ComboboxModel subclasses, which have also been updated. BUG=963982 Change-Id: Idc3b8a853261a1afd8f0c9132d34d1a681b10204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614756Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#660616}
-
Victor Costan authored
All the necessary data has been collected. This CL undoes the parts of https://crrev.com/c/1180530 and https://crrev.com/c/1183786 that were not general code health improvements. Bug: 875538 Change-Id: Ibd604c69996072db71c47b18b99f79962f389c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612266 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#660615}
-
Wez authored
This test sometimes hangs on Fuchsia, so add diagnostics to show us where. Bug: 959245 Change-Id: Id09d68d089fcf7eac1fbe6b2fe760767ad337c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614707 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#660614}
-
Lukasz Anforowicz authored
kEnforceRequestInitiatorLockForCorb has been enabled by default since 73.0.3661.0 and there are no known issues associated with this feature. SiteIsolation.XSD.NetworkService.InitiatorLockCompatibility metric shows that kBlockingWhenIncorrectLock is encountered in practice, but only for 0.01% of requests. Bug: 871827 Change-Id: I46d5eea647bde5408482cb21441e260df83a78e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612357Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#660613}
-
Mounir Lamouri authored
This is a reland of c097ed0a Original change's description: > Picture-in-Picture: implement OnStopped() in session observer. > > This is removing the latest IPC for Picture-in-Picture and solves one bug that > had the element not notified of the Picture-in-Picture state change if the > window was closed after the src was reset and therefore the media player wasn't > able to get the IPC. > > Bug: 919860, 940694 > Change-Id: I3f2badd7724fc9037d360bf88fb22adc3b7f14a2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611509 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659655} TBR=dcheng@chromium.org,dalecurtis@chromium.org Bug: 919860, 940694 Change-Id: Ie503d9a1ed2bbbaf0b2502d827c6922aef574054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613368Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#660612}
-
Ryan Hamilton authored
Change-Id: Iae28c97538f406f27d44181ba280d995e8d276c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615833 Commit-Queue: Ryan Hamilton <rch@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#660611}
-
Bo Liu authored
Low rank connections often rebind because their group or importance in group needs to be updated. This means the low rank group is often considered the most recently used by activity manager. This however is the exact opposite of desired behavior though. Instead, add a rebind method and rebind high rank connections, with a delay, after group is updated. Bug: 946216 Change-Id: I5c3ad1c07083daceab37bc3ec14e2450480cbc4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606184Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#660610}
-
Alexander Alekseev authored
This Cl fixes regression added in https://crrev.com/c/1554042 moving DISPLAY_TYPE enum back to global space. Bug: 952223 Change-Id: If7dde9e34b18d282e2c258a69d107c7edb7951a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614108Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#660609}
-
Peter K. Lee authored
This adds a delegate method to ContentSuggestionsHeaderViewControllerDelegate protocol specify how user's avatar image would be processed. New Tab Page uses this delegate method to add/update the avatar for the current user's identity and display at the top right corner of NTP. Bug: 961120 Change-Id: I19abd5eab02481214a605de4b6321aa9a22ea79f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612091Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#660608}
-
Brandon Wylie authored
Bug: 954404 Change-Id: I76c44b4cca9f8c442de4ac2c0a1154cb8e2938dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610598 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#660607}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ea05691e76b6..a2e4f03e8e6a git log ea05691e76b6..a2e4f03e8e6a --date=short --no-merges --format='%ad %ae %s' 2019-05-16 crouleau@chromium.org [Telemetry] Save shard index in test results JSON. Created with: gclient setdep -r src/third_party/catapult@a2e4f03e8e6a The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:960951 TBR=simonhatch@google.com Change-Id: I2a96855cbac186d91922d9d27bae9d8e973c0750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615878Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660606}
-
Christopher Cameron authored
The FormControlsRefresh feature will make macOS use the Aura theme (and the refresh theme, where it is implemented). Add a runtime feature, FormControlsRefresh, to control this in blink. Update and dedupe tests. TBR=pbr,avi Bug: 846357, 956778 Change-Id: If274aab5b5ac2169758e50d12c27d8772263b45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613755Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#660605}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c3df392d69c9..0391cd9d0f6b git log c3df392d69c9..0391cd9d0f6b --date=short --no-merges --format='%ad %ae %s' 2019-05-16 evanhernandez@chromium.org tree_status: Move health alerting to lib/alerts Created with: gclient setdep -r src/third_party/chromite@0391cd9d0f6b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I9c056f97d9b6552331d4d35350cb26574fc84244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614251Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660604}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6cf65f671c1d..ab1e2b49fe88 git log 6cf65f671c1d..ab1e2b49fe88 --date=short --no-merges --format='%ad %ae %s' 2019-05-16 chrisforbes@google.com Unbreak some synchronization edge cases Created with: gclient setdep -r src/third_party/swiftshader@ab1e2b49fe88 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/132897411 TBR=swiftshader-team+autoroll@google.com Change-Id: I200aab9d2c2a4f8f9c47adf93992322f303cb2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614526Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660603}
-