GitLab

 * Sync step documentation ('line position' -> 'line' and similar.)
 * Remove remnants of 'best position' and re-number steps.
 * Implement new cue dodging logic.

BUG=301580

Review URL: https://codereview.chromium.org/1306833003

git-svn-id: svn://svn.chromium.org/blink/trunk@200987 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This disallows getUserMedia() from being used on insecure origins. Adds
a console warning message that the API call has failed because of this.

BUG=520765

Review URL: https://codereview.chromium.org/1284193003

git-svn-id: svn://svn.chromium.org/blink/trunk@200986 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1304183003

git-svn-id: svn://svn.chromium.org/blink/trunk@200985 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We normally use RELEASE_ASSERT for checking !isScriptForbbiden() because executing
a script in places where script execution is not allowed can lead to security issues.

Review URL: https://codereview.chromium.org/1304103002

git-svn-id: svn://svn.chromium.org/blink/trunk@200984 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This bot is new and has a lot of flakiness that needs
digging into. These were generated from
webkit-patch print-flaky-tests.

BUG=521764
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/1302373002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200983 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1304623002

git-svn-id: svn://svn.chromium.org/blink/trunk@200982 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |inRenderedText()| to "VisibleUnits.cpp" from "Position.cpp"
to simplify "Position.cpp" for improving code health since it is used only in
"VisibleUnits.cpp"

BUG=518738
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1309673002

git-svn-id: svn://svn.chromium.org/blink/trunk@200981 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes a regression from Blink r199364 where credentials are not
sent for same-origin webfont requests. This patch basically does the
same thing as HTMLImportsController::load(); set AllowStoredCredentials
flag only when the request is same-origin.

BUG=516192
TEST=http/tests/webfont/same-origin-credentials.html

Review URL: https://codereview.chromium.org/1267023004

git-svn-id: svn://svn.chromium.org/blink/trunk@200980 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1304043002

git-svn-id: svn://svn.chromium.org/blink/trunk@200979 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of [Editing][Codehealth] Replace Position::uptream/downstream to mostBackward/ForwardCaretPosition. (patchset #1 id:1 of https://codereview.chromium.org/1306743002/ )

Reason for revert:
This patch misused each other.
See:
 https://codereview.chromium.org/1310433004/

Original issue's description:
> [Editing][Codehealth] Replace Position::uptream/downstream to 
> mostBackward/ForwardCaretPosition
> 
> Position::upstream calls just VisibleUnit.cpp::mostForwardCaretPosition and also 
> downstream:
> https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/c
> ore/editing/Position.cpp&l=484&cl=GROK
> 
> This CL replaces it.
> We will replace all upstream/downstream and remove them.
> 
> BUG=518738
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200977

TBR=yosin@chromium.org,tkent@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=518738

Review URL: https://codereview.chromium.org/1304133002

git-svn-id: svn://svn.chromium.org/blink/trunk@200978 bbb929c8-8fbe-4397-9dbb-9b2b20218538

mostBackward/ForwardCaretPosition

Position::upstream calls just VisibleUnit.cpp::mostForwardCaretPosition and also 
downstream:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/c
ore/editing/Position.cpp&l=484&cl=GROK

This CL replaces it.
We will replace all upstream/downstream and remove them.

BUG=518738

Review URL: https://codereview.chromium.org/1306743002

git-svn-id: svn://svn.chromium.org/blink/trunk@200977 bbb929c8-8fbe-4397-9dbb-9b2b20218538

mostForwardCaretPosition returns a most backward position and
mostBakwardCaretPosition returns a most forward position.
This is opposite meaning each other.

This CL fixes that.

BUG=518738

Review URL: https://codereview.chromium.org/1310433004

git-svn-id: svn://svn.chromium.org/blink/trunk@200976 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The WTF_PRETTY_FUNCTION takes the name of the class using the typename
given by the compiler. This gives the base class name for all
sub-classes. To make the dump name unique the, gcInfoIndex is appended
to the object name.

BUG=521490

Review URL: https://codereview.chromium.org/1303693005

git-svn-id: svn://svn.chromium.org/blink/trunk@200975 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is partial revert of https://codereview.chromium.org/1060033002.

This CL unships Request.context because it was removed from the spec:
https://github.com/whatwg/fetch/issues/93

This CL
- removes Response.context from Request.idl, and
- updated/removed related Layout tests.

Underlying implementation is left unchanged to be reused for Response.type.

BUG=515786

Review URL: https://codereview.chromium.org/1292503002

git-svn-id: svn://svn.chromium.org/blink/trunk@200974 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch by Jan Olaf Krems
https://gist.github.com/jkrems/5f08ab53c05d96356a1e

BUG=523124

Review URL: https://codereview.chromium.org/1303073002

git-svn-id: svn://svn.chromium.org/blink/trunk@200973 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fixes a raw pointer in MainThreadTaskRunner.

BUG=509911
R=haraken@chromium.org, keishi@chromium.org, oilpan-reviews@chromium.org

Review URL: https://codereview.chromium.org/1296243004

git-svn-id: svn://svn.chromium.org/blink/trunk@200972 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |isVisuallyEquivalentCandidate()| to "VisibleUnits.{cpp,h} from
"Position.{cpp,h}" to consolidate |InlineBox| dependency to "VisibleUnits.cpp"
for ease of working them later.

This patch also gets rid of unused include directives from "Position.cpp".

BUG=518738
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1304063002

git-svn-id: svn://svn.chromium.org/blink/trunk@200971 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |computeInlineBoxPosition()| to "VisibleUnits.{cpp,h} from
"Position.{cpp,h}" and "VisiblePosition.{cpp,h}" to consolidate |InlineBox|
dependency to "VisibleUnits.cpp" for ease of working them later.

BUG=518738
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1303173002

git-svn-id: svn://svn.chromium.org/blink/trunk@200970 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken
BUG=340522

Review URL: https://codereview.chromium.org/1297383003

git-svn-id: svn://svn.chromium.org/blink/trunk@200969 bbb929c8-8fbe-4397-9dbb-9b2b20218538

They don't work until we switch to wptserve because they have links to
/html/resources/common.js.

BUG=490511
TBR=kojii@chromium.org

Review URL: https://codereview.chromium.org/1305983002

git-svn-id: svn://svn.chromium.org/blink/trunk@200968 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=523051

Review URL: https://codereview.chromium.org/1309603002

git-svn-id: svn://svn.chromium.org/blink/trunk@200967 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add IDL for Navigator.Nfc and Nfc. Add the supporting .h|cpp files.
Add simple Layout tests.
Add nfc in webexposed layout test.

Intent to Implement:
https://mail.google.com/mail/u/1/#label/blink-dev/14f261c80935592e

BUG=520391

Review URL: https://codereview.chromium.org/1291663004

git-svn-id: svn://svn.chromium.org/blink/trunk@200966 bbb929c8-8fbe-4397-9dbb-9b2b20218538

cssFloat does not show up as an enumerated property of 
CSSStyleDeclaration even though it does evaluate to a value. FF and 
IE both treat cssFloat as an enumerable property of CSSStyleDeclaration

BUG=492999

Review URL: https://codereview.chromium.org/1288623005

git-svn-id: svn://svn.chromium.org/blink/trunk@200965 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Consequently, update its IDL attribute to [GarbageCollected] and adjust
the return type of its constructor.

R=haraken
BUG=522949

Review URL: https://codereview.chromium.org/1309463002

git-svn-id: svn://svn.chromium.org/blink/trunk@200964 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For the v8 callback objects that PromiseTrackers create, insist on using
a WeakPersistent<> back reference to the PromiseTracker when Oilpan
is enabled.

R=haraken
BUG=340522

Review URL: https://codereview.chromium.org/1301253002

git-svn-id: svn://svn.chromium.org/blink/trunk@200963 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fully transition MediaError, MediaKeyError and TimeRanges to Oilpan.

R=haraken
BUG=340522

Review URL: https://codereview.chromium.org/1306613002

git-svn-id: svn://svn.chromium.org/blink/trunk@200962 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also, add a RELEASE_ASSERT when creating an ArrayBuffer from an
ArrayBufferContents that the backing store is non-NULL.

BUG=522128

Review URL: https://codereview.chromium.org/1302193002

git-svn-id: svn://svn.chromium.org/blink/trunk@200961 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none
R=ksakamoto

Review URL: https://codereview.chromium.org/1300493004

git-svn-id: svn://svn.chromium.org/blink/trunk@200960 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This series of CLs fixes WebCallback parameter types used in PushMessaging.

 - WebPushSubscription* (ownership transferred)
  => PassOwnPtr<WebPushSubscription>
 - WebPushPermissionStatus* (ownership not transferred)
  => WebPushPermissionStatus
 - WebPushError* (ownership transferred)
  => const WebPushError&

1/3: https://codereview.chromium.org/1304723002/
2/3: https://codereview.chromium.org/1291023005/
3/3: https://codereview.chromium.org/1302833004/

BUG=493531

Review URL: https://codereview.chromium.org/1302833004

git-svn-id: svn://svn.chromium.org/blink/trunk@200959 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The issue 521655 causes bad case in |toShadowRoot()| with a test script in
|TextIterator::advance()|. However, I could not get a HTML fragment causing
this situation since the test script generates HTML fragment and I could not
reproduce on my machines.

This patch changes |TextIterator| to stop when it fails to handle shadow tree
to avoid bad cast for preventing attacker to use this.

We'll add a test case for this once we have HTML fragment to cause this
bad cast.

BUG=521655
TEST=n/a; It is hard to create a test case for this issue

Review URL: https://codereview.chromium.org/1293703006

git-svn-id: svn://svn.chromium.org/blink/trunk@200958 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We only need the size of the invalidation rect, so don't need
paintInvalidationContainer to adjust the offset of the rect.

Review URL: https://codereview.chromium.org/1307663002

git-svn-id: svn://svn.chromium.org/blink/trunk@200957 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The while loop starting from L163 in insertOrderedList::doApply uses two loop 
variables, |startOfCurrentParagrap| and |startOfLastParagraph|.
They are of Position type and modified in loop.
Old implementation can go into infinite loop if |startOfCurrentParagrap| skips over 
|startOfLastParagraph|.
Thus this CL adds condition that |startOfCurrentParagrap| 
 should be before |startOfLastParagraph|.

TEST=LayoutTests/editing/execCommand/execCommand/insert-list-infinite-loop2.html

Review URL: https://codereview.chromium.org/1285103002

git-svn-id: svn://svn.chromium.org/blink/trunk@200956 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Allow failure until chromium change is landed and test is updated.

TBR=wolenetz@chromium.org
BUG=523073

Review URL: https://codereview.chromium.org/1293543007

git-svn-id: svn://svn.chromium.org/blink/trunk@200955 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is to gather data for this intent: https://groups.google.com/a/chromium.org/d/topic/blink-dev/qBqeSQeyVXc/discussion

R=leviw@chromium.org
BUG=240765

Review URL: https://codereview.chromium.org/1304853002

git-svn-id: svn://svn.chromium.org/blink/trunk@200953 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Increase information density and address broken layout.

BUG=519609

Review URL: https://codereview.chromium.org/1291483002

git-svn-id: svn://svn.chromium.org/blink/trunk@200951 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Don't consider must-revalidate as uncacheable

BUG=520353

Review URL: https://codereview.chromium.org/1294473004

git-svn-id: svn://svn.chromium.org/blink/trunk@200950 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Here is the piece of code that categorizes various file types:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/modules/filesystem/InspectorFileSystemAgent.cpp&rcl=1424812033&l=280
Note that it doesn't handle media (audio/video, e.g. "audio/mp3",
"video/mp4" and so on) types explicitly. Currently
MIMETypeRegistry::isSupportedNonImageMIMEType will return true for
supported media types, and that will cause media files to be reported
as ResourceType::Document and we'll do
entryForFrontend->setIsTextFile(true) for media files as well.

BUG=462329

Review URL: https://codereview.chromium.org/960333002

git-svn-id: svn://svn.chromium.org/blink/trunk@200949 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Adding support for Smart GO NEXT feature in Android Chrome (patchset #23 id:460001 of https://codereview.chromium.org/939603002/ )

Reason for revert:
Regression in power.android_acceptance.
crbug.com/520952


Original issue's description:
> Adding support for Smart GO NEXT feature in Android Chrome
> 
> This change takes care of providing easy navigation among text input
> elements inside a form.
> 
> Corresponding changes to control the PREVIOUS, NEXT and GO button is done
> at https://codereview.chromium.org/1080693002/
> 
> BUG=410785
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200398

TBR=kochi@chromium.org,l.gombos@samsung.com,ajith.v@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=410785,520952

Review URL: https://codereview.chromium.org/1303123002

git-svn-id: svn://svn.chromium.org/blink/trunk@200948 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522939
TBR=pfeldman

Review URL: https://codereview.chromium.org/1307643002

git-svn-id: svn://svn.chromium.org/blink/trunk@200947 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL exposes the outgoingReferrer() method on the public WebDocument
interface. This allows Chromium to access a page's outgoing referrer
(stripped of undesirable information) via WebDocument.

BUG=522734

Review URL: https://codereview.chromium.org/1289343006

git-svn-id: svn://svn.chromium.org/blink/trunk@200946 bbb929c8-8fbe-4397-9dbb-9b2b20218538