- 08 Aug, 2019 40 commits
-
-
Maggie Chen authored
base::Time represents an absolute point in coordinated universal time (UTC). base::TimeTicks which tracks the amount of time a task runs. Watchdog V2 uses TimeTicks to check timeout. Adding clock time and analyzing the difference between these two might help debugging V2. Bug: 949839 Change-Id: I21e9250e67a02f4190d12d28d33c5c7a52a2168c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742440 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#685365}
-
John Delaney authored
This change exposes a new method on the NavigationController that commits an error page in a frame. This is necessary in order to trigger error pages from the browser process, and to ensure that they are committed correctly and in the correct process. This error page navigation API is used in https://chromium-review.googlesource.com/c/chromium/src/+/1744639 Change-Id: Idc3ff81219e1313c12c45a969c2099a68869f957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731554 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#685364}
-
Yury Semikhatsky authored
Bug: v8:9509 Change-Id: I7a7da029e95edf845456673e7a776bf7ac5e1aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743875 Commit-Queue: Yury Semikhatsky <yurys@chromium.org> Auto-Submit: Yury Semikhatsky <yurys@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#685363}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/940c2b500589..287bff32f45e git log 940c2b500589..287bff32f45e --date=short --no-merges --format='%ad %ae %s' 2019-08-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 498f5876..9230e75a (685149:685264) 2019-08-08 srte@webrtc.org Adds struct parameters parser/encoder. Created with: gclient setdep -r src/third_party/webrtc@287bff32f45e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I6ef941c367bde0db77902c18e1f5c0f2a9b4785b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744774Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685362}
-
David Grogan authored
Added comment and DCHECK showing why it didn't make sense. No behavior change. Some code churn due to accommodating the DCHECK. Bug: 845235 Change-Id: If159ec3d44821cf447563f60e8a25959c86c46a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744520 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#685361}
-
Dominick Ng authored
These features have had their launch dates pushed back. Update the flags accordingly. Change-Id: I9507c636a615661645bc0e8a77aab5c4ca187ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743234Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#685360}
-
Sam Goto authored
Change-Id: Ia85fde8f82c6205f08a6458d9c1ead191bebb6e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744664Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Sam Goto <goto@chromium.org> Cr-Commit-Position: refs/heads/master@{#685359}
-
Mark Mentovai authored
dump_syms and the .dSYM archiver are intended for use on official Chrome-branded builds. While they work in other configurations, they draw from a static list of data sources that match what ships in an official build. Component builds break code out into many other modules, none of which are in the static list. Any output produced by the chrome_dump_syms or chrome_dsym_archive targets would be misleadingly unusable in a component build. To avoid producing these pointless artifacts, disable their function (while leaving the target names viable via empty "group" definitions, in case anyone depends on them.) Note that the chrome target never depends on either of these targets in a component build. These targets are only reachable explicitly or via a full build. Bug: 991206 Change-Id: I8b6e09f78896da1e02f8dabd2d60d0fd42df2ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742213Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#685358}
-
Matt Simmons authored
The Tab is only used to get the activity and overview mode behavior. Let the consumers (NewTabPageView and FeedNewTabPage) handle instanceof and null checks and pass in the two new parameters. R=yusufo@chromium.org Bug: 985386 Change-Id: Id760dabc41a3c08cf37b0e72a8d6513003b5b88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741965Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#685357}
-
Scott Little authored
This test is flaky on linux-chromeos-rel, so disabling it for now. TBR=hsuregan@chromium.org Bug: 992116 Change-Id: I77512076711cac37eaefea34320475977d05fd26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743102Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#685356}
-
Rakib M. Hasan authored
Bug: chromium:973936 Change-Id: Ib0a9e1e878ad5903363a86359ce21f6562992e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744662Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#685355}
-
Sinan Sahin authored
Remove the scrim's background color because the theme already dims the background. Bug: 989330, 989336 Change-Id: I488e171a4d70317df4a5a0de59e281e3e350fb3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744648 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#685354}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/07b2fa3a..46afc4f9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I58f8e92b8432a8e1b6d254ab1ed7ec94099160ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744374Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685353}
-
Raphael Kubo da Costa authored
These tests were just asserting that the given interfaces existed. The idl harness tests in web-platform-tests do the same and a lot more, so rely exclusively on those instead. Bug: 816462 Change-Id: If2dd8e6bda97d23bb71eff3070921481dc1281a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743631 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#685352}
-
Luke Zielinski authored
Bug: 937369 Change-Id: Icc5fa60040bad133567598cee73e549742e0dd83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744661 Auto-Submit: Luke Z <lpz@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8bd58eb928c3..5472a5a44c1c git log 8bd58eb928c3..5472a5a44c1c --date=short --no-merges --format='%ad %ae %s' 2019-08-08 rmhasan@google.com [Telemetry] Implement GetBrokenExpectations in typ_expectations.StoryExpectations Created with: gclient setdep -r src/third_party/catapult@5472a5a44c1c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:973936 Change-Id: I4a2c1edce7622d8e607dc92f192173a86c453c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744767Reviewed-by:
-
Morten Stenshorne authored
I didn't check why one test started to pass (it's not a very interesting test for overflow). Bug: 829028 Change-Id: I2c2d5fe3ea8c6a87f00df47f81d4158936d8a1bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742162Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#685349}
-
Leo Zhang authored
Chrome crash report ../../sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc: **CRASHING**:seccomp-bpf failure in syscall 0098 Bug: 991435 Change-Id: I249a80192cc874eee1769233f2c10fb4e1267dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741329Reviewed-by:Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#685348}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a110bf60c043..1b4c7e9f3844 git log a110bf60c043..1b4c7e9f3844 --date=short --no-merges --format='%ad %ae %s' 2019-08-08 cbiesinger@chromium.org Make gclient_utils work with Python 3 Created with: gclient setdep -r src/third_party/depot_tools@1b4c7e9f3844 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:984182 Change-Id: I003198b4b72870a29b85cc385ff96af229f450d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744769Reviewed-by:
-
Elly Fong-Jones authored
This change is a fixed version of <https://chromium-review.googlesource.com/c/1334147>. This change: 1) Has MenuController consider command to be an accelerator key, along with control and alt, for the purpose of not searching for mnemonics; 2) Has MenuController stop handling a key press, and cancel the menu, when the key press looks like it is a window-level accelerator instead. Testing: 1) Open the app menu 2) With the app menu still open, hit cmd-T 3) The app menu should dismiss 4) A new tab should appear Bug: 885138 Change-Id: Ib9c9e1517ae9ad3f9ec55eadb9bdfe61762df4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742520 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#685346}
-
Aaron Krajeski authored
It's possible that it has been disposed but its ID still exists. This can lead to UAP bugs. Bug: 978793 Change-Id: Idb4639cb78110878a28ab3c50807174343a66033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744642Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#685345}
-
Jared Saul authored
Was set to ENABLED_BY_DEFAULT, so should be a no-op. Change-Id: I78aa42ca8a7d00face3d2e702c4c7beae550a6db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742441Reviewed-by:
Siyu An <siyua@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#685344}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0b1c529c6e47..0756495a26fb git log 0b1c529c6e47..0756495a26fb --date=short --no-merges --format='%ad %ae %s' 2019-08-08 treehugger-gerrit@google.com Merge "perfetto-ui: Add truncate end option" 2019-08-08 treehugger-gerrit@google.com Merge "perfetto-ui: Update example trace" 2019-08-08 treehugger-gerrit@google.com Merge "trace_to_text: Truncate traces from start or end" 2019-08-08 eseckler@google.com Merge "Trace processor: Export Chrome metadata to JSON" 2019-08-08 skyostil@google.com Merge "client api: Always compile watchdog_posix.cc" Created with: gclient setdep -r src/third_party/perfetto@0756495a26fb The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I2cf01c56638bded45841dc21176d488b4b6ecfd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743022Reviewed-by:
-
Max Moroz authored
The header (testing/libfuzzer/libfuzzer_exports.h) should be included in fuzz targets they define optional libFuzzer symbols, as otherwise those symbols may be stripped by the linker on Mac and fuzz target may work incorrectly, see https://crbug.com/687076 for more information. Bug: 991345 Change-Id: I459774f2bc8de708d67c0af455031146592c4799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738756 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#685342}
-
Sophie Chang authored
Without this, it chokes if multiple optimization types have filters Bug: 969558 Change-Id: Ib8e9fa546847a865f91b758e6f4980b1e4eedad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743103Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#685341}
-
Robbie Gibson authored
One major change is making all the leftImages template images. I looked through all the places I could find that set a left image and they all looked like they are currently blue, so making them a template image should work. Bug: 991185 Change-Id: Ie84b2a945bab07b4eebef889371a94d653eedecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742235 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#685340}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f51ce3d98c68..8b062b2de99f Created with: gclient setdep -r src-internal@8b062b2de99f The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: Ia431d41a01fbe1a86e4f85b983330dffda393bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743023Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685339}
-
Yuly Novikov authored
conformance/reading/read-pixels-test.html on Win Vulkan passthrough TBR=kbr Bug: angleproject:3788 Change-Id: I606f82780bf93cf904bebdf6a864d28f941817b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744581Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#685338}
-
Gabriel Charette authored
MOCK_TIME now works across all managed Threads (main thread and ThreadPool) and also drives TimeTicks::Now(). There once was a desire to perhaps make that the default mode for tests using ScopedTaskEnvironment but I've been hesitant to go there because it might be surprising at times. In light of recent discussions where other defaults (multi-threadedness) have been surprising, I think keeping minimally modifying defaults is better for TimeSource. This completes crbug.com/905412 R=dcheng@chromium.org Bug: 905412 Change-Id: I8ad7669c1abee0c95acc9f06bc4bea5454bd8c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742616Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
-
Juan Antonio Navarro Perez authored
Add descriptions for all tools implemented in src/tools/perf/cli_tools. Bug: 991270 Change-Id: I2781439821f18090cdd95bb82b6291d93e5cf9a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743633 Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
-
Ahmed Mehfooz authored
Adding workaround for keeping the notification timestamp visible. Invalidating the layout of the parent view of the timestamp any time it's visibility is changed. Bug: 991150 Change-Id: If8c750bfc8f34310a8e93ff2ea30e180e19a9e68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739976Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#685335}
-
Fernando Serboncini authored
This adds a flag to disable: - window.OffscreenCanvas - Context2DCreation.desynchronize. - HTMLCanvasElement.transferControlToOffscreen This is a reland to add WebView layout test expectations. TBR=alexmos,chrishtr,wfh,boliu Bug: 940953 Change-Id: I1973c94ced693f0e91785c5197c0d9173e467af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743098Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#685334}
-
Chris Mumford authored
TBR=pwnall@chromium.org Bug: None Change-Id: Ie9ef58efb532a0f2392959fa3f3b3cd35118f910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744523Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#685333}
-
dpapad authored
test_util.waitForRender -> test_util.waitBeforeNextRender PolymerTest.afterNextRender -> PolymerTest.waitAfterNextRender This is a preparatory step for exposing these helpers from the auto-generated test_util.m.js, necessary for testing Polymer3 elements. Bug: 965770 Change-Id: I6fbee615a19311c534023490222298b4582e3d7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744580Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#685332}
-
Emircan Uysaler authored
This CL adds enforce-vulkan-protected-memory switch that forces us to use protected memory for vulkan compositing in fuchsia. Based on this flag, we make sure that all the allocations and vulkan calls are marked as protected according to the spec. This is a part of the bigger effort to enable protected memory usage for video playback, see bug for details. Adding these changes behind this flag allows us to test chrome in different environments while there are ongoing changes re protected memory in skia, scenic and HW decode. Bug: 982922 Change-Id: If69345ee757d6571c4934cab477a3e19c6dd888b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695931 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#685331}
-
Christopher Cameron authored
Add a cache of the result of calls to NewLibraryWithRetry. This will store all resulting MTLLibraries indefinitely, and will grow without bound. The goal is to minimize the number of calls hitting the MTLCompilerService, which is prone to hangs. Should this significantly help the situation, a more robust cache will be added either to MTLDeviceProxy or to Skia. This does not cache MTLRenderPipelineState results (a follow-on patch may, if that seems helpful in diagnosing the crases). Bug: 974219, 988964 Change-Id: I94e360eb8996b0624eae03fe6f0a85a3aee71fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738807Reviewed-by:
-
Nicolas Arciniega authored
Setting this policy should affect the state of the network service as it is getting created. This test verifies that the policy does indeed modify the state of the network service. It does not experimentally verify the number of connections per proxy. That sort of test is covered in /services code. Bug: 981598 Change-Id: Icf376f922d7d8907fb22abfad62ffd7daf33c6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738342 Commit-Queue: Nicolas Arciniega <niarci@microsoft.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4c833efb60a1..b8ec98fe171b git log 4c833efb60a1..b8ec98fe171b --date=short --no-merges --format='%ad %ae %s' 2019-08-08 courtneygo@google.com Fix build issue with tracing enabled 2019-08-08 ianelliott@google.com Vulkan: Fix crash with glBeginTransformFeedback 2019-08-08 clemendeng@google.com BasicMangledName class 2019-08-08 iannucci@chromium.org Roll ./build/ 54ea0e7fd..680f9ea3d (665 commits) Created with: gclient setdep -r src/third_party/angle@b8ec98fe171b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Bug: chromium:973721 Change-Id: I90943e9ef4b08a0c8fb3c350c6d6bc77c85c8254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743024Reviewed-by:
-
Tibor Goldschwendt authored
This test dummy module will be used by a smoke test execute various bundle / DFM system test scenarios (see go/dfm-testing for more details). The test type needs to be a smoke test as we will be testing scenarios that depend on packaging, i.e. we need an actual bundle with separate DFM APKs. That is something a unit or integration test doesn't provide. This CL adds one sample test scenario. We will add more later. Bug: 989651 Change-Id: I3f78025a7f0b48904eaa24c1080a817dadd7811a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726394Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#685327}
-
Danan S authored
Also, hide Parental controls from regular settings if SplitSettings is enabled. Bug: 977615 Change-Id: I13aa6f32aec8768e94bc2bf4730fb62209633c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740306 Commit-Queue: Danan S <danan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#685326}
-
