- 20 Feb, 2019 40 commits
-
-
Daniel Murphy authored
R=mek@chromium.org Bug: 927534 Change-Id: Ic50cb227f34127ed69cbd9e8edf13ca5824238d6 Reviewed-on: https://chromium-review.googlesource.com/c/1479274Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#633881}
-
Stefan Zager authored
BUG=933694 R=atotic@chromium.org Change-Id: I0a0aac1da5ab30ab09c1557e88387b1a2987bdf0 Reviewed-on: https://chromium-review.googlesource.com/c/1478944Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#633880}
-
Xiyuan Xia authored
- Make InputMethodMus send changed text client data before notifying OnCaretBoundsChanged because InputMethodChromeOS processes on the data in its OnCaretBoundsChanged. - Adjust RemoteTextInputClient::GetTextFromRange to allow empty range on empty text. Otherwise, when all text is deleted, GetTextFromRange returns false that causes IMEEngine's SetSurroundingText not getting called in this scenario and breaks suggestions later on. Bug: 933059, 933019 Change-Id: I93802a78c6c605c5f4dcdb5ea6a806e149745f17 Reviewed-on: https://chromium-review.googlesource.com/c/1478262 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#633879}
-
Hiroshige Hayashizaki authored
After this CL, WorkerGlobalScope's URL is initially set to the null URL, and later set to the response URL of the top-level script - When the top-level script is loaded, if off-the-main-thread fetch is enabled for the worker, or - Immediately after that during construction, otherwise. This CL adds CHECK()s to catch cases where the URL is accessed before ready. |GlobalScopeCreationParams::script_url| is still used to set the WorkerGlobalScope's SecurityOrigin that should be the same as the response URL's origin. This is ensured by https://chromium-review.googlesource.com/1147664 and this CL adds CHECK()s for this in WorkerGlobalScope::InitializeURL(). Even after this CL, DevTool's context selector will still show request URLs for off-the-main-thread-fetched worker scripts (because WorkerThreadDebugger::ContextCreated() uses |GlobalScopeCreationParams::script_url|) while global scope's Url() is changed to the response URL. This should be handled later in Issue 866666. Bug: 861564, 866666 Change-Id: I304309ca4d7f08a11bb0dc5c0bcb6cc661d3fdba Reviewed-on: https://chromium-review.googlesource.com/c/1139074 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#633878}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5f2e9a96. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" af3b056c "[WPT] [wasm] Add JS-API tests for wasm threads" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" e555be86 "Sec-CH-UA: Send only the major version by default." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ie8003db432ede70dfc00312c1778f512dd09577f Reviewed-on: https://chromium-review.googlesource.com/c/1478941Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#633877}
-
Mina Almasry authored
Currently cast_media_unittests can't build on platforms (enable_video_with_mixed_audio == true && use_alsa == false), because of not finding the VideoDecoderForMixer::InitializeGraphicsForTesting symbol. This symbol isn't useful on those platforms, so define a dummy that can be used in this case. BUG=b/124520050 TEST=Build cast_media_unittests Change-Id: I35abfc3a549cd1fa185534d7b48d8dd93db14e04 Reviewed-on: https://chromium-review.googlesource.com/c/1475048 Commit-Queue: Mina Almasry <almasrymina@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Auto-Submit: Mina Almasry <almasrymina@chromium.org> Cr-Commit-Position: refs/heads/master@{#633876}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e19ff219c478..5f79016feed9 git log e19ff219c478..5f79016feed9 --date=short --no-merges --format='%ad %ae %s' 2019-02-20 thestig@chromium.org Fix data ownership in CPDF_ObjectStream. Created with: gclient setdep -r src/third_party/pdfium@5f79016feed9 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:933212 TBR=dsinclair@chromium.org Change-Id: I936daf98be578a98395d9daaec923c114999a392 Reviewed-on: https://chromium-review.googlesource.com/c/1479372Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#633875}
-
Yiming Zhou authored
Bug: 885350 Change-Id: I2a60146063a675c1bc815134b2a15060520390b1 Reviewed-on: https://chromium-review.googlesource.com/c/1479304 Auto-Submit: Yiming Zhou <uwyiming@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#633874}
-
Hiroshige Hayashizaki authored
To avoid ExecutionContext::Url() calls during worker initialization. Ideally, the URL should be the response URL of the worker top-level script, but in off-the-main-thread worker top-level script fetch cases, it isn't available at the time of WorkerInspectorController ctor that immediately uses the |url_|. Therefore this CL uses |script_url| (which is the request URL of the worker top-level script in off-the-main-thread worker top-level script fetch) and leave the issue tracked by Issue 866666. Bug: 861564, 866666 Change-Id: I5ccae99996871558762e8a76b141352e17b57216 Reviewed-on: https://chromium-review.googlesource.com/c/1478458 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Tom Anderson authored
Bug: 495204 R=thakis Change-Id: I4c2e9b0a57e7d51e487ae1671e8822b487e0f42a Reviewed-on: https://chromium-review.googlesource.com/c/1114301 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#633872}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ad6d56748d98..6c62e9541214 git log ad6d56748d98..6c62e9541214 --date=short --no-merges --format='%ad %ae %s' 2019-02-20 mikenichols@chromium.org chromeos_config: Increase PFQ timeout to 8 hours 2019-02-20 dgarrett@google.com branch_archive_stages: Create FactoryArchiveStage. Created with: gclient setdep -r src/third_party/chromite@6c62e9541214 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ibf2cc62c51aa3a6c9a85f6ec605813b7d0bf0efc Reviewed-on: https://chromium-review.googlesource.com/c/1479053Reviewed-by:
-
Eric Orth authored
Added functionality to MockCachingHostResolver to handle automatic invalidation of cache entries after X resolves from cache. As this was the last override of MockHostResolverBase, convert the constructor to private with friends to force everything to deal with MockHostResolver or MockCachingHostResolver as that seems to be the intention of MockHostResolverBase. Bug: 922699 Change-Id: I245e9ee32683f67cfcc7b1ad9a406cfbd223f56e Reviewed-on: https://chromium-review.googlesource.com/c/1478354 Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#633870}
-
Karan Bhatia authored
This CL modifies the URLPatternIndex matching algorithm to ensure that the separator placeholder (^) also matches the end of the text, thus fixing an existing TODO. BUG=772260 Change-Id: If6917c1ea4c7a037765ca421075bf298f64c5ceb Reviewed-on: https://chromium-review.googlesource.com/c/1476814 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#633869}
-
Sorin Jianu authored
Remove the public accessors, and bind the data in the callbacks instead. Bug: 929167 Change-Id: Ib6b41bc33551d3a81f2226344e53325cace5cf87 Reviewed-on: https://chromium-review.googlesource.com/c/1479191Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#633868}
-
danakj authored
Allows usage only in .cc files (which won't leak out of test_runner) and the Web(Frame|View|Widget)TestProxy headers, which are not included in non-web-test code. Also restricts //content/shell from including the Web(Frame|View|Widget)TestProxy headers. R=jochen@chromium.org Bug: 912193 Change-Id: I82528217eeaa363f54f0fc102e1e5a9500f707a8 Reviewed-on: https://chromium-review.googlesource.com/c/1476462 Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#633867}
-
wutao authored
This patch replaces the Assistant icon to Mic icon and entering listening state if clicking the Mic. Bug: 924624 Test: manual Change-Id: I40e224254693178963f9fadb185818f4b902349b Reviewed-on: https://chromium-review.googlesource.com/c/1477514Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#633866}
-
Robbie McElrath authored
Change-Id: I7b39e8d244b150ab4093c2dcee21ca9873934661 Reviewed-on: https://chromium-review.googlesource.com/c/1478471Reviewed-by:
-
liberato@chromium.org authored
This CL turns off one-hot conversion for nominal features, and instead adds a similar effect directly in RandomTreeTrainer. Instead of converting each nominal feature of N values into N binary features, have the tree builder pick uniformly at random one of the N values to do the split. This choice is made without regard to the number of examples with a particular value, since that's what one- hot encoding would do. For example, if 9 examples have value "A" and 1 has value "B", then each "A" and "B" has a 50% chance of being the split point. For one-hot, there would be two binary features, and the split selection would similarly pick between them with equal probability. There is one difference between one-hot values, however. The current system still picks first, uniformly, a set of features to split on, then chooses (again uniformly) which value to split on this time. The first pick is different, since one-hot would give each value equal weight across multiple features. For example, if we have two features f1 and f2 with values {A,B} and {C,D,E,F}, then one-hot would pick a split uniformly over the resulting 6 features, each of which was a feature value in the original nominal. Now, we'll pick uniformly between f1 and f2, then uniformly again from either {A,B} or {C,D,E,F}, depending on whether we chose f1 and f2. With one-hot encoding, we had twice the chance to pick a f2 value than f1. We could emulate this when choosing features, but it seemed to work okay and is simpler. The reason this is faster is that, for M features of N nominal values each, one-hot would generate M*N features that would be searched over at each node. Now, we have only M features and then a search over N to pick the split. We could preserve this even if we fixed the discrepancy above. For FisherIrisDataset test with nominal features, locally this reduces the runtime of the test from ~325 msec to ~90 msec. Change-Id: I8a43963db8be7e7eb6eb8bb5efc64aefdc6ca67d Reviewed-on: https://chromium-review.googlesource.com/c/1478177 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#633864}
-
Akihiro Ota authored
Adds new hotkey (modifier + a + f) for ChromeVox users to quickly get all supported text format attributes: bold, italic, underline, strike through, font family, font size, and color. Bug: 929414 Change-Id: Ia33463e4a3566aed34631964a28d537c7d14fbbc Reviewed-on: https://chromium-review.googlesource.com/c/1456210 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#633863}
-
Andrew Luo authored
Bug: 919221 Test: python /<sdk dir>/platform-tools/systrace/systrace.py -a org.chromium.webview_shell Change-Id: Id58f9a840ceaa6e88d11616e590091d2d588b901 Reviewed-on: https://chromium-review.googlesource.com/c/1478452 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#633862}
-
Caitlin Fischer authored
Change-Id: I7087dbf6199cb4634acb8371674053fc508ce495 Reviewed-on: https://chromium-review.googlesource.com/c/1477816 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#633861}
-
Morten Stenshorne authored
When loading via ScheduleNavigation(), we didn't change null URLs to about:blank. The test is quite meaningless when it doesn't crash, so it's not exported. Bug: 930065 Change-Id: Ia23d30fe85720627d231a18d7b5f1dcf3927e9fa Reviewed-on: https://chromium-review.googlesource.com/c/1459623Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#633860}
-
Daniel Libby authored
This reverts commit 3e4749d2. Reason for revert: This change is no longer needed - we are no longer planning on removing the dependency from ui/base to ui/events Original change's description: > Create BUILD.gn in ui/base/idle > > This one step in a series of clean up refactoring changes > that will result in ui/base no longer having dependencies on > ui/events. This will allow ui/base to be treated more as the lowest > layer of the ui/ components. > > This change adds a BUILD.gn to ui/base/idle to create a new > component. This is in preparation of doing the same for > ui/base/user_activity which has a dependency on ui/events > (and on which ui/base/idle has a dependency). > > Bug: 921723 > Change-Id: I1b98d33ce8dfd78309fd532cbfc2bb013453c83f > Reviewed-on: https://chromium-review.googlesource.com/c/1428563 > Commit-Queue: Daniel Libby <dlibby@microsoft.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#627720} TBR=sadrul@chromium.org,sky@chromium.org,dcheng@chromium.org,dlibby@microsoft.com Bug: 921723 Change-Id: I80080945da2f2726ce79b477644b65e82b0e2ff2 Reviewed-on: https://chromium-review.googlesource.com/c/1478252Reviewed-by:
-
Nancy Li authored
The file device_manager_test.mojom-lite.js is updated so add a '$' here to make it working. Bug: 931809 Change-Id: I3d1b3c469743bdce45c511079d833c1401cf7f2f Reviewed-on: https://chromium-review.googlesource.com/c/1479093 Auto-Submit: Nancy Li <nancyly@google.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#633858}
-
Matt Menke authored
This file should have been removed in https://chromium-review.googlesource.com/c/chromium/src/+/1417719, which converted the two remaining tests in that file to be TransportClientSocketPoolTest.SOCKS and TransportClientSocketPoolTest.TagSOCKSProxy, and removed the file from the build. Bug: 472729 Change-Id: I30ad81ecceaab75e84597ab3d162c65c4729cb31 Reviewed-on: https://chromium-review.googlesource.com/c/1479291Reviewed-by:
-
Eric Orth authored
More resolves that only exist to warm the HostCache. Replaced with LoadIntoCache(). Bug: 922699 Change-Id: I88a842f388bbbf44b34eaf84c66a85079470cd1a Reviewed-on: https://chromium-review.googlesource.com/c/1477937 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
-
Thomas Anderson authored
Mac asan libraries don't provide operator new/delete unlike on Linux, so libc++ must provide them. BUG=933365 R=thakis Change-Id: I99dfe5aa7979721c0026bdb73845b1a8a012708e Reviewed-on: https://chromium-review.googlesource.com/c/1479392 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Tommy Nyquist authored
The Google Play inline update feature previously needed to be enabled manually or from a server side configuration, but this CL makes it possible to do this directly from chrome://flags/#enable-inline-update-flow The forced update types (#force-update-menu-type) still overrides this though, to be able to test the feature without using the real backend after the feature is on by default. BUG=922714 Change-Id: I9a4f0b826a267c8c01cabd8d57679a35278c1938 Reviewed-on: https://chromium-review.googlesource.com/c/1478450Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Eyor Alemayehu authored
Currently, we only track whether or not consent has been given to access a user's Web and App activity in Assistant. We do the tracking using a boolean preference flag. However, due to the need to handle the various consent error states, we need to replace the boolean flag with an integral one. The work in this CL is needed to provide a separate experience for GSuite users whose administrators have not granted access to Web & App activity. Design: go/gsuite-optin Bug: b:123638794 Change-Id: I4bfbde8b90b9b560ef2f6e29721e655051ad111d Reviewed-on: https://chromium-review.googlesource.com/c/1446779Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Eyor Alemayehu <eyor@google.com> Cr-Commit-Position: refs/heads/master@{#633853}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c74512c7ff9e..5bb4470727b8 git log c74512c7ff9e..5bb4470727b8 --date=short --no-merges --format='%ad %ae %s' 2019-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 93317ec84443..e205d343d90c (1 commits) 2019-02-20 brianosman@google.com Refactor and further generalization of particle model 2019-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader f4b99b674a1b..93317ec84443 (3 commits) 2019-02-20 egdaniel@google.com Fix setting of GL texture swizzle when using 1 for swizzle. Created with: gclient setdep -r src/third_party/skia@5bb4470727b8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I0b2f41b2ba1f3ba684202dcd088d75c775e12204 Reviewed-on: https://chromium-review.googlesource.com/c/1479270Reviewed-by:
-
Pedro Amaral authored
Currently we always disable the bottom toolbar home button in the NTP. This is a problem if the user has a homepage set. This CL makes it so the home button is only disabled if Clear Tabs is enabled or if a homepage is not set (not setting a homepage means the home button defaults to the NTP). Bug: 933431 Change-Id: I44ea34d21e42952b9ed07a09c0ad9e21ef712718 Reviewed-on: https://chromium-review.googlesource.com/c/1477760 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#633851}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e8ab7db4d4da..73105e25f71c git log e8ab7db4d4da..73105e25f71c --date=short --no-merges --format='%ad %ae %s' 2019-02-20 crouleau@chromium.org Add Simon as catapult owner Created with: gclient setdep -r src/third_party/catapult@73105e25f71c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:933445 TBR=sullivan@chromium.org Change-Id: I12b193a8e25fba69705586734477e873684b4ea3 Reviewed-on: https://chromium-review.googlesource.com/c/1479051Reviewed-by:
-
Scott Violet authored
In classic ash IME would only stop processing if StopPropagation was called. In mash, IME was stopping processing if handled() was called. This patch changes mash so that it can distinguish between the two. Specifically mojom::TextInputClient::DispatchKeyEventPostIME() gets a boolean so that it has both handled and stopped_propagation so that logic can be wired up to match classic. BUG=931923 TEST=none Change-Id: Ica08929c4ce998c2f2af4fc8bf59a6b2081e97f2 Reviewed-on: https://chromium-review.googlesource.com/c/1477941 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#633849}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/74142cf4ffe7..c3f2ec7ab3ee git log 74142cf4ffe7..c3f2ec7ab3ee --date=short --no-merges --format='%ad %ae %s' 2019-02-20 fmayer@google.com Merge "profiling: Move demangling off device." Created with: gclient setdep -r src/third_party/perfetto@c3f2ec7ab3ee The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I378e823744676c60de9f5c6e5f2771733298ec92 Reviewed-on: https://chromium-review.googlesource.com/c/1479271Reviewed-by:
-
Wez authored
Move StartCastComponent() into the test fixture, and break out the CastChannel implementation to a separate helper class, for clarity. Also fixes WebComponent to be usable even if the caller does not provide a service-directory request handle to CreateComponent(). Bug: 918724, 893229 Change-Id: I9fafd6536d550240d79ee7baa7f4e653db823066 Reviewed-on: https://chromium-review.googlesource.com/c/1474647Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#633847}
-
Rohit Rao authored
Support for bundle_deps was largely already present, but not fully propagated through to the innermost GN rule. BUG=930859 Change-Id: I5150d062189d8d251a2bb756c67a9f843b2fbef3 Reviewed-on: https://chromium-review.googlesource.com/c/1478494Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#633846}
-
Brandon Jones authored
Reland of https://chromium-review.googlesource.com/c/chromium/src/+/1343065 Incorporates fixes made by jacde@chromium.org (Thanks!) Deactivates XRFrame objects once the relevant callback returns, which causes future calls to the object methods to throw an exception. Bug: 906842 Change-Id: Ib635f56ed28b728434a08347b9d9fb98d1ecd694 Reviewed-on: https://chromium-review.googlesource.com/c/1363836 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#633845}
-
Nico Weber authored
Bug: 926235 Change-Id: If8aad69145d67db353b17364d4e7c28ef38a7f51 Reviewed-on: https://chromium-review.googlesource.com/c/1477827 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#633844}
-
Bruce Dawson authored
On ARM64 builds of mini_installer the compiler generates calls to memcpy. Since we don't link mini_installer with the CRT (to guarantee that it is kept small) we have to implement this function. Bug: 931856 Change-Id: I3e1909b6ebf6255e0da981f20282562c33547a9b Reviewed-on: https://chromium-review.googlesource.com/c/1476527 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#633843}
-
Liquan(Max) Gu authored
The current implementation has a memory leak issue. TextPaintTimingDetector has two heaps which only allows adding but not removing. This leads to a memory leak issue. In a test case (see bug 922925) where new nodes keep generated and deleted, the memory leak is detected. To fix this issue, we use a cap as a stopping condition for tracking new nodes. The cap has already been in place but only used by recorded_text_node_ids_. We will extend it to the heaps. The stopping condition was triggered by the size of recorded_text_node_ids_, which was not in sync with the two heaps. In our change, we will make the three in sync so that the two heaps' deactivation will also be subjected to the same condition. More impl details: * We add a detached-node-set to record the detached nodes. Initially, when a node was detached, we completely forgot the record of it. Now, we keep it in detached-node-set until the node is reattached. * We replace the heaps with ordered set, which instruments the adding of detached-node-set. We used to use heap, which only allowed visiting the top of the heap each time. If the top had been erased, we discard the value. In this change, we need to support visiting the non-top as we no longer employ the discarding approach, so we need to replace the heap with the ordered set. Bug: 922925 Change-Id: Ie7d988bf077aa99ee776c7280c63ce39d51fa447 Reviewed-on: https://chromium-review.googlesource.com/c/1475907 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#633842}
-
