- 16 Aug, 2018 40 commits
-
-
kylechar authored
1. Call reset() instead of assigning nullptr for scoped_refptrs. 2. Don't reset |worker_context_provider_| if |main_context_provider_| fails to get created. Bug: 791660 Change-Id: Ib9610981ed165b220ae2129a2ebd11e52464f693 Reviewed-on: https://chromium-review.googlesource.com/1176343 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583844}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia1199785d91120d49c08e46c85e0bc730709ee3d Reviewed-on: https://chromium-review.googlesource.com/1178884 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583843}
-
Jacob Dufault authored
By merging the two separate methods, the control flow is simplified, which will help prevent any possible animation glitches if, for example, both PIN and public session are animating at the same time. Bug: 873328 Change-Id: Ia3faa9d60aba91996804fc1ee3f64030467a4a1a Reviewed-on: https://chromium-review.googlesource.com/1173393 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#583842}
-
Scott Little authored
This CL implements support for the "lazyload" attribute on frames, according to https://github.com/whatwg/html/pull/3752, and as part of the LazyLoad feature. The accepted values are: "on", which causes the browser to lazily load a frame even if it's same-origin or nested inside another lazyloaded frame, "off", which causes the browser to avoid lazily loading this frame or any of it's children (unless those children are marked with lazyload="on"), "auto", which activates the default behavior, and is therefore not explicitly handled in code. Bug: 873358 Change-Id: I2fde65adb15216260291b08e39888a2363f44d4a Reviewed-on: https://chromium-review.googlesource.com/1176293 Commit-Queue: Scott Little <sclittle@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#583841}
-
Xiaocheng Hu authored
Bug: 699017 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I88f9753576e67f1ed5ff4f6ca8fbf52cac4bcda2 Reviewed-on: https://chromium-review.googlesource.com/1178755 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#583840}
-
Kyle Horimoto authored
This allows the settings page to request that multi-device features be enabled or disabled via clicks on a toggle. Bug: 824568 Change-Id: I7edf3991036d5119a1bed8cf67f82b2138594b13 Reviewed-on: https://chromium-review.googlesource.com/1176870 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#583839}
-
Adrienne Walker authored
The renderer doesn't use these flags, so this is just a temporary mechanism for crash visibility. Right now there are some number of crashes that are happening on platforms where OOP-R is not turned on (e.g. Windows), and it would be helpful to verify in the short term that OOP-R is being turned on deliberately via a command line flag vs accidentally. These should be removed once OOP-R is shipping by default everywhere. Bug: 757605 Change-Id: Ib5a1a1d49939851b71563762409ac0fc0ba05ede Reviewed-on: https://chromium-review.googlesource.com/1178570Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#583838}
-
siyua authored
After this change, the offer-dialog should be properly shown if a user clicks the continue button in the migration bubble. 1) Made changes related to Autofill Client and wires things up. 2) Changed method names of showing local card migration bubble from ShowLocalCardMigrationMainPrompt to ShowLocalCardMigrationDialog. The flow will be enabled only on desktops for now. Bug: 852904 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id5ee55156eb1e8615e955716836cfecd677ff456 Reviewed-on: https://chromium-review.googlesource.com/1173551Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#583837}
-
Timothy Gu authored
The removed test fast/loader/document-destruction-within-unload.html was originally added in 8809405d, to make sure that a document.write() call that blows away the current page still works in unload event listeners and blocks any current attempt to navigate. Since we no longer allow that to happen, the test is obsolete. In fact, it can be seen as contradictory to external/wpt/html/browsers/browsing-the-web/unloading-documents/005.html, which tests that document.open() in an unload event doesn't block navigation. Bug: 583586, 866274 Change-Id: I99b35dd28c97e8603455805b31d49644bc7b23a5 Reviewed-on: https://chromium-review.googlesource.com/1169320 Commit-Queue: Timothy Gu <timothygu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#583836}
-
Robbie McElrath authored
This migrates NetworkStatusListenerImpl from using net::NetworkChangeNotifier to content::NetworkConnectionTracker, which works with the network service enabled. Bug: 868011 Change-Id: I98d8644c128174b7b887c76dc40ad2725f052182 Reviewed-on: https://chromium-review.googlesource.com/1161200Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#583835}
-
inglorion authored
This test was re-enabled in crrev.com/c/1110151, but creates noise on the bots because it is flaky. Disabling it for now to stop the noise. Bug: 873792 Change-Id: I4c136a36d916bc8096ebba6d8d5839dea22533cf Reviewed-on: https://chromium-review.googlesource.com/1173406Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#583834}
-
BUG=762641 TBR=michaelpg@google.com Change-Id: I67360a75937b38fde2a636e6c759949ffb84cf97 Reviewed-on: https://chromium-review.googlesource.com/1178756Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583833}
-
Eric Willigers authored
FeaturePolicyForPermissions has been retired from runtime enabled features. We don't need to mention it in VirtualTestSuites. BUG=788390 Change-Id: I22e05513852fcc17c2eea514fd5c54b3c0051b37 Reviewed-on: https://chromium-review.googlesource.com/1176882Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#583832}
-
Greg Thompson authored
base::CreateDirectoryAndGetError now ensures that the last error code on Windows is relevant so that callers may meaningfully use the PLOG family of macros to get readable error messages. BUG=874037 R=gab@chromium.org Change-Id: I6d426c57e0a0ae101e13ebdbe34815ec40801b1e Reviewed-on: https://chromium-review.googlesource.com/1175782 Commit-Queue: Greg Thompson <grt@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#583831}
-
Carlos Knippschild authored
Introduces the API to be used for the article suggestions provider to be implemented by the new and upcoming Feed implementation. Bug: 841516 Change-Id: I83181cc2f90a26a98bab2cd3c8a8717a6fac596b Reviewed-on: https://chromium-review.googlesource.com/1176397 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#583830}
-
Sergey Ulanov authored
The function as crashing browser process after GPU process is crashed. Bug: 874533 Change-Id: I2c506b6f90642a0881aa510807cb407e1b655050 Reviewed-on: https://chromium-review.googlesource.com/1178753Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#583829}
-
kylechar authored
The VizDisplayCompositor feature enables OOP-d which changes the display compositor pipeline. WebView doesn't support OOP-D and any shared code that checks the features status risks breaking if it's enabled. Bug: 732555 Change-Id: Ibc84d53a0ca4691ba7fadd10ed362244fb2b0e7a Reviewed-on: https://chromium-review.googlesource.com/1177630Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#583828}
-
kylechar authored
Add missing code VizCompositorThreadRunner to support GPU compositing and GPU process force shutdown. Remove code in VizMainImpl and just use VizCompositorThreadRunner there. Bug: 849639 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I34ae6adec13d8be11e563f2c32de36504b6711b4 Reviewed-on: https://chromium-review.googlesource.com/1165842 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#583827}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a82d0a22067f..e5f282cb55b2 git log a82d0a22067f..e5f282cb55b2 --date=short --no-merges --format='%ad %ae %s' 2018-08-16 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@e5f282cb55b2 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4b2b2780764e2d3a49b90a00f7554638f92cf895 Reviewed-on: https://chromium-review.googlesource.com/1178562Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583826}
-
Xida Chen authored
TBR=wjmaclean@chromium.org Bug: 874976 Change-Id: I6973e2de0fb52dbfe5cec8319a02507736603243 Reviewed-on: https://chromium-review.googlesource.com/1178476Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583825}
-
Pete Williamson authored
In the field we are seeing a small percentage of exceptions while trying to schedule a task with JobScheduler. The invalid argument exception is complaining that we haven't registerd our scheduler component properly, but we believe that we have. This seems to happen on older OSs that have been more heavily modified. Since we have limited means of debugging these, we'll catch the error and return failure instead. Bug: 831911 Change-Id: I8c8c376a24744d786e87bf30a8c4ab914f13e5be Reviewed-on: https://chromium-review.googlesource.com/1171873Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#583824}
-
Ryan Sleevi authored
Presently, CertVerifier::Verify() takes a series of per-verification flags that express the ways in which certificate verification may be configured. However, these flags represent overall verifier-wide configuration, in that they are tied to user preferences or enterprise policies. These flags are plumbed through the layers by virtue of SSLConfig, but generally do not change between verifications. As part of making the verification configuration opaque to callers, move the flags from being something passed in each verifier-call to something that is implicitly handled on the CertVerifier, via the CertVerifier::Config. All verifications started will share the same configuration, while allowing callers to focus on the per-verification parameters that are unique (such as the hostname or certificate). This sets the stage for moving the CRLSet in as explicit CertVerifier configuration, rather than passed-per-call, as well as to having the socket pools more intelligently respond to these configuration changes. Originally landed in https://chromium-review.googlesource.com/c/chromium/src/+/1122709 TBR: zea@chromium.org, kinuko@chromium.org, torne@chromium.org, mfoltz@chromium.org, sergeyu@chromium.org, xunjieli@chromium.org, pmarko@chromium.org Bug: 848277, 854635 Change-Id: Ie113be88c88d86a5abbff200aa623b97bca461a3 Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1177801 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#583823}
-
Oksana Zhuravlova authored
Change-Id: I42740095792d5a1db12399950e856d927d17143b Reviewed-on: https://chromium-review.googlesource.com/1178245Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#583822}
-
Ramin Halavati authored
Cloud Print preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I601f41f611a81c2a5dccc712dba7f5e5626c923a Reviewed-on: https://chromium-review.googlesource.com/1176810 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#583821}
-
Dominik Laskowski authored
ClientControlledShellSurface does not use it. Bug: b:77972398 Test: exo_unittests Change-Id: I42a5be08d94b12a2fa2d15792d297bae236a76b1 Reviewed-on: https://chromium-review.googlesource.com/1176655Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Cr-Commit-Position: refs/heads/master@{#583820}
-
Majid Valipour authored
Update ScrollTimeline to use post-snapped scroll offsets instead of pre-snapped one. This fixes jitter when scroll-linked worklet animation is trying to position items against the scroll offset. Background: Scrolling layers are pixel snapped which means they are shifted so that they get aligned to pixel boundaries. This means that the raw scroll offset of a scrolling layer is not exactly what is display on the screen. The snapping is done by adjusting the effective transform of the associated TransformNode for this scrolling element. Previously ScrollTimeline would use raw scroll offset to compute its time. This patch introduces a new method on the ScrollTree that will use the info from TransformNode to calculate an effective scroll offset that represents the post-snapped position of the scrolling node. Bug: 585458 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I30bb052d8cfef8a32ec1a613921d7594bef3c982 Reviewed-on: https://chromium-review.googlesource.com/1153583 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#583819}
-
Ben Pastene authored
We don't have enough capacity for layout tests in 10.13, and the fall back triggering isn't working sufficiently (crbug.com/871453) The 10.12 pool w/ 8086:0a2e GPUs has plenty of spare capacity, and flashing them up to 10.13 isn't going to happen soon (crbug.com/873421). Meanwhile, pending times are getting out of hand on ios-sim and mac_chromium_rel_ng bots. So this temporarily moves layout tests fully back to 10.12 That should free up plenty of 10.13 capacity. According to my SQL'ing, the 10.13 pool ran ~8100 bot hours of tests yesterday; and layout tests on mac_chromium_rel_ng accounted for ~1000 of them. (LMK if you want my queries and I can link them.) # No-try to help unblock mac_chromium_rel_ng NOTRY=true Bug: 854874 Change-Id: Ibd708f795d1df67de74cebf3f955ff175c00c0f3 Reviewed-on: https://chromium-review.googlesource.com/1175243 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#583818}
-
Dominik Laskowski authored
ClientControlledShellSurface does not use the configure protocol. Bug: b:77972398 Test: exo_unittests Change-Id: I87f7be2e385c7184e7c717ccf5f0d41921c80e36 Reviewed-on: https://chromium-review.googlesource.com/1164552Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Cr-Commit-Position: refs/heads/master@{#583817}
-
Tarun Bansal authored
Use network quality tracker instead of network quality estimator (NQE) to obtain network quality in offline pages. Network quality tracker can provide network service when network service is enabled as well as when network service is disabled. Bug: 819244 Change-Id: I0b2bad429c1e7745759a1172fb1fbaa843dd8b8b Reviewed-on: https://chromium-review.googlesource.com/1171863Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#583816}
-
Tessa Nijssen authored
Previously, -updateTextSelection:range:offset: could receive an invalid range from WebContentsTextObserver::DidChangeTextSelection(). This invalid range would then cause a crash in -requestSuggestions. A check has been added to -updateTextSelection:range:offset: to make sure that a selection with an invalid range is not passed to -requestSuggestions. This should prevent future crashes. TextSuggestionsTouchBarControllerTest.InvalidRange tests that an invalid range does not crash the controller and is handled properly. Bug: 717553 Change-Id: I69f49cb1f1819e1d528837767dfb894d8652e84d Reviewed-on: https://chromium-review.googlesource.com/1178467Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Commit-Queue: Tessa Nijssen <tnijssen@google.com> Cr-Commit-Position: refs/heads/master@{#583815}
-
Stephan Stross authored
This CL adds a README.md file to the tools/fuchsia/comparative_tester/ directory, explaining how all the scripts interact with each other, and how they should be used. Change-Id: Ib9f668fb09f5fa1ba50d6da396251b2c8113d4a5 Reviewed-on: https://chromium-review.googlesource.com/1176366 Commit-Queue: Stephan Stross <stephanstross@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#583814}
-
Lei Zhang authored
Split all IO thread code into a separate helper class. Now there is no refcounting, so ownership is clearer. Now only the helper class has a WeakPtrFactory, so WeakPtrs are only used on the IO thread. BUG=873529 Change-Id: I326aa6f69839c193507df4c63250aa1560bbd0ef Reviewed-on: https://chromium-review.googlesource.com/1177444 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#583813}
-
Katie D authored
Changes a "if" to a "DCHECK". Change-Id: I17cbe0efee059bbc76ca85cacd395f57b1ac41a2 Reviewed-on: https://chromium-review.googlesource.com/1178224Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#583812}
-
Robbie McElrath authored
This migrates all NetworkChangeNotifier usages in components/data_reduction_proxy/core/browser to the new NetworkConnectionTracker, which will work with the network service enabled. Bug: 868005 Change-Id: Ia81ebef073b72f9baa3e97550451ad92c4aac2aa Reviewed-on: https://chromium-review.googlesource.com/1157345 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#583811}
-
Eric Karl authored
Bug: 874703 Change-Id: I63bc492d44f230ced991d6525ae43ede1e6a8359 Reviewed-on: https://chromium-review.googlesource.com/1176826Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#583810}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5f4cd74d2693..f956badf3dd2 git log 5f4cd74d2693..f956badf3dd2 --date=short --no-merges --format='%ad %ae %s' 2018-08-16 hnakashima@chromium.org Add a way to save a barcode generated bitmap to a .png. 2018-08-16 tsepez@chromium.org Remove more optional args in core/ 2018-08-16 hnakashima@chromium.org Optimize rendering of two dimensional barcodes: deduplicate regions. Created with: gclient setdep -r src/third_party/pdfium@f956badf3dd2 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:872907 TBR=dsinclair@chromium.org Change-Id: If58ebe0565280b1361422a9ced2f70af30a93c3b Reviewed-on: https://chromium-review.googlesource.com/1178247Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583809}
-
David Davidović authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1145066, which adds an STL-compatible interface to EnumSet and EnumSet::Iterator, replace all uses of the previous iteration interface with a range-based for loop. This allows eventual removal of the old interface altogether. Also, replace existing usage of |arraysize| with |base::Size|, since the former was deprecated. This is CL part 1 of 2. Bug: 860435 Change-Id: Ida43a641fd24f567be162ae5e18665e2ea7e39f6 Reviewed-on: https://chromium-review.googlesource.com/1146819 Commit-Queue: David Davidović <davidovic@google.com> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#583808}
-
Xianzhu Wang authored
The tests failed because of different graphics layer structures about ChildContainmentLayer and AncestorClippingLayer which are intentionally not created by BGPT, so rebaseline them. Bug: 854196 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I96223cc733ff0a1e792d4660e8e667a7d9e17460 Reviewed-on: https://chromium-review.googlesource.com/1178628Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#583807}
-
Siddhartha authored
R=twellington@chromium.org Change-Id: I074521c0835fe6d71cfa19fef359cd2f6bd42db9 Reviewed-on: https://chromium-review.googlesource.com/1178561Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#583806}
-
Chase Phillips authored
Bug: None Change-Id: I1e86c4a52bb3f0eca8c896b5e23664ab1ca1f505 Reviewed-on: https://chromium-review.googlesource.com/1178629 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#583805}
-