GitLab

BUG=125488
TEST=disable JS, go to https://no.such.host/. Should show a regular error page
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10412053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138464 0039d316-1c4b-4281-b951-d872f2087c98

1) Return before cause a crash.
2) Add `volatile` so that the compiler does not optimize us out.

FYI, The test initially added here:
https://gerrit.chromium.org/gerrit/#change,23212

BUG=chromium:126774
TEST=./run_remote_tests.sh client/site_tests/logging_AsanCrash

Review URL: https://chromiumcodereview.appspot.com/10417031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138463 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138462 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10411091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138461 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128328,127396
TEST=Starting chrome with --try-chrome-again=10001 doesn't crash in policy code anymore


Review URL: https://chromiumcodereview.appspot.com/10388211

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138460 0039d316-1c4b-4281-b951-d872f2087c98

This is failing conistently on WebKit Win (deps)

BUG=129331

Review URL: https://chromiumcodereview.appspot.com/10423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138459 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a problem when showing the custom shell window frame where 1px of
the native windows frame peeks out below the custom frame.

BUG=129293
R=ben@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10411087

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138456 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138455 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10407119

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138454 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138453 0039d316-1c4b-4281-b951-d872f2087c98

This allows ash to inject Dispatcher for root window without
a dispatcher being dependent of aura.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10407081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138451 0039d316-1c4b-4281-b951-d872f2087c98

Install AshFocusManagerFactory before creating launcher, tray, wall paper and their views::FocusManagers.

Otherwise, Ash shortcut keys cannot be used when either launcher or status area is focused.

BUG=120953,123856
TEST=crosbug.com/120953#c17
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10388229

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138450 0039d316-1c4b-4281-b951-d872f2087c98

The new name would be better since we support remapping the right control key. Do the same for chromeos::input_method::kLeftAlt.

This cleanup is for issue 115112.

BUG=115112
TEST=none
TBR=csilv@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10416028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138449 0039d316-1c4b-4281-b951-d872f2087c98

This doesn't need to be in Browser, and won't always open a Browser
window.

BUG=None
TEST=Existing tests

Review URL: https://chromiumcodereview.appspot.com/10409023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138448 0039d316-1c4b-4281-b951-d872f2087c98

This CL depends on https://chromiumcodereview.appspot.com/10399046

BUG=128295
TEST=try

Review URL: https://chromiumcodereview.appspot.com/10416027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138447 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10332289

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138446 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122017
TEST=

Review URL: https://chromiumcodereview.appspot.com/10391183

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138445 0039d316-1c4b-4281-b951-d872f2087c98

Now it may always refer operation_context->file_system_context() as it tries to invalidate the usage cache whenever it finds inconsistency.

BUG=129303
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10407115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138444 0039d316-1c4b-4281-b951-d872f2087c98

The only remaining use of content::URLFetcher is content::URLFetcher::Create.

Make content::URLFetcher not inherit from net::URLFetcher.

Also make code that directly create URLFetcherImpl instead call content::URLFetcher::Create.

BUG=118220
TEST=
TBR=mnissler@chromium.org,sky@chromium.org,mal@chromium.org,sail@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10412050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138443 0039d316-1c4b-4281-b951-d872f2087c98

Suppress stdout of 'expand' command unless there's an error.

i.e.

"""
[2294->7960/10271 ~17] ACTION content_common: extract_xinput
Microsoft (R) File Expansion Utility  Version 6.1.7600.16385
Copyright (c) Microsoft Corporation. All rights reserved.

Adding ../out/Debug\tmpamaser\xinput1_3.dll to Extraction Queue

Expanding Files ....

Expanding Files Complete ...
[2164->8090/10271 ~17] ACTION content_gpu: extract_d3dx9
Microsoft (R) File Expansion Utility  Version 6.1.7600.16385
Copyright (c) Microsoft Corporation. All rights reserved.

Adding ../out/Debug\tmpcxuoz9\d3dx9_43.dll to Extraction Queue

Expanding Files ....

Expanding Files Complete ...
[2163->8091/10271 ~17] ACTION content_gpu: extract_d3dcompiler
Microsoft (R) File Expansion Utility  Version 6.1.7600.16385
Copyright (c) Microsoft Corporation. All rights reserved.

Adding ../out/Debug\tmploys57\D3DCompiler_43.dll to Extraction Queue

Expanding Files ....

Expanding Files Complete ...
"""

R=apatrick@chromium.org
BUG=126483

Review URL: https://chromiumcodereview.appspot.com/10409086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138442 0039d316-1c4b-4281-b951-d872f2087c98

With this change, we can safely return error for invalid object path and service name.
It still crashes on invalid method name and interface name if we use MethodCall::MethodCall for setting those parameters.

BUG=128967
TEST=dbus_unittests

Review URL: https://chromiumcodereview.appspot.com/10409065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138441 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127233
TEST=Build mini_installer on system that doesn't have VS installed, test that msvc*dll get copied to build dir.

Review URL: https://chromiumcodereview.appspot.com/10407053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138440 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138439 0039d316-1c4b-4281-b951-d872f2087c98

(Broke chromium os build.)

This pulls in the following Native Client changes:

r8656: (mseaborn) sel_main_chrome: Add an interface for setting the /dev/urandom FD
r8657: (halyavin) Test for debug stub with real gdb.
r8658: (halyavin) Gcl commited file not in CL. Revert for this.
r8659: (halyavin) Skip qualification test when gdb tests are run with asan.
r8660: (mseaborn) Scons: Move some glibc-test-disabling logic out of SConstruct
r8661: (mseaborn) Remove nacl_file.cc and the src/untrusted/ppapi directory
r8662: (mseaborn) libpthread: Remove a comment which I missed in my earlier change
r8663: (bradchen) Update build/untrusted.gyp for glibc builds
r8664: (mseaborn) Enable running nacl-glibc tests under the IRT
r8665: (bbudge) Update Chrome revision in NaCl DEPS.
r8667: (jvoung) Bump llvm rev for cleanup (removing -arm_static_tls flag).
r8668: (bsy) Change lock_impl_win.cc to use CRITICAL_SECTION objects.
r8669: (kschimpf) Generalize the concept of two instructions executing atomically.
r8670: (mseaborn) Thread suspension: Implement for Linux
r8671: (mseaborn) Build untrusted code with "-g" to get debugging info
r8672: (khim) Fix for bug #2796
r8674: (jvoung) Switch perf expectations size test from checking
r8675: (scottmg) avoid noise from assembler wrapper when preprocessing
r8676: (mseaborn) IRT threading: Add a test for TLS inside the IRT

BUG=none
TEST=nacl_integration

Review URL: https://chromiumcodereview.appspot.com/10422004

TBR=bradchen@google.com
Review URL: https://chromiumcodereview.appspot.com/10399139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138438 0039d316-1c4b-4281-b951-d872f2087c98

TBR=eroman
BUG=126016
TEST=chrome_frame_tests --gtest_filter=TestServerTest.TestServer
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10417045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138436 0039d316-1c4b-4281-b951-d872f2087c98

This information will be read by breakpad during minidump preparation to
upload any java stack trace.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10412045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138435 0039d316-1c4b-4281-b951-d872f2087c98

Get rid of the RenderViewType concept in content, since it was only used by Chrome. Store the enum value in the WebContents' property bag.

BUG=98716
Review URL: https://chromiumcodereview.appspot.com/10409088

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138434 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138433 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r8656: (mseaborn) sel_main_chrome: Add an interface for setting the /dev/urandom FD
r8657: (halyavin) Test for debug stub with real gdb.
r8658: (halyavin) Gcl commited file not in CL. Revert for this.
r8659: (halyavin) Skip qualification test when gdb tests are run with asan.
r8660: (mseaborn) Scons: Move some glibc-test-disabling logic out of SConstruct
r8661: (mseaborn) Remove nacl_file.cc and the src/untrusted/ppapi directory
r8662: (mseaborn) libpthread: Remove a comment which I missed in my earlier change
r8663: (bradchen) Update build/untrusted.gyp for glibc builds
r8664: (mseaborn) Enable running nacl-glibc tests under the IRT
r8665: (bbudge) Update Chrome revision in NaCl DEPS.
r8667: (jvoung) Bump llvm rev for cleanup (removing -arm_static_tls flag).
r8668: (bsy) Change lock_impl_win.cc to use CRITICAL_SECTION objects.
r8669: (kschimpf) Generalize the concept of two instructions executing atomically.
r8670: (mseaborn) Thread suspension: Implement for Linux
r8671: (mseaborn) Build untrusted code with "-g" to get debugging info
r8672: (khim) Fix for bug #2796
r8674: (jvoung) Switch perf expectations size test from checking
r8675: (scottmg) avoid noise from assembler wrapper when preprocessing
r8676: (mseaborn) IRT threading: Add a test for TLS inside the IRT

BUG=none
TEST=nacl_integration

Review URL: https://chromiumcodereview.appspot.com/10422004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138432 0039d316-1c4b-4281-b951-d872f2087c98

Split the previous implementation into two pieces:
XmppPushClient and NonBlockingPushClient.

Add FakePushClient and FakePushClientObserver.

Remove use of ThreadSafeObserverList.

Add PushClient::CreateDefault() function, which creates a
NonBlockingPushClient for an XmppPushClient.

Dep-inject PushClient into P2PNotifier.

Add some helper functions to notification_defines.{h,cc}.

BUG=76764
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138216

Review URL: https://chromiumcodereview.appspot.com/10413014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138431 0039d316-1c4b-4281-b951-d872f2087c98

This fixes breakage of component_build on ChromeOS

BUG=129131
TEST=emerge and run chrome on ChromeOS

Review URL: https://chromiumcodereview.appspot.com/10399120

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138430 0039d316-1c4b-4281-b951-d872f2087c98

TBR=fsamuel@chromium.org
TEST=compiles

Review URL: https://chromiumcodereview.appspot.com/10413068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138429 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10408078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138426 0039d316-1c4b-4281-b951-d872f2087c98

This fixes bot redness caused by 10411086

Bug=None
Test=Bots go green

Review URL: https://chromiumcodereview.appspot.com/10421030

TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10408083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138423 0039d316-1c4b-4281-b951-d872f2087c98

The test relies on a WebKit layout test. The test code was updated in
WebKit r117702 but basics-shared-workers-expected.txt was not updated as
that test is not run in WebKit. Expectation updated in WebKit r117800.

BUG=128959
TEST=browser_tests --gtest_filter='IndexedDBLayoutTest.BasicTests'


Review URL: https://chromiumcodereview.appspot.com/10417017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138421 0039d316-1c4b-4281-b951-d872f2087c98

Broken by http://codereview.chromium.org/9968097/

BUG=none
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/10414068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138420 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes the places where we will be sending DIP to the GPU process but should be sending pixels instead to the GPU process once https://bugs.webkit.org/show_bug.cgi?id=86051 lands.
This patch reverts:
http://codereview.chromium.org/127553/
http://codereview.chromium.org/10332077/

Bug=127455, 114677
Test=Manual
SchedulePaintInRect is called with parameters in DIP

TBR=piman@chromium.org,sky@chromium.org,jamesr@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10411086

TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10383297

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138419 0039d316-1c4b-4281-b951-d872f2087c98

This fixes bot redness caused by 10411086

Bug=None
Test=Bots go green

Review URL: https://chromiumcodereview.appspot.com/10421030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138418 0039d316-1c4b-4281-b951-d872f2087c98

Major Classes:

BrowserPluginChannelManager: Manages GuestToEmbedderChannels. It essentially wraps a map that is keyed on channel names.

GuestToEmbedderChannel: Is a Dispatcher. Receives/Sends Ppapi messages. Keeps track of all RenderViews that have an associated PP_Instance in a map (RenderViews that are guests). brettw@ might want to have a look here?

BrowserPluginRegistry: Wrapper around map that keeps track of Browser Plugin PluginModules keyed on the guest process id. This is similar to the PepperPluginRegistry but has a different key type.

BrowserPluginVarSerializationRules: Temporary do nothing class as suggested by brettw@

BrowserPlugin: Towards becoming a wrapper around a WebPluginContainerImpl that swaps out WebPluginImpl/WebViewPlugin on navigation. We get a blank WebViewPlugin (is this a best thing to do to get a blank placeholder?) if we have an empty src attribute or while we're navigating for the first time. Otherwise, on cross-process navigations, we substitute one WebPluginImpl for another WebPluginImpl. TODO: BrowserPlugin should track the lifetime of WebPluginContainerImpl, but right now it lives forever which is bad. Will fix this in a subsequent patch. This requires some WebKit changes first.

BUG=117897
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/9968097

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138416 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes the places where we will be sending DIP to the GPU process but should be sending pixels instead to the GPU process once https://bugs.webkit.org/show_bug.cgi?id=86051 lands.
This patch reverts:
http://codereview.chromium.org/127553/
http://codereview.chromium.org/10332077/

Bug=127455, 114677
Test=Manual
SchedulePaintInRect is called with parameters in DIP

TBR=piman@chromium.org,sky@chromium.org,jamesr@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10411086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138415 0039d316-1c4b-4281-b951-d872f2087c98