- 27 May, 2020 40 commits
-
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=torne@chromium.org Bug: 1026641 Change-Id: I6b36b810dac8ee0af5b4c80f46b24d5505bacd18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217202 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#772231}
-
Reilly Grant authored
An upcoming lint check will flag calls to toLowerCase() that do not specify a locale. Since these strings are being compared to those entered by the user the default locale is used. Bug: 1085466 Change-Id: I4cbc60d99b02d34f741947c2ec8bd719b8843253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216684 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#772230}
-
Alice Wang authored
This CL fixes the ConfirmSyncDataStateMachine crash related to the DialogFragment update to androidx. Bug: 1083833 Change-Id: I7f78f491f1b8e66668b1f5552c1483ac68c48624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216070 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#772229}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590522742-b76e1162c3da480ee6f6075020dc3e74b538d7b3.profdata to chrome-win64-master-1590580498-39ab72543da7a96a4f695b1a54bce8558b65f184.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: If31a9601813b30ec290885dcad03d6b68c9a26e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214057Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772228}
-
Liviu Tinta authored
The tests in pointer_lock_browsertest.cc were flaky for 3 reasons: - requestPointerLock being asynchronous - mouse events being asynchronous - native mouse events interfering with tests during execution All the above were addressed in prior CLs. Bug: 766450 Change-Id: Icc977b9c8bbfaba8c322a82ff6388886aee83941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212997Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#772227}
-
Bruce Long authored
Some languages (Chinese, Japanese, ...) have no Windows or Hunspell dictionary support, but a user will often have English spellchecking enabled. In this case, when Windows spellchecking is enabled, all editable content composed in the unsupported spellcheck language will be red squiggled as misspelled, since the words aren't recognized by the Windows spellchecker. This is a pretty ugly experience and differs from what was seen when there was only Hunspell. The fix is to check if a word that is flagged as misspelled by the Windows spellchecker is written in a script associated with any of the enabled spellchecker dictionaries (either Windows or Hunspell). If not, ignore the word as a misspelling. Bug: 1076677 Change-Id: I072a783d84a981e8f5f0316e8957d7ab93979ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210796 Commit-Queue: Bruce Long <brlong@microsoft.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#772226}
-
Akihiro Ota authored
Bug: N/A Change-Id: I41626e917bf140bc6f13cd47910b8c452af70fd2 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216370Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#772225}
-
Anastasiia Nikolaienko authored
Move account_manager_* and account_migration_* files to ui/webui/chromeos/account_manager. Bug: 1083147 Change-Id: I2f61237cf4b781a8ddd0ed8837e690e7f59adac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207226 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#772224}
-
Charlie Hu authored
FeaturePolicyFeature::kStorageAccessAPI is present in feature_policy_feature.mojom and feature_policy.cc, but is missing in feature_policy_features.json5. This CL sync storage-access-api to feature_policy_features.json5. Change-Id: Iad1a20a59fe8c08fa39e93fb661d89bfed7987ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210735Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#772223}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f9826008618a..4a81e3dba0fd 2020-05-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 79dcb2a5abbd to 9e718f962f87 (1 revision) 2020-05-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 9cb2571a184c to d3d89bb90cbd (2 revisions) 2020-05-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 3e390a159761 to 006586926ade (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I49ecb58d2dab2eac998c4cf60d9909b9e870dedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214050Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/72edaabd..d0a8b04f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3a5dc8e8f03a25c5d9ad2bafb78ad45534624678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217869Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772221}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590566295-b6fe751361b0ee5373100e3cddc0b82fdbd8c8ba.profdata to chrome-win32-master-1590580498-31d289ff4006e295949604b3b99c516a32499368.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic826470e765ff0a4a5732bf8d3dc1b867147e405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214058Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2d4ee009038b..b7228caa9292 2020-05-27 changhaohan@chromium.org e2e test for media query inspector; add canDock option in ReloadDevTools 2020-05-27 pfaffe@chromium.org Remove protobuf dependency in the symbol server 2020-05-27 janscheffler@chromium.org Enable TypeScript for DOMDispatcher 2020-05-27 alexrudenko@chromium.org Position object popover after live location is updated 2020-05-27 kimanh@chromium.org Remove 'this' from local scope for wasm debugging If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1043034,chromium:1069467,chromium:1079233,chromium:1082696,chromium:1086159 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6e12ce181b8685034b3a96ffa6a879f76cdbe490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214054Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1ba864348bde..1303a1a15c88 2020-05-27 bryct@amazon.com Fix CanvasKit generated documentation to work with emscripten 1.39.16. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I153a93c01fd22a8e786fa27dac8af2b9ac21dae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214053Reviewed-by:
-
Nicolás Peña Moreno authored
UKM collection review: https://docs.google.com/document/d/1ZaqRqI2c6LiRTrT12f8RLhuzpT-NQ5mkSLoFN5RzZ7c/edit# Bug: 1086681 Change-Id: I2a54e4e54694377cebcc48b6c538118b803b5680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216677Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#772217}
-
Maksim Ivanov authored
Change-Id: I0495931f6b8826f2668b08a95ca06449d0df8cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215860 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#772216}
-
Stephan Hartmann authored
GCC complains that explicit specialization in non-namespace scope is happening for TraceImpl. Move TraceImpl implementations into different nested classes and select implementation using std::conditional. Bug: 819294 Change-Id: I8feea5f2aa6e1f87daad61f496d6b53b1bbc49ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217887Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#772215}
-
Sylvain Defresne authored
Recent changes to this value demonstrated the value of having all the bots provide an explicit value (avoid breaking them when the default is changed). Bug: 1086389 Change-Id: I89902abe5d0e2b69931ce7396efca0c8fc884265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214549Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#772214}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e309651f3330..014197b581a3 2020-05-27 danilchap@webrtc.org In modules/ replace mock macros with unified MOCK_METHOD macro If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6adf7f51fade73d1659a3a513c0f4ff4813c9f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214052Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I89dfd3a21537a537c8953e5953760ab10c204553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215187Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772212}
-
Jan Wilken Dörrie authored
Following the rename of `autofill::PasswordForm::origin` to `url` this change renames the `origin` fields of PasswordStore::FormDigest and autofill::PasswordFormFillingData to `url` as well. Furthermore, this change also renames PasswordFormManagerForUI::GetOrigin() to PasswordFormManagerForUI::GetURL(). Bug: 1081389 Change-Id: I907f85711f773518bbacfbb1f142ee1c344da29f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207113 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#772211}
-
Roman Aleksandrov authored
Bug: 1082234 Change-Id: I6c5c8c7ce492f99fb1c27ff31179684a8e2bf213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199147 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#772210}
-
Richard Knoll authored
This class manages the lifetime and profile affinity of the sandbox process that runs Nearby Connections. Only one instance of the process will run at a time and it will be associated with one profile only. A profile can be set as the active profile (usually via an explicit user action) after which it gets access to the mojo interfaces running in the sandboxed process. Bug: 1084576 Change-Id: I50c8c61e1b7b85a078f4fdea96e0ecda1ac57123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196486Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#772209}
-
Leonard Grey authored
This reverts commit 8cc706be. Reason for revert: (Sheriff) "checkdeps" failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/90719 Looks like a few files still include these Original change's description: > Remove 'ash/keyboard/ui/public' from DEPS files. > > It no longer exists. > > Change-Id: I4f6f08d6b2ae3c3bdafccf71b03f91e6d68bc47b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215547 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772190} TBR=thakis@chromium.org,yhanada@chromium.org Change-Id: I47b2aef7e5cc21dcac92311aca4a377968103780 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218248Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#772208}
-
Wez authored
Reporting an exit status on graceful termination allows the ApplicationContext implementer to distinguish intentional component terminations from crashes. Bug: fuchsia:51028, b/148594115 Change-Id: I8f36799e16c729cb15e7e267da4375e35ff91aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209140 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#772207}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590566295-92309f25158961ce5d340e659f77e189eb24879f.profdata to chrome-mac-master-1590580498-ea3616ac9902235828b373566b290618f1842868.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I2565f5b61425c932eb3ebf57219a25545e80521d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214055Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5cca9894. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ie7719aa851e840c2f58821b03c1895d28bc745b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217868Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772205}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6f8823b42515..fffa2ecdc7fc 2020-05-27 skyostil@google.com sdk: Add example code If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iae6b0872b525d74aebc566af4b5d66bd0a617aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214051Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8a08a7ccdeec..0edc2a3f0892 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jdoerrie@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1047629 Tbr: jdoerrie@google.com Change-Id: I2c9c6e03a19e38617199c77f56944ea748501d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214048Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772203}
-
Jan Wilken Dörrie authored
This change renames autofill::PasswordForm::origin to url, which is a more fitting name, considering that origin does not refer to a web origin, but rather the URL the form corresponds to. Bug: 1081389 Change-Id: I01c94cfeb0894a3a5676f25847c3ef8dc587b706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202804 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Aya ElAttar authored
As this policy was needed for the transition from public session to managed-guest session and since M73 public sessions are no longer used, So this policy should be deprecated. Bug: 1086429 Change-Id: Ic8c047c54b5e6b2c20949cf83c282ccea0b1dc45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215811 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Anastasiia Nikolaienko authored
Send AccountManager.EduCoexistence.FlowResult to record the last completed step in the flow. The value is updated when active screen is changed in the flow, and stored in InlineLoginHandlerDialogChromeOS. When dialog is getting closed, we send UMA with last set flow result. It allows us to track on which screens users close the dialog. See go/cros-beaker-metrics. Bug: 1082791 Change-Id: I422ea8c751f569b716f79dd3fe85a34c054c7df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208982 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
-
Dominic Farolino authored
This CL adds an async script scheduling test, mainly to document the current scheduling behavior of async scripts with respect to other scripts. It indicates that currently, async scripts are allowed to load before: - First Paint - The Document is Finished Parsing A follow-up CL (https://crrev.com/c/2213343) implements the delaying of async script execution until: - Finished Parsing - First Paint or Finished Parsing ... and asserts that the implementation affects the output of this test accordingly. The test has to be hosted in wpt_internal/, because we need to use WPT server features such as the trickle pipe, that are not available for use in regular web_tests. Bug: 1086227 Change-Id: I2562df28efbba2c8ab5c21fe55d82a2e44676f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213354Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#772199}
-
Olesia Marukhno authored
Added permission chip to location bar. The permission chip is shown on the permission request. The permission bubble is anchored by the chip instead of the location icon. Bug: 1019129 Change-Id: I0477ed5d1244b99ca399b0bbd280b84e950d4e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193773 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#772198}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a5e07cc3db44..e309651f3330 2020-05-27 jonaso@webrtc.org Don't SetNeedsIceRestartFlag if widening candidate filter when surface_ice_candidates_on_ice_transport_type_changed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iff0b06e08b3a1c9ef6a234cbf1411ba3366fe5e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214047Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/09f5f6d7..72edaabd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifbb2904f1fd6a6522486089a38963e8ce46e47a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217867Reviewed-by:
-
Antonio Gomes authored
BUG=919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ia1d237955345a66881d75627f18b734d243b69c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216593Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#772195}
-
Antonio Gomes authored
... instead of its Blink API wrapper WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: I402e0b38edc5d52bda41eac592b3fd9355db850f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216046Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#772194}
-
Sergey Poromov authored
As the class only accesses local state, it could directly get it from g_browser_process and be a static helper class. Bug: 383695 Test: Run tryjobs Change-Id: I69e7e3e63b00e507b2b3ef36d3ab4d4678ae5f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215322Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#772193}
-
Aya ElAttar authored
Changed UpdatePublicAccountDisplayName to check for kUserDisplayName in local state before trying to get the display name from the policy broker. Bug: 1079220 Change-Id: Ibbc81e5c8449f6304e8142083a3493380b6f42b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210500 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
-
