- 28 Nov, 2019 40 commits
-
-
Jay Harris authored
Previously, the names of the methods in web_app_file_handler_registration implied it was the sole place where file handler registrations occurred. This was confusing, as Chrome OS directly interfaces with the registry of installed apps, so these methods were no-ops while it seemed like they should have been doing something. Functionally, this also reverts https://crrev.com/c/1935296, as it doesn't align with new aim of the interface. Bug: 1028448 Change-Id: I8630f31ee7829165ffaef39374ea286cc85caaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941528Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#720079}
-
Noel Gordon authored
CL:1924341 limited the horizontal scroll of the directorytree to 0, to resolve issue 1025581, and needs a test of this behavior. Create a nested tree of test folders. Expand the directory tree to the last folder, verify the navigation, and that the directory tree is not horizontally scrolled (directorytree.scrollLeft should be 0). The test passes with CL:1924341 and fails before that CL (good). Tbr: anyone Test: browser_tests --gtest_filter="*TreeExpandHorizontal*" Bug: 1029019 Change-Id: I609b06ddfc3d18cf24cf5b5c3e4e118c06989c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942667Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#720078}
-
Jonathan Backer authored
This is similar to the bypass in RealGLApi::glDrawArraysFn. It is necessary to avoid timeouts in content_browsertests running under TSAN. Bug: 967716 Change-Id: Ifd35f188b878fb15b8eb909574e31de370e12045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942772Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#720077}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0279cf266561..278d2d006e50 Created with: gclient setdep -r src-internal@278d2d006e50 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I9c47dd27949e3db754585b3b4c7f1ee18fb66634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943307Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720076}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d6ba572f..9e80f699 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7c8585ad6c7a89e677fa49df65500c67ff7bfad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942992Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720075}
-
Andrew Grieve authored
Adds GN arg: java_warnings_as_errors = !is_java_debug And sets the arg on our trybot that runs errorprone. TBR=jbudorick # Expedite fixing local dev flow. Bug: 1029357 Change-Id: I817931328dc56ca67d7047d711fa60ba38e21fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943014 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#720074}
-
Peter Wen authored
Allow //src/build/android/OWNERS to own all gn-related files under //src/chrome/android/. Bug: None Change-Id: Icbb98b2cef2869024045a736c2e5f1b21820b725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942876 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#720073}
-
Jasper Chapman-Black authored
Bug: 978307 Change-Id: Ic2951d62e1d6a148acbee0bf9bde3c517ecae602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942943 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
This CL converts all uses of EmbeddedWorkerInstanceClient interface as below, - Convert EmbeddedWorkerInstanceClientRequest to PendingReceiver<EmbeddedWorkerInstanceClient> Bug: 955171 Change-Id: Ib40dcca2e9e3caab54e1d2c22b83d17d43102ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932142Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#720071}
-
Ilya Nikolaevskiy authored
Bug: 988705,988702,988695,988683,988672,988658,988653,988647,988628,988627 Change-Id: I6ef78ae7b5601f28223c91dbebfbb6cdc6062998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940182 Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#720070}
-
Greg Thompson authored
BUG=None R=gab@chromium.org, robertshield@chromium.org Change-Id: I2d5f46aa0cc04f99c59ddb3d543de6313c2183f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939287 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Robert Shield <robertshield@chromium.org> Reviewed-by:
Robert Shield <robertshield@chromium.org> Cr-Commit-Position: refs/heads/master@{#720069}
-
Kevin Ellis authored
The patch removes the last of the uses of PlayStateUpdate scope. The dead code will be removed in a followup patch. Note that a change was also required to PauseForTesting. The reason for this change is that PauseForTesting did not modify internal_play_state_. Even though the hold time was being explicitly set, the internal play state could still indicate that the animation was idle. Now that the correct play state is being used, PauseForTesting can restart a canceled animation, which is not the intended behavior. Next steps: * Remove dead code including PlayStateUpdateScope. * Remove legacy flags * Align DocumentTimeline::ServiceAnimations with spec (issue 10293484) Bug: 960944 Change-Id: Ia1472f4e769e3a7630fbc54ba2f735a4feafb91a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936528 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#720068}
-
danakj authored
TBR=jbroman@chromium.org Bug: 1007760 Change-Id: I75898a2a440f85cfe397e88be4d03e9c2db58a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943108Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#720067}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/389749ae554d..72e6f396eec5 git log 389749ae554d..72e6f396eec5 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 bclayton@google.com Rename SpirvShader_dbg.cpp -> SpirvShaderEnumNames.cpp 2019-11-28 bclayton@google.com SpirvShader: Remove now unused includes 2019-11-28 bclayton@google.com SpirvShader: Move arithmetic ops to new cpp file 2019-11-28 bclayton@google.com SpirvShader: Move image handling to new cpp file 2019-11-28 bclayton@google.com SpirvShader: Move spec ops to new cpp file 2019-11-28 bclayton@google.com SpirvShader: Move group ops to new cpp file 2019-11-28 bclayton@google.com SpirvShader: Move memory ops to new cpp file 2019-11-28 bclayton@google.com SpirvShader: Move control flow handling to new cpp file 2019-11-28 bclayton@google.com SpirvShader: Move GLSLstd450 handling to new cpp file 2019-11-28 bclayton@google.com Pipeline: Move utility functions to ShaderCore Created with: gclient setdep -r src/third_party/swiftshader@72e6f396eec5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:b/145351270,chromium:b/145336353,chromium:b/145336353,chromium:b/145336353,chromium:b/145336353,chromium:b/145336353,chromium:b/145336353,chromium:b/145336353,chromium:b/145336353,chromium:b/145336353 Tbr: swiftshader-team+autoroll@google.com Change-Id: Ib9e9135c8235f46414c4c665adb7460ac50c0b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942493Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720066}
-
Greg Thompson authored
BUG=546640 R=droger@chromium.org Change-Id: I6edc0f43ef922f70b060292af766d197769089c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942328 Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#720065}
-
Greg Thompson authored
ProtoDatabaseImplTest tests must allow posted tasks to run after closing DBs so that all files can be closed before temp dirs are cleaned up. SharedProtoDatabaseTest must keep its ScopedTempDir alive until after the TaskEnvironment is destroyed. BUG=546640 TBR=nyquist@chromium.org Change-Id: I9b07ddc31f691eb875c08eb05a1779a4614c7ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940111 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#720064}
-
Greg Thompson authored
BUG=546640 R=mark@chromium.org Change-Id: I6cb8db349fb05f2ebe7c07f86b6f127441ea91dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942428 Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#720063}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3188d6f8a991..0279cf266561 Created with: gclient setdep -r src-internal@0279cf266561 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I1eb83739ae80fc472979aea7738e6bb89c72f332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942720Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0ee91fc0a1c8..77f6db7a0b78 git log 0ee91fc0a1c8..77f6db7a0b78 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 rharrison@chromium.org Fix BUILD.gn issues for Android & Fuschia 2019-11-28 yunchao.he@intel.com Add memory synchronization tests - multiple write then multiple read 2019-11-28 rharrison@chromium.org Add runtime toggle for using SPVC 2019-11-28 rharrison@chromium.org Use spvc's rules for spirv-cross Created with: gclient setdep -r src/third_party/dawn@77f6db7a0b78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Id4809ac096f67010f0742f4b50e233cf63d5bf7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942721Reviewed-by:
-
Morten Stenshorne authored
TBR=jfernandez@igalia.com,obrufau@igalia.com,rego@igalia.com Bug: 921722, 941987, 1027384, 1005519, 1018439 Change-Id: I2de7688a312cecb58b4976bfb5b742639234bd8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943168Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#720060}
-
Jasper Chapman-Black authored
Change-Id: I5eb7006446ee403a9efe60227dba43399a135300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941187 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
-
Christopher Grant authored
This broken line break snuck in while adjusting other wrapping. TBR=agrieve@chromium.org Bug: None Change-Id: I2fbcf7c099cc798a91e1022c030c3fe03fd86b51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943109Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#720058}
-
Eric Willigers authored
We add a new metric Webapp.Install.DisplayMode2 With desktop PWAs, the existing metric Webapp.Install.DisplayMode was recording installed PWAs as being 'standalone', regardless of the display value in the manifest. Bug: 1028798 Change-Id: I630c78445ae27629a86279403299c286e8e41728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939127Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#720057}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6ebed5428e4e..82219d287b57 git log 6ebed5428e4e..82219d287b57 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 syoussefi@chromium.org Vulkan: fix alpha values in convert vertex shader 2019-11-28 jonahr@google.com Vulkan support for MacOS (using SwiftShader) 2019-11-28 cwallez@chromium.org Suppress SimpleStateChange failure on Metal NVIDIA Created with: gclient setdep -r src/third_party/angle@82219d287b57 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1015454 Tbr: cwallez@google.com Change-Id: Ia0862f2e031187a99644f00ac06db5326efac29f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942874Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/11c25d274307..2c594009d354 git log 11c25d274307..2c594009d354 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 tneda@google.com Merge "Refactoring - changing TODO labels" 2019-11-28 treehugger-gerrit@google.com Merge "trace_processor: Clear sort queues on ForceExtract" 2019-11-28 tneda@google.com Merge "Expanding details panel to full height when selection is heap profile" 2019-11-28 ilkos@google.com Merge "trace_processor: fix incorrect DCHECK and loop condition" Created with: gclient setdep -r src/third_party/perfetto@2c594009d354 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ice15e416dda5cf8c055d07850e54208159cc224b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942719Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c742e26b..d6ba572f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1011e4429265ec82cdb649654da8a4e2f7a11ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942990Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/30f0559dd278..f205775e90f3 git log 30f0559dd278..f205775e90f3 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 9856269+sarahM0@users.noreply.github.com spvc: add --amb flag to glslangValidator in spvc test script (#915) Created with: gclient setdep -r src/third_party/shaderc/src@f205775e90f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I92cd70543b0a868fbfdcb6a5c68f28c3a2708735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942718Reviewed-by:
-
Joe Mason authored
R=proberge Change-Id: Ib426b5a99d3ad01c127a05fdafdfe7dba9bb432b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942813Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#720052}
-
Felicia Lim authored
Causes a warning with -Wnull-pointer-arithmetic and the code wasn't doing anything anyway (the ctl call ignores NULLs) Cherry-picked from https://git.xiph.org/?p=opus.git;a=commitdiff;h=693098f Bug: 1027106 Change-Id: Ica3e6de4820f9adcedd19034e07f7cdf23331ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935369Reviewed-by:
Felicia Lim <flim@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Auto-Submit: Felicia Lim <flim@chromium.org> Commit-Queue: Felicia Lim <flim@chromium.org> Cr-Commit-Position: refs/heads/master@{#720051}
-
Rohit Agarwal authored
Ambient authentication in private modes can currently be toggled with feature flag. The default value is to allow for all profile types. We want to change this behavior to be controlled by policy. This CL adds the preference needed to setup the policy and also links them together. Please note, we are not changing the behavior of how ambient authentication is allowed in this CL. This would be followed up later. Bug: 458508 Change-Id: I97d16e3b804d38ab668238adc90a938affe73b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932448 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#720050}
-
Sebastien Marchand authored
This CL removes the |SiteCharacteristicsDataReader| object from the SessionRestorePolicy::TabData struct. The goal is to make it easier to switch to the Graph owned local DB once it's ready. The |used_in_bg| bit is still set asynchronously and we need a way to cancel the initialization callback when it goes out of scope. It used to be done indirectly by releasing the SiteCharacteristicsDataReader but it now has to be explicit, this is achieved by a adding a CancelableOnceClosure member to SessionRestore::TabData. This callback will also be useful once we have the PM based version of the LocalDB. Bug: 961336 Change-Id: I443277dc711f2c22558fd76ec328b3623777b0d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927168 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#720049}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4a8d66b9713e..3188d6f8a991 Created with: gclient setdep -r src-internal@3188d6f8a991 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:none Tbr: jbudorick@google.com Change-Id: I7ae1ebc821a31cbbd2d24a773033b24804d450e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942717Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4cea2aef55dc..389749ae554d git log 4cea2aef55dc..389749ae554d --date=short --first-parent --format='%ad %ae %s' 2019-11-28 jmadill@chromium.org Fix ICD generation (again). Created with: gclient setdep -r src/third_party/swiftshader@389749ae554d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I7ca43ba10f96bd9220311640c5f188497030d351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942712Reviewed-by:
-
kylechar authored
1. Fix class header ordering violations. 2. Use empty callbacks instead of optional callbacks. 3. Pass callbacks by value when transferring ownership. 4. Fix NOTIMPLEMENTED() for SkiaOutputSurfaceImplOngpu swap buffers and presentation feedback. This is handled elsewhere already. Bug: none Change-Id: Iedd18969fb674d48713ef406029e942b7afd947c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942969Reviewed-by:
-
David Bokan authored
This test no longer exists in the codebase so removing its expectations. TBR=nzolghadr@chromium.org Bug: 940829 Change-Id: I255cb97f630641f739c6f7a86ba21ca877f2abb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943051Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#720045}
-
Sahel Sharify authored
This cl enables reading shipping and contact info delegation for JIT installation of payment apps on Android. Bug: 984694 Change-Id: I722ca93c462acc623f0f3e9fb8d2f787f8b69c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941193Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#720044}
-
Armando Miraglia authored
Since onion souping, the event logs generated for peer connection were translated from std::string to WTF::String. However, the data being stored is binary and WTF::String attempts to appropriately format the string, resulting in corrupted binary data. This CL changes back WTF::String to std::string where possible and converts the binary data into a vector<uint8> to be sent via Mojo. This way the data is correctly stored in the output file. This is the first of 3 steps that will convert the data from string to vector<uint8>, which is more suitable for representing binary data. The next step will be to convert the data representation to vectors in the renderer code and the last in the browser code. Fixed: 1028536 Change-Id: If470069c45da24e298e9a4ceab926b8d7c08d05c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942652Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#720043}
-
Kevin Ellis authored
Play controls recently broke for composited animations due to timing differences on when variables are changes. Per spec, the start time is not cleared when pausing an animation until after the animation is ready. This discrepancy lead to a case when PreCommit would not get called when pausing a composited animation. Reverse and updatePlaybackRate were also broken for composited animations. We cannot composite infinite duration animations in the reverse direction. We were using playback rate instead of EffectivePlaybackRate in one of our checks for compositor eligibility, and falling to catch this case. Finally, with changes to when start time is cleared, we can be in a case where it is important to preserve the start time or the current time when starting a composited animation. Fortunately, we can determine when start time is the important factor based in whether the animation is pending. Next step: Add WPT tests that would have caught the regressions. Filed as issue 1029123. Bug: 1028985, 1028986 Change-Id: I4edf851790a860d20962df84944558e7dbc1863a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940885 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#720042}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bc42a63a70fc..5e2f45a379a7 git log bc42a63a70fc..5e2f45a379a7 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 tvanderlippe@chromium.org Add script to remove unused globals Created with: gclient setdep -r src/third_party/devtools-frontend/src@5e2f45a379a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I46e1643432daea567743c5a9c7fd6bf1383d1162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942711Reviewed-by:
-
Yi Xu authored
Tracking transform/clip/fliter for non-drawing ops with PaintTrackingCanvas doesn't change how canvas is rasterred. Removing the implementation of PaintTrackingCanvas. Bug: 1014246 Change-Id: I3d57c3511b05151fac6b3b2821d9fb74c13675ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902272Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#720040}
-
