GitLab

BUG=419723
R=pinkerton@chromium.org

Review URL: https://codereview.chromium.org/625593002

Cr-Commit-Position: refs/heads/master@{#297845}

This is a race condition that gets triggered if we get *both* audible and
inaudible directives in the same instruction. This causes us to encode both
the tokens, but when ProcessNextTransmit gets called after the samples for the
first token are received, it tries to play the other type of token also (for
which samples may not have been received yet). The simplest way to fix it is
adding a HasKey check to the cache for both types of tokens. We will get
called after each of the samples tokens are added to their respective caches,
so if we skip playing one particular type of token (since it hasn't landed in
its cache yet), we will get called again after it gets added to its cache, so
both the tokens will definitely play.

R=xiyuan@chromium.org
BUG=419585

Review URL: https://codereview.chromium.org/614903007

Cr-Commit-Position: refs/heads/master@{#297844}

The BUG 419364 was solved by crrev.com/297660.

BUG=419364
TEST=None

Review URL: https://codereview.chromium.org/618653003

Cr-Commit-Position: refs/heads/master@{#297843}

* Add unused parameter for toggling spoken feedback handler
* For Athena disable magnification, use proper shutdown API

BUG=419708

Review URL: https://codereview.chromium.org/626503002

Cr-Commit-Position: refs/heads/master@{#297842}

Add 4 Variations.SeedDateSkew.* histograms to analyze whether the system clock or the build time could be used as a long term expiry clock for very old variations seeds.

BUG=419622

Review URL: https://codereview.chromium.org/617263007

Cr-Commit-Position: refs/heads/master@{#297841}

Seems to have some tabs in there too

BUG=

Review URL: https://codereview.chromium.org/619913004

Cr-Commit-Position: refs/heads/master@{#297840}

BUG=413685
R=noms@chromium.org
TEST=Sign in to a profile with an @gmail.com or @google.com account,
lock should be available. Sign in with another other domain (such as
chromium.org) and lock will not be available.

Review URL: https://codereview.chromium.org/566933005

Cr-Commit-Position: refs/heads/master@{#297839}

BUG=399735
R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/620093004

Cr-Commit-Position: refs/heads/master@{#297838}

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/611983004

Cr-Commit-Position: refs/heads/master@{#297837}

R=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/624533003

Cr-Commit-Position: refs/heads/master@{#297836}

BUG=408089

Review URL: https://codereview.chromium.org/622543007

Cr-Commit-Position: refs/heads/master@{#297835}

This caused --report-silk-details to throw exceptions.

TEST=manual,thread_times_unittest

Review URL: https://codereview.chromium.org/615253007

Cr-Commit-Position: refs/heads/master@{#297834}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2152879..48c0239

TBR=eustas@chromium.org,jsbell@chromium.org

Review URL: https://codereview.chromium.org/625563003

Cr-Commit-Position: refs/heads/master@{#297833}

BUG=331424

Review URL: https://codereview.chromium.org/294973002

Cr-Commit-Position: refs/heads/master@{#297832}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b77955e..29fe24c

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/625443005

Cr-Commit-Position: refs/heads/master@{#297831}

Previously, in order to initialise CommandLine, you had to know whether
you were running as part of Content Shell, Chrome Shell, or Chrome, and
call the corresponding method.

This led to ugly code like ChromiumSyncAdapter.java having to provide an
abstract initCommandLine method that gets implemented by the subclasses
ChromeShellSyncAdapter.java and ChromeBrowserSyncAdapter.java.

Instead this patch adds an abstract initCommandLine method on
ContentApplication.java, implemented by the subclasses:
- ContentShellApplication
- ChromeShellApplication
- ChromeMobileApplication
- ChromeNativeTestApplication

Thus any code in the content layer can now initialize CommandLine with:
    ContentApplication.initCommandLine(context);

BUG=350384
TBR=fgorski@chromium.org
CQ_TRYBOTS=tryserver.chromium:android_aosp,android_arm64_dbg_recipe,android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel,android_clang_dbg_recipe,android_dbg_tests_recipe

Review URL: https://codereview.chromium.org/615153002

Cr-Commit-Position: refs/heads/master@{#297830}

Git hash: 6e94c9e17806e3243f31d96b8049ab0c8ecf7d67

BUG=
TBR=hajimehoshi@chromium.org,toyoshim@chromium.org

Review URL: https://codereview.chromium.org/619953002

Cr-Commit-Position: refs/heads/master@{#297829}

This is to prepare for running the scanner as a presubmit check.

I have added some manual tests to make sure that the new scanner is
compatible with the old one. I plan to replace them with automatic
unittests once I start using presubmit-style input API objects that
are easily mockable.

BUG=343104

Review URL: https://codereview.chromium.org/622493004

Cr-Commit-Position: refs/heads/master@{#297828}

To move the WebView telemetry bot off hard coding
which tests to use and start getting the list of tests
automatically we need to label which tests don't work
on the WebView.

Bug tracking enabling them here: crbug.com/419687

BUG=391488, 419687

Review URL: https://codereview.chromium.org/619903003

Cr-Commit-Position: refs/heads/master@{#297827}

Sync up chrome_restart_request.cc with ui/events/event_switches.h

BUG=none

Review URL: https://codereview.chromium.org/617583002

Cr-Commit-Position: refs/heads/master@{#297826}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/28da02d..2152879

TBR=eustas@chromium.org,jsbell@chromium.org

Review URL: https://codereview.chromium.org/617703003

Cr-Commit-Position: refs/heads/master@{#297825}

Use a boolean to only send WINDOW_CONTENT_CHANGED the first time
notifyFrameInfoInitialized is called. See bug for longer discussion of
issue.

BUG=419541

Review URL: https://codereview.chromium.org/624503002

Cr-Commit-Position: refs/heads/master@{#297824}

Propagate touchscreen information so that Ash can map touchscreens to displays.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/616633002

Cr-Commit-Position: refs/heads/master@{#297823}

We never unregistered an audio stream that were using keyboard mic channel, so we never inactivated the keyboard mic when no more streams were using it. This fixes it.

Fix for CL https://codereview.chromium.org/599443003/

BUG=418993

Review URL: https://codereview.chromium.org/618663003

Cr-Commit-Position: refs/heads/master@{#297822}

Creating a runtime table of std::string objects, just to copy those
into a map, is not optimal from a runtime or footprint point of view.

Making the table use raw char pointers shrinks the code and data by 75%,
from 36 KB to 10 KB (clang, Linux, 64 bit content_shell).

clang:
Total change: -27266 bytes
==========================
  2 added, totalling +8448 bytes across 1 sources
  774 removed, totalling -36401 bytes across 2 sources
  1 grown, for a net change of +687 bytes (481 bytes before, 1168 bytes after) across 1 sources

R=estade@chromium.org,mark@chromium.org
BUG=

Review URL: https://codereview.chromium.org/573623003

Cr-Commit-Position: refs/heads/master@{#297821}

BUG=v8:3597
R=cpu@chromium.org,wfh@chromium.org

Review URL: https://codereview.chromium.org/619543002

Cr-Commit-Position: refs/heads/master@{#297820}

Cr-Commit-Position: refs/heads/master@{#297819}

BUG=417315

Review URL: https://codereview.chromium.org/599173002

Cr-Commit-Position: refs/heads/master@{#297818}

According to latest editor draft(http://rawgit.com/w3c/html-api-map/master/index.html) above mentioned input type attributes should have xml-roles. Also math tag should have xml-role.

BUG=418486

Review URL: https://codereview.chromium.org/609343002

Cr-Commit-Position: refs/heads/master@{#297817}

Revert of Making WebRTC Java api avaliable in Chromium. (patchset #5 id:100001 of https://codereview.chromium.org/551793003/)

Reason for revert:
This CL breaks official Chrome.

Original issue's description:
> Making WebRTC Java api avaliable in Chromium.
>
> BUG=383418
> TEST=Build target libjingle_peerconnection_javalib
>
> Committed: https://crrev.com/e65a8cbe2e8b0634a66715b3959b418431f4d0c0
> Cr-Commit-Position: refs/heads/master@{#297801}

TBR=hellner@chromium.org,kjellander@chromium.org,serya@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=383418

Review URL: https://codereview.chromium.org/614263007

Cr-Commit-Position: refs/heads/master@{#297816}

BUG=399735

Review URL: https://codereview.chromium.org/617963006

Cr-Commit-Position: refs/heads/master@{#297815}

The existing file handler registration code in ShellUtil was highly
specific to Chrome (and the necessary actions to register a web
browser). Refactored the code and split it up so that there is reusable
code for general (non-browser app) file handler registrations.

Added AddFileAssociations and DeleteFileAssociations, which can register
and unregister file handlers for any command line and for any file
extensions. These are intended to be used when installing/uninstalling
Chrome apps with file_handlers in their manifest.

BUG=130455

Review URL: https://codereview.chromium.org/487693002

Cr-Commit-Position: refs/heads/master@{#297814}

TBR=bruening@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/614223005

Cr-Commit-Position: refs/heads/master@{#297813}

Currently the credentials mode of the FetchEvent's request is always 'omit'.
But this should be 'same-origin' or 'include'.
ex:
- <img src="./test.png">
 mode: no CORS
 credentials mode: same-origin
- <img src="./test.png" crossOrigin="anonymous">
 mode: CORS
 credentials mode: same-origin
- <img src="./test.png" crossOrigin="use-credentials">
 mode: CORS
 credentials mode: include

[1/2] blink: https://codereview.chromium.org/610403002/
[2/2] chromium: https://codereview.chromium.org/615493003/

This value is passed from the renederer to the ServiceWorker in the following steps.

In the renederer process:
  blink::ResourceRequest::setFetchCredentialsMode()  // not called yet
 blink::ResourceRequest::m_fetchCredentialsMode
  content::WebURLLoaderImpl::Context::Start()
   blink::WebURLRequest::fetchCredentialsMode()
    GetFetchCredentialsMode()
 conetnt::RequestInfo::fetch_credentials_mode

In the browser process:
 conetnt::RequestInfo::fetch_credentials_mode
  content::ResourceDispatcherHostImpl::BeginRequest()
   content::ServiceWorkerRequestHandler::InitializeHandler()
    content::ServiceWorkerProviderHost::CreateRequestHandler()
     content::ServiceWorkerControlleeRequestHandler::ServiceWorkerControlleeRequestHandler()
 content::ServiceWorkerControlleeRequestHandler::request_credentials_mode_
  content::ServiceWorkerControlleeRequestHandler::MaybeCreateJob()
   content::ServiceWorkerURLRequestJob::ServiceWorkerURLRequestJob()
 content::ServiceWorkerURLRequestJob::request_credentials_mode_
  content::ServiceWorkerURLRequestJob::CreateFetchRequest()
 content::ServiceWorkerFetchRequest::credentials_mode

In the ServiceWorker process:
 content::ServiceWorkerFetchRequest::credentials_mode
   content::ServiceWorkerScriptContext::OnFetchEvent()
   GetBlinkFetchRequestCredentialsMode()
   blink::WebServiceWorkerRequest::setCredentialsMode()
 blink::WebServiceWorkerRequest::WebServiceWorkerRequestPrivate::m_credentialsMode
  blink::Request::create()
  blink::FetchRequestData::create()
 blink::FetchRequestData::m_credentials

BUG=418509

Review URL: https://codereview.chromium.org/615493003

Cr-Commit-Position: refs/heads/master@{#297812}

This is a long-standing task, I have been waiting to proceed with it to avoid complicated merges while things were hot on the settings protection front.

Now is a good time to clean this up before doing further cleanup work.

TBR=grt@chromium.org
BUG=419505

Review URL: https://codereview.chromium.org/620933002

Cr-Commit-Position: refs/heads/master@{#297811}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e3dbcaf..28da02d

TBR=eustas@chromium.org,jsbell@chromium.org

Review URL: https://codereview.chromium.org/623703002

Cr-Commit-Position: refs/heads/master@{#297810}

This workaround is no longer needed as the NSS bug was fixed in NSS 3.12.10 (see: https://bugzilla.mozilla.org/show_bug.cgi?id=635778), and Chromium requires NSS 3.14.3 or later now.

BUG=138571

Review URL: https://codereview.chromium.org/616093002

Cr-Commit-Position: refs/heads/master@{#297809}

This CL removes IndividualSettings and GlobalSettings from ExtensionManagment header file in order to simply header file and reduce static size of ExtensionManagement class. Linked pointer is used to prevent potential unintended use of copy constructor of these structure in the future, when more fields are added.

A new internal header file is created since these structures are also used in unit tests.

BUG=177351

Review URL: https://codereview.chromium.org/602803002

Cr-Commit-Position: refs/heads/master@{#297808}

"X-DevTools-Request-Initiator" and "X-DevTools-Emulate-Network-Conditions-Client-Id" HTTP headers may be set by InspectorResourceAgent when the inspector window is open.
This headers are removed by DevToolsNetworkTransaction before sending the request to the network.
But when the request passed to the ServiceWorker these headers are not removed.
This may cause accidental problems.

BUG=419318

Review URL: https://codereview.chromium.org/615413002

Cr-Commit-Position: refs/heads/master@{#297807}

This is the Chromium part of a two-sided patch.
The Blink part is https://codereview.chromium.org/615893004

R=dgozman, vsevik

Review URL: https://codereview.chromium.org/620953003

Cr-Commit-Position: refs/heads/master@{#297806}