GitLab

Revision b779ce61 broke the
generate_build_files step on the Dr. Memory build:

gyp: Key 'conditions' repeated at level 6 with key path
'targets.0.conditions.5.1' while reading
C:\b\build\slave\drm-cr\build\src\printing\printing.gyp

BUG=607668
TEST=none
TBR=skau@chromium.org

Review-Url: https://codereview.chromium.org/2173063002
Cr-Commit-Position: refs/heads/master@{#407160}

BUG=629867

Review-Url: https://codereview.chromium.org/2173493002
Cr-Commit-Position: refs/heads/master@{#407159}

This CL modifies the way in which account credentials (URL/username) are displayed on PasswordEntryEditor.java and adds buttons which will allow users to view/copy their credentials.

BUG= 628669

Review-Url: https://codereview.chromium.org/2156613002
Cr-Commit-Position: refs/heads/master@{#407158}

BUG=626827

Review-Url: https://codereview.chromium.org/2165413002
Cr-Commit-Position: refs/heads/master@{#407157}

This CL retains the maximum autofill profile use-count,
instead of summing the use-counts, when merging two
profiles.

The previous behaviour, summing, inflates the use-count
during profile deduplication, double counts on profile
usage, and falsely counts a fully-typed submission as a
reuse of any profile it matched. All of these skew the
frecency score of the resulting merged profile.

BUG=629978
R=mathp@chromium.org, sebsg@chromium.org

Review-Url: https://codereview.chromium.org/2164143002
Cr-Commit-Position: refs/heads/master@{#407156}

The interface has been broken for a long time.

BUG=

Review-Url: https://codereview.chromium.org/2165313002
Cr-Commit-Position: refs/heads/master@{#407155}

BrowsingDataRemover::RemoveImpl runs on the UI thread. It schedules several
operations on other threads and flips a boolean flag to "true" for each of
them. Each operation responds with a callback on the UI thread flipping its
flag back to "false" and call NotifyIfDone(), a method that checks if all
flags are already false, in which case it reports that the deletion was
completed.

In addition, NotifyIfDone() is also called at the end of
BrowsingDataRemover::RemoveImpl - this is in case that no tasks on other
threads were scheduled.

Consider the following simplified scenario with arbitrary task "X":

BrowsingDataRemover::RemoveImpl() {
  DCHECK_CURRENTLY_ON(BrowserThread::UI);
  waiting_for_task_x_ = true;
  ScheduleTaskX(&OnXDone);

  // ...

  NotifyIfDone();
}

BrowsingDataRemover::OnXDone() {
  DCHECK_CURRENTLY_ON(BrowserThread::UI);
  waiting_for_task_x_ = false;
  NotifyIfDone();
}

While this pattern should only be used if X is on a different thread,
consider what would happen if X was on the UI thread and yielded to the UI
thread. NotifyIfDone() in OnXDOne() would find all flags false and notify
about the deletion being complete. Immediately after, NotifyIfDone() in
RemoveImpl() would do the same. The observer would receive two deletion
notifications.

This is not hypothetical - clearing with remove_mask == REMOVE_COOKIES
will run OnClearedDomainReliabilityMonitor() before RemoveImpl() is finished.

This CL fixes that by considering the execution of RemoveImpl() as a task
of its own, having its own boolean flag to indicate that the body of
RemoveImpl() has finished.

This was discovered during the implementation of a task scheduler for
BrowsingDataRemover in a different CL and will be covered against regression
by the tests of that CL. It was not caught by our tests before because
BrowsingDataRemoverCompletionObserver that is commonly used in the unittests
always unregisters itself after the first callback and thus never spotted
the second callback.

BUG=630327

Review-Url: https://codereview.chromium.org/2173443002
Cr-Commit-Position: refs/heads/master@{#407154}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bf66428a..2cf82064

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2169293003
Cr-Commit-Position: refs/heads/master@{#407153}

Latest crash dumps suggest that callback is invoked
re-entrantly during QuicHttpStream::DoLoop(). This can be
problematic because the caller can delete the
QuicHttpStream when the callback is run. This CL changes
QuicHttpStream::OnClose() to not invoke callback when
already in DoLoop().

This CL also adds a unit test which will crash without the
change or the CHECKs.

BUG=629043

Review-Url: https://codereview.chromium.org/2163883004
Cr-Commit-Position: refs/heads/master@{#407152}

Currently ESCAPE key event is not handled correctly while playing
full screen video. Now exiting full screen video when receives
ESCAPE key event to match desktop behavior.

BUG=614185

Review-Url: https://codereview.chromium.org/2124003004
Cr-Commit-Position: refs/heads/master@{#407151}

This CL calls WillStartRequest on the current NavigationHandle when a
navigation is starting. This mimics the SimulateRedirect call, and enables
NavigationThrottles which override WillStartRequest to be unit testable
using the content unit test framework.

Note: like SimulateRedirect, there is no current support for the throttles
actually cancelling / deferring the navigation.

BUG=627501

Review-Url: https://codereview.chromium.org/2157153003
Cr-Commit-Position: refs/heads/master@{#407150}

Smoothly scroll effect also triggers TalkBack read previous screen after navigate to new screen.

BUG=602373, 628255

Review-Url: https://codereview.chromium.org/2166383002
Cr-Commit-Position: refs/heads/master@{#407149}

This test case is passing now.

BUG=none

Review-Url: https://codereview.chromium.org/2172983002
Cr-Commit-Position: refs/heads/master@{#407148}

Bump the priority of BACKGROUND threads to NORMAL during shutdown.
This will prevent TaskTracker::Shutdown() from waiting for work to
be done by threads that never get a time slice.

BUG=553459

Review-Url: https://codereview.chromium.org/2161213002
Cr-Commit-Position: refs/heads/master@{#407147}

The tests CanMakeAudioCallAndThenRenegotiateToVideo and
CanMakeVideoCallAndThenRenegotiateToAudio had been disabled because of a
bug in libjingle/webrtc.

These tests run fine in my machine. It might have been
fixed by now.

BUG=484826

Review-Url: https://codereview.chromium.org/2171313003
Cr-Commit-Position: refs/heads/master@{#407146}

BUG=629867

Review-Url: https://codereview.chromium.org/2167283002
Cr-Commit-Position: refs/heads/master@{#407145}

https://chromium.googlesource.com/skia.git/+log/2259c5f65015..da626aadcced

$ git log 2259c5f65..da626aadc --date=short --no-merges --format='%ad %ae %s'
2016-07-22 jcgregorio Revert of Redo Tiling (patchset #14 id:260001 of https://codereview.chromium.org/2134893002/ )

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2175733002
Cr-Commit-Position: refs/heads/master@{#407144}

Cleaning up video-playback* and sources-fallback* tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956, 443596

Review-Url: https://codereview.chromium.org/2121383005
Cr-Commit-Position: refs/heads/master@{#407143}

This makes layers with animated opacity get treated as though they
have non-1 opacity when determining whether they need a render surface,
since an animation can cause opacity to change from 1 to non-1 without
a commit happening in between.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2169143002
Cr-Commit-Position: refs/heads/master@{#407142}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/911591f6..bf66428a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2170313004
Cr-Commit-Position: refs/heads/master@{#407141}

https://chromium.googlesource.com/skia.git/+log/6af0c958a0d0..2259c5f65015

$ git log 6af0c958a..2259c5f65 --date=short --no-merges --format='%ad %ae %s'
2016-07-22 bsalomon Disable CopySurface test on Nexus 10 for flakiness

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2173723003
Cr-Commit-Position: refs/heads/master@{#407140}

In Android N loading system libraries is banned so use the supported mechanism
for Android M and newer releases.  For Android L we still need to manually load
the system library.

BUG=625188

Review-Url: https://codereview.chromium.org/2160263002
Cr-Commit-Position: refs/heads/master@{#407139}

Enable top_10_mobile_memory and top_10_mobile_memory_ignition benchmarks on
mac. They were dissabled because the earlier pageset contained google.com
which was being redirected to google.ca. This caused problems with scrolling
action. This cl: https://codereview.chromium.org/2138133003/ updated the
pageset to use google.co.uk to avoid redirection problem. So I am enabling these
benchmarks on mac.

BUG=v8:5019
LOG=N
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2170853002
Cr-Commit-Position: refs/heads/master@{#407138}

This is for better polish in the UI but it fixes a drag
image issue on Linux crbug.com/593256 .

Also add a kGpuDriverBugListJson entry to automatically
disable transparent visuals on all drivers (especially
the proprietary NVIDIA driver) except for opensource
drivers (i.e. Mesa based drivers).

BUG=369209

R=kbr@chromium.org, sadrul@chromium.org, tapted@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/71b2517dd4cd620a56ca6f13571129c6aee30b42
Review-Url: https://codereview.chromium.org/2124633002
Cr-Original-Commit-Position: refs/heads/master@{#406505}
Cr-Commit-Position: refs/heads/master@{#407137}

Revert of [system health] Make mobile washington post story more robust. (patchset #4 id:60001 of https://codereview.chromium.org/2171713003/ )

Reason for revert:
It broke Android perf bots.

Original issue's description:
> [system health] Make mobile washington post story more robust.
>
> This patch makes sure that we wait for either the "Close" or
> the "Send link to phone" button after loading the document.
>
> BUG=629983
>
> Committed: https://crrev.com/10766908401f0dd9631b670aa252c33473c41f67
> Cr-Commit-Position: refs/heads/master@{#406816}

TBR=ulan@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=629983

Review-Url: https://codereview.chromium.org/2172153004
Cr-Commit-Position: refs/heads/master@{#407136}

BUG=609747

Review-Url: https://codereview.chromium.org/2167653002
Cr-Commit-Position: refs/heads/master@{#407135}

BUG=629459

Review-Url: https://codereview.chromium.org/2169233003
Cr-Commit-Position: refs/heads/master@{#407134}

There are many places where we're passing the current realm instead of
the relevant realm of the platform object, and it's wrong.  This CL
fixes most of those but not all.  Following CLs may fix the rest.

BUG=618672,560308

Review-Url: https://codereview.chromium.org/2049493005
Cr-Commit-Position: refs/heads/master@{#407133}

BUG=616090

Review-Url: https://codereview.chromium.org/2175683002
Cr-Commit-Position: refs/heads/master@{#407132}

https://chromium.googlesource.com/skia.git/+log/901257a3ba1d..6af0c958a0d0

$ git log 901257a3b..6af0c958a --date=short --no-merges --format='%ad %ae %s'
2016-07-22 mtklein GN: restore gn.py partly as fetch-gn
2016-07-22 caryclark conic fuzz fix

BUG=630378

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2175693002
Cr-Commit-Position: refs/heads/master@{#407131}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1a2021bc..911591f6

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2175583003
Cr-Commit-Position: refs/heads/master@{#407130}

Usually iOS framework bundle will be included in an application
so have them define a ${target}+bundle target that can be used
to depend and cause the copy into the application bundle.

BUG=629867

Review-Url: https://codereview.chromium.org/2172733003
Cr-Commit-Position: refs/heads/master@{#407129}

The <base> URL can change between the attribute (href) is updated and
the shadow tree constructed. This causes confusion in the target
resolving code since it can produce different results at different
points in time.
Only resolve the URL on changes (to 'href'), extract the fragment
identifier and store whether the reference is local or not.
Refactor the SVGUseElement target element lookup with an eye to
future handling of "fragment-only" (local) URLs.
This makes the externalDocument in
SVGURIReference::targetElementFromIRIString unused, so remove that
codepath and simplify the function accordingly.

This changes behavior from resolving the URL and target element when
needed (depending on when layouts happen), to only when the 'href' is
mutated. This new behavior matches Edge, but not Gecko.

BUG=601203, 470608

Review-Url: https://codereview.chromium.org/2173453002
Cr-Commit-Position: refs/heads/master@{#407128}

iOS framework requires a valid Info.plist file, so add support for
generating it to ios_framework_bundle template.

BUG=629867

Review-Url: https://codereview.chromium.org/2164393002
Cr-Commit-Position: refs/heads/master@{#407127}

These two CSSValue classes are used to represent the same semantic,
which is a reference to an element by means of a "url(...)" function.
CSSSVGDocumentValue carries additional state to be able to handle
references to external documents, by caching a DocumentResource.

Move all the DocumentResource state to CSSURIValue, while also keeping
the naming of the URL string (m_url). Also do some minor cleanup, for
instance by removing "SVG" from the cachedSVGDocument() method name and
dropping some unnecessary .get()s.

This bloats CSSURIValue a bit for the cases where the DocumentResource
is not utilized, but this bloat will be reduced (in relative terms) with
future developments. On the "pro"-side is naturally that we now don't
have to extend two CSSValue classes with additional functionality and
state.

BUG=470608, 405315

Review-Url: https://codereview.chromium.org/2165833006
Cr-Commit-Position: refs/heads/master@{#407126}

Revert of Roll buildtools 55638fe5c3..60f7f9a8b4 (patchset #1 id:1 of https://codereview.chromium.org/2166993002/ )

Reason for revert:
Speculative revert - this probably broke the official build - see crbug.com/630514 for more details. Will reland if the suspicion was wrong.

Original issue's description:
> Roll buildtools 55638fe5c3..60f7f9a8b4
>
>   In order to roll GN af92718f..1f417360 (r405547:r406705) and pick up
>   the following changes:
>
>   267b1de9 Make `gn refs` handle files in data directories properly.
>   5fc3fafd Add TaskPriority as a parameter to SequencedWorkerPool in preparation for TaskScheduler experiment.
>   aca08753 Make `gn refs` look at script files.
>   05316e06 Re-land r406064 "[GN] Add JSON project writer".
>   5a1b4b17 Revert of [GN] Add JSON project writer (patchset #11 id:200001 of https://codereview.chromium.org/2064533002/ )
>   d2edeb9a [GN] Add JSON project writer
>   f0544fc6 Remove calls to MessageLoop::current() in tools.
>   d93e5cf4 Document GN invoker and target name variables.
>
> TBR=dpranke@chromium.org
>
> Committed: https://crrev.com/d8a18dc3820a4d54d8fc9ad8667d242798f10d33
> Cr-Commit-Position: refs/heads/master@{#406727}

TBR=dpranke@chromium.org,brettw@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2171273002
Cr-Commit-Position: refs/heads/master@{#407125}

This CL adds a generic throttler of requests that
 - checks new requests against daily quota (configurable by Finch),
 - reports to UMA status of each request w.r.t. the quota,
 - reports to UMA the total count of request per day.

As an example application, it adds throttler for NTPSnippetsFetcher. This throttler will be used in another CL.

BUG=627073

Review-Url: https://codereview.chromium.org/2158843002
Cr-Commit-Position: refs/heads/master@{#407124}

https://chromium.googlesource.com/chromium/src/+/b856aa2c6

BUG=104922
TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/2173763002 .

Cr-Commit-Position: refs/heads/master@{#407123}

This CL also renames mobile_facebook_login.LoginAccount to
facebook_login.LoginWithMobileSite.

Motivation: later we will add a login method for facebook desktop, hence
generalize this module to support both.

BUG=589726

Review-Url: https://codereview.chromium.org/2166743005
Cr-Commit-Position: refs/heads/master@{#407122}

Original issue's description:
> Changes the lines to go from always 2 to at most 2 by default, so that
> we don't show empty lines on very large screens.
> For smaller screens, the title can go up to 4 lines, and we then hide
> the description.
> On bigger screens, we add space on the side of the cards
>
> Measures used:
> < 360dp: Narrow -> 4 lines title
> >= 360dp: Regular -> 2 + 2 lines
> >= 600dp: Wide -> 2 + 2 lines, 48dp gutters around the cards
>
> Preview: https://goo.gl/photos/prJ42tvP4jzwiCn3A

Was reverted as https://codereview.chromium.org/2167973004/

Reason for revert:
> Broke Android compile:
> NewTabPageAdapterTest.java:162: error: constructor NewTabPageAdapter in
>   class NewTabPageAdapter cannot be applied to given types;
>   NewTabPageAdapter ntpa = new NewTabPageAdapter(mNewTabPageManager, null, mSnippetsBridge);
>                                  ^
>   required: NewTabPageManager,NewTabPageLayout,SnippetsBridge,UiConfig
>   found: NewTabPageManager,<null>,SnippetsBridge
>   reason: actual and formal argument lists differ in length

TBR=bauerb@chromium.org,mvanouwerkerk@chromium.org,peconn@chromium.org,dbeam@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
BUG=625628, 624333

Review-Url: https://codereview.chromium.org/2173723002
Cr-Commit-Position: refs/heads/master@{#407121}