GitLab

BUG=378909, 381233, 381233
TBR=eugenis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/536023002

Cr-Commit-Position: refs/heads/master@{#293158}

MessageLoopProxy is deprecated.

This basically does a search and replace:

MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get().

BUG=391045
TEST=unittests
R=sky@chromium.org

Review URL: https://codereview.chromium.org/516173002

Cr-Commit-Position: refs/heads/master@{#293157}

Revert of Reland  501823002: Used native deinterleaved and float point format for the input streams (patchset #4 id:80001 of https://codereview.chromium.org/510073002/)

Reason for revert:
It is speculated that this CL is blamed for crbug/409819, I temporarily revert it to be able to verify it on canary.

Original issue's description:
> Used native deinterleaved and float point format for the input streams.
>
> If we call GetProperty of kAudioUnitProperty_StreamFormat before setting the format, the device will report kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved as the native format of the device, which is the same as the output.
>
> This patch changes the format to use kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved to open the device, so that we will avoid format flipping back and forth. Hope this optimization will help increase the stability of the input audio on Mac.
>
> TBR=DaleCurtis@chromium.org
>
> BUG=404884
> TEST=media_unittests && https://webrtc.googlecode.com/svn-history/r5497/trunk/samples/js/demos/html/pc1.html, https://www.google.com/intl/en/chrome/demos/speech.html
>
> Committed: https://chromium.googlesource.com/chromium/src/+/2c732c000e18a6decd1da8da24e1f5f9e5f16833

TBR=dalecurtis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=404884

Review URL: https://codereview.chromium.org/532303002

Cr-Commit-Position: refs/heads/master@{#293156}

The bug causing failure of the test has been fixed (crbug.com/245441).

BUG=394338
TBR=zhaoqin

Review URL: https://codereview.chromium.org/537593002

Cr-Commit-Position: refs/heads/master@{#293155}

BUG=390894
TEST=N/A

Review URL: https://codereview.chromium.org/509283003

Cr-Commit-Position: refs/heads/master@{#293154}

Since the indication of an active script running won't always be tied to the
location bar, it doesn't make sense for ActiveScriptController to be owned by
LocationBarController.

Since the "generated" actions were also only used for display
in the location bar, move that logic to the LocationBarController.

And, since we're there, also add a bit more testing for LocationBarController.

BUG=408676
TBR=avi@chromium.org (for method name change in cocoa)

Review URL: https://codereview.chromium.org/527963003

Cr-Commit-Position: refs/heads/master@{#293153}

TBR=zhaoqin@chromium.org
BUG=NONE
NOTRY=true

Review URL: https://codereview.chromium.org/539533003

Cr-Commit-Position: refs/heads/master@{#293152}

Cleanup:  https://crrev.com/516443002/ obsoleted PrerenderCondition* classes.

BUG=406583

Review URL: https://codereview.chromium.org/517843005

Cr-Commit-Position: refs/heads/master@{#293151}

Newer mobile devices may support the Open GL extension
EXT_disjoint_timer_query, these devices can now be traced in Chrome.

R=vmiura@chromium.org
BUG= https://code.google.com/p/chromium/issues/detail?id=397294
TEST= trybots

Review URL: https://codereview.chromium.org/509723002

Cr-Commit-Position: refs/heads/master@{#293150}

The only user of this interface has been folded into
NetworkMetricsProvider.

BUG=409872

Review URL: https://codereview.chromium.org/532623003

Cr-Commit-Position: refs/heads/master@{#293149}

Revert of [fsp] Enable the File System Provider API for extensions. (patchset #2 id:20001 of https://codereview.chromium.org/527663002/)

Reason for revert:
Speculative revert, failed ChromiumOS browser_tests.

[1422/1422] FileSystemProviderApiTest.Extension (11555 ms)
1 test failed:
    FileSystemProviderApiTest.Extension

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/11812

Original issue's description:
> [fsp] Enable the File System Provider API for extensions.
>
> Previously, only apps were allowed to use this api, however most clients will
> be actually written as extensions.
>
> TEST=browser_tests: *FileSystemProvider*Extension*
> BUG=409487
>
> Committed: https://chromium.googlesource.com/chromium/src/+/4acb869459901c6fa627473bb15b8a0f6190cc11

TBR=benwells@chromium.org,kalman@chromium.org,mtomasz@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=409487

Review URL: https://codereview.chromium.org/537603002

Cr-Commit-Position: refs/heads/master@{#293148}

BUG=410327
TBR=tkent,rvargas

Review URL: https://codereview.chromium.org/539473004

Cr-Commit-Position: refs/heads/master@{#293147}

This reverts commit 69538c3b.

As described in the bug, the proposed approach is invalid, as Blink's bindings
code isn't ready to deal with terminated scripts properly, resulting in random
crashes. Hence reverting the patch.

BUG=390906

Review URL: https://codereview.chromium.org/534093004

Cr-Commit-Position: refs/heads/master@{#293146}

The bug has long been fixed so can remove this workaround.

BUG=353687
TBR=thakis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/536903003

Cr-Commit-Position: refs/heads/master@{#293145}

The deadlock occurs because we hold lock when posting flush tasks.
If MessageLoop::PostTask() also calls TRACE_EVENT and the TRACE_EVENT
has never been reached before, the TRACE_EVENT will try to get the
category enabled flag which will also need a lock.

Copy thread_message_loops into a temporary vector of
scoped_refptr<SingleProcessTaskRunner> to avoid lock when calling
PostTask().

BUG=397022
TEST=Existing tests and ThreadSanitizer

Review URL: https://codereview.chromium.org/491393002

Cr-Commit-Position: refs/heads/master@{#293144}

Rather than being a subscriber to DTAB port forwarding becomes part of it so that DTAB could stop discovering new devices when chrome://inspect is closed.

BUG=387067

Review URL: https://codereview.chromium.org/500373004

Cr-Commit-Position: refs/heads/master@{#293143}

Update rules2 in app_resource_rules.plist.in to a set of rules that ought to work on 10.9.5 and 10.10, with the latest Gatekeeper policy changes.

This removes the “nested” tag from the live versioned directory, so that
it will be treated as data instead of code. There are problems with
“nested” validation of unversioned frameworks. There are other problems
with “nested” allowing components to be replaced, although these can be
overcome by creatively applying designated requirements to the nested
components. The non-“nested” version allows us to not version the
frameworks, which would introduce symbolic links and weaken v1 code
signature validation as done by pre-10.9 systems because v1 code
signatures do not consider symbolic links. This non-“nested” version is
also the simplest change to the existing set of resource rules that
works. The v2 rules2 dictionary is now identical to the v1 rules
dictionary.

In order for rules2 to be honored and for a v2 signature to be produced,
the app must be signed on 10.9 or later. (This will also produce a v1
signature to be validated on pre-10.9 systems.)

BUG=399276
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/533943003

Cr-Commit-Position: refs/heads/master@{#293142}

This was useful to reduce the log output when Clang's Windows
support was less mature.

BUG=82385
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/539473003

Cr-Commit-Position: refs/heads/master@{#293141}

In case the address is a negative 32-bit integer (greater than 0x80000000), it
is converted into 64-bit preserving the sign so all the leading bits are set.
This results in an invalid 64-bit address.

The conversion must be done via an unsigned 32-bit integer (uintptr_t).

BUG=409826

Review URL: https://codereview.chromium.org/533173002

Cr-Commit-Position: refs/heads/master@{#293140}

I changed analyzer such that if a gyp file (or an included gypi file)
changes all targets in the gyp file are marked as changed. This means
I should no longer have to special case gyp files. I'm leaving the
exception in place for any gyp files in build as any change to those
really needs to recompile the world.

BUG=109173
TEST=none
R=thakis@chromium.org

Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/5110e8b

Review URL: https://codereview.chromium.org/512693004

Cr-Commit-Position: refs/heads/master@{#293139}

disable browser_tests RequestContentScriptAPITest.PermissionMatcherAgreementInjection on Dr.Memory bots

TBR=bruening@chromium.org
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/528353002

Cr-Commit-Position: refs/heads/master@{#293138}

BUG=382367

Review URL: https://codereview.chromium.org/466983004

Cr-Commit-Position: refs/heads/master@{#293137}

Revert of Recorded additional tough_energy_cases. (patchset #1 id:1 of https://codereview.chromium.org/506063002/)

Reason for revert:
Errors: "WARNING:root:The page set archives for some pages are missing. Someone forgot to check them in, or they were deleted. Skipping those pages. To fix this, record those pages using record_wpr. To ignore this warning and run against live sites, pass the flag --use-live-sites."

Example: http://chromegw/i/chromium.perf/builders/Win%208%20Perf%20%282%29/builds/3086/steps/tab_switching.tough_energy_cases/logs/stdio

Original issue's description:
> PERF SHERIFF: This CL changes the tough_energy_cases test.
>
> Recorded additional tough_energy_cases.
> Moved all test cases to codepen, so they're easy to edit and all http.
>
> BUG= 386152
>
> Committed: https://chromium.googlesource.com/chromium/src/+/f4919a56f8dde79db10d158940bab9b5a95688f0

TBR=tonyg@chromium.org,jeremy@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG= 386152

Review URL: https://codereview.chromium.org/535153003

Cr-Commit-Position: refs/heads/master@{#293136}

The declared output was incorrect, forcing a systematic rebuild.

R=dzhioev@chromium.org

Review URL: https://codereview.chromium.org/534263002

Cr-Commit-Position: refs/heads/master@{#293135}

Original description from commit 63e36e6b:

ui: Move ui_unittests.gyp into ui/base.

ui_unittests.gyp -> ui_base_tests.gyp (follow gfx_tests.gyp pattern).
ui_unittests_bundle.gypi -> ui/base/ui_base_tests_bundle.gypi
ui_unittests.isolate -> ui_base_tests.isolate

Add a TODO assigned to me to rename ui_unittests target to
ui_base_unittests when buildbot is updated.

It was reverted in commit 6297a2f1,
because a test from ui_unittests in ios_dbg_simulator started to
failing.

BUG=331829,373148,299841,103304
TEST=ui_unittests
R=sky@chromium.org,rohitrao@chromium.org

Review URL: https://codereview.chromium.org/518423002

Cr-Commit-Position: refs/heads/master@{#293134}

The unit test framework brings up blink, so we have an initialized
isolate we can just use.

BUG=none
R=andrewhayden@chromium.org,dmichael@chromium.org

Review URL: https://codereview.chromium.org/537543002

Cr-Commit-Position: refs/heads/master@{#293133}

UserMediaClientImpl's purpose is to implement blink::WebUserMediaClient and does not implement a MediaStream. Thus the class is renamed to reflect this.

BUG=409560

Review URL: https://codereview.chromium.org/524363003

Cr-Commit-Position: refs/heads/master@{#293132}

Review URL: https://codereview.chromium.org/538443003

Cr-Commit-Position: refs/heads/master@{#293131}

https://chromium.googlesource.com/chromium/blink/+log/19b54260b70e697c0dc31e29206cc564d1fbf114..104ecc5a02c328914490c6c17ccc8a17d8e40fca
TBR=tkent@chromium.org,arv@chromium.org

Review URL: https://codereview.chromium.org/529363004

Cr-Commit-Position: refs/heads/master@{#293130}

Cr-Commit-Position: refs/heads/master@{#293129}

Revert of Enable forced extension updates on NaCl arch mismatch (patchset #5 id:100001 of https://codereview.chromium.org/516293007/)

Reason for revert:
Chrome OS build with DCHECKs enabled fails on start. This CL breaks assumption, that GAIA extension can be loaded without performing IO-operations.

Log and stack trace:
[16275:16275:0903/161435:WARNING:renderer_freezer.cc(55)] Cgroup freezer does not exist or is not writable. Processes will not be frozen during suspend.
[16275:16275:0903/161435:WARNING:configuration_policy_pref_store.cc(30)] Policy RemoteAccessClientFirewallTraversal: This policy has been deprecated.
[16275:16275:0903/161437:FATAL:thread_restrictions.cc(38)] Function marked as IO-only was called from a thread that disallows IO!  If this thread really should be allowed to make IO calls, adjust the call to base::ThreadRestrictions::SetIOAllowed() in this thread's startup.
#0 0x7fe3122e555e base::debug::StackTrace::StackTrace()
#1 0x7fe31237c462 logging::LogMessage::~LogMessage()
#2 0x7fe3124824af base::ThreadRestrictions::AssertIOAllowed()
#3 0x7fe3123630a1 base::PathExists()
#4 0x7fe321cfd5f3 extensions::(anonymous namespace)::CollectPlatformSpecificResourceArchs()
#5 0x7fe321cfad22 extensions::Extension::InitFromValue()
#6 0x7fe321cfa490 extensions::Extension::Create()
#7 0x7fe321cfa114 extensions::Extension::Create()
#8 0x7fe3233ebe1b extensions::ComponentLoader::Load()
#9 0x7fe3233ec3cf extensions::ComponentLoader::Add()
#10 0x7fe3233ec32a extensions::ComponentLoader::Add()
#11 0x7fe3233ec2b0 extensions::ComponentLoader::Add()
#12 0x7fe32437505f (anonymous namespace)::LoadGaiaAuthExtension()
#13 0x7fe324374d5e extensions::GaiaAuthExtensionLoader::LoadIfNeeded()
#14 0x7fe324237f7e ScopedGaiaAuthExtension::ScopedGaiaAuthExtension()
#15 0x7fe322f68bb2 chromeos::WebUILoginView::Init()
#16 0x7fe322f556ef chromeos::LoginDisplayHostImpl::InitLoginWindowAndView()
#17 0x7fe322f52640 chromeos::LoginDisplayHostImpl::LoadURL()
#18 0x7fe322f5226a chromeos::LoginDisplayHostImpl::StartWizard()
#19 0x7fe322f54acd chromeos::LoginDisplayHostImpl::StartPostponedWebUI()
#20 0x7fe322f541f8 chromeos::LoginDisplayHostImpl::Observe()
#21 0x7fe322f54bfd chromeos::LoginDisplayHostImpl::Observe()
#22 0x7fe31b222377 content::NotificationServiceImpl::Notify()
#23 0x7fe322d51a24 chromeos::(anonymous namespace)::UserWallpaperDelegate::OnWallpaperAnimationFinished()
#24 0x7fe31188692f ash::RootWindowController::OnWallpaperAnimationFinished()
#25 0x7fe3117c633a ash::(anonymous namespace)::ShowWallpaperAnimationObserver::OnImplicitAnimationsCompleted()
#26 0x7fe311f72d30 ui::ImplicitAnimationObserver::CheckCompleted()
#27 0x7fe311f72cd5 ui::ImplicitAnimationObserver::SetActive()
#28 0x7fe311f965d5 ui::ScopedLayerAnimationSettings::~ScopedLayerAnimationSettings()
#29 0x7fe3117c5ec7 ash::DesktopBackgroundWidgetController::StartAnimating()
#30 0x7fe3117bbb0c ash::DesktopBackgroundController::InstallDesktopController()
#31 0x7fe3117bbc03 ash::DesktopBackgroundController::InstallDesktopControllerForAllWindows()
#32 0x7fe3117bb3cc ash::DesktopBackgroundController::SetDesktopBackgroundImageMode()
#33 0x7fe3117bb096 ash::DesktopBackgroundController::SetWallpaperImage()
#34 0x7fe322f9a6b9 chromeos::WallpaperManager::DoSetDefaultWallpaper()
#35 0x7fe322f99b73 chromeos::WallpaperManager::PendingWallpaper::ProcessRequest()
#36 0x7fe322fbac72 base::internal::RunnableAdapter<>::Run()
#37 0x7fe322fbabe9 base::internal::InvokeHelper<>::MakeItSo()
#38 0x7fe322fbaba5 base::internal::Invoker<>::Run()
#39 0x7fe3122cc9ce base::Callback<>::Run()
#40 0x7fe312488f86 base::Timer::RunScheduledTask()
#41 0x7fe3124890bc base::BaseTimerTaskInternal::Run()
#42 0x7fe312489382 base::internal::RunnableAdapter<>::Run()
#43 0x7fe3124892ec base::internal::InvokeHelper<>::MakeItSo()
#44 0x7fe312489295 base::internal::Invoker<>::Run()
#45 0x7fe3122cc9ce base::Callback<>::Run()
#46 0x7fe3122eb9b3 base::debug::TaskAnnotator::RunTask()
#47 0x7fe3123a1c57 base::MessageLoop::RunTask()
#48 0x7fe3123a1d9b base::MessageLoop::DeferOrRunPendingTask()
#49 0x7fe3123a228d base::MessageLoop::DoDelayedWork()
#50 0x7fe3122a1f25 base::MessagePumpGlib::Run()
#51 0x7fe3123a17f0 base::MessageLoop::RunHandler()
#52 0x7fe3124093b2 base::RunLoop::Run()
#53 0x7fe324217e4d ChromeBrowserMainParts::MainMessageLoopRun()
#54 0x7fe31ad2a8bf content::BrowserMainLoop::RunMainMessageLoopParts()
#55 0x7fe31ad344c7 content::BrowserMainRunnerImpl::Run()
#56 0x7fe31ad251b1 content::BrowserMain()
#57 0x7fe31abb997f content::RunNamedProcessTypeMain()
#58 0x7fe31abbcce8 content::ContentMainRunnerImpl::Run()
#59 0x7fe31abb8ee5 content::ContentMain()
#60 0x7fe3206d3505 ChromeMain
#61 0x7fe3206d34b2 main

Cannot upload crash dump: cannot exec /sbin/crash_reporter

Crash_reporter failed to process crash report

Original issue's description:
> Enable forced extension updates on NaCl arch mismatch
>
> This makes extensions aware of the platforms for which
> they have platform-specific resources installed, if any.
>
> This also hooks up the extension update code with some
> additional logic to place an extension in forced-update
> mode if it has platform-specific resources which don't
> match the current NaCl architecture.
>
> BUG=409948
> TEST=install an extension which uses NaCl (QuickOffice for example). Rename the _platform-specific/<your-nacl-arch> directory some something else and force an update (e.g. via chrome://extensions button). Observe that a new CRX is downloaded and installed.
>
> Committed: https://chromium.googlesource.com/chromium/src/+/4a92281fa5d331860d65a59ba45dc882a5c71df4

TBR=sorin@chromium.org,yoz@chromium.org,shuchen@chromium.org,rockot@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=409948

Review URL: https://codereview.chromium.org/532183003

Cr-Commit-Position: refs/heads/master@{#293128}

BUG=402684

Review URL: https://codereview.chromium.org/517273004

Cr-Commit-Position: refs/heads/master@{#293127}

Summary of changes available at:
https://chromium.googlesource.com/chromium/deps/icu52/+log/ff8353094b0b..89831135d5f7

BUG=409851
TBR=jshin@chromium.org

Review URL: https://codereview.chromium.org/539463002

Cr-Commit-Position: refs/heads/master@{#293126}

This CL fixes an issue where the NativeViewHostAura clipping window would
not be hidden correctly and steal mouse events from the experimental app
list. This CL simply hides the clipping window when the NativeViewHost
is hidden.

BUG=408877

Review URL: https://codereview.chromium.org/517143003

Cr-Commit-Position: refs/heads/master@{#293125}

Original patch can be found at https://codereview.chromium.org/534533002

TBR=tommi
BUG=NONE

Review URL: https://codereview.chromium.org/535033003

Cr-Commit-Position: refs/heads/master@{#293124}

The new avatar menu has multiple views, and on any view, the avatar menu
change event may occur and trigger refresh. Thus instead of always refreshing
with the profile chooser view mode, we should refresh with the current view mode.

BUG=

Review URL: https://codereview.chromium.org/530113002

Cr-Commit-Position: refs/heads/master@{#293123}

BUG=231331
R=ygorshenin@chromium.org

Review URL: https://codereview.chromium.org/494473003

Cr-Commit-Position: refs/heads/master@{#293122}

This CL adds descriptions to dictionaries.

TEST=Tested manually with a test server.
BUG=248427

Review URL: https://codereview.chromium.org/527723002

Cr-Commit-Position: refs/heads/master@{#293121}

This patch adds nullability validation of handles and
pointers upon struct serialization in the Java bindings.

BUG=324170

Review URL: https://codereview.chromium.org/524703004

Cr-Commit-Position: refs/heads/master@{#293120}

This is a modified due to the regression caused by
https://codereview.chromium.org/415343003/. The test case now checks the
number of items in the menu list to not include items with "display: none"

[1] https://codereview.chromium.org/475723002/ patch that fixes the regression.

BUG=398051,403299
R=tkent

Review URL: https://codereview.chromium.org/475733002

Cr-Commit-Position: refs/heads/master@{#293119}