- 06 Feb, 2018 40 commits
-
-
Alexei Svitkine authored
This reverts commit 55424d2f. Reason for revert: Windows compile failure. Original change's description: > Remove code from obsolete field trial from 2015. > > Originally added here: https://codereview.chromium.org/1117193004 > > Bug: 799180 > Change-Id: I8e46beafdc57c249fb9909e39c197519b2652c7b > Reviewed-on: https://chromium-review.googlesource.com/902769 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#534776} TBR=asvitkine@chromium.org,mark@chromium.org Change-Id: If512ffd90d5218190d3bddb4931491f76e161aed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 799180 Reviewed-on: https://chromium-review.googlesource.com/905462Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#534781}
-
Marina Ciocea authored
* Remove EnableDebugRecording/DisableDebugRecording from AudioManager, and add a getter for AudioDebugRecordingManager instead, used by AudioDebugRecordingSessionImpl to toggle debug recording directly on AudioDebugRecordingManager. * Pass a file creation callback instead of file name to AudioDebugRecordingManager::EnableDebugRecording. * Move CreateFile from AudioDebugRecordingManager to AudioDebugRecordingSessionImpl. * Add unittest for AudioDebugRecordingSessionImpl.cc:CreateFile. * Add MockAudioDebugRecordingManager. * Rename AudioDebugFileWriter::GetFileNameExtension to GetFileExtension, so that it's not confused with extensions of filename, e.g output.<ID>. Bug: 788657 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9d0c4323f0e9630185d5e8af81c9e1b8f7b07a71 Reviewed-on: https://chromium-review.googlesource.com/881501 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#534780}
-
Zhenyao Mo authored
TBR=jmadill@chromium.org https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/98a3d3b..a182a9a Cq-Include-Trybots: master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.angle:linux_angle_rel_ng;master.tryserver.chromium.angle:win_angle_rel_ng Change-Id: Ia2dff519f9b9c8f28bb494a2ea825f0f3e7330f3 Reviewed-on: https://chromium-review.googlesource.com/904858Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#534779}
-
Joshua Pawlicki authored
This prepares for servicification of the unzipping library, where the library will not have direct access to the filesystem. Bug: 792066 Change-Id: I696dd8ef0936f22dc637e078bd8bba565e854ead Reviewed-on: https://chromium-review.googlesource.com/860996 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#534778}
-
Victor Costan authored
Our custom code for recovering from database corruption uses "recoverVtableInit" as the initialization method. This is in the global namespace. The generic name choice is especially unfortunate in component builds, where this name is seen by the dynamic library loader. This CL turns the name into chrome_sqlite3_recoverVtableInit, which significantly reduces the probability of clashes, and helps trace the name to its source. Bug: 807093 Change-Id: I11fb75a780bf8f432b6a19e58c30fe4b08979760 Reviewed-on: https://chromium-review.googlesource.com/899044Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#534777}
-
Alexei Svitkine authored
Originally added here: https://codereview.chromium.org/1117193004 Bug: 799180 Change-Id: I8e46beafdc57c249fb9909e39c197519b2652c7b Reviewed-on: https://chromium-review.googlesource.com/902769Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#534776}
-
Alexei Svitkine authored
Some code was still using the metrics namespace in the variations component. This CL fixes that. BUG=284540 TBR=sky@chromium.org,caitkp@chromium.org,torne@chromium.org Change-Id: I42ece14781a358b5ce802d8013056456c10f1290 Reviewed-on: https://chromium-review.googlesource.com/902328 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
-
Joshua Bell authored
From the Explainer: If a web application detects an unrecoverable state - for example, some coordination point like a Service Worker determines that a tab holding a lock is no longer responding - it can "steal" a lock by passing this option to acquire(). When specified, any held locks for the resource will be released (the lock's released promise will resolve with AbortError), and the request will be granted. Explainer: https://github.com/inexorabletash/web-locks Bug: 804545,807499 Change-Id: Ib837b8b7fa6ca7b0e1e96a8aa0dedc1292b26130 Reviewed-on: https://chromium-review.googlesource.com/890024 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#534774}
-
Weidong Guo authored
Background: After dragging a item in AppsGridView, the |view_model_| is reordered. But the child views' order in AppsGridView is not updated. Since FocusManager moves focus based on the child views' order, so focus traversal is broken. Changes: Update the indice of AppLitItemView in AppsGridView in accordance with with |view_model_| after dragging. BUG=791758 Change-Id: Ibf66fb1b3814086457928a36e3500b1bbad5114d Reviewed-on: https://chromium-review.googlesource.com/898528 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#534773}
-
Victor Costan authored
After https://crrev.com/c/898564, //base/ios/ios_util.h is not needed by SQL::Connection unittests. Bug: 807093 Change-Id: If6736c69dc42d35ecc24a01fc19d43d04b5db7d8 Reviewed-on: https://chromium-review.googlesource.com/903585Reviewed-by:
-
Ria Jiang authored
Pass in features::IsVizHitTestingEnabled() value when creating a DirectLayerTreeFrameSink and set up Viz hit-test in DLTFS when it is enabled. Bug: 805581 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Iec2e2c81444fda85a5d1f99824527360ae22ac5c Reviewed-on: https://chromium-review.googlesource.com/901945Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#534771}
-
Jamie Madill authored
This means we will no longer need to maintain the exec script whitelist in two places for ANGLE (in Chrome and ANGLE itself). Tbr: dpranke@chromium.org Bug: angleproject:2339 Change-Id: I4ad9d2d4a66cbfeb2245785c07839489a7e4ad58 Reviewed-on: https://chromium-review.googlesource.com/902197Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#534770}
-
David Valleau authored
This update to the enum refers to this change (https://chromium-review.googlesource.com/c/chromium/src/+/842691) R=skau@chromium.org Bug: 768606 Change-Id: I377ffce7ba22bc47c692c6b4885d43a9dcb86674 Reviewed-on: https://chromium-review.googlesource.com/857886Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: David Valleau <valleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#534769}
-
MinChen authored
Test: SplitViewControllerTest.DividerPositionWithWindowMinimumSizeOnSnapTest Bug: 807109 Change-Id: Ibd8680bc60e0d53c01c33efcc6e38536ef2d924d Reviewed-on: https://chromium-review.googlesource.com/894628Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: min c <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#534768}
-
https://webrtc.googlesource.com/src.git/+log/5c8622fa2570..29f14322d13e $ git log 5c8622fa2..29f14322d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie5fe729b7e26b22bfd75b6efec6d86605a49c8b7 Reviewed-on: https://chromium-review.googlesource.com/905089Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534767}
-
Yuri Wiitala authored
If frame capture was to proceed, but couldn't because the buffer pool was depleted, schedule a refresh to ensure the content update will eventually be captured and sent to the consumer. Bug: 785072 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ifd28739a8ceeeb75d07a05f314b6cb6827a86ea7 Reviewed-on: https://chromium-review.googlesource.com/903373Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#534766}
-
Gary Kacmarcik authored
Current icon is set to WARNING, which is incorrect. Bug: 677564 Change-Id: Ia89d1a67053cd635fa791dc6bc8b7978f886a76b Reviewed-on: https://chromium-review.googlesource.com/900269Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#534765}
-
Sammie Quon authored
Hide both for the item currently dragged. Only hide the close button for the rest of the items. Spec: https://mccanny.users.x20web.corp.google.com/www/splitscreen-motion/index.html Window selection and deselection Test: ash_unittests WindowSelectorTest.WindowItemTitleCloseVisibilityOnDrag Bug: 782320, 775655 Change-Id: I7e06a0154a9afdb391966109517b1aed419083e4 Reviewed-on: https://chromium-review.googlesource.com/893212Reviewed-by:
-
Kurt Horimoto authored
When navigations occur mid-scroll, the scroll view delegate callbacks are not always received. This CL updates the main content UI to reset the scroll state upon navigations it doesn't get out of sync. Bug: 807992 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia13244aa9f702caa988626541cf1edd4034cfa85 Reviewed-on: https://chromium-review.googlesource.com/903189 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#534763}
-
https://skia.googlesource.com/skia.git/+log/b915b978e3c3..2fb7c8aef57e $ git log b915b978e..2fb7c8aef --date=short --no-merges --format='%ad %ae %s' 2018-02-06 jvanverth Cleanup of large text rendering. 2018-02-06 djsollen Move location of skqp in the site heirarchy. 2018-02-06 update-docs Update markdown files 2018-02-06 reed move GrColor.h to private, IWYU 2018-02-06 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 1ea5993d9..6fd3bac65 (1 commit) 2018-02-06 caryclark fix bookmaker nightly 2018-02-06 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 44dcb911c..2d1c0a2b8 (1 commit) 2018-02-06 kjlubick Promote perf bots to CQ 2018-02-06 rmistry Graduate Android Framework Compile bot to be a full CQ bot 2018-02-05 bsalomon Remove integer texture support Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bsalomon@chromium.org Change-Id: Id8ecff2e5e502b6909b99a9881bde3a85b0ea6fe Reviewed-on: https://chromium-review.googlesource.com/904857 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534762}
-
Corentin Wallez authored
BUG=chromium:809594 BUG=chromium:809595 TBR=kbr@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ieaab1775fafa95765f21c9d736539df3e85dff4b Reviewed-on: https://chromium-review.googlesource.com/905098 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#534761}
-
David Tseng authored
Previously, table predicates were triggering wrapping logic; this is exepnsive and user-perceivable. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8dab50d0b638033a347fedf1da14ff3e03d40b69 Reviewed-on: https://chromium-review.googlesource.com/902609Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#534760}
-
David Tseng authored
ChromeVox currently defaults to generate speech output with queue mode category flush. Changes: - remove no-op calls to force queue mode to category flush - users of Output should now consider |forceModeForNextUtterance| as the global switch for queue mode behavior - Output.prototype.withQueueMode should be considered as a local way of specifying queue mode. It gets overridden by the global mode if set. - live region output is locally category flushed/ queued, keyboard handler is globally flushed. chromevox_tests: ensure live region suite in particular passes (which contains various tricky cases for queue mode in various situations). Bug: 800915 Test: manual: test on inbox.google.com. Ensure pressing 'x' triggers flushed speech. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic767411e7d4a017c274e33b596b77b8312adac6c Reviewed-on: https://chromium-review.googlesource.com/895059Reviewed-by:
-
Klaus Weidner authored
My fix for the slightly-wrong poses in WebVR unfortunately resulted in completely wrong (uninitialized) poses for VR browsing mode. Sorry about that. Use a mode-appropriate pose, and add comments. BUG=809608,808147 Change-Id: I2193fd6dfd6d2093b18c16b35680338a64bec5fe Reviewed-on: https://chromium-review.googlesource.com/905101Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#534758}
-
Shubhie Panicker authored
I2I link: https://groups.google.com/a/chromium.org/d/msg/blink-dev/1WFVPbRL640/TPPG9gs5AwAJ Bug: 809283 Change-Id: Id0942f146cffc07981b135ca0590a7fab1b23140 Reviewed-on: https://chromium-review.googlesource.com/903183Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Reviewed-by:
Ojan Vafai <ojan@chromium.org> Commit-Queue: Shubhie Panicker <panicker@chromium.org> Cr-Commit-Position: refs/heads/master@{#534757}
-
Peng Huang authored
Bug: 807632 Change-Id: I4ba225af77087aec951420e033c6e361f88f249d Reviewed-on: https://chromium-review.googlesource.com/905222Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#534756}
-
Emil A Eklund authored
Add flag-specific results for a number of layout tests that vary only in minor text kerning, list marker rendering or border radius antialiasing. Tbr: kojii@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I1c2770322d0c820de670e91802534abb19aea939 Reviewed-on: https://chromium-review.googlesource.com/902705 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#534755}
-
James Forshaw authored
Due to a bug in CreateProcess when enabling an AppContainer profile and setting process mitigations at the same time CreateProcess will fail with ERROR_INVALID_PARAMETER. This is due to CreateProcess internally enabling some mitigations such as force image relocation. To try and preserve the set mitigations we convert all possible to delayed mitigations instead. This CL also fixes a typo in a member variable name. Bug: 760977 Change-Id: I45f65c5ba5bab83270fcf113fbc6fbae66caa7a0 Reviewed-on: https://chromium-review.googlesource.com/902047Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#534754}
-
https://chromium.googlesource.com/catapult.git/+log/4c7a9a8e39f1..e6e84629dbe5 $ git log 4c7a9a8e3..e6e84629d --date=short --no-merges --format='%ad %ae %s' 2018-02-05 dtu Don't send browser or dimensions from dashboard to Pinpoint. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia1c7f88a7651e67eb456e544067c4f607691a622 Reviewed-on: https://chromium-review.googlesource.com/904962 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534753}
-
xdai authored
In M65, some ARC apps can be freely resized and thus are capable of displaying in splitscreen, however, the splitscreen is not supported for ARC apps windows in M65 yet, thus we should explictly disable it. Otherwise we may see issues as in crbug.com/808748. It will be reverted later in M66. Bug: 808748 Test: Manually Change-Id: I1d2a5efdb503aabaa2e0f2c519c89373c0c43f83 Reviewed-on: https://chromium-review.googlesource.com/904969Reviewed-by:
-
Chris Blume authored
The current README is unclear about when a .patch file must be generated and how we intend to isolate our changes from upstream changes. This patch clarifies how someone can contribute to third_party/zlib while minimizing risk of conflicts with upstream changes. BUG=807488 Change-Id: Iaa503b94f110cb83febbdd8d57527d606d3eb779 Reviewed-on: https://chromium-review.googlesource.com/894856Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#534751}
-
Colin Blundell authored
This CL converts SubscriptionManager from using //components/signin to using the Identity Service client library. The conversion is straightforward: - Observer IdentityManager rather than SigninManager. - Get info of primary account via IdentityManager rather than SigninManager. - Create PrimaryAccountAccessTokenFetcher via IdentityManager rather than directly. I tested the relevant behavior manually as follows, based on instructions from mamir@chromium.org: 1. Enabled Breaking News Push by turning on "enable-breaking-newspush on chrome://flags: https://cs.chromium.org/chromium/src/chrome/browser/about_flags.cc?type=cs&q=kEnableBreakingNewsPushName&sq=package:chromium&l=2497 2. Checked the about:histograms for the feature's metrics by doing "find in page" for "subscription". Saw no histogram entries after visiting the NTP when signed out but *did* see histogram entries after visiting the NTP when signed in. Metrics listed here: https://cs.chromium.org/chromium/src/components/ntp_snippets/breaking_news/breaking_news_metrics.cc?type=cs&l=17 A followup change will convert the test to use IdentityTestEnvironment. Bug: 798413 Change-Id: I9193d25c2793cf52fd825186cd5d875b352eb8bb Reviewed-on: https://chromium-review.googlesource.com/888520 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#534750}
-
David Benjamin authored
This makes for a much simpler and more uniform API. Replace the unused RSA-PSS-SHA1 test vectors (which was never an algorithm we used) with newly-generated RSA-PSS-SHA256 ones. Bug: none Change-Id: Id7010818f496952d07f81b152113a08460f1c2d5 Reviewed-on: https://chromium-review.googlesource.com/896810 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#534749}
-
Jonathan Metzman authored
TBR=aarya@chromium.org, mbarbella@chromium.org Change-Id: I2aae3d83db9365f0c429070386c671090b89943b Reviewed-on: https://chromium-review.googlesource.com/905224Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#534748}
-
Dominik Laskowski authored
Bug: 707170 Test: No DCHECK when mouse first enters gtk3-demo. Change-Id: Id8c7cd5834b8071384be2967c686988e16eadf9e Reviewed-on: https://chromium-review.googlesource.com/899912Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Cr-Commit-Position: refs/heads/master@{#534747}
-
Jiaquan He authored
The GetWallpaperProminentColors and GetContextMenuModel in AppListViewDelegate are interfaces with outputs, by returning values or updating pass-by-address params. This commit refactors them to use callback instead, to match the need of future mojo calls. For context menus, this commit also takes out relevant interfaces and structures to reuse. Bug: 733662 Change-Id: I196da33d1f040548e0f7643783d2b434c17174f1 Reviewed-on: https://chromium-review.googlesource.com/894667Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#534746}
-
Yuri Wiitala authored
Fixes the test SetUp() to use the instrumented software GL impl when the WebContentsVideoCaptureDevice browser tests are MSAN-built. This prevents false testing failures caused by memory bugs in the platform- specific libraries. Bug: 806715 Change-Id: Idec6245674b36d0c8b9cca0488e0601e02d932c8 Reviewed-on: https://chromium-review.googlesource.com/903584Reviewed-by:
-
Leon Scroggins III authored
Bug: 807324 Bug: 808665 An upgrade to libpng version 1.6.34 resulted in Chromium truncating some pngs. This pngs are technically incorrect, but according to libpng-manual.txt, "hundreds of PNG files in the wild that have" this error, and we previously displayed them properly, so we should continue to do so. That bug is fixed with crrev.com/c/901985, which is safe to land prior to the (re-)upgrade. crrev.com/c/904262 is a regression test that will ensure that this does not re-break these images. Along with that fix, revert d59d694c, taking us back to 1.6.34 along with the arm optimizations that were reverted in that commit. Change-Id: I9ee925e25d94d1ba0d27fb9ba65abf9606f13828 Reviewed-on: https://chromium-review.googlesource.com/902145Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Reviewed-by:
-
Sammie Quon authored
These two mostly copy and paste from WindowSelectorItem OnGesture and OnMouse, and only affect minmized windows. This cl removes minimized windows widget ability to accept events and let them fall through to the WindowSelectorItem, so the minimzed window have the same effect. Removed the press to select window for minimized, both minimized and non minimized windows now require click to select window. Test: manual, trybot Bug: 782320 Change-Id: Idb7ec4784990e32358fb76a4b067277c95318394 Reviewed-on: https://chromium-review.googlesource.com/896636Reviewed-by:
-
Scott Violet authored
This is a revert of most of https://chromium-review.googlesource.com/c/chromium/src/+/879029 (the test stays). I did that patch at a time when I thought I wouldn't create g_browser_process. I ended up creating g_browser_process though, which means these changes were unnecessary. BUG=800358 TEST=none Change-Id: I49eedf78abc7d6a19c49effb0c35450958dc558b Reviewed-on: https://chromium-review.googlesource.com/902683Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#534742}
-
