GitLab

We're doing some clean up and would like to retract SkColorSpaceXform
from Skia's public API.  It's obsolete now that you can either,

   1) just use Skia's drawing pipeline or readPixels()/writePixels()
      for most of its functionality; or
   2) use the much more flexible skcms interface for fancy features.

In this case, SkPixmap::readPixels() works just fine.

Change-Id: I7195eecae4ca71d408a9641c4be8d247d877ac50
Reviewed-on: https://chromium-review.googlesource.com/1203996Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595229}

 - Remove paper-slider dependency.
 - Differentiate active/inactive markers based on knob position.
 - Add label support from display-size-slider.
 - Replace display-size-slider with settings-slider.

Bug: 881290, 858882
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ib0863f37f5484f146d7cd944af4fe9a13a35ea0a
Reviewed-on: https://chromium-review.googlesource.com/1211805
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595228}

Implement a few optimizations for AudioParams

o Preallocate summing_bus instead of creating a new summing bus each
  time the final values need to be computed. And only use the bus if
  needed.
o Use vectorized Vclip to clamp the values to the nominal range.

Roughly the CPU usage (according to top) goes from 120% to 90% on my
machine.  The bug contains pprof dot files that show all of the
profiling results.

Bug: 878301
Change-Id: I99670a8397f5344e9a3ad88fe4d748f7e0486895
Reviewed-on: https://chromium-review.googlesource.com/1249583Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595227}

Bug: 820612
Change-Id: If4d415afbbdeef41ad2a0a2d5df27f3a9ebde9e7
Reviewed-on: https://chromium-review.googlesource.com/1227251
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595226}

To avoid the previous regression (see analysis in bug), we force
layout in the case where we otherwise would get an outdated result.

This relands https://chromium-review.googlesource.com/c/chromium/src/+/1246730
with an additional fix for the Chrome UI CSS. I also split out the
test change into its own patch.

IF THIS BREAKS ANY FURTHER CHROME UI:
Please don't revert this patch; instead, add min-height: 0 to any
inner nested flexboxes that may be affected by this patch. This is
an important change for web interop with the other browsers.

Bug: 596743,890100
Change-Id: Ice629c2a7823ef07d075fa23b99022b4012c6200
Reviewed-on: https://chromium-review.googlesource.com/1252682Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595225}

This relands just the testcase portion of
https://chromium-review.googlesource.com/c/chromium/src/+/1246730,
so that it won't be reverted in case the patch reland
will be reverted again.

R=eae@chromium.org, mstensho@chromium.org

Bug: 596743
Change-Id: I7c0d76794d65278c96de7eb650a717e3802bbf97
Reviewed-on: https://chromium-review.googlesource.com/1252681Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595224}

This CL adds a pref which is used to track the form signatures
(modulo ~1000) for which uploads have been triggered and for which
events.

The pref is reset every 28 days.

PasswordManager use a different throttling mechanism; they opt out
of this one by passing nullptr for the pref service when they upload.

Bug: 860285,801698
Change-Id: I132408ae9fa48d2af1272913f16f21787dc30839
Reviewed-on: https://chromium-review.googlesource.com/1236413Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595223}

OWNERS file generation was broken for a long time until today. The fix
caused the generation script to invoke the "git" command which breaks
on Windows because "git" is not a binary on the path.
This fix makes the script find the path of the git binary on Windows.

Bug: 890451
Change-Id: Ib3df557170ac53ad259663dfec6bc5481b76f6d0
Reviewed-on: https://chromium-review.googlesource.com/1252464Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595222}

This would enable Pylint with a few warning types in chromium/src.

Change-Id: Ie37d44da7b8256a52f0b9f05a0c517b599b11da3
Reviewed-on: https://chromium-review.googlesource.com/1252201Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595221}

Cancelled download cannot be interacted on Android.
Thus we can safely remove them from history.

BUG=889213

Change-Id: Ia6c85a230a60c26d5a35f0f07cd68ec32d28044f
Reviewed-on: https://chromium-review.googlesource.com/1244736
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595220}

The bug was caused by the change event on the password text field
triggering the event 'user-submitted-password' which causes a forward
navigate attempt. This fails if the password is wrong (this causes the
'incorrect password' issue in the bug) and succeeds if the password is
correct (this causes the spurious flow continuation issue).

Bug: 884965
Change-Id: I4ae9f9f9fd01901dacd9e69a216bdd3123eb9344
Reviewed-on: https://chromium-review.googlesource.com/1252503
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595219}

When we have satisfied the allocation with a new OS page, we can skip the
`memset`.

Bug: 864462
Change-Id: Ib13539a83a931dbad3e588001aa248ff994d3900
Reviewed-on: https://chromium-review.googlesource.com/1213957
Commit-Queue: Chris Palmer <palmer@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595218}

When a kMsgHaveWork task is processed by the pump, allowing it a
timeslice in which to process tasks, we pull the next MSG from the
thread's queue and dispatch that, to minimize impact of kMsgHaveWork on
MSG scheduling. WM_QUIT must be observed directly by GetMessage in order
for a nested loop to exit, though, so we must re-post it to the thread
queue, for GetMessage to report.

Re-posting was removed by crrev.com/553653, which caused WM_QUIT to be
ignored by MessagePumpForUI, missing that we must still re-post the
message, in case we're inside a nested loop, to allow it to quit.

To address this:
- When pulling a MSG to replace kMsgHaveWork, we unconditionally re-post
  WM_QUIT messages, in case ::GetMessage() needs to see them.
- Only actually handle WM_QUIT when it is observed directly by
  DoRunLoop(), i.e. if WM_QUIT was the kMsgHaveWork replacement, don't
  process it until we see it re-posted.
- Continue ignoring WM_QUIT when handled iff |!enable_wm_quit_| to
  properties of crrev.com/573620.
- Add comments and tests to properly explain and verify the special-case
  handling of WM_QUIT.
- Document a another edge case bug uncovered by this investigation.

Bug: 888559, 890016
Change-Id: I548165b6103b1c7454f90335ba6dfb4f8cf149d9
Reviewed-on: https://chromium-review.googlesource.com/1240158
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595217}

third_party/vulkan-validation-layers/src used to be populated by a DEPS
file in ANGLE. Because of this, it was added to the .gitignore to
prevent excess code downloading.

However, ANGLE later changed to pull its DEPS into
third_party/angle/third_party. That left
third_party/vulkan-validation-layers/src inside .gitignore without
actually being pulled in by DEPS.

This patch removes that directory from the .gitignore file so we can
later update the directory. This is needed to pull in a fix for a bug.

BUG=843346

Change-Id: I0563deadeef759af11f85dbdb0781238e82b21eb
Reviewed-on: https://chromium-review.googlesource.com/1252622Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595216}

Bug: 890360
Change-Id: I9ec730922415edf59e1878f89f9a046e5d1cc811
Reviewed-on: https://chromium-review.googlesource.com/1252006
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595215}

The old SigninManager::IsSignoutProhibited() had a few smells
1. callers of SM::SignOut() were expected to always call SignOut()
   even when prohibited. This allowed the *chrome* client to do special
   cleanup.
2. ProhibitSignout() was really meant to narrowly prohibit user-triggered
   sign-out for scenarios like cloud-managed accounts. But the prohibition
   was applied broadly for all SignOut() calls, leading to weird states
   when sign-out was triggered for internal reasons (e.g. cloud policy
   changes).

These issues came up in planning an analogous API for the new
IdentityManager. This CL implements the proposed fixes
https://docs.google.com/document/d/14esaufZT0fr258zL5I69y7YBBc24XsxtDU0B7wpWxBo/edit#bookmark=id.t69fnqpy377k

Namely:
- Prohibiting sign-out is now up to the SigninClient. SignOut() signals
  the source of the sign-out (user-driven vs internal reasons) and the client
  runs a callback indicating whether the sign-out may continue.
- signin_util::SetUserSignoutAllowedForProfile() chrome/ code
  allow/block user-driven sign-outs.
- Other implementers of SigninClient never block sign-out and are unchanged.

NOTE: For now, signin_util::SetUserSignoutAllowedForProfile() actually
prohibits most non-user-driven signouts to avoid changing sign-out behavior in this
large plumbing CL. This will change in a follow up CL where non-user-driven
sign-outs are always permitted.
https://chromium-review.googlesource.com/c/chromium/src/+/1175797/


Bug: 866518
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I4758706d796f953cbb68ff1b4a0c8d2985d12fb3
Reviewed-on: https://chromium-review.googlesource.com/1162173
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595214}

The WebAudio spec moved the resume method from the BaseAudioContext to
its subclasses AudioContext and OfflineAudioContext.

Update the idl and implementation to reflect this change.  This change
causes the following tests to fail:

AudioContext/audiocontext-properties.html
BaseAudioContext/baseaudiocontext-properties.html
OfflineAudioContext/offlineaudiocontext-properties.html

We remove these tests because they basically duplicate the test in
external/wpt/webaudio/idlharness.https.window.html.

Bug: 889663, 888870
Test: already covered by existing tests
Change-Id: Ic7ed8a5f950e8d069ac7c916d716526f96bf3c18
Reviewed-on: https://chromium-review.googlesource.com/1247703Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595213}

mojo::MakeRequest never fails to create to initialize the InterfacePtr
and it is ok to start using the InterfacePtr before initialization is
complete.
https://cs.chromium.org/chromium/src/mojo/public/cpp/bindings/interface_request.h?l=96-99&rcl=2985a2476a50ee04dbd78b6a0c3228c5f96a2559

Change-Id: Ie5ec84cdcf8896cf646a58aca4ceab8db82eb428
Reviewed-on: https://chromium-review.googlesource.com/1249811Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595212}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/928526013073..6956b3094ad4


Created with:
  gclient setdep -r src-internal@6956b3094ad4

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ie15ea4976a4c890e70b01fcafae4985763fe7843
Reviewed-on: https://chromium-review.googlesource.com/1252344Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595211}

Update storage/browser/quota to use url::Origin to represent origins
rather than GURL. Various bits of chrome/ and content/ reach into
storage/browser, so update those minimally.

As in previous changes for this issue, any calls to origin.GetURL()
are data flowing into a system that needs similar updating. Calls to
url::Origin::Create (outside of tests) indicate data coming out of a
system that needs updating.

Bug: 598424
Change-Id: I8253ec84221c8e4aba50252c291457b28b692b3f
Reviewed-on: https://chromium-review.googlesource.com/1242035
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595210}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/32381e30ef56..ddc705933d3f


git log 32381e30ef56..ddc705933d3f --date=short --no-merges --format='%ad %ae %s'
2018-09-28 stevenperron@google.com Analyze uses for all instructions. (#1937)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@ddc705933d3f

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ib1ef3b27ab19b8f45308dfcb18ad8cdf20017241
Reviewed-on: https://chromium-review.googlesource.com/1252368Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595209}

Using wpt-import in Chromium acc15375.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25464

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: Ib1b59bfb388f27991be43dac5d329204de190c9f
Reviewed-on: https://chromium-review.googlesource.com/1252325
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595208}

Revert "Add QWAVE/DSCP support for unconnected sockets.  Create a helper class for maintaining remote addresses that have been configured for dscp.  Adapted from cl 682456."

This reverts commit 86cf2b47.

Reason for revert: Likely causing build flakiness: https://bugs.chromium.org/p/chromium/issues/detail?id=890293#c2

Original change's description:
> Add QWAVE/DSCP support for unconnected sockets.  Create a helper class for maintaining remote addresses that have been configured for dscp.  Adapted from cl 682456.
> 
> Bug: webrtc:5836
> Change-Id: I2ded915e82a7e967962ff3b1f4027b422d055157
> Reviewed-on: https://chromium-review.googlesource.com/1191925
> Commit-Queue: Tim Haloun <thaloun@chromium.org>
> Reviewed-by: Ryan Hamilton <rch@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594931}

TBR=pauljensen@chromium.org,rch@chromium.org,thaloun@chromium.org

Change-Id: If2502da611962557ecf4eb4da2760860a3c9540a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:5836
Reviewed-on: https://chromium-review.googlesource.com/1252529Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595207}

This CL reverts my recent cleanup changes here:
  https://crrev.com/c/1246826/7/ui/aura/window_targeter.cc#b140
The event target may not be |root_window| nor one of its descendants.

Bug: 890062
Test: Touch input on linux desktop works correctly.
Change-Id: Icf49255b55797488ecc186597de910ecde600efc
Reviewed-on: https://chromium-review.googlesource.com/1251467
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595206}

Follow-up on this CL:
  https://chromium-review.googlesource.com/c/chromium/src/+/1249909

R=piman@chromium.org, oysteine@chromium.org

Bug: 888580
Change-Id: Ia8a6404b7a750f102d224f173abf59c48c5e3b10
Reviewed-on: https://chromium-review.googlesource.com/1251765Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595205}

A CHECK in base::Value::FindKey(..) is hit in a small number of crashes
during shutdown. A check should be in place to make sure the base::Value
instance is in fact a dictionary before calling FindKey(..)

Bug: 890399
Change-Id: I0b24395afc192dbab03f241d94b25309923758d6
Reviewed-on: https://chromium-review.googlesource.com/1252623Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595204}

This reverts commit e392dddd.

Reason for revert:
Follow-up design discussions with dmazzoni and dtseng suggest that
this might not be the right direction to go.

Instead we might want to use AXHostService as the way that both
out-of-process ash and remote app windows/widgets talk to the
browser. We may also have a different mechanism for assigning
AX child tree IDs per-widget.

Original change's description:
> chromeos: Move AXHostService into ash
> 
> This is a step toward supporting multiple remote apps and widgets. We
> need this for browser windows under single-process-mash.
> 
> Under mash the ash process is responsible for top-level window creation
> for remote apps. It will need to route accessibility actions (like hit
> testing) to the correct remote app. Likewise it manages window frames
> and focus. Therefore it should own the mojo AXHostService, not the
> browser.
> 
> Accessibility events from the remote app must be routed out of ash
> into chrome to the accessibility extension. For now we do this with
> the in-process AccessibilityDelegate. I didn't introduce a new delegate
> because the mojo service is lazily created and it's hard to connect
> a new delegate at startup. Subsequent CLs will:
> * Always create the service at ash startup
> * Convert the delegate methods to mojo
> 
> See go/mash-ax-node-tree for the full plan.
> 
> Bug: 888147
> Test: ash_unittests, manually use ChromeVox and STS with shortcut viewer
> Change-Id: Ia9e63689a8cb407b66397778be4617479fdf6c92
> Reviewed-on: https://chromium-review.googlesource.com/1249920
> Commit-Queue: James Cook <jamescook@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594949}

TBR=jamescook@chromium.org,sky@chromium.org,dtseng@chromium.org

Change-Id: I156656b5114a28693308252ee531bbf4c3db867a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 888147
Reviewed-on: https://chromium-review.googlesource.com/1252629Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595203}

Adds a NewTabWithUserActivation method to open a new tab
with a user activation. This means that the page will
behave as if the user has interacted with it and autoplay
will always be allowed.

This CL also tweaks assistant to use it so that it can
open tabs without the autoplay restriction.

BUG=884777

Change-Id: I7c9327b438ac51003442f0e97bd6e63086fb48cd
Reviewed-on: https://chromium-review.googlesource.com/1239543Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595202}

This patch ensures that we don't leak geometry outside of paint
contained element, which may incorrectly affect layout oveflow
of other elements.

Added a WPT with a tall clipped div which causes scrollbars without
this patch, and passes with the patch.

R=chrishtr@chromium.org

Bug: 882322
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I929542d4ad643df8dad1ab388a878bd0892c0c69
Reviewed-on: https://chromium-review.googlesource.com/1246922
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595201}

In practice, Extension objects are pretty much always const. Update
extensions/browser/api_unittest.h to use const Extension objects, rather
than mutable ones.

Bug: 889925
Change-Id: I7e13dac4376eb0e358a30e2fe49154976f02fb0d
Reviewed-on: https://chromium-review.googlesource.com/1252008Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595200}

When undo is pressed on the theme installation info bar the background
should be reset to the selected custom background. To accomplish this
run the same update theme info logic whenever the theme is changed.

Bug: 881750
Change-Id: I1fe5d8d2f8c6d9459a65a4cd801b5583b8f21935
Reviewed-on: https://chromium-review.googlesource.com/1252461
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595199}

Also refactors all FilterGroup contruction out of StreamMixer into a
more focused class.

Bug: 112439135
Test: tuning console
Change-Id: I2c8011a73bdc641eb0b014a18dd3448b6bacb5ed
Reviewed-on: https://chromium-review.googlesource.com/1244608Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Benjamin Shaya <bshaya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595198}

This removes most Token Binding code from chromium. There are a few
places that still have Token Binding references (but will go unused)
that can possibly be removed in the future. These are:
- android_webview/
- net/third_party/quic/
- third_party/tlslite/

There are two UMA histograms in //net that also have TokenBinding in
their name; these are (confusingly) used by Channel ID code as part of
the work on debugging Channel ID mismatches, and can be removed with the
rest of the Channel ID code.

Bug: 875046
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ie3d23f8e9580f2d582febfb04e777006f57baa17
Reviewed-on: https://chromium-review.googlesource.com/1248125Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595197}

Bug: 889346
Change-Id: I44a357c52c0a37064e1bb98bf2cfaef44e60db6b
Reviewed-on: https://chromium-review.googlesource.com/1246947Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595196}

R=chrishtr@chromium.org, pdr@chromium.org, wangxianzhu@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3d4efdc5e5f164cd990f76a8d5f863f3e5db3942
Reviewed-on: https://chromium-review.googlesource.com/1249861
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595195}

For get_characterExtents() at the offset just past the last character,
return bounds equivalent to the caret's bounds if it
placed there, e.g. width of 1, but the same height as the current line.

Bug: 869985
Change-Id: Ib544b863c1fd7ab132dc5ff4ddbeebdde8ed342b
Reviewed-on: https://chromium-review.googlesource.com/1157228
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595194}

In some versions of MacOS, live regions don't work consistently, due to a bug
in those versions of VoiceOver. Due to these bugs, use the announce API when
running on an older version of MacOS.

Bug: 884801,875843
Change-Id: Ia9711cf935ba605785dfb3cfaf32f85bd2c8cf13
Reviewed-on: https://chromium-review.googlesource.com/1228635
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595193}

This CL keeps most usage of the DocumentLoadStatistics struct as a
normal struct and not a *Ptr, since we don't really need nullability.

Bug: 820612
Change-Id: Ib00002d6b5d320fa7bf4341812f3aca26da2e244
Reviewed-on: https://chromium-review.googlesource.com/1214506
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595192}

This change implements the RTCQuicTransport.start() method and
associated events: onstatechange, onerror.

Bug: 874296
Change-Id: I8cb5d525ff5dd9d7d0a07a306f72297febc9aaaa
Reviewed-on: https://chromium-review.googlesource.com/1171904
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595191}

Prior to this patch, IntersectionObserverEntry was reporting
coordinates in device pixels.

BUG=887974

Change-Id: Ic91748cd2eb9b828a787bb4372d5d5b10bcf8cfb
Reviewed-on: https://chromium-review.googlesource.com/1250121
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595190}