- 07 Dec, 2017 35 commits
-
-
Artur Khachatryan authored
Due to a bug fix now we are enabling tests ChromeDriverPageLoadTimeoutTest.testHistoryNavigationWithPageLoadTimeout and ChromeDriverPageLoadTimeoutTest.testRefreshWithPageLoadTimeout. Tests ChromeDriverTest.testDoesntHangOnFragmentNavigation and PageLoadingTest.testShouldBeAbleToGetAFragmentOnTheCurrentPage are now enabled for HEAD but they are disabled for v63 and v64 Bug: chromedriver:2025 Change-Id: I16079017885504c77c0128bc64fefa598cd42e0b Reviewed-on: https://chromium-review.googlesource.com/812148Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#522295}
-
Dmitry Skiba authored
Memory ablation payload is just a single dirty byte in otherwise zero page. The lz4 compression ratio of such page is 151, i.e. the effect of the payload greatly reduces as its pages are moved into zram. This CL fills the payload with random bytes to make sure its effect is not diminished by zram. Measurements on 1GiB Android Go device show that this change increases time spent on touching one chunk (512KiB) by 30% (2.7ms to 3.5ms). Bug: 710048 Change-Id: I1e5cfebb1593bf3c3a917fd40fd689e43a144263 Reviewed-on: https://chromium-review.googlesource.com/809962Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Cr-Commit-Position: refs/heads/master@{#522294}
-
Eric Karl authored
We're hitting scenarios where it appears that we may be creating an EGL window surface for a given window before destroying the previous. This leads to errors on Android, and shouldn't be possible. We're suspecting that someone may be taking a reference on the glSurface, extending the lifetime beyond the expected range. This CL adds logging to catch this scenario. Bug: 787086 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I31bb0c55fb393a0719486f32f885273ee81ab9f8 Reviewed-on: https://chromium-review.googlesource.com/802186 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#522293}
-
Louis Romero authored
The library Motion Transitioning for Objective-C is a new dependency of the Material Components for iOS. Library description: Light-weight API for building UIViewController transitions. Bug: 785248 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifcc89ff8871b1630c7a9feb04c39cc61d9408335 Reviewed-on: https://chromium-review.googlesource.com/803621Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#522292}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f0303631. With Chromium commits locally applied on WPT: 2e6a737d "WPT: Add form-based file upload coverage" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/6982 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=robertma No-Export: true Change-Id: Ie7ffdba0f5344ed20ad1d95cfa3219536c46d8cd Reviewed-on: https://chromium-review.googlesource.com/812150 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522291}
-
Chris Watkins authored
See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I54509993b185fa581ad75c81ee39ece60a8d3ee0 Reviewed-on: https://chromium-review.googlesource.com/789724 Commit-Queue: Chris Watkins <watk@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#522290}
-
Anna Maria authored
Bug: 695937 Change-Id: I9355c99f508f61a3d72156c9bca6cbcb4ed18324 Reviewed-on: https://chromium-review.googlesource.com/812445Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#522289}
-
Peter Collingbourne authored
Make the class StubOfflinePageModel derive from OfflinePageModelImpl. This fixes several test failures where code in offline_page_model_factory.cc expects to be able to cast these objects to type OfflinePageModelImpl. Bug: 469376 Change-Id: I67b2d84cd2e2c549ceaa2bc8708bff478af30bd0 Reviewed-on: https://chromium-review.googlesource.com/812493 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#522288}
-
Carlos Knippschild authored
Bug: Change-Id: I89904bcce184dfb41ef4177b432cd77568caf737 Reviewed-on: https://chromium-review.googlesource.com/812490Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#522287}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/cad08c855e23..409506c4c978 $ git log cad08c855..409506c4c --date=short --no-merges --format='%ad %ae %s' 2017-12-06 mtklein Only look for WinSDK when building _for_ Windows 2017-12-06 angle-deps-roller Roll skia/third_party/externals/angle2/ 378c3a51d..43fd0d44d (1 commit) 2017-12-06 brianosman Reland "Always use the Win 10 SDK, and optionally detect/use the latest version" 2017-12-06 rmistry Revert "Always use the Win 10 SDK, and optionally detect/use the latest version" 2017-12-06 reed upgrade SkReadBuffer to always validate 2017-12-06 egdaniel Add define to use customize vulkan header. 2017-12-06 mtklein remove ThermalManager 2017-12-06 angle-deps-roller Roll skia/third_party/externals/angle2/ 10a4d4346..378c3a51d (1 commit) 2017-12-06 brianosman Always use the Win 10 SDK, and optionally detect/use the latest version 2017-12-06 jcgregorio Move experimental CQ bots to non-experimental. Add 3 more CQ bots as experimental. 2017-12-06 kjlubick Add dimension to differentiate Golo from Skolo for Android tasks 2017-12-06 caryclark Revert "keep SVG arcs axis aligned" 2017-12-06 mtklein add SkVptr() 2017-12-06 brianosman Add win_toolchain_version to support MSVC 2017 Updates 2017-12-06 angle-deps-roller Roll skia/third_party/externals/angle2/ 12a18ad35..10a4d4346 (1 commit) 2017-12-06 liyuqian Test performance of 565 bitmap scaling 2017-12-06 egdaniel Add to blacklist for intel405 vulkan bot 2017-11-29 herb Remove previous blur image implementation. Try 2 2017-12-05 caryclark keep SVG arcs axis aligned 2017-12-06 reed add benchType deserial to time deserializing pictures 2017-12-06 herb Revert "Remove previous blur image implementation" 2017-11-29 herb Remove previous blur image implementation Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: Id3094b9daeed80d93bd84130ed21db9d10807a92 Reviewed-on: https://chromium-review.googlesource.com/812467Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522286}
-
Ted Meyer authored
PA pa_stream_begin_write() allocates a maximum of 8184, which can cause a check fail when the audio-buffer-size is greater than that. To fix this, we just have to write as many as will fit in the allocated space, allocate another space, and write the remainder. BUG=740054 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4effc3a405c1bfe2727a688b237841470dc1efd4 Reviewed-on: https://chromium-review.googlesource.com/809334Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#522285}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/2fb645091977..cc65bd018d54 $ git log 2fb645091..cc65bd018 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If3a77da1717cecea17e0a8317027f116c22a5501 Reviewed-on: https://chromium-review.googlesource.com/812156Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#522284}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/a2299532b526..82cfea0e3cd5 $ git log a2299532b..82cfea0e3 --date=short --no-merges --format='%ad %ae %s' 2017-12-06 spang Fix buffer usage indication when tracing via chrome://inspect?tracing Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I71860a0106e0c6197c5fc74a6c909efebad2dd57 Reviewed-on: https://chromium-review.googlesource.com/812158 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522283}
-
Hitoshi Yoshida authored
We are planning to replace snapshot_blob.bin with v8_context_snapshot.bin. This CL makes media/ code to load v8_context_snapshot.bin to work with it. Bug: 789964, 764576 Change-Id: Idfa5ad0d1407f364430170f485e854413ed8d9f0 Reviewed-on: https://chromium-review.googlesource.com/810326Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#522282}
-
Patti authored
Show the Flash permission always on desktop Page Info. Bug: 791142 Change-Id: I42dd4e856ce0818cea9905e36669a74cc54a6f98 Reviewed-on: https://chromium-review.googlesource.com/809987 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#522281}
-
Ahmed Fakhry authored
BUG=783304 TEST=Maual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idbb42367dd9c55ea5f48d32842bf10bac612fb38 Reviewed-on: https://chromium-review.googlesource.com/812157Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#522280}
-
Hiroshige Hayashizaki authored
- Preparation for removing GetResource() from ScriptSourceCode. - Preparation for removing ExecuteScriptResult. Bug: 788828, 686281 Change-Id: If2b4d1ca3d98a224871df38f6b01723f23cf5132 Reviewed-on: https://chromium-review.googlesource.com/791530 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#522279}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/378c3a51d5f0..43fd0d44d2a6 $ git log 378c3a51d..43fd0d44d --date=short --no-merges --format='%ad %ae %s' 2017-12-06 cwallez Add the EGL_ANGLE_iosurface_client_buffer extension text Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I13167d85ba96f6bb0b330801cb4a88120d1a69c2 Reviewed-on: https://chromium-review.googlesource.com/812115Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522278}
-
Michael McGreevy authored
This uses "install to" instead of "add to" in both the app menu and the confirmation dialog for known-installable apps. The choice of string for the app menu does not block on the installability check, but uses the result of the installability check if available. Bug: 789817 Change-Id: Ic73194b41766f98dfcfdba293b70b56319af9fe3 Reviewed-on: https://chromium-review.googlesource.com/798914 Commit-Queue: Michael McGreevy <mcgreevy@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#522277}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/fd9e0b8f5f92..11506300e6a6 $ git log fd9e0b8f5..11506300e --date=short --no-merges --format='%ad %ae %s' 2017-12-06 hnakashima Fix ps rendering. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I158842a7e3f8b45b19623f5dad9335317338d4e3 Reviewed-on: https://chromium-review.googlesource.com/812221 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522276}
-
Nate Chapin authored
This changes ResourceClient to hold a Member<Resource> as ResourceOwner did. Existing ResourceOwner subclasses can just switch to the appropriate ResourceClient subclass. Classes that were using a ResourceClient directly no longer need to hold their own Member<Resource> and can instead use SetResource/ClearResource/GetResource, implemented in ResourceClient, to manage the resource. Bug: 790778, 652966 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id21231355a12a27e1241c87dbb153c2a8629de8e Reviewed-on: https://chromium-review.googlesource.com/794370 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#522275}
-
Chris Harrelson authored
A filter on a canvas can itself lead to origin tainting, for reasons other than that the canvas contents are tainted. This CL changes to distinguish these two causes, so that we recompute filters on content-tainting change. Bug: 778506 Change-Id: I3cec8ef3b2772f2af78cdd4b290520113092cca6 Reviewed-on: https://chromium-review.googlesource.com/811767Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#522274}
-
Kyle Horimoto authored
The field was erroneously named. The field's meaning actually indicates whether enrollment was done through ARC++. It is possible to have multiple enrollments of a single device: one through native CrOS and one through ARC++. The new name is "isArcPlusPlusEnrollment". Bug: 778026, 672263 Change-Id: I0be749e32e1569602efa30c5a9df768d7a45d15c Reviewed-on: https://chromium-review.googlesource.com/811830Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#522273}
-
Miguel Casas authored
This CL adds |buffer->data_size()| to the decode TRACE_EVENT() in vpx_video_decoder.cc. The addition helps correlating the time it takes to decode with the encoded buffer size; examples of how it looks like: https://i.imgur.com/LUXijLO.png (https://imgur.com/a/1Gllg) or https://i.imgur.com/67QfgKj.png (https://imgur.com/a/3PhQt) Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I240b6f49d61fa385045e3a67fb4fc1e6e4c96fe0 Reviewed-on: https://chromium-review.googlesource.com/812160Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#522272}
-
Matthew Jones authored
This reverts commit cf0d7c2a. Reason for revert: Fix interface impl bug Original change's description: [Home] Separate swipe detecting logic from the bottom sheet This change moves all of the swipe detecting from the bottom sheet into its own class. A relatively simple interface has been introduced to prevent needing the entire bottom sheet to detect swipes. BUG= TBR=tedchoc@chromium.org Change-Id: Ie77d5c2bcec7874787bd23bf347c6abd8716b492 Reviewed-on: https://chromium-review.googlesource.com/812466Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#522271}
-
Christian Fremerey authored
Reland "Reland "Enable video capture service by default on platforms where it is rolling out with M61."" This is a reland of 0fdb7a80 The reason for the second revert was anouther Webkit layout tests failing with this CL. With https://chromium-review.googlesource.com/c/chromium/src/+/811865 landed to fix the test, this CL should now be able to reland without modification. Original change's description: > Reland "Enable video capture service by default on platforms where it is rolling out with M61." > > This is a reland of 1e2e99ef > > The reason for the revert was a Webkit layout test failing with this CL. With > https://chromium-review.googlesource.com/c/chromium/src/+/806442 landed to fix that test, > this CL should now be able to reland without modification. > > Original change's description: > > Enable video capture service by default on platforms where it is rolling > > out with M61. > > > > Bug: 721812 > > Change-Id: I1de0f625a1fb106e2dea664675e94267e66fc2fd > > Reviewed-on: https://chromium-review.googlesource.com/719416 > > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > > Reviewed-by: Emircan Uysaler <emircan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#517761} > > TBR=emircan@chromium.org > > Bug: 721812 > Change-Id: If69cdb660b0b97a28084b6bd0610234d5abb232f > Reviewed-on: https://chromium-review.googlesource.com/809530 > Reviewed-by: Christian Fremerey <chfremer@chromium.org> > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521800} TBR=emircan@chromium.org Bug: 721812 Change-Id: I3287fbfc810caf3d7472c0871a9e0bb73c871841 Reviewed-on: https://chromium-review.googlesource.com/812484 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#522270}
-
Matt Mueller authored
Also renames / removes some X509Certificate methods to make more sense in the use_byte_certs world: os_cert_handle() -> cert_buffer() GetIntermediateCertificates() -> intermediate_buffers() CreateFromHandle() -> CreateFromBuffer() CreateOSCertHandleFromBytes() -> CreateCertBufferFromBytes() CreateOSCertHandlesFromBytes() -> CreateCertBuffersFromBytes() GetDEREncoded() -> x509_util::CryptoBufferAsStringPiece() IsSameOSCert() -> x509_util::CryptoBufferEqual() DupOSCertHandle() -> x509_util::DupCryptoBuffer() FreeOSCertHandle() -> N/A (everything uses bssl::UniquePtr<CRYPTO_BUFFER>) Bug: 769549 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5d94158ea5e7ba5e9e3b9f2f5e76221564c9683b Reviewed-on: https://chromium-review.googlesource.com/775540 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#522269}
-
Doug Turner authored
In this CL, we create a new implementation of NavigationThrottle, called PolicyBlacklistNavigationThrottle in which we call into a policy::URLBlacklistManager implementation during calls to WillStartRequest(). If the requested URL is in the blocklist, we’d return CANCEL otherwise PROCEED. This CL also introduces a KeyedService for accessing the policy::URLBlacklistManager. Bug: 756642 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_site_isolation Change-Id: I2d9ca0982e78b03be191b67e61eea14764150e68 Reviewed-on: https://chromium-review.googlesource.com/745326 Commit-Queue: Doug Turner <dougt@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#522268}
-
W. James MacLean authored
These files appear to have been missing from the BUILD.gn file, and I suspect causing the try-bots not to run tests on CLs that touch them. Bug: Change-Id: I694b759396838498bca6de3550551f1aedba04e1 Reviewed-on: https://chromium-review.googlesource.com/812109Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#522267}
-
Tim Brown authored
This will be the replacement backup way of getting the setting, rather than using the deprecated gconf. I will remove the gconf code in a separate CL. gsettings app to change values and test behavior in chromium. Test: Force use of gsettings for config (see patchset 3) and used Bug: 768027 Change-Id: I957edc5f03c20f42e74d0ba9d1e57a352cc2d418 Reviewed-on: https://chromium-review.googlesource.com/809730Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#522266}
-
Danyao Wang authored
The removed code was originally added to fix a security bug in iOS 9 (crbug.com/610297). The issue seems to be fixed in WKWebView now so this patch is no longer necessary. This is step 2 to removing _lastRegisteredRequestURL from CRWWebController. Bug: 789993,792515,610297 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2eaf5ec47d156ce71d724752fb6d35001c044b3f Reviewed-on: https://chromium-review.googlesource.com/812174 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#522265}
-
Christopher Grant authored
Now that we have element types, we can ditch special-casing and remove a TODO. BUG= R=bshe, ymalik Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I22d00c5722f78da4e3bef92ece25ae3231a67981 Reviewed-on: https://chromium-review.googlesource.com/810926 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#522264}
-
Robert Flack authored
Bug: None Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I18af9c1d0486446d5cb321b1376a233e6b652755 Reviewed-on: https://chromium-review.googlesource.com/806679Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#522263}
-
Francois Doray authored
The NetworkChangeNotifier must be created after TaskScheduler because it posts tasks to it. Bug: 789442 Change-Id: Ie6066064a5f840666160bac76d95ad16d3363708 Reviewed-on: https://chromium-review.googlesource.com/810925Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#522262}
-
Gyuyoung Kim authored
base/memory/ptr_util.h includes are changed with <memory> as well. Bug: 755727 Change-Id: I12c15e3258153550cd11721b32a76519664ba3e2 Reviewed-on: https://chromium-review.googlesource.com/804612Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#522261}
-
- 06 Dec, 2017 5 commits
-
-
Dominick Ng authored
BUG=None Change-Id: I2608465fce0ca012d906f8190da541770c5b44ef Reviewed-on: https://chromium-review.googlesource.com/809915Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#522260}
-
Ilya Sherman authored
R=rdevlin.cronin@chromium.org Bug: None Change-Id: I921fa487be7e8007ef525e8b7f9602bdb64662f3 Reviewed-on: https://chromium-review.googlesource.com/810095Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#522259}
-
Christopher Grant authored
For now, this capability is gated by the keyboard-enabled flag. BUG= Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I050b9dff9552ce3cff6c82f81296f4657d810ccf Reviewed-on: https://chromium-review.googlesource.com/811064 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#522258}
-
Nicolas Pena authored
This CL updates links in some idls so they point to the correct interfaces. Change-Id: I9865ed3c499f8b476b4da1a3acbdc7cd6ae976ea Reviewed-on: https://chromium-review.googlesource.com/802294Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#522257}
-
Maria Khomenko authored
The new metric is called PrivateSwapFootprint. It records the value of VmSwap from /proc/<pid>/status and is available only on Linux and Android. This metric is useful for evaluating changes in swap use with memory ablation. BUG=791802 Change-Id: Ica436198fd00d85cd5f5896ce994547a73aea27f Reviewed-on: https://chromium-review.googlesource.com/807358 Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#522256}
-