GitLab

The latest EME spec has MediaKeys.createSession() return the session
object, and adds MediaKeySession.generateRequest() to actually call
the CDM with the necessary |initData| for the session.

This change also updates the layout tests to match the new way of
creating sessions.

BUG=358271
TEST=updated layout tests pass

Review URL: https://codereview.chromium.org/543173002

git-svn-id: svn://svn.chromium.org/blink/trunk@181765 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357747

Review URL: https://codereview.chromium.org/544443002

git-svn-id: svn://svn.chromium.org/blink/trunk@181764 bbb929c8-8fbe-4397-9dbb-9b2b20218538

String is much more useful, it can be used as key for StringMap.

BUG=

Review URL: https://codereview.chromium.org/556363002

git-svn-id: svn://svn.chromium.org/blink/trunk@181763 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=412027

Review URL: https://codereview.chromium.org/558793002

git-svn-id: svn://svn.chromium.org/blink/trunk@181762 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This path required a connection to the WindowServer, which should be avoided
(see the two bugs for details). Instead this data can be retrieved via the
ColorProfile class, which can access a value that has been cached during
pre-sandbox warmup.

BUG=397642,306348
R=noel@chromium.org

Review URL: https://codereview.chromium.org/554033002

git-svn-id: svn://svn.chromium.org/blink/trunk@181761 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I found that InvalidationLocationChange is a very frequent invalidation
reason for some repaint storms. The invalidation is because the
location (from the paint invalidation container) of the render object
changed since the last invalidation. It will be helpful to know how
the location changes when debugging repaint storms.

Review URL: https://codereview.chromium.org/561443002

git-svn-id: svn://svn.chromium.org/blink/trunk@181759 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As LocalDOMWindow controls the registration lifetime of its
DOMWindowProperties, there's no need to offer a separate unregistration
mechanism. Remove it, simplify notification code + retire now unused
LocalDOMWindow back reference on DOMWindowProperty.

R=haraken,ager
BUG=

Review URL: https://codereview.chromium.org/558213002

git-svn-id: svn://svn.chromium.org/blink/trunk@181758 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The LCD bit is captured in run paints at blob build time, so any
adjustments should be performed at that point. Also, text encoding is
handled similarly, and we don't need to set it on draw paints.

R=jbroman@chromium.org,reed@chromium.org,eae@chromium.org
BUG=412445

Review URL: https://codereview.chromium.org/551183005

git-svn-id: svn://svn.chromium.org/blink/trunk@181757 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Support for CSSPropertyWebkitCursorVisibility has been removed:
https://chromiumcodereview.appspot.com/14612004

Review URL: https://codereview.chromium.org/563553002

git-svn-id: svn://svn.chromium.org/blink/trunk@181756 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=383125

Review URL: https://codereview.chromium.org/464073002

git-svn-id: svn://svn.chromium.org/blink/trunk@181755 bbb929c8-8fbe-4397-9dbb-9b2b20218538

From WebKit legacy we have two redundant copies of this file.
In order for switching shapers on mac, we need to fuse these files again. 
This is part two of the merge,
after the headers were merged in r181655 / ad011a9df.

BUG=334269

R=eae

Review URL: https://codereview.chromium.org/550083005

git-svn-id: svn://svn.chromium.org/blink/trunk@181754 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Prior to https://codereview.chromium.org/403393002, an SVG image which had
no intrinsic size specified, would (somewhat accidentally) get the
<image>'s bounds set as their container size. After said CL, the container
size would never be set, and hence remain as 300x150. This will result in
incorrect scale factors being used when painting, and hence an incorrectly
scaled result.
Revert to setting the <image>'s bounds when the SVG image does not have an
intrinsic size.

BUG=411906

Review URL: https://codereview.chromium.org/551043006

git-svn-id: svn://svn.chromium.org/blink/trunk@181752 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=412027

Review URL: https://codereview.chromium.org/556563002

git-svn-id: svn://svn.chromium.org/blink/trunk@181751 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since jpeg_read_raw_data reads blocks of memory, we have to make sure
that the memory allocated is a multiple of the DCT block size. For
example, if DCTSIZE is 8, which is generally the case, we have to make
sure that the allocated memory to read the raw JPEG data has a width
rounded up to the next multiple of 8 (if it's not already a multiple
of 8) to avoid writing data out of the bounds of the memory. If this
isn't done properly, the end of some decode image lines can overwrite
the beginning of the following lines.

BUG=411189

Review URL: https://codereview.chromium.org/544323002

git-svn-id: svn://svn.chromium.org/blink/trunk@181749 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=408075
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/558243003

git-svn-id: svn://svn.chromium.org/blink/trunk@181748 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dglazkov@chromium.org
BUG=395425

Review URL: https://codereview.chromium.org/558253002

git-svn-id: svn://svn.chromium.org/blink/trunk@181747 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Noticed that it was (in content_shell x64 for Linux) 421 and 425 bytes
which seemed excessive. Just rewrote it a bit to do less work for the
same result.

gcc (not even going to guess why createQualifiedName changed):
---------------------------------------------------------------------------------------------------------------------
 -635 - Source: /home/bratell/src/chromium/src/third_party/WebKit/Source/core/dom/Document.cpp - (gained 8, lost 643)
---------------------------------------------------------------------------------------------------------------------
  Grown symbols:
         +8: WebCore::Document::didChangeVisibilityState() type=t, (was 299 bytes, now 307 bytes)
  Shrunk symbols:
        -64: WebCore::createQualifiedName(WTF::AtomicString const&, WTF::AtomicString const&, WebCore::ExceptionState&) type=t, (was 1112 bytes, now 1048 bytes)
       -579: WebCore::Document::updateTitle(WTF::String const&) type=t, (was 1541 bytes, now 962 bytes)

clang:
  Shrunk symbols:
       -241: WebCore::Document::updateTitle(WTF::String const&) type=t, (was 1124 bytes, now 883 bytes)

Review URL: https://codereview.chromium.org/390003003

git-svn-id: svn://svn.chromium.org/blink/trunk@181746 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181733

BUG=411833
TBR=fs@opera.com

Review URL: https://codereview.chromium.org/552053004

git-svn-id: svn://svn.chromium.org/blink/trunk@181745 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This flag has been stable for over three months, no point keeping it around.

BUG=375171

Review URL: https://codereview.chromium.org/559903002

git-svn-id: svn://svn.chromium.org/blink/trunk@181744 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The left hand icon bar now is drawn through to the bottom of the toolbar, so media queries start at actual zero of the rulers. The vertical ruler had to be enlarged to accommodate.

BUG=411247

Review URL: https://codereview.chromium.org/544013003

git-svn-id: svn://svn.chromium.org/blink/trunk@181743 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Along the way, create BoxDecorationData and BorderEdge classes, to represent classes
that used to be internal to the RenderBox and subclass implementations. Also moves
a couple of methods to RenderStyle that use only style data.

This CL increases the size of RenderBox, RenderTable, Render TableCell and RenderFieldset objects by one pointer,
to accomodate a back pointer from the BoxPainter to the Render object.

BUG=412088

Review URL: https://codereview.chromium.org/550363004

git-svn-id: svn://svn.chromium.org/blink/trunk@181742 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Let TracingManager handle back-end interactions while TracingModel
acts just as a container for trace events. The model will later be
moved out of sdk and this will allow introducing backing storage for
trace events (e.g. a file).

BUG=412709

Review URL: https://codereview.chromium.org/557013005

git-svn-id: svn://svn.chromium.org/blink/trunk@181741 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This allows us to simplify callers by not having a v8::TryCatch there, and
instead only check the ExceptionState object.

Review URL: https://codereview.chromium.org/556273003

git-svn-id: svn://svn.chromium.org/blink/trunk@181738 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patterns have a transformation matrix, which controls how the pattern is used when it is painted. 

Initially, a pattern's transformation matrix must be the identity transform. 

When the setTransform() method is invoked on the pattern, the user agent must replace the pattern's
transformation matrix with the one described by the SVGMatrix object provided as an argument to the method.

Specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-canvaspattern-settransform
IDL Definition: http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting.html#2dcontext:dom-canvaspattern-settransform
Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dUt2_2xn3NU

BUG=289572
R=junov@chromium.org

Review URL: https://codereview.chromium.org/527193002

git-svn-id: svn://svn.chromium.org/blink/trunk@181737 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Spec now allows currentTime to be set when the readyState is still HAVE_NOTHING.
This patch modifies the behaviour in accordance to the spec. The default playback
start position is set to the new currentTime and the resource plays from that point
once it is loaded.
http://www.whatwg.org/specs/web-apps/current-work/#dom-media-currenttime

BUG=399314

Review URL: https://codereview.chromium.org/517593003

git-svn-id: svn://svn.chromium.org/blink/trunk@181736 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This allows developers to pass any combination of plugin flags
without modifying the existing GYP setup. For example,
GYP_DEFINES+="blink_gc_plugin_flags='dump-graph=1 warn-raw-ptr=1'"
will enable both graph dumps and raw-pointer warnings.

R=haraken@chromium.org
BUG=334149

Review URL: https://codereview.chromium.org/551343003

git-svn-id: svn://svn.chromium.org/blink/trunk@181734 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a filter primitive has an 'in' (or, where applicable, 'in2') attribute
that references a non-existent result, treat that reference as having the
default value (==no value) instead of producing an error.
This aligns with Presto and IE.

BUG=411833

Review URL: https://codereview.chromium.org/558693002

git-svn-id: svn://svn.chromium.org/blink/trunk@181733 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Spec: https://svgwg.org/svg2-draft/painting.html#OrientAttribute

BUG=367748

Review URL: https://codereview.chromium.org/539833004

git-svn-id: svn://svn.chromium.org/blink/trunk@181732 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Remove some CSS properties from UseCounters (patchset #1 id:1 of https://codereview.chromium.org/558473002/)

Reason for revert:
We don't want to remove properties that we still support.

Original issue's description:
> Remove some CSS properties from UseCounters
> 
> All of these measure stable features except CSSPropertyWebkitCursorVisibility which
> is actually removed.
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181680

TBR=rob.buis@samsung.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/559073002

git-svn-id: svn://svn.chromium.org/blink/trunk@181731 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL caused memory leaks in content_unittests.
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7259

> Oilpan: Move MediaStreamSource, MediaStreamComponent and MediaStreamDescriptor
> to oilpan's heap
> 
> - MediaStreamSource, MediaStreamComponent and MediaStreamDescriptor must be moved
> to oilpan's heap in one go because their lifetime are tightly coupled.
> 
> - Removed m_descriptor->setClient(0) from MediaStream's destructor. This is OK
> because MediaStreamDescriptor has a strong Member back to the Client
> (i.e., MediaStream).
> 
> - Removed m_component->source()->removeObserver(this) from MediaStreamTrack's
> destructor. This is OK because this CL made the observers weak
> (i.e., MediaStreamSource::m_observers is a hash set of weak members to
> MediaStreamTrack objects).
> 
> - Removed WebMediaStreamTrack::ExtraData::m_owner because it's unused.
> 
> - Introduced MediaStreamComponentDisposer to delay the destruction of
> MediaStreamComponent::m_extraData. The ExtraData is exposed to the web
> and some Chromium objects inherit from the ExtraData. If we clear the
> m_extraData in the MediaStreamComponent's destructor, those Chromium-side
> objects are also destructed in the MediaStreamComponent's destructor.
> This is problematic because the destructors of the Chromium-side classes
> can touch other on-heap objects in the Blink side. To avoid the issue,
> we need to delay the destruction of the ExtraData to thread-specific
> weak processing. The disposer pattern actually makes the deletion of
> the extra data happen earlier and not later. The disposer makes sure
> that the extra data is destructed in weak processing which is run before
> sweeping and therefore all the objects are still alive and can be touched.
> 
> 
> - The same problem arises for MediaStreamDescriptor and MediaStreamSource.
> This CL adds MediaStreamDescriptorDisposer and MediaStreamSourceDisposer.
> 
> - This CL depends on https://codereview.chromium.org/543603003/ and https://codereview.chromium.org/549153002.
> 
> BUG=340522
> 
> Review URL: https://codereview.chromium.org/552653005

TBR=haraken@chromium.org

Review URL: https://codereview.chromium.org/562663002

git-svn-id: svn://svn.chromium.org/blink/trunk@181730 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Enumerations are essentially the same as Strings, but those values
are restricted to specific values. When a value is invalid, we should
throw an exception as the spec requires[1].

[1] http://heycam.github.io/webidl/#es-enumeration

BUG=321462

Review URL: https://codereview.chromium.org/561633003

git-svn-id: svn://svn.chromium.org/blink/trunk@181729 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This affects the 'crossOrigin' IDL attributes in the interfaces
HTMLImageElement, HTMLLinkElement, HTMLMediaElement and HTMLScriptElement,
and is done to match the corresponding specification change:
  http://html5.org/r/8727

The effect is that on setting the IDL attribute to null, the content
attribute is removed (if present) instead of set to the string "null", and
on getting null is returned instead of the empty string if the content
attribute is not present.

BUG=409524

Review URL: https://codereview.chromium.org/529933002

git-svn-id: svn://svn.chromium.org/blink/trunk@181728 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves the single call to ContentSecurityPolicy::completeURL
up from CSPDirectiveList to ContentSecurityPolicy. We now resolve the
URL when sending reports rather than resolving them during parsing. This
allows us to parse a policy without already being bound to an execution
context.

BUG=411889

Review URL: https://codereview.chromium.org/561693002

git-svn-id: svn://svn.chromium.org/blink/trunk@181727 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The current behavior, pseudo classes inside :not() work when they used in the <content select=””> context,  however, it does not satisfy the matching criteria.
This patch reject them.


BUG=389003

Review URL: https://codereview.chromium.org/547363002

git-svn-id: svn://svn.chromium.org/blink/trunk@181726 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=366145

Review URL: https://codereview.chromium.org/557283002

git-svn-id: svn://svn.chromium.org/blink/trunk@181725 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For CSS Animations the name is prefilled with the animation-name. For
Transitions the name is the transitioning property.

BUG=351446

Review URL: https://codereview.chromium.org/535843002

git-svn-id: svn://svn.chromium.org/blink/trunk@181724 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=haraken@chromium.org, mkwst@chromium.org, oilpan-reviews@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/561703002

git-svn-id: svn://svn.chromium.org/blink/trunk@181723 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RenderGrid has several methods that take pointers to RenderBox
instances but the body of those methods assumes that the objects
will never be NULL. We should replace them by references.

Review URL: https://codereview.chromium.org/554293003

git-svn-id: svn://svn.chromium.org/blink/trunk@181722 bbb929c8-8fbe-4397-9dbb-9b2b20218538

FYI: screenshot is available here: https://code.google.com/p/chromium/issues/detail?id=391593#c30

BUG=391593

Review URL: https://codereview.chromium.org/532223002

git-svn-id: svn://svn.chromium.org/blink/trunk@181721 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Updated main.py to support core/modules results.
Moved all current test results into Source/bindings/tests/results/core.
Added TestInterface5.idl to tests/idls/modules and V8TestInterface5.{h,cpp} to tests/results/modules.

BUG=358074

Review URL: https://codereview.chromium.org/557203002

git-svn-id: svn://svn.chromium.org/blink/trunk@181720 bbb929c8-8fbe-4397-9dbb-9b2b20218538