- 20 Jul, 2020 40 commits
-
-
Bettina authored
When the blocklist updates, the blacklist state map may be empty or does not include the remotely disabled extension. This means that not even a "NOT_MALWARE" is sent for the extension. The extension then gets put into no_longer_blocked which is not what is expected. Bug: 1107040 Change-Id: Ia58f0d7b831b54b02843d5c03f9179e84ec11ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305598 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790076}
-
Aaron Tagliaboschi authored
Added an end goal for the UA-CH enterprise policy Bug: 1097951 Change-Id: If54d458a25319de1e2188fee7f6f31e7212dd863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303511Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#790075}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595246042-98b0c1a3c65c5614c7a736e7fb083fada959e352.profdata to chrome-mac-master-1595267899-0b639e1a830eedc083c30d777051dfd02b3a214f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I3ebf0e07e0f0e14c817c145552a21bed9cbc1d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307916Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790074}
-
Yue Li authored
The current implementation of delayed action might bring timing issues: 1. Transiend hold finish 2. The session is resumed 3. Since there is a delayed pause action, the session is suspended imediately after the resume call, which might bring timing issue Also, even if the timing issue did not trigger, the media session will play for a short time before the delayed pause action being executed, which is also not the ideal behavior. Bug: b/138330472 Test: Manual Test Change-Id: I22434b61c83577bcf2ce9769c8ffb5dc17084d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304950Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#790073}
-
Robbie McElrath authored
This CL adds a Browser.setTopControlsMinHeight method, and hooks up WebContentsDelegate::GetTopControlsMinHeight to return it. This also modifies BrowserControlsContainerView to show the real top controls when they're collapsed but a min height is present, as otherwise the bitmap copy of them would still be shown. Bug: 1069498 Change-Id: Ic9a8554ebbbc1d29dc5fa06f84250dadfebe47dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300800 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790072}
-
Anastasia Helfinstein authored
Previously, Switch Access would try to set a listener on the keyboard node, regardless of whether the node was found in the tree. This change checks if the keyboard is found, and if not sets a callback for when the node is found. It also re-orders the calls in enterKeyboard() to reduce the times when focus is drawn back to the text field after it has shifted to the keyboard. AX-Relnotes: n/a. Bug: None. Change-Id: I79663f1bc3297ce8e468e38f0364bd7e3a90f01a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302748 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#790071}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9aece75e2a0b2ac420b91818838d08f92da70720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307488Reviewed-by:
-
Peter Wen authored
Remove //{clank,chrome/browser}* from allowlist now that clank has rolled. Bug: 1082904 Change-Id: I7d5f1694ffa3571579a6723b1f5b84f62eba9899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307730 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#790069}
-
Devlin Cronin authored
Rather than constructing a new vector of strings on each invocation of MimeTypesHandler::GetMIMETypeAllowlist(), use base::NoDestructor<> to cache the result and return a reference. Since this method is called multiple times during hot paths, this helps (a bit). Bug: None Change-Id: Ib3598ee7b0580a266d497ef57177cf0964101f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305005Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790068}
-
Xianzhu Wang authored
This reverts commit 87d25058. Reason for revert: The test is always passing: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests&tests=printing%2Fcomposited-thead-tfoot-repeat.html Original change's description: > Mark printing/composited-thead-tfoot-repeat.html flaky on Mac10.13 > > TBR=wangxianzhu@chromium.org > > Bug: 945085 > Change-Id: Ibfcfb829b51ea4d97b5f65e1a7f6972a808be789 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536565 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#643662} TBR=wangxianzhu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 945085 Change-Id: I5b13bf00edd9a08f4666d90d89c893af28fadc44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307917Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790067}
-
Liquan (Max) Gu authored
Context: When the merchant send a PaymentRequest to the browser, the merchant specifies what additional information (shipping, payer name/email/phone) it requests. On the payment apps side, payment apps specify which delegations they support. The browser as a middleman compares the requested information from the merchant and the supported delegations from the payment apps and decides which payment app can supports all requested delegations (aka full delegation), which app can support only part of the delegations (aka partial delegation). Before: For those partial delegations, the browser used to prompt users to input shipping addresses or contact info. After: * When the feature EnforceFullDelegation is enabled, for those apps with partial delegations, the browser will treat them as invalid apps - hiding them from the payment app list in the payment sheet. This applies for both Android payment apps and sw payment apps. For Android payment apps, an error will be logged in logcat; for SW payment apps, no error message would be logged yet (crbug.com/1100656). * Although the flag is default to disabled, the Android Apps that support the play billing method will be treated like the full delegation is enforced. * When disabled, the old behaviour remains. Affected: Android Payment Apps, Service Worker Payment Apps Change: * Add a flag: EnforceFullDelegation (default to disabled) * payment apps with the app store billing methods bypasses the flag with the enforcement behaviours. * Not to show a Android or SW Payment Apps in the payment sheet when the app does not support full delegation. Bug: 1095821, 1103695 Change-Id: I99023ed3383b53b5e3c006925b3f4cd032808e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260956Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#790066}
-
zhaoyangli authored
Disabled 2 tests failing in downstream builder. Bug: 1106996, 1106997 Change-Id: I96f0d9197e4242587b667b271cc9d51ba50c0b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305123Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#790065}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9e46bb61c5d7..5efa529cc107 2020-07-20 amaiorano@google.com Update to latest PowerVR to keep cmake source clean If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I1ad3b483390b5105b199b2f1590412dc85ea5a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307420Reviewed-by:
-
Yuwei Huang authored
This CL adds a stream request parser to parse StreamBody messages sent by a server that handles protobuf over HTTP. It will later be used by ProtobufHttpClient to handle stream request. It also makes ProtobufHttpStatus something similar to grpc::Status, that has a unified code and message, as the error code can now come from three different places. Bug: 1103416 Change-Id: I62c4d9c74cc17a9b10244fa1013372308ec9d4a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305113 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#790063}
-
Mehran Mahmoudi authored
This makes all Views added through TabViewManager explicitly focusable. On some versions of Android, these views were not focusable by default and this led to an issue where the omnibox gained focus after a View was added and it never releases the focus. Bug: 1081628 Change-Id: Ifb272500a274dfd64f432650a567ce20881e6c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307536Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#790062}
-
ckitagawa authored
If scaling + scrolling happened in parallel there were some issues with double-buffering. This CL fixes that by - Early exiting PlayerFrameMediator#updateVisuals if in the middle of a scaling. - "Locking" the visible state to prevent new bitmaps from being requested. This CL also improves the logic for tracking the first set of bitmaps to prevent a scenario where swapping never happens. Bug: 1099722 Change-Id: Ibacffadf5690b69fb79dd872562fd84da175780a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307440Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#790061}
-
Mitsuru Oshima authored
instead of using mask layer Bug: 1107106 Change-Id: Ie10dc48e4ca130ccfa6736f6aa45dd49639cfb25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306209Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#790060}
-
Adlai Holler authored
This is part of a larger effort to require users to provide the GrDirectContext when manipulating GPU images, rather than having the images themselves own pointers to the context. See bug for details Bug: skia:104662 Change-Id: If7cffbc980a4a72a9d338a849582d74f1946387e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307531 Commit-Queue: Adlai Holler <adlai@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Auto-Submit: Adlai Holler <adlai@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#790059}
-
John Williams authored
Re-land (with fixes) of commit 3fd89cb3, reverted by 186d7133. Bug: 796717, b/149843583 Change-Id: I9b063e2bbbbbef4985f7bb186dfe6910867c995d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285333 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Doug Steedman <dougsteed@chromium.org> Cr-Commit-Position: refs/heads/master@{#790058}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4181.3-1594633354-benchmark-86.0.4206.0-r1 to 86-4183.25-1595237914-benchmark-86.0.4207.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If0eda0d98bffc39f8d0bf06c68fa95791084ff25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308350Reviewed-by:
-
Marc Treib authored
The directory was recently deleted (crrev.com/c/2274884). Bug: 1099672 Change-Id: I5e724a2251654899c8fd861f8796de07d17359b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297640Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#790056}
-
Sammie Quon authored
In cros, normally overview related, we apply transforms on an anchor widget (normal the browser). The browser may have a number of transient bubbles associated with it. The transient bubbles get transformed to the correct locations on entry, but when the anchor widget's bounds update, we query the new transient bubbles bounds (and will transform). The transient bubbles bounds include the transform of their anchor, (GetAnchorBoundsInScreen()) applies transforms from descendants, so their offset by the anchor widget's translation. To counter this, undo the translation of the anchor widget when fetching the anchor rectangle. Easiest way to repro is by forcing the crash bubble to always show, then entering overview and rotating the chromebook. For a browser sized 1600x800 with anchor rect say 1500,0, after entering overview, the browser has a translation of 100,100. After rotating, the browser is sized 800x1600 and the anchor rect will be 800,100. On exiting the bubble correctly relocates and the anchor rect is seen to be 700,0. Test: manual Change-Id: Ie732e95e9b353cccfb7ae7158b6842596467d284 Fixed: 1004238, 1001039, 920134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305067 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#790055}
-
Mohamed Amir Yosef authored
This CL makes CredentialManagerImplTest paramtereized to make sure they pass when the the account storage feature is enabled. This uncovered some bug where the http-->https was invoked twice. Bug: 1093286 Change-Id: Ieb8db5de2d5f19c144b14cb72797d70888fa2b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307255 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#790054}
-
Darwin Huang authored
Sheriffs correctly disabled these Clipboard API Feature Policy tests, that were failing on same-origin iframes not getting focus quickly enough on MacOS. That said, while this issue wasn't completely expected, we did know of an underlying issue that could lead to this, so move these 2 test failures to be grouped with related cross-origin failures. These test failures are due to focus() on Chrome not being synchronous, as specified. These tests are not being immediately fixed, as the synchronous focus() not existing on Chrome is not specified, so we shouldn't add waiting for this async focus behavior until either: (1) this is specified (hopefully this will happen), or (2) focus() is sync on Chrome (unlikely given cross-origin security) Bug: 1104125, 1105278 Change-Id: I91cc3c20eb7af4357669548e906bf0b7fc7f0298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303286 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#790053}
-
Vikas Soni authored
Add capability to use SharedImageInterface to SyncTokenClientImpl. Bug: 1091945 Change-Id: I215fc72d0610eb64fe4c764099b97f8ff960b0ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307353Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#790052}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1dcc3cfc0639..3c13bf1fa865 2020-07-20 treehugger-gerrit@google.com Merge "Deploy release by default" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2d6831f1bf01b9c03888a3bb13c2b7ffafc06ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307642Reviewed-by:
-
Mohamed Amir Yosef authored
This CL makes sure the account store opt-in flow isn't triggered upon password update even if the user hasn't opted in yet. Bug: 1107384 Change-Id: I35c0bb359af3ca5ed7cc33b74d052fd7cd769b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306092 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
dpapad authored
Specifically: - basic_plugin_test - beep_test, nobeep_test - title_test, whitespace_title_test Bug: 1000989 Change-Id: I43baab0c538bc106ac68e6ec88908053ed290f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303430 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790049}
-
Xianzhu Wang authored
This is a part of the work of removing DisplayItemClient::VisualRect() which is an obstacle of integrating FragmentData with LayoutNGBlockFragments. This CL calculates visual rects for inline boxes during paint. Bug: 1104064 Change-Id: Ibdc332d33925979234dbef6b1aa0a7795d577093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300996Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790048}
-
Nate Fischer authored
This amends documentation to mention CTS generally requires the en-US locale. This is actually a requirement for WebSettingsTest#testAccessAllowFileAccess(), and it's probably worth calling out explicitly since some of the WebView team are based in the United Kingdom (and en-GB is *not* compatible). For more context, see https://android-review.googlesource.com/c/platform/cts/+/1363422 Test: Upload to gerrit > open file > click "gitiles" Change-Id: I4d8f197d9cf2ed259a3757650d042725448f2a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304555 Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#790047}
-
Eugene But authored
The fix was copied from context_menu_egtest.mm which is to add a matcher for context menu button. Bug: 1106739 Change-Id: I1e89c3ccbc081aa0ff254a0a8bef535ed02054a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304963 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#790046}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4ed789b24fc7..ade0fed37fc7 2020-07-20 dproy@chromium.org metrics: Add diagnostics to console error metric If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1086962 Tbr: sadrul@google.com Change-Id: Ia3224efc4ddb7cd71e43a92bb2d83a7bf793432a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307652Reviewed-by:
-
Jan Wilken Dörrie authored
This change prolongs a few Password Manager histograms that are about to expire in M86. Furthermore, it swaps the roles of jdoerrie@ and battre@ of primary and secondary owner where appropriate. Fixed: 1104973, 1104967 Change-Id: Idccd646d7a857fa4c59baff7d83b400164e07c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307789 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#790044}
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: Ib7ccb4c10429d8d7b270fc0ec3d045e26e4ddeba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293376Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#790043}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/92ebe87b74f1..3ed44f56c5bf 2020-07-20 cwallez@chromium.org dawn.json: Noop argument rename for mapAsync If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I8c08dfc22196f6627b76778aa7f73a175e3b28d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307641Reviewed-by:
-
arthursonzogni authored
After the refactoring: https://chromium-review.googlesource.com/c/chromium/src/+/2251999 The path for executor.html from property.https.html was incorrect. This patch fixes it. Bug: chromium:1090273 Change-Id: Ie6384ff1cd8d5227e65130ff6ab291f1c09769b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306098 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#790041}
-
Dominique Fauteux-Chapleau authored
Bug: 1102530 Change-Id: I89feec186c7e8636374100e6c4f94b14b4b8ae59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302928Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
-
Julian Mentasti-Meza authored
Bug: 1103776 Change-Id: I5b52e9aa2c7250faf396393a776ce5484f68fa60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290778 Commit-Queue: Julian Mentasti-Meza <jmentasti@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#790039}
-
Evan Stade authored
Bug: 1107361 Change-Id: I6e5413b8c717690d04a078001ed93b61a64447b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307691Reviewed-by:
-
Andy Lu authored
Make search in chrome accept a string input that will be searched in any search engine of user's choice Bug: 1106922 Change-Id: I4bb79e8f0d77b04d1cf79cda83cbe87fe00eabb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297731 Commit-Queue: Andy Lu <andyhylu@google.com> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#790037}
-
