GitLab

Now the feature is approved to roll out into Stable channel,
let me flip the feature flag to be enabled by default.

This is a required process to launch the feature through the field study,
and should be done before the feature is rolled out to 100%.

BUG=591245

Review-Url: https://codereview.chromium.org/2296603002
Cr-Commit-Position: refs/heads/master@{#415569}

This CL makes SharedBuffer in Resource non-discardable (i.e. replaces
SharedBuffer::createPurgeable() with SharedBuffer::create()), as we no longer
have SharedBuffer::lock()/unlock() after
https://codereview.chromium.org/2253853002/.

After that, all SharedBuffers are non-purgeable, and thus this CL makes
SharedBuffer always non-purgeable by replacing PurgeableVector in SharedBuffer
with WTF::Vector.

BUG=603791

Review-Url: https://codereview.chromium.org/2247073007
Cr-Commit-Position: refs/heads/master@{#415568}

BUG=545318

Review-Url: https://codereview.chromium.org/2222863002
Cr-Commit-Position: refs/heads/master@{#415567}

Using new WinRT APIs introduced since SDK version 10.0.10240.0 to replace legacy
WinMM APIs on Windows 10.

Note: the new implementation is currently enabled by setting a compile-time flag
(midi_winrt); since we distribute same binaries for all Windows versions, we
should include both implementations in the build and use a runtime flag for
enabling the new one.

BUG=512433
R=toyoshim@chromium.org

Review-Url: https://codereview.chromium.org/2243183002
Cr-Commit-Position: refs/heads/master@{#415566}

Add check that tests client is not suspended. If not,
OnSensorReadingChanged is called on that client.

Review-Url: https://codereview.chromium.org/2297593002
Cr-Commit-Position: refs/heads/master@{#415565}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/af009a36..8b4e1a30

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2291123005
Cr-Commit-Position: refs/heads/master@{#415564}

* win: Members of base classes now should show up in debugger.
* win: Debugger shouldn't show funny highlights anymore due to
  debug info no longer including column information.  (we still
  force this on if sanitizers are used, mostly for clusterfuzz.
  maybe we want to make this toggleable independent of sanitizers
  at some point)
* win: -Wextern-initializer no longer warns on midl-generated code
* win: clang-cl now accepts /source-encoding:utf-8 and friends
  (utf-8 was the source enconding in clang-cl before already, but
  now we don't warn on an explicit flag requesting this)
* all platforms: Three plugin checks are now on-by-default,
  remove flags for these (see
    https://codereview.chromium.org/2267713003
    https://codereview.chromium.org/2268203002
    https://codereview.chromium.org/2265093002
  )
* win: clang-cl's /Brepro now does what it's supposed to do
* win: clang-cl now emits absolute paths in diagnostics, by
  popular request.

Ran `tools/clang/scripts/upload_revision.py 280106`.

BUG=640254,637456,636109,636091,636099

Review-Url: https://codereview.chromium.org/2292173002
Cr-Commit-Position: refs/heads/master@{#415563}

This patch converts "editing/selection/replace-selection-1.html"
to use w3c test harness to simplify test script for improving readability, and
rename to "editing/inserting/insert_html_to_replace_selection.html" since this
test tests "insertHTML" command instead of selection itself.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2290143002
Cr-Commit-Position: refs/heads/master@{#415562}

Even though the metrics that we have aren't ideal quite yet (total
energy consumed, average power draw), we still want system health
benchmarks running ASAP in order to prevent major regressions.

We discussed having two runs of the system health benchmarks:
memory and non-memory, with memory being isolated due to its high
overhead. At least for the time being, that's not possible with power
benchmarks because we need to decide in the benchmark constructor
whether to enable BattOr tracing, even though we don't have any ability
to know whether a BattOr is attached. Because of that, we're forced to
disable the test on any devices without BattOrs in the @ShouldDisable
predicate.

BUG=637158,589726
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2239053003
Cr-Commit-Position: refs/heads/master@{#415561}

This adds NamedPlatformHandle, which represents a named pipe - a path to
a unix domain socket on POSIX or a pipe name on Windows - and
CreateServerHandle and CreateClientHandle which create server and client
ScopedPlatformHandles, respectively, from a NamedPlatformHandle. This
also changes ChannelPosix to support unconnected server sockets created
by CreateServerHandle.

BUG=604282

Review-Url: https://codereview.chromium.org/2282413004
Cr-Commit-Position: refs/heads/master@{#415560}

BUG=598051
TBR=senorblanco@chromium.org,wkorman@chromium.org,pdr@chromium.org

Review-Url: https://codereview.chromium.org/2289123004
Cr-Commit-Position: refs/heads/master@{#415559}

Since GlDisplay already triggers an onCanvasRendered() event, TouchInputHandler
just simply needs to listen to that event decide what to do inside its scope.
This CL moves the setAnimationEnabled logic into TouchInputHandler since
DesktopView doesn't need to do anything in this process.

BUG=641123

Review-Url: https://codereview.chromium.org/2281983004
Cr-Commit-Position: refs/heads/master@{#415558}

This CL remove debugPosition() functions for Position, VisiblePosition, and
VisibleSelection. showTree*() functions are usually enough.

This CL doesn't affect production.

Review-Url: https://codereview.chromium.org/2291423002
Cr-Commit-Position: refs/heads/master@{#415557}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/314ef813f4cf2f862b33e9b2a9796c0df17a7ccb Explicitly set is_component_build = false for standalone pdfium. (thestig@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2298073002
Cr-Commit-Position: refs/heads/master@{#415556}

Currently, any force installed extension attempts to reload after 3s. We're currently seeing an uptick in extension process crashes -- please see BUG for details.

This is a short term fix, which will mitigate crash loops for component extensions. Any extensions that are policy-enabled will still be reloaded after 3s. We avoid using exponential backoff for policy-installed extensions since this can allow users to kill the extension multiple times, effectively disabling it.

This patch adds tracking for BackoffEntry objects corresponding to each component extensions that attempt to reload. The backoff policy values are similar to the extension check update's backoff policy.

BUG=639104

Review-Url: https://codereview.chromium.org/2281323002
Cr-Commit-Position: refs/heads/master@{#415555}

This is after MacOSX switches to core prpfile

BUG=635081
TEST=Mac gpu bots
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2293313002
Cr-Commit-Position: refs/heads/master@{#415554}

To prevent changes there from breaking Android gpu.fyi bots.

BUG=626498
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2297083002
Cr-Commit-Position: refs/heads/master@{#415553}

This patch converts "editing/deleting/merge-paragraph-into-pre.html" to use w3c
test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2289093002
Cr-Commit-Position: refs/heads/master@{#415552}

Revert of Move DIP scale away from AwContents (patchset #2 id:20001 of https://codereview.chromium.org/2288273003/ )

Reason for revert:
Android build failure.
https://build.chromium.org/p/chromium/builders/Android/builds/61497/steps/compile/logs/stdio

Original issue's description:
> Move DIP scale away from AwContents
>
> This small refactoring removes device scale factor from AwContents
> cache and uses the value from ContentViewCore.
> The device scale factor in ContentViewCore is defined after
> ContentViewCore native initialization, therefore this CL also
> moves the device scale propagation until after that.
>
> This is a prerequisite for https://codereview.chromium.org/2300463002
>
> BUG=632461
>
> Committed: https://crrev.com/8d849fd2d39c9db747f4e8d89dcedfebb0273a97
> Cr-Commit-Position: refs/heads/master@{#415546}

TBR=boliu@chromium.org,sievers@chromium.org,timav@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=632461

Review-Url: https://codereview.chromium.org/2297603004
Cr-Commit-Position: refs/heads/master@{#415551}

Cr-Commit-Position: refs/heads/master@{#415550}

This lets us avoid all of the string copies and externalization costs for the
key names when getting properties.

BUG=615174

Review-Url: https://codereview.chromium.org/2285183005
Cr-Commit-Position: refs/heads/master@{#415549}

BUG=641851
R=dgozman

Review-Url: https://codereview.chromium.org/2297443002
Cr-Commit-Position: refs/heads/master@{#415548}

BUG=641643
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2291753002
Cr-Commit-Position: refs/heads/master@{#415547}

This small refactoring removes device scale factor from AwContents
cache and uses the value from ContentViewCore.
The device scale factor in ContentViewCore is defined after
ContentViewCore native initialization, therefore this CL also
moves the device scale propagation until after that.

This is a prerequisite for https://codereview.chromium.org/2300463002

BUG=632461

Review-Url: https://codereview.chromium.org/2288273003
Cr-Commit-Position: refs/heads/master@{#415546}

EventListeners array hold references to the objects which
they were listening to, preventing them from being
cleaned up.

BUG=none
R=dgozman

Review-Url: https://codereview.chromium.org/2298473003
Cr-Commit-Position: refs/heads/master@{#415545}

As CachedMetaData::m_serializedData is set only at the initialization timing,
we can call Vector<char>::reserveCapacity to save memory consumption without
loosing performance.

This CL includes other cleanups:

 - Renaming methods,
 - Replacing error handling logic with DCHECKs,
 - Replacing unsigned with uint32_t.

BUG=636462

Review-Url: https://codereview.chromium.org/2258743002
Cr-Commit-Position: refs/heads/master@{#415544}

- Adds a bunch of conversion functions between physical and logical offsets and sizes.
- The NGAlgorithm now outputs a NGPhysicalFragment (NGFragment output doesn't make sense in this instance as would immediately get unwrapped and destroyed).

BUG=635619

Review-Url: https://codereview.chromium.org/2282213002
Cr-Commit-Position: refs/heads/master@{#415543}

WebView's text selection handles(TouchHandleDrawables) should be
notified when their container view gets swapped out to be
repositioned accordingly. This is now being done through
|ContainerViewObserver| in |ContentViewCore| which is slated for
removal as a part of content layer refactoring.

This CL makes use of a new interface method in
|SynchronousCompositorClent| to let AwContents manage the handles
directly, and notify them of the event of the container view switching.

BUG=624977

Review-Url: https://codereview.chromium.org/2263043002
Cr-Commit-Position: refs/heads/master@{#415542}

This patch:
- introduces WI.IsolatedFileSystemManager.fileSystems() method. This allows
  to avoid type casts.
- splits out WI.NetworkMapping._addMappingsForFileSystem to avoid creating
  artificial event.

BUG=none
R=dgozman, pfeldman

Review-Url: https://codereview.chromium.org/2295693003
Cr-Commit-Position: refs/heads/master@{#415541}

Revert of Clean up paint expectations. (patchset #2 id:20001 of https://codereview.chromium.org/2286393002/ )

Reason for revert:
In spite of the CL description this CL changes the expectation.

Original issue's description:
> Clean up paint expectations.
>
> No change, just re-ordering.
>
> TBR=chrishtr@chromium.org
> BUG=636475
>
> Committed: https://crrev.com/079b912c02a8838fbf2f246c3215d359d50df7a5
> Cr-Commit-Position: refs/heads/master@{#415422}

TBR=chrishtr@chromium.org,schenney@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=636475

Review-Url: https://codereview.chromium.org/2299503002
Cr-Commit-Position: refs/heads/master@{#415540}

Review-Url: https://codereview.chromium.org/2295673002
Cr-Commit-Position: refs/heads/master@{#415539}

Highlight JavaScript booleans, null, undefined, etc as pink

BUG=none

Review-Url: https://codereview.chromium.org/2294113002
Cr-Commit-Position: refs/heads/master@{#415538}

This CL makes mojo::Watcher run on the correct task runner instead of the
default task runner of the main thread.

BUG=603396

Review-Url: https://codereview.chromium.org/2274833002
Cr-Commit-Position: refs/heads/master@{#415537}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/4d356cb6646e17da23a490ec3b1dea4577e24283 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/06e2710700b619355253228d7c2caa1bc76e13bc Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
recipe_engine:
  https://crrev.com/a93ebc8b69c18bce873f4df1979b6534f3c13e68 Organize environment whitelist, add PYTHONUNBUFFERED. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=635641

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2289303003
Cr-Commit-Position: refs/heads/master@{#415536}

Remove abstraction for PlatformKeyboardEvent and use WebKeyboardEvent
directly inside core.

BUG=625684

Review-Url: https://codereview.chromium.org/2290313002
Cr-Commit-Position: refs/heads/master@{#415535}

BUG=493815
R=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2293833003
Cr-Commit-Position: refs/heads/master@{#415534}

Some gl functions have not been bound,if no context created before.

BUG=

Review-Url: https://codereview.chromium.org/2273483004
Cr-Commit-Position: refs/heads/master@{#415533}

Currently, if CreateBlimpContents() is called more than once, multiple
BlimpContents are created with the same kDummyTabId. In this CL,
1. BlimpContentsManager will return nullptr if CreateBlimpContents() is
called when there's an existing BlimpContents.
2. If BlimpContentsManager returns nullptr, BlimpClientContextImpl won't
set the delegate.
2. TabBlimpContentsObserver won't be added in Tab.java

BUG=642216

Review-Url: https://codereview.chromium.org/2299453002
Cr-Commit-Position: refs/heads/master@{#415532}

Revert of Switch context_lost test to gpu_integration_test harness. (patchset #4 id:60001 of https://codereview.chromium.org/2297623002/ )

Reason for revert:
Broke context_lost tests on Android as seen on https://build.chromium.org/p/chromium.gpu.fyi/console .

Original issue's description:
> Switch context_lost test to gpu_integration_test harness.
>
> BUG=352807
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> TBR=zmo@chromium.org
>
> Committed: https://crrev.com/d89cde2c1cfa24e74c97efa88170ed80637f2ae5
> Cr-Commit-Position: refs/heads/master@{#415456}

TBR=zmo@chromium.org,vmiura@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=352807

Review-Url: https://codereview.chromium.org/2292323003
Cr-Commit-Position: refs/heads/master@{#415531}

type_traits adds std::is_arithmetic which is used in
safe_conversions_impl.h, however this header was not
included.

This is reported as an error by flycheck-clang (using my
system clang version 3.4, system headers, and --std=c++1y),
and is causing every source file that has
safe_conversions_impl.h as a dependency (about 13,000 of
them) to fail to syntax check anything after the include.

Review-Url: https://codereview.chromium.org/2295903002
Cr-Commit-Position: refs/heads/master@{#415530}