- 11 Jun, 2020 40 commits
-
-
Lan Wei authored
Because of Linux memory leak, pointerevent wpt tests pointerevent_boundary_events_at_implicit_release_hoverable_pointers.html pointerevent_releasepointercapture_onpointerup_mouse.html and pointerlock/pointerevent_pointermove_on_chorded_mouse_button_when_locked .html are flaky, we should finish the test in the actions promise's callback to guarantee the actions are all executed before the test finishes to avoid memory leak. Bug: 998948, 1025944 Change-Id: I1ba6cbd8029a6093eefc29c287af86c80cb45ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203144 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#777464}
-
Piotr Bialecki authored
Anchor creation based off of hit test result was incorrectly using unstable native origin (planes' origins may change diametrically from frame to frame) - this CL fixes the issue. Additionally, hit test logic did not correctly treat hit test results as computed based off of plane intersection - the issue did not cause any problems with hit test API, but is problematic for anchor creation API. Changes: - plane-attached anchor creation now accepts native origin information and pose relative to passed in native origin - this is done to ensure that anchor creation uses a frame of reference that is stable w.r.t. the environment (plane pose is not a correct choice as it changes when plane extents are changing) - fixed an issue in ArCoreImpl::RequestHitTest() - it would not report results as computed based off of a plane even if they were - mojom's hit test result now uses pose instead of matrix - pose is directly provided by ARCore SDK and has smaller cognitive load as it does not require considering column-major vs. row-major memory layouts - IDL - anchor creation based on hit test result and on plane no longer accepts initial pose since the spec draft has changed - initial pose was considered confusing and unnecessary since it did not extend the capabilities of the API - JS-exposed anchor creation from XRHitTestResult and from XRPlane no longer accepts an XRRigidTransform - the spec draft was already changed to account for this All other changes (parameter renames, comment updates, fixing call sites to account for parameter count changes, etc.) are related to the above major changes. Change-Id: I5acb872c5a9d9003f1f85173edd82e6e6fa002bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236592 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#777463}
-
David Black authored
Previously, if the AssistantBetterOnboarding feature was enabled, the onboarding view was always shown. In a follow up CL, we will only conditionally show the onboarding view, and otherwise showing our greeting. This CL prepares for that. Bug: b:157689497 Change-Id: Ice53901c04c35170f106b0acc3230072f2608839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240019 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#777462}
-
Eugene But authored
This is a follow up cleanup which will allow removing some GN targets. Original CL broke downstream chrome for iOS tree. A change has been landed downstream to prevent the breakage after reland: https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/3102155 Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2232862 TBR: yuweih@chromium.org Bug: 1017165 Change-Id: Ibc8504b9077c59a4cb1da5fbe746106758fdcaf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241336 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#777461}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/36248741c28b..88183900a5bd 2020-06-11 johnstiles@google.com Honor return value of `registerChildProcessor` when creating child FPs. 2020-06-11 egdaniel@google.com Fix calling finishedProcs that are null in backend surface APIs. 2020-06-11 fmalita@chromium.org [skrive] Initial binary reader plumbing 2020-06-11 ethannicholas@google.com Fixed SkSL optimization issue 2020-06-11 bungeman@google.com Delete .a file before writing static library. 2020-06-11 johnstiles@google.com Fetch clang-format automatically when compiling .fp files. 2020-06-11 michaelludwig@google.com Implement computeFastBounds in SkLocalMatrixImageFilter 2020-06-11 herb@google.com move test op creation to GrTextAtlasOp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: Id75d9f102e55ee8ce4a44fbbb51017ee2cd18f3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241919Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777460}
-
Lei Zhang authored
Extend PrintPreview.DestinationAction and PrintPreview.PrintSettingsUi histograms since they remain useful. Add a second owner. Bug: 1089322 Change-Id: I558150b2700c21e81a559ea334b63aa4f662e854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239200Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#777459}
-
Jonathan Ross authored
FrameTokenMessageQueue is setup to kill misbehaving Renderer processes, when frame submission happens out of order. This has typically been a side effect of other more serious bugs, and used to help identify the cause. However FullscreenInteractiveBrowserTest.NotifyFullscreenAcquired has been flaking with this failure. In order to get a better idea of what is the cause I'm looking to add extra stateful info, along with two earlier DCHECKs. I'm also re-enabling the test in order to get reproductions, as I haven't been able to reproduce locally. TBR=ellyjones@chromium.org TEST=FullscreenInteractiveBrowserTest.NotifyFullscreenAcquired Bug: 1087744 Change-Id: I470c33e3ca1c76abd810d551bf02dcfc9a0eaa51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239677Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#777458}
-
siashah authored
Screenshot: https://screenshot.googleplex.com/q2i5yz96Opg Bug: 1093612 Change-Id: I9af01375b287d9856bdee0740895a786ce04ca70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240262 Commit-Queue: Siddharth Shah <siashah@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#777457}
-
Dale Curtis authored
Code has been sending this histogram for some time, but we didn't have a histogram entry for it. Bug: 1073252 Change-Id: I56f3a58c5e9b65687d44d2f940aaeaa75c86e7ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240447 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#777456}
-
Stefan Zager authored
BUG=1092673 R=pdr@chromium.org Change-Id: Ie7ca01a0d35974c342b4e013ab63b2f95e6c8189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236755Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#777455}
-
David Black authored
Previously the greeting was only shown on view creation, but the AssistantOnboardingView is only created once. By the time the view is shown, the greeting may be stale. Bug: b:157689497 Change-Id: I3d1e9fe325efbeda8d92ac4534762fc421ff7a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239980 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Nina Satragno authored
Fix two issues that can break WebAuthn when the virtual authenticator environment is enabled: * CaBLE discovery should only be available if a CaBLE flag is set. * Move the Bluetooth Low Energy platform support check to FidoRequestHandlerBase and FidoDiscoveryFactory. This prevents us from trying to manage bluetooth on devices that may not support it when the virtual authenticator environment and CaBLE flags are enabled. Fixed: 1090475 Change-Id: I01836ac3dffabfeb51835505d15d9c8a805c7028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232760 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#777453}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c532354149c5..e73f278c09bc 2020-06-11 engeg@google.com packages: remove manifest from virglrenderer uprev 2020-06-10 vapier@chromium.org pformat: convert various json dump logic to new helper 2020-06-10 richardfung@google.com Remove betty-arcvm-pi 2020-06-10 mmortensen@google.com BuildAPI: Have GetBuilderMetadata handle find_fingerprints return []. 2020-06-10 vapier@chromium.org pformat: add json formatter 2020-06-10 saklein@chromium.org sdk: Remove explicit clean from sdk.delete 2020-06-10 sammc@chromium.org Enable HW tests for Puff. 2020-06-10 dhanyaganesh@chromium.org TestPlanStage: bug in logs printed 2020-06-10 navil@google.com cbuildbot: Only send notifications for master branch. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I1bb6311a4f30f56da2f33ad8f26f438c46ea0e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241722Reviewed-by:
-
Mark Brand authored
Since the addition of the MojoLPM fuzzer generators, when visibility has been granted for a single mojom target, it also needs to be granted for the resulting _mojolpm target. Bug: 1093408 Change-Id: Ie2dd792e65eb84a444aaa0b4fcc8457660111838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241651 Commit-Queue: Mark Brand <markbrand@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#777451}
-
Jazz Xu authored
This CL fix the issue where the overlay notification not resize when expand state changes. Bug: 1090538 Change-Id: I03c7be269a877ce2dd9d9474f2b9099dca414491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227233 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#777450}
-
Nate Chapin authored
Was reverted because of callsites where GetDocument() was guaranteed non-null, but GetExecutionContext() might be null if the Document is detached. Fixed and added regression tests for the places where we got crash reports. Bug: 1029822 Change-Id: I2fb16bb8a90613b92a4603289bd7df20ffa992a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238891 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#777449}
-
Stephen Chenney authored
The test was running printing layout inside double nested for loops with about 30 iterations per loop, stepping by 1. The goal was to test a range of page sizes. The same effect can be had stepping by 10, so do that. TBR=mstensho@chromium.org Bug: 1093340 Change-Id: I3be9bcc4dc5391cc043f0c282760a56dbb16af39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241992Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#777448}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0eae8ff30b9ec63405b5880332052dc255e8ba14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241350Reviewed-by:
-
Sammie Quon authored
Reland crrev.com/c/2224990, including a fix for failing builders and a fix with tablet screenshot related. Speculative fix crrev.com/c/2218557 was not enough. I was able to repro locally and confirm this fix this time. It seems with certain build args we can get into a state where the CrossFadeObserver which observes window can be not animating, which is strange as the observer observes window and deletes itself on animation end. It seems in that test and bot, it can happen perhaps OnWindowDestroying is called before the window starts animating, or some other edge case. In this case, make sure the window is deleted if not animating. Test: none Bug: 1088169, 1088039 Change-Id: Ibe035209e83400921f16cff2bb272a8e186934dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224023 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#777446}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1591876517-dd7faaeec22d918256a2af8afd22dfee486b79d5.profdata to chrome-win32-master-1591891084-93c0746032c0f0f524ed3f7cc0072f07701d672c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I8b6f9977f3a275970503313f2a43815e56ccf1f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241913Reviewed-by:
-
Mirko Bonadei authored
This will allow projects that use //base to override these two GN args in an easier way (//build_overrides/build.gni instead of gn args). Bug: 1093406 Change-Id: I26d012732a428798a28e43726ce0abba54b3dd68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241123Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#777444}
-
Esmael El-Moslimany authored
Fixes the delay when initially showing the OneGoogleBar. Fixes transitions for overlays, for example when dragging an app icon in the app launcher overlay. Reproduce transition issue: 1. Navigate to chrome://new-tab-page?ogbiframe with chrome://flags/#ntp-one-google-bar-modal-overlays disabled. 2. Ensure the browser window is tall enough to the app launcher window does not extend to the bottom. 3. Click on the app launcher button to show the app launcher. 4. Start dragging on of the app links. 5. The app launcher overlay will increase the height with a transition. Without this CL, the overlay will appear cutoff. Bug: b/158390281 Change-Id: I148b26d54e1c8b9834e26c22e5bfe37a8004530c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238414Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#777443}
-
Bailey Berro authored
Some tests inavlidated assumptions about refresh rate. This change fixes these problems so that once kListAllDisplayModes is enabled these tests still pass. This change also sets the default refresh rate for ManagedDisplayInfo to 60 rather than 0 when constructing from spec. Bug: 1024113 Change-Id: Ia45dcaef09203298a900b91e9242c0598a3dc73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226068 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#777442}
-
Asanka Herath authored
Conceptually settings and state are as follows: * IdentifiabilityStudySettings : Configuration specified via means that are external to the browser and remain constant throughout the browser session. * IdentifiabilityStudyState : Current state of the identifiability study. Includes state that's ephemeral (session local) and persisted. In addition, there exists a couple of method renames also included in this CL. TBR: rkaplow@chromium.org Bug: 973801 Change-Id: Ibc4915e9d4c359f6548fec88fdfc1f934746a154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228990 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#777441}
-
OlivierLi authored
Since this intervention is meant to ease resource use, having it enabled should show a better performance profile then having it disabled. The motivation for the experimentation comes from finding cases of severe resource crunch triggered by the intervention at the critical pressure level before it was disabled. Bug: 1087530 Change-Id: I44e6f8351ea6d353328fc9fdf7c416b46f962380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227041 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#777440}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fbdd5786ca23..36a4d5db981c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huangs@google.com,japhet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1017165,chromium:1087037 Tbr: huangs@google.com,japhet@google.com Change-Id: I1f12d12044f529292e74f47fd455fca38d13f3c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241454Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777439}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/59622a5b31a4..77463bb18852 2020-06-11 nguyenmh@google.com Preserve raw commit message If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I781e68c098fdffa3cefcb88504648c7c2b4f8529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241917Reviewed-by:
-
James Cook authored
Lacros doesn't yet have an implementation for open/save dialogs. We have a plan for this, but it will take some work. Add a stub implementation of SelectFileDialogLacros and a factory to create it. Open and save still don't work, but they don't crash, and this gives us a place for future code. Bug: 1090587 Change-Id: Icb9aaf1a466c5da4d83a8060304d557dac7af4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240409 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#777437}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1591862337-51b5f2ed74f339e6e324f6777979fb62f66b655e.profdata to chrome-win64-master-1591891084-aba021c93c6154939062eeedbd2df61f396b7253.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I87a872460fa38c351417b7080f7ed2669ab4c9af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241914Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1e79c9ba9c6f..ac937d03b0de 2020-06-11 srte@webrtc.org Fix for potential infinite loop in TCP traffic simulator. 2020-06-11 ilnik@webrtc.org Allow HVGA Vp9 SVC to have 2 spatial layers and remove excessive rounding 2020-06-11 srte@webrtc.org Fix for flakiness in real time scenario test 2020-06-11 danilchap@webrtc.org Embed FrameDependencyTemplate builder helpers directly into the struct 2020-06-11 hbos@webrtc.org [Adaptation] Adding adaptation resources from Call. 2020-06-11 mbonadei@webrtc.org Switch to absl single target when building with Chromium. 2020-06-11 eshr@google.com Only allow most limited resource to trigger adapt up 2020-06-11 terelius@webrtc.org Deprecate inheritance hierachy of plot formats in event_log_visualizer. 2020-06-11 jianj@google.com Add implementation name for libaom decoder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1046390 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2ac018293e26fae0f5049b846f060f51f379152c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241916Reviewed-by:
-
Peng Huang authored
With this executor, skia will off some CPU works (computing draw path, releasing vk resource, etc) from GPU main thread to background threads. Bug: None Change-Id: Iac3f235cb17e7896edd432d205a3bb7ab9cf8a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240132 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@google.com> Reviewed-by:
-
Justin Cohen authored
Bug: 1084055, 1089068 Change-Id: I57536fe4ab807597bd3f87e31af35a6700d5f36e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241173 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Brian Sheedy authored
Disables the offline connection indicator on egl_pixel_skia_gold_test like we do for the other GPU pixel tests. TBR=twellington@chromium.org Bug: 1093085 Change-Id: I727a090b75a97e23f89df0659fb76c77db6ecde0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241635Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#777432}
-
Mason Freed authored
These tests were using Web Components V0 features, but seemed to be testing ongoing features of devtools. I attempted to migrate them to V1 versions of Shadow DOM and Custom Elements. Bug: 937746 Change-Id: Ibca2773d1d255f738658e86b911661c2847e4154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240228 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#777431}
-
Ben Schwartz authored
These padding constants are generic to accessory views for RadioButtonWithDescriptionLayout. Renaming the constants will allow us to introduce a new instance of that pattern without duplicating the constants. Bug: 1040146 Change-Id: Id177a044216535766e4df6e3396fdcc023026fab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240455Reviewed-by:
-
Reilly Grant authored
This change modifies the serial port enumerator on macOS to generate a single entry for each serial device so that the user is not presented with duplicate options in the Serial API permission prompt. Unlike other platforms macOS provides up to two devices paths for each serial device. These paths represent the "dialin" and "callout" behavior for the port. For most devices the "callout" behavior is preferred, while the "dialin" behavior will cause the system to block while opening the device until the "Data Carrier Detect" signal is detected. This behavior was useful for writing applications that wait for a modem to receive a phone call (hence "dialin") but is largely irrelevant today. The ability to select the path for the "dialin" device is retained in the chrome.serial API and the design of the change allows for selecting this behavior in the Serial API if developers demonstrate a need. This will require implementing support for this behavior on Linux and Windows, which do not provide separate device paths. Bug: 1084285 Change-Id: I290ffa0b58a096fe0a957db8f7d8c1210fa664e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227690Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/45510ad8a778..a6940c8e6eb0 2020-06-11 sugoi@google.com Regres: Roll deqp forward to latest 1.2.1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I4074f812b09366b8a131b68d458f5ec95f707e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241724Reviewed-by:
-
Wez authored
The fuchsia.legacymetrics.MetricsRecorder channel is expected to remain connected until the service explicitly signals OnCloseSoon, or the fuchsia.web.Context is destroyed, so log unexpected disconnections regardless of the reported disconnect status. Bug: b/158283552 Change-Id: I3bdf2f935c3ce2db04d0d8812b50703822703fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232367 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#777427}
-
Peter Wen authored
Similar to https://crrev.com/c/1803895, now that cmdline-tools is no longer in canary channel, we can add it to the rest of the sdk packages. Updated instructions for updating and adding new packages. Fix android-sdk-packager build since it was broken by android releasing bugs starting early May. Bug: 1093896 Change-Id: I800b285a4e03193f4b9c3c67a44f55eb4b77fd6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241994 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#777426}
-
Dominique Fauteux-Chapleau authored
This makes the BinaryUploadService use a URL populated by the service provider config when starting a request. It falls back to legacy URLs if the request has no valid URL. Bug: 1069048, 1069028 Change-Id: I214883f4e6eba137b7e6c08bbe8ede311e0740a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229202Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#777425}
-
