- 22 Feb, 2019 40 commits
-
-
Travis Skare authored
Change-Id: I48b82707892caa2ed85ab776b6cae73274382fde Reviewed-on: https://chromium-review.googlesource.com/c/1481121 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#634850}
-
Bailey Berro authored
Create a cups_printing watchlist to watch the CUPS related chromium files Bug: None. Change-Id: I48846d834983c51d4780f4b89962a000f12cfaea Reviewed-on: https://chromium-review.googlesource.com/c/1483944 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#634849}
-
Kristi Park authored
This reverts commit 90ffaeaa. Reason for revert: Breaks Win x64 Builder. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%20x64%20Builder/63687 Original change's description: > Add the win::WMIRefresher class and use it in SystemMonitor > > This class will be used to retrieve the disk idle time on Windows (some > other performance counters will probably be added in the future). > > The metric will initially be used in the tracing infra to make it > easier to analyze the I/O activity in the slow reports we're getting > from the wild. > > The Windows specific code has been review by rogerta@ and forschaw@ in https://chromium-review.googlesource.com/c/chromium/src/+/1340373 > > Bug: 771478 > Change-Id: Ie1988818f521097d6078ce67e597ec02115f4c07 > Reviewed-on: https://chromium-review.googlesource.com/c/1349670 > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634843} TBR=jwd@chromium.org,fdoray@chromium.org,oysteine@chromium.org,sebmarchand@chromium.org Change-Id: I857594acf56af3f050c1559a72269579f467a326 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 771478 Reviewed-on: https://chromium-review.googlesource.com/c/1484088Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#634848}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1aecf87b9620..36e541ccbf9f git log 1aecf87b9620..36e541ccbf9f --date=short --no-merges --format='%ad %ae %s' 2019-02-22 thestig@chromium.org Add more tests for AFPercent_Format(). 2019-02-22 thakis@chromium.org Another whitespace change to trigger bots. Created with: gclient setdep -r src/third_party/pdfium@36e541ccbf9f The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:934825 TBR=dsinclair@chromium.org Change-Id: Icf5b3dd16e4050c17706185fe0239a09dc11ae09 Reviewed-on: https://chromium-review.googlesource.com/c/1483826Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634847}
-
siyua authored
Create two studies since the two features have two different chrome flags. Using one study would cause DCHECK failure (Feature has conflicting field trial overrides) in Chromium debug mode. Bug: 897998 Change-Id: Icf093329e30f660ce7697241f5fbcd0604a1f9ac Reviewed-on: https://chromium-review.googlesource.com/c/1474277Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#634846}
-
Karandeep Bhatia authored
ErrorUtils.FormatErrorMessage_Death fails on official builds because failure messages aren't passed to CHECK in official builds. Modify the death regex for the test in official builds and fix the test. BUG=934831 Change-Id: I4b301410ce990e3ced014c5fa82c42d1fea98cce Reviewed-on: https://chromium-review.googlesource.com/c/1483938 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#634845}
-
François Beaufort authored
Change-Id: I81252edcac31490248001c59623b1da220136451 Reviewed-on: https://chromium-review.googlesource.com/c/1480455 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#634844}
-
Sebastien Marchand authored
This class will be used to retrieve the disk idle time on Windows (some other performance counters will probably be added in the future). The metric will initially be used in the tracing infra to make it easier to analyze the I/O activity in the slow reports we're getting from the wild. The Windows specific code has been review by rogerta@ and forschaw@ in https://chromium-review.googlesource.com/c/chromium/src/+/1340373 Bug: 771478 Change-Id: Ie1988818f521097d6078ce67e597ec02115f4c07 Reviewed-on: https://chromium-review.googlesource.com/c/1349670 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#634843}
-
Nicolas authored
The value of these policies is written to cache.dat so IE knows how to open a URL in Chrome. Bug: 909878 Change-Id: I0410e9022b96f35354666946a19fa6492afc7963 Reviewed-on: https://chromium-review.googlesource.com/c/1476062 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#634842}
-
Robert Ogden authored
This allows easier manual testing using chrome://flags Bug: 934376 Change-Id: Ic9bb78c8c8db20b5a8e6f0f8f5ce26d6897d7e52 Reviewed-on: https://chromium-review.googlesource.com/c/1483390Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#634841}
-
tby authored
This CL makes a slightly expanded version of the Dolphin category ranking model that learns information on subtypes of omnibox results, eg. history results and bookmark results. This is guarded behind a Finch parameter. Bug: 931149 Change-Id: I01c9edef80aee9f7f386fe301ffcd44e0a18fc78 Reviewed-on: https://chromium-review.googlesource.com/c/1482095 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#634840}
-
Takumi Fujimoto authored
The new CastToolbarButton in the toolbar's trusted area is now enabled by default, so this CL removes the old Media Router toolbar action that was replaced by it. MediaRouterActionController is still used by the new icon, and will be renamed in a separate patch. Bug: 919185 Change-Id: I95842e657379f823bd483d0a3da00015f76d8255 Reviewed-on: https://chromium-review.googlesource.com/c/1395419Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/f109f2087349712d3ac717d15fab48e130618110..c18353d214c04da5349e97283d6d70b8176a96f8 The following commits have Chromium bugs associated: c18353d21 Add uint64_t support in CBS and CBB. TBR: davidben@chromium.org Bug: 634570 Change-Id: Id2c0d63f53bfd683ff20f9f2745f626201b78be4 Reviewed-on: https://chromium-review.googlesource.com/c/1483700Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#634838}
-
Alexis Hetu authored
The Y and UV planes weren't getting released properly because the local variables used in base::RetainBlock() are snapshots of their current values and do not get updated by subsequent code. In this case, y_surface and uv_surface would always be at their original value of EGL_NO_SURFACE and eglReleaseTexImage/eglDestroySurface would never get called. Using pointers to these values solves the issue, since the pointers do not get modified by subsequent code and the values can be checked properly by dereferencing the pointers. Bug: chromium:932986 chromium:929088 Change-Id: Id0b9fcc79af733b645eaf8fed12d905dd40e9fbc Reviewed-on: https://chromium-review.googlesource.com/c/1483690Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#634837}
-
Dominik Röttsches authored
Due to issues we have with retrieving correct font metrics on Mac OS, due to [1, 2] when computing the vertical origin for Emoji Color Emoji we receive an incorrect vertical origin with a 0 y-value, which leads to an emoji glyph being placed too high. Fallback to retrieving the slightly inflated SkFont.getBounds when SkPath + getBounds() returns an empty rectangle, as it does for Apple Color Emoji. Added emoji-vertical-origin-visual.html test as part of own tests, but in the style of a WPT test. As far as I can tell, we cannot yet run pixel tests as part of WPT but I do not see a way to verify our rendering as a ref test. [1] https://bugs.chromium.org/p/skia/issues/detail?id=8779 [2] https://bugs.chromium.org/p/skia/issues/detail?id=5328 Test: fast/text/emoji-vertical-origin-visual.html Bug: 933264 Change-Id: I3487bf832b857764fb638a3f2df5803137d3fd66 Reviewed-on: https://chromium-review.googlesource.com/c/1480463 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#634836}
-
Etienne Pierre-doray authored
This CL records value returned by UnPackArchive in a new histogram Setup.Install.LzmaUnPackResult This value contains result of GetLastError() if Unpack failed, or ERROR_SUCCESS. Following WinGetLastError are also added to handle WriteFile failure: INVALID_USER_BUFFER NOT_ENOUGH_QUOTA Bug: 933975 Change-Id: I6177bf738383a0212d054f3cf2ddd3ec6d0b9fda Reviewed-on: https://chromium-review.googlesource.com/c/1461083 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#634835}
-
Lily Chen authored
A network error should be reported if the resource fetch is aborted before it is complete: https://w3c.github.io/network-error-logging/#transmission-of-request-and-response-errors This CL adds NEL error generation (with report type ERR_ABORTED) for any HttpNetworkTransactions destructed without previously generating a success or error report. This guarantees that every HttpNetworkTransaction results in a NEL report. Successes are reported after receiving valid headers (if the response code is 4xx or 5xx, or if the body will not be read, or on a redirect), or after completely reading the body. Any other outcome is reported as an error. Bug: 934000 Change-Id: I8f71309c9cea0295546b23861fba6b131f72a3d7 Reviewed-on: https://chromium-review.googlesource.com/c/1480195 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#634834}
-
Xianzhu Wang authored
It almost always crash on CQ bot linux-rel. Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=query-encoding%2Futf-16le.html Bug: 930297 Change-Id: I456dddf952daffae77efdf023fe0790df4644d4a Reviewed-on: https://chromium-review.googlesource.com/c/1483684Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634833}
-
Tomasz Wiszkowski authored
This change allows AnswerSuggestionProcessor to manage Calculation suggestions as well, ensuring all answers (including calculation) are uniformly processed when new answer layout is enabled. Bug: 920396 Change-Id: If233480827eb286131eae4a761b8cb9d210cdc3a Reviewed-on: https://chromium-review.googlesource.com/c/1481953Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#634832}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/245337d62e22..151c3484da58 git log 245337d62e22..151c3484da58 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 sergiyb@chromium.org Replace post-process checks with ones that are not deprecated Created with: gclient setdep -r src/third_party/depot_tools@151c3484da58 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:899266 TBR=agable@chromium.org Change-Id: I8eda5926e8c32d8be88e9b5dcd5181a5fdf23230 Reviewed-on: https://chromium-review.googlesource.com/c/1483870Reviewed-by:
-
Wenzhao Zang authored
Bug: None Change-Id: Ibd0ba93f9b06aabe342f63b87443de46e8cf0023 Reviewed-on: https://chromium-review.googlesource.com/c/1483705 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#634830}
-
Sidney San Martín authored
This reverts commit 75a861f2. Reason for revert: It turns out this is an upstream issue. See: - https://chromium-review.googlesource.com/c/chromium/src/+/1482557 - https://github.com/Valloric/ycmd/pull/1193 Original change's description: > [Vim/YCM] Fix missing system headers when YCM was built with its own libclang. > > Bug: 932667 > Change-Id: I2eb9965da1eb3f9ad4a5ce103cf6e32d35019e48 > Reviewed-on: https://chromium-review.googlesource.com/c/1476105 > Auto-Submit: Sidney San Martín <sdy@chromium.org> > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Commit-Queue: Asanka Herath <asanka@chromium.org> > Reviewed-by: Asanka Herath <asanka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632846} TBR=sdy@chromium.org,asanka@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 932667 Change-Id: I5a684c91723d28470e1d903cd74674ce145b421b Reviewed-on: https://chromium-review.googlesource.com/c/1483709Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#634829}
-
bsheedy authored
Automates a manual VR regression test that ensures that the hover state and hit testing of search suggestions in the VR browser function as expected. In order to prevent the test from flaking due to the blinking omnibox cursor, also adds the ability to crop images before comparing them in via the RenderTestRule. Bug: 887561 Change-Id: Ifddd18ff492b14bee08658251dc2191e7e481dcb Reviewed-on: https://chromium-review.googlesource.com/c/1479550Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#634828}
-
Kristi Park authored
The following tests fail on Linux trybots: URLLoaderImplementation/PreviewsLitePageServerBrowserTest.LitePagePreviewsTriggering/0 URLLoaderImplementation/PreviewsLitePageServerBrowserTest.ReloadingLitePagesDisablesLitePages/0 TBR=ryansturm@chromium.org Bug: 934955 Change-Id: I9701e912909d694fe4cdbd3f2a3f8dc3c5de6723 Reviewed-on: https://chromium-review.googlesource.com/c/1483674Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#634827}
-
Nico Weber authored
Only enables the warning for chromium_code.n Also fix the last few -Wextra-semi instances in sanitizer and linux/ozone builds. Getting to this state required fixing > 3000 unique warnings in 15+ different repositories. If this breaks some internal-only build somewhere, either consider using no_chromium_code for your internal code, or fix the warnings -- it's pretty easy. (Build with treat_warnings_as_errors=false, then open the error log in vim, run `:%g/warning:/t$` to copy the warnings to the end of the buffer, remove all but just those lines, run `:sort u` to get uniques, then save as `tmp.txt` and run `:cf %` and then use something like `:map m :w<cr>:cn<cr>` to go through them quickly.) TBR=rsesek Bug: 926235 Change-Id: Ica629737523ff6bbd756edc44d182f35ff6cf8ac Reviewed-on: https://chromium-review.googlesource.com/c/1483396Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#634826}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/045e7629..6b0fdfce Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iab67f081e437402a2b3d5fa397c239d0a3ad74d0 Reviewed-on: https://chromium-review.googlesource.com/c/1483353Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634825}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bf36568f5a9a..f6be20565150 Created with: gclient setdep -r src-internal@f6be20565150 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:932292,chromium:790153,chromium:790158,chromium:790159,chromium:790163,chromium:790153,chromium:790158,chromium:790159,chromium:790163 TBR=mmoss@chromium.org Change-Id: I209ba4517387614ec6ccfce883e97358c6d30672 Reviewed-on: https://chromium-review.googlesource.com/c/1483611Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634824}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/e72b8874b23a..3cab5a95cea8 $ git log e72b8874b..3cab5a95c --date=short --no-merges --format='%ad %ae %s' 2019-01-30 quiche-dev Replace calls to deprecated googletest macros *TEST_CASE() with *TEST_SUITE() 2019-01-30 quiche-dev Replace calls to deprecated googletest macros *TEST_CASE() with *TEST_SUITE(). Created with: roll-dep src/net/third_party/quiche/src Change-Id: Ide881ea35ff659707aa010e438c3a0d2a21df33a Reviewed-on: https://chromium-review.googlesource.com/c/1483262Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#634823}
-
David Benjamin authored
RtpTransceiverInterface::mid returns a temporary absl::optional<std::string>. This line below could avoid an extra copy by moving out of the return value. https://cs.chromium.org/chromium/src/content/renderer/media/webrtc/transceiver_state_surfacer.cc?rcl=76cea1da07cfc1bbbf571219cde4dcccaa259e01&l=102 (The caller didn't need to be changed because it was already returning a temporary.) Bug: none Change-Id: I5ec3964953febe8152086f374f9a8f3e89c8b43a Reviewed-on: https://chromium-review.googlesource.com/c/1481996 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634822}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/12aef8732ec6..1aecf87b9620 git log 12aef8732ec6..1aecf87b9620 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 thakis@chromium.org Whitespace change to trigger bots. 2019-02-22 thestig@chromium.org Make FX_ParseStringString() faster. Created with: gclient setdep -r src/third_party/pdfium@1aecf87b9620 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:934825,chromium:934403 TBR=dsinclair@chromium.org Change-Id: I9b7a65e27982ea50ae4694228134ff8cad62f30c Reviewed-on: https://chromium-review.googlesource.com/c/1483473Reviewed-by:
-
Matt Falkenhagen authored
Somehow we're getting Mojo calls like DispatchFetchEvent (on the ServiceWorker interface, example crash/fe94cd10d8ba922d) and C++ calls like DispatchOrQueueFetchEvent (from ControllerServiceWorkerImpl, example crash/974589224224beec) at a time where context_ is null. That doesn't make sense because if context_ is null we would have destroyed both the blink::mojom::ServiceWorker binding and ControllerServiceWorkerImpl. Add instrumentation to try to figure out why. Bug: 934622, 907311 Change-Id: I0c1d8e858245d51f10a084f8d6d0b5e20ac9ecc3 Reviewed-on: https://chromium-review.googlesource.com/c/1482440 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#634820}
-
Yusuf Ozuysal authored
This adds the necessary strings and constants for the three IPH that will be shown for Tab Groups. It also adds a utility class to facilitate showing the IPH. Also adds a string for context menu changes. BUG=930970,930965 Change-Id: Ide45f0a89a66bdab0096213ec8676303df37efe4 Reviewed-on: https://chromium-review.googlesource.com/c/1482592Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#634819}
-
Erik Jensen authored
Also adds basic tests for IpcFileOperations. Bug: 679313 Change-Id: I6ab03fb0cab5c5c5d60117c3687fe3c166b4e6ff Reviewed-on: https://chromium-review.googlesource.com/c/1477307 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#634818}
-
Michael Moss authored
This should be referenced as chrome/chromium.chrome everywhere now, instead of chromium/chromium.chrome. Also remove the chromium.chrome builders from the "main" waterfall, since the presubmits seem to want anything included there to have a local console definition, and complains about: Missing subwaterfall console for set([u'chromium.chrome']) BUG=790153,790158,790159,790163 R=jbudorick@chromium.org, tandrii@chromium.org Change-Id: I3062bdb1c868fc9e9d9d5f7e1e8f73e4e2aaeedc Reviewed-on: https://chromium-review.googlesource.com/c/1483363 Auto-Submit: Michael Moss <mmoss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#634817}
-
Varun Khaneja authored
See https://bugs.chromium.org/p/chromium/issues/detail?id=934786#c3 for detailed analysis R=nparker Bug: 934786,907280 Change-Id: Ib53720fc1ea0d10ba7efbfe3b1192097448f694f Reviewed-on: https://chromium-review.googlesource.com/c/1483930 Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#634816}
-
Daniel Nicoara authored
Move the wp_presentation interface into its own files. This change only moves code around, no functional changes. Bug: 896710 Test: Build and run exo_unittests Change-Id: I221c199074376420f3ca842dcd063c4bd4057589 Reviewed-on: https://chromium-review.googlesource.com/c/1480995 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#634815}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cf9b2853a7e7..d09546e1ec90 git log cf9b2853a7e7..d09546e1ec90 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 jmadill@chromium.org D3D: Fall back to old compiler DLL. Created with: gclient setdep -r src/third_party/angle@d09546e1ec90 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:920704 TBR=geofflang@chromium.org Change-Id: I3d4e1946bfd9b010b69d39238bae968c3bdcd553 Reviewed-on: https://chromium-review.googlesource.com/c/1483471Reviewed-by:
-
Yun Liu authored
As agrieve@ suggested, changed to use android_deps tool to get androidx test libraries from maven. This can be easier to add more binaries and upgrade by version later. Doc: https://chromium.googlesource.com/chromium/src/+/HEAD/tools/android/roll/android_deps/README.md Bug: 900746 Change-Id: I631ed39e4bb07719ffe7d49c928380223def29af Reviewed-on: https://chromium-review.googlesource.com/c/1478257Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#634813}
-
Antonio Gomes authored
R=jbroman@chromium.org CC=blink-reviews-onion-soup@chromium.org BUG=891908 Change-Id: I6d13142d63c924632370a1abd57b4effdb596f3c Reviewed-on: https://chromium-review.googlesource.com/c/1483570 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#634812}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/29f9cd9358ee..487c09bb73c1 git log 29f9cd9358ee..487c09bb73c1 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 srte@webrtc.org Adds FakeNetworkPipeTest to rtc_unittests. Created with: gclient setdep -r src/third_party/webrtc@487c09bb73c1 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I368eb8e46ad5e24365cf83e0cd4986eeb93def29 Reviewed-on: https://chromium-review.googlesource.com/c/1483470Reviewed-by:
-
