GitLab

Revert of Disable Slimming Paint rasterize_and_record (patchset #1 id:1 of https://codereview.chromium.org/1053303002/)

Reason for revert:
Re-enabling by reverting this temporary revert.

Original issue's description:
> Disable Slimming Paint rasterize_and_record
>
> We need to revert
> https://src.chromium.org/viewvc/blink?view=rev&revision=192695
>
> Reverting will cause this benchmark to crash, which is bad.
>
> TBR=pdr,sullivan
> NOTRY=true
> BUG=457054
>
> Committed: https://crrev.com/798e40fff8abe7d608cd44515ef29ee8158ca97c
> Cr-Commit-Position: refs/heads/master@{#323781}

TBR=pdr@chromium.org,sullivan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=457054

Review URL: https://codereview.chromium.org/1066143002

Cr-Commit-Position: refs/heads/master@{#324114}

of HttpProxyClientSocket and SpdyProxyClientSocket. Instead,
contruct a "URL" from the endpoint used in the CONNECT request.

Review URL: https://codereview.chromium.org/1060883002

Cr-Commit-Position: refs/heads/master@{#324113}

BUG=b/18275087

Review URL: https://codereview.chromium.org/1064903003

Cr-Commit-Position: refs/heads/master@{#324112}

Refactored these two functions into a single one to ease the
transition of https://codereview.chromium.org/920443003.

Tested on Android (with Nexus 5 device) with the following command
lines:

$ ./build/gyp_chromium -DOS=android -Goutput_dir=out_android
$ ninja -C out_android/Debug content_unittests content_unittests_apk
$ export CHROMIUM_OUT_DIR=out_android
$ build/android/test_runner.py gtest -s content_unittests --debug

BUG=338338
TEST=see above
R=boliu@chromium.org

Review URL: https://codereview.chromium.org/1064033002

Cr-Commit-Position: refs/heads/master@{#324111}

https://chromium.googlesource.com/angle/angle/+log/51a1db16..ae2d8a3af

BUG=436191

Review URL: https://codereview.chromium.org/1066623003

Cr-Commit-Position: refs/heads/master@{#324110}

When you run `gn gen out-gn/Debug` on Mac you get the following:

ERROR at //build/toolchain/mac/BUILD.gn:200:12: Build argument has no effect.
      os = current_os
           ^---------
The variable "os" was set as a build argument
but never appeared in a declare_args() block in any buildfile.

BUG=None
TEST=`gn gen out-gn/Debug` passes without the above error
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1064063002

Cr-Commit-Position: refs/heads/master@{#324109}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/44fc33d..0cdfa90

TBR=falken@chromium.org,cbiesinger@chromium.org

Review URL: https://codereview.chromium.org/1060373002

Cr-Commit-Position: refs/heads/master@{#324108}

Refine interfaces, implementation, formatting and comments according to the C++
style guide and Chrome coding standards. Behavior is unaltered except for a few
edge cases and Win32 API error handling.

This change is done as part of the readability review process. Original review:
https://crrev.com/1016563004.

Review URL: https://codereview.chromium.org/1030923002

Cr-Commit-Position: refs/heads/master@{#324107}

BUG=472038

Review URL: https://codereview.chromium.org/1068623002

Cr-Commit-Position: refs/heads/master@{#324106}

BUG=none

Review URL: https://codereview.chromium.org/1063153002

Cr-Commit-Position: refs/heads/master@{#324105}

Noticed this was missing on all the new android bots.

BUG=

Review URL: https://codereview.chromium.org/1067923002

Cr-Commit-Position: refs/heads/master@{#324104}

This will help us track down how an invalid resource is ending up in
the frame hopefully.

R=enne, piman@chromium.org
BUG=455931

Review URL: https://codereview.chromium.org/1062043003

Cr-Commit-Position: refs/heads/master@{#324103}

BUG=468201
TEST=Follow the repro steps in the bug and ensure there's no crash.

Review URL: https://codereview.chromium.org/1069043002

Cr-Commit-Position: refs/heads/master@{#324102}

Tile manager and eviction tile priority queues are using combined
priorities to schedule tiles, so tiling set eviction queues should use
those same priorities in order to return tiles in expected order.

R=vmiura, danakj, vmpstr

Review URL: https://codereview.chromium.org/1051473002

Cr-Commit-Position: refs/heads/master@{#324101}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5965b73..bb4a1cf

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1067853004

Cr-Commit-Position: refs/heads/master@{#324100}

This allows to have multiple Disabled group, e.g. Disabled/Disabled_control, and thus eases experimentation.

TBR=sky@chromium.org
BUG=465815

Review URL: https://codereview.chromium.org/1062243002

Cr-Commit-Position: refs/heads/master@{#324099}

In the past eglSwapBuffers used to return early, before the swap actually happened and descheduling in the driver. This resulted in the scheduler beginning the next frame early and hitting the page flip deadline in time more often.

Freon returns swap ack when page flip actually happened, but with the side effect of scheduling shifted forward, resulting in more missed vblanks and reduced performance.

This change restores original performance on freon.

BUG=465599

Review URL: https://codereview.chromium.org/1059503003

Cr-Commit-Position: refs/heads/master@{#324098}

http://crrev.com/1047223004 added experimental icon NTP support and
changed default "white-space: nowrap" to "white-space: pre-wrap", then
make current Material Design select the old one. This is broke 3rd-party
NTPs that don't have the same setting. This CL changes the defaults back,
and adds a new "ntl" to signal intent of having multiline titles. Also
updated single-iframe NTP to match.

BUG=474164

Review URL: https://codereview.chromium.org/1061163003

Cr-Commit-Position: refs/heads/master@{#324097}

BUG=

Review URL: https://codereview.chromium.org/1067003002

Cr-Commit-Position: refs/heads/master@{#324096}

Also ported gcd_client_unittests to use mock_xhr as a proof of concept,
but left original test as a supplement to xhr_unittests.

BUG=471928

Review URL: https://codereview.chromium.org/1055313002

Cr-Commit-Position: refs/heads/master@{#324095}

Move the implementation of doing power related actions from device_utils to battery_utils.

BUG=472763

Review URL: https://codereview.chromium.org/1067853003

Cr-Commit-Position: refs/heads/master@{#324094}

Adds a new junit_binary template for gyp which makes it easy to
make new Junit test suites by setting a lot of the options and
necessary dependencies for you.

Also, adds a new java_binary.gypi file which uses the
create_java_binary_script.py similiar to how the java_binary
GN template works when main_class is specified. This lets
GYP and GN work similiar when building a junit binary, so
our test runner can run them the same way.

Finally, because of the slightly different way were now running
the junit binary, the java classpath contains all of the jars
instead of just the test jar (before we were running
java -jar test_jar.jar which set the classpath to just be
test_jar.jar). Therefore, we can simplify things and just look
in the classpath for the paths to the Robolectric dependencies
when running Robolectric junit tests.

BUG=

Review URL: https://codereview.chromium.org/1057783002

Cr-Commit-Position: refs/heads/master@{#324093}

This test was invalid on modern glibc:
asprintf errors EOVERFLOW without attempting an allocation
when the size is at least INT_MAX - 32. INT_MAX - 33 is the
largest size that can attempt to trigger allocation failure,
and will not necessarily accomplish that on some systems.

Create a library that is specified to wrap malloc trivially,
to accomplish the goal of the test without external dependencies
or inconsistently implemented behavior.

BUG=428211

Review URL: https://codereview.chromium.org/1064793002

Cr-Commit-Position: refs/heads/master@{#324092}

BUG=

Review URL: https://codereview.chromium.org/1069033002

Cr-Commit-Position: refs/heads/master@{#324091}

BUG=467260

Review URL: https://codereview.chromium.org/1053423002

Cr-Commit-Position: refs/heads/master@{#324090}

BUG=424436,467287

Review URL: https://codereview.chromium.org/1068603002

Cr-Commit-Position: refs/heads/master@{#324089}

Revert of Reland Track memory consumption of SP on top 7 sites. (patchset #1 id:1 of https://codereview.chromium.org/1052843002/)

Reason for revert:
I think the original CL meant to make changes to memory.py, not run-perf-test.cfg. We shouldn't be submitting changes to run-perf-test.cfg, this file is used by the perf-try bots to pass try job parameters.

Original issue's description:
> Track memory consumption of SP on top 7 sites.
>
> Tests:
> android: https://codereview.chromium.org/1023783006/
> linux & mac: https://codereview.chromium.org/1013723006/
> win: https://codereview.chromium.org/1038773002/
>
> All above pass the "Running With Patch" step.
>
> BUG=None
>
> Committed: https://crrev.com/82b8e167143a5f0d4dd4515c6d0e14a64f654083
> Cr-Commit-Position: refs/heads/master@{#323680}

TBR=pdr@chromium.org,sullivan@chromium.org,prasadv@chromium.org,pan.deng@intel.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/1062253002

Cr-Commit-Position: refs/heads/master@{#324088}

BUG=474654

Review URL: https://codereview.chromium.org/1067903003

Cr-Commit-Position: refs/heads/master@{#324087}

This is a step towards unifying the various ways to "notify"
MemoryPressureListeners.

This also provides "GetCurrentPressureLevel" to a more general-purpose
place so we'll be able to use it on other platforms.
(Especially Windows, so we can use it in renderer_frame_manager).

See:
https://docs.google.com/a/chromium.org/document/d/1z3SR3JfKOwVaZxrsfHLOrPjo4-IVtnijaX86LKYPEQs/edit#
for more on the rationale and design, and
https://codereview.chromium.org/1045433002/
for what this might look like for ChromeOS's memory
monitor.

BUG=463546

Review URL: https://codereview.chromium.org/1048983006

Cr-Commit-Position: refs/heads/master@{#324086}

This CL adds methods to extract the content of a log in an external module
and import it to upload in the main application.

BUG=474625

Review URL: https://codereview.chromium.org/1030503003

Cr-Commit-Position: refs/heads/master@{#324085}

Now that Blink handles animated gifs, this code is not needed.

BUG=467197

Review URL: https://codereview.chromium.org/1061203002

Cr-Commit-Position: refs/heads/master@{#324084}

Previously, onPrefsChanged was a no op. This CL implements functionality for notifying listeners on the event when a pref has changed.

In the process:
- pull out shared logic into a prefs util namespace.
- simplify the whitelisting logic so there is only one GetWhitelistedPrefs method and not a CrOS-specific one.

BUG=468093

Review URL: https://codereview.chromium.org/1061613002

Cr-Commit-Position: refs/heads/master@{#324083}

BUG=267773

Review URL: https://codereview.chromium.org/1046343002

Cr-Commit-Position: refs/heads/master@{#324082}

Key releases enqueue a task on KeyboardEvdev that dispatches the release
ui::Event as well as cancels any scheduled repeats for that key. The
release itself is enqueued from the dedicated evdev thread and so can be
expected to arrive in a timely manner.

Unfotunately, due to the way base::Timer works, this is not robust when
the UI thread is very busy. The base::Timer object posts a delayed task,
and upon running checks to see if enough real time has passed (see
Timer::RunScheduledTask). If so, it runs the timer callback immediately.
This is fine, except that base::Timer also reuses scheduled tasks from
previous calls to Start() if they are still in the future (see
Timer::Reset). This can mean the timeout callback runs from a task that
was scheduled before the current timer was started.

The net effect of this is that the timer task may run first even if
(initial timer start + delay) > (key release task timestamp). The message
loop queue itself would have run the tasks in the correct order.

So, if we simply use PostDelayedTask() ourselves, there's no cleverness
in base::Timer to worry about and the tasks run in the needed order.

BUG=473446
TEST=Press Ctrl-W to close a tab with lots of activity (multiple copies
  of gmail loading, etc). Only one tab closes. Also tested with
  simulated jank (1s delay in tab closure).

Review URL: https://codereview.chromium.org/1052273006

Cr-Commit-Position: refs/heads/master@{#324081}

This uses a PaintRecorder to get at the canvas() for painting, instead
of grabbing it directly off PaintContext. This will allow PaintContext
to be backed by a DisplayItemList instead of a Canvas.

R=sadrul, sky
BUG=466426

Review URL: https://codereview.chromium.org/1064763002

Cr-Commit-Position: refs/heads/master@{#324080}

(Continuing from original cl https://codereview.chromium.org/1055893003 .)

Change IsMaximized() to return false if the window is in the dock, and
a unit test to make sure this is always the case. It turns out
-isZoomed can sometimes return YES for a docked window, which
sometimes results in the window becoming undocked on the next restart.
Please read the long entry in the bug report for a complete explanation
of how the change fixes the problem.

BUG=452976

Review URL: https://codereview.chromium.org/1062053002

Cr-Commit-Position: refs/heads/master@{#324079}

Remove various minor android_webview_build references now that we no
longer support that build configuration.

BUG=440793

Review URL: https://codereview.chromium.org/1048863002

Cr-Commit-Position: refs/heads/master@{#324078}

This CL brings the BackgroundSyncRegistration options up-to-date with the spec: https://github.com/slightlyoff/BackgroundSync/pull/74

TODO in followup CLs:
* Rename 'name' to 'tag': http://crrev.com/1068863003.
* Give periodic and one-shot tags their own namespaces in the map so that they don't conflict.

BUG=474573

Review URL: https://codereview.chromium.org/1068863002

Cr-Commit-Position: refs/heads/master@{#324077}

Add some tests for disabling/enabling/uninstalling extensions from the
chrome://extensions page. Since we don't have any, these will help us determine
if we break anything during the transition to observing events from the
developerPrivate API.

BUG=461039

Review URL: https://codereview.chromium.org/1063863004

Cr-Commit-Position: refs/heads/master@{#324076}

Added new histograms to break down Current bypasses (i.e. "Chrome-Proxy: block-once") by audio/video content types, as well as "content-type: application/octet-stream".

BUG=473763

Review URL: https://codereview.chromium.org/1048303004

Cr-Commit-Position: refs/heads/master@{#324075}