- 10 Sep, 2020 40 commits
-
-
Luum Habtemariam authored
The URLLoaderFactory interface grabbed from g_process can become invalidated, like on network changes, so we can't save it. This change modifies PpdProvider to grab it fresh before every fetch. Test: chromeos_unittests passes Bug: chromium:1123567 Change-Id: I2718548c45b61b34d78c17966037e8ccb91d654f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389020Reviewed-by:
Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#805835}
-
Peter Kasting authored
Bug: none Change-Id: I391f332af03db0d79877b0983c2060fc3f6bfaf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385239 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#805834}
-
Andrew Grieve authored
Also update comment about .ndjson->.size Bug: 1123778 Change-Id: I3f7465d5babcb990da23cefee0582589a15e44a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404142 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#805833}
-
Owen Min authored
The command line swtiches --device-management-url and --realtime-reporting-url are disabled on Window, Mac, Linux, Android on Beta and Stable channel. They are still allowed in Dev, Canary, trunk and browser tests. The are still allowed on Chrome OS without any additional condition. Bug: 1119515 Change-Id: I8b78b030e06e4339e374387004d4e8e37ab863f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382870 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#805832}
-
Charlie Hu authored
This CL fixes a crash caused by having a stand alone default feature(*) in document policy header/policy attribute. Bug: 1124853 Change-Id: I2ac5ef051e19e2b729a7e80724a1deedc1d333da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403584 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#805831}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/498d5ea20aed..9427c97d9c29 2020-09-10 bryan.bernhart@intel.com Fix ASSERT in WindowsDebugLogger again If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Id2c0eb72dd979f2da6e83bdb81639fa2201da755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403903Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805830}
-
Josh Nohle authored
When the Nearby Share service is created, start the certificate, contact, and local-device-data managers. No manager tasks are run until the managers are started. We also add logging. Change-Id: I9ee592d181f1fbe670318d364b3a5fec4dec45b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370924 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#805829}
-
Prakhar authored
Pending build time looks within limits as of now: http://shortn/_knva2rUxM9 (except for a single spike) Bug: 1024915 Change-Id: I48263543636a7d47c02164f183d85e24983dab1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404220 Auto-Submit: Prakhar Asthana <pasthana@google.com> Commit-Queue: Erik Staab <estaab@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#805828}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009100800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/rr3VhMXsq7y_PFGfYuF4xO5k6h8d3dTyYtD20gc4jK8C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/128567301,b/138961540,b/159892033,b/161761740,b/162294373,b/162706572 Tbr: media-app@grotations.appspotmail.com Change-Id: Ief0ec7ac5c174ac0de829ff6b2a19deffa470bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403637Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805827}
-
Matthias Körber authored
The missing groups result in a DCHECK fail when votes for the new types are generated. Change-Id: Id8000421161b382d7d3d35dcd95c9f8411a19faa Bug: 1126957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403472Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Auto-Submit: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#805826}
-
Alison Maher authored
Handle :visited background-colors in a similar way to the normal background-color property in Forced Colors Mode. Bug: 970285 Change-Id: I1dd0ac2530f3dec7de4b79de459d34e1d2ae193b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393299Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#805825}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d281ff186273..607aa13c8b9a 2020-09-10 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-10 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-10 vapier@chromium.org image test: rename white/black lists 2020-09-10 yueherngl@google.com brya: add factory/recovery signing and disable HW test 2020-09-09 yichengli@chromium.org artifacts: Use paths without leading ./ in firmware tarball If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I2afd0da6ac1321287665cde038dc4553edb371dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403634Reviewed-by:
-
Michael Chang authored
This will add a mechanism for the updater to be able to remove any apps that are not currently on a machine. Bug: 1056450 Change-Id: Id8fa734def07599d3926999a7a2c5910fb618656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393947 Commit-Queue: Michael Chang <donchan@microsoft.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805823}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fb5e0ebef07c..18f6a54fc3ce 2020-09-10 bsalomon@google.com Revert "Temporary hack to force text texture index varying to be float." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: Idcd459c243edaf3ce34c2050b9281e78b39a4c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403636Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b24900a1aa39..41974f57973e 2020-09-10 jaebaek@google.com Allow OpTypeVoid for debug function return type If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I4a554fc725fe900ae10be8804fe4e243aeba18aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403633Reviewed-by:
-
John Z Wu authored
This will allow users to opt out of leak check if desired. Also added a missing test for passwordAutofillEnabled. Bug: 1096281 Change-Id: Ibff3bf6fdb7b6bac6170f6b9aaa44938076f49fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401943Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#805820}
-
Yuki Shiino authored
macOS and iOS do not support malloc_stats and mallopt, plus we'll hit the following error if we define them. ../../chrome/tools/build/mac/verify_order: unordered symbols in Chromium Framework.framework/Versions/87.0.4260.0/Chromium Framework: _malloc_stats _mallopt So, this patch removes them when OS_APPLE. Bug: 998048 Change-Id: I5820670ce7b77d19b4f80acded73b3703b8aa478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400584Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#805819}
-
Miguel Casas authored
crrev.com/c/2401512 suggested using sizeof(variable) ISO sizeof(type) for various reasons [1]. This CL follows up by cleaning a previously landed similar idiom. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2401512/comment/8675d0dc_90c8dccc/ Bug: b/166646505 Change-Id: I86f21fd4e12f8c1b4402ec2520391f138a402f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403680 Auto-Submit: Miguel Casas <mcasas@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#805818}
-
Shengfa Lin authored
Enable chromedriver log for CI wpt tests Change-Id: I02d4acb627ca90233b7c0dab401c7c28e6759604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402319Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#805817}
-
Daniel Classon authored
Changes the release notes online and offline elements to render with a dom-if instead of with hidden. This makes it easier to deep link to either of the elements. Bug: 1084154 Change-Id: I1e062524cfbfb616e960141e404230fb3d85a2e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402131 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#805816}
-
Eugene But authored
Test is consistently failing on downstream bots (iPhone and iPad device) Bug: 1126746c TBR: fernandex@chromium.org Change-Id: I0cf93a563b5ca25356aa2fe8027559fc87e8f45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404021Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#805815}
-
Hajime Hoshi authored
Change-Id: I211318679e7d1c7f360a7ac0588713290c27a62d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400019Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#805814}
-
Stepan Khapugin authored
Fix the way localized strings are accessed in UI blocker to allow them to be safely loaded in multiwindow. Also remove the "." in "Switch to Open Window." Fixed: 1126071 Change-Id: I4346d84c288ef8a88375e6a985e27e5b550481e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398545 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#805813}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599651808-28c874736fb144e9b48a72308f081ee03ad277c7.profdata to chrome-win64-master-1599738815-40f6ae90536e6d0f415f1d4a37e068148427b479.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I84ba3cd27f048b2708d213c61ea77a0e5e476b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403631Reviewed-by:
-
Yuki Shiino authored
Moves InitializeDefaultDispatchToMacAllocator from allocator_shim_default_dispatch_to_mac_zoned_malloc.{cc,h} to allocator_interception_mac.{cc,h} so that it works with other allocator shims. The function is used to hook the standard allocation functions and not used to install our own allocator shim. So, allocator_interception_mac.{cc,h} is a better place. This patch makes PA-E on macOS compilable. Bug: 998048 Change-Id: I03f3cecc0f79febd5aec6ef4fde9a72cc0787d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400781Reviewed-by: -
cfredric authored
Change-Id: Ifff3526b22063147a403c33a323fd3a86d9efa74 Bug: 1126207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398963 Auto-Submit: Chris Fredrickson <cfredric@google.com> Reviewed-by:
-
Regan Hsu authored
When enabled, Wallpaper picker app will pull wallpaper collections from the alpha server instead of prod. Bug: b/168114365 Change-Id: I0fbfde5ff4d0043fb3e1a499a9f4261c7c9dba32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401948Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Wenbin Zhang authored
The processors on FYI are for testing propose. We don't need them any more and we can shut them down the free up resources. Bug: chromium:1045256 Change-Id: I82fe460916a55768f1b5e3c053ac31dfc87f37ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402658 Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
-
K. Moon authored
Replaces all instances of scoped_refptr<UrlLoader> with std::unique_ptr<UrlLoader>. It turns out there's no need for multiple ownership of UrlLoader. Drops OutOfProcessInstance's embed_loader_ and embed_preview_loader_ fields in favor of binding to the result callback. This may cause behavioral changes in two cases: 1. The field is overwritten before the callback runs. 2. The field is not cleared after the callback runs. (1) would cause other problems, as the current code assumes only one load occurs at a time (as tracked by document_load_state_ and preview_document_load_state_). The extra fields are needed only to simulate bound parameters in the old pp::CompletionCallback implementation. (2) is the case currently, but this change simply ensures that the loader is cleaned up as soon as it's no longer needed, rather than "leaking" a lingering reference. Retains the form_loader_ field, rather than also binding to the result callback, as this loader is not handed off to PDFiumEngine. In general, we don't handle form submission correctly, but fixing this is more a matter for crbug.com/719344. Bug: 1099022 Change-Id: I012be0e65583940f08275d7ce3469e01fbf72dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402122Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#805807}
-
Matthias Körber authored
The usage of Java script in forms can result in unstable renderer ids and therefore cache misses. This is mitigated by using unique-only field signatures as a fallback. Change-Id: Icae0f719c8ad1ea4de9dd9ab142b0d6aa746b2ab Bug: 1087386, 1091401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396141Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#805806}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2f11d877efaa..12e6ff85f6e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC seblalancette@google.com,mstensho@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: seblalancette@google.com,mstensho@google.com Change-Id: I50c5ff97e056a743f232b2fca0d01de0cf5dd121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403628Reviewed-by:
-
Daniel Rubery authored
Due to consolidating the two different configs currently applying to the CSD model version, we need the fieldtrial_testing_config to be kept in sync. Change-Id: I1adef41facd0d38d16e562561639ac1f5672ec07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399722Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#805804}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009100800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/ewmYZK3dZxBbgR06k6qpzdRqlikpeAfsd40KuNLCOSYC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Ib17351e7cdda384ba536a73f0923b72d38b86ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403639Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/822283dbb736..fc83cdc8198b 2020-09-10 tommi@webrtc.org Avoid proxy thread hops for reading const properties. 2020-09-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6e37a7f7..b55cb19f (805451:805701) 2020-09-10 peah@webrtc.org Add explicit initialization for the FilterAnalyzer in AEC3 2020-09-10 mbonadei@webrtc.org Revert "Switch from "rtc_ios_xctest_test" to "test"." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I458b3528eb84e663de0c1523e2ed7c23e7903667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403638Reviewed-by:
-
Mario Sanchez Prada authored
This is a follow-up CL for crrevc.com/c/2403260 to remove the methods SetMouseOverURL() and SetKeyboardFocusURL() from Blink::WebView, since they are no longer used from //content/renderer, but simply internally from Blink's chrome_client_impl.cc and WebViewImpl. Bug: 993189, 1047464 Change-Id: I377a03939773b276c0a94704fb36ebd230b121ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403264Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Akihiro Ota authored
This is a first pass at a nudge system for the interactive tutorial. This is particularly important for the OOBE tutorial, where we block ChromeVox until an expected action is performed. The issue is that the user only receives instructions once; if they miss the instruction, they have no way of hearing it again. To fix this issue, periodically announce the current item after a time interval. After reading the current item a few times, give general hints about using ChromeVox. Finally, if enough nudges have been given, provide a hint to exit the tutorial. This change also ensures that the new behavior doesn't conflict with hints for the practice area. Note: The strings added in this change have not been localized yet. Localization for the tutorial will land in a following change: https://chromium-review.googlesource.com/c/chromium/src/+/2254345 Bug: 1124074 Change-Id: I8ad0ec963c2cabb7a3b145ca3713a7f0bc66c1b4 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390962Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#805800}
-
Alex Ilin authored
TBR=michaelbai@chromium.org Bug: 1126950 Change-Id: I624983b8f86f24180ed8200ddb0793d8a7af2c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403562Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805799}
-
Fredrik Söderqvist authored
If the first animation in the sandwich does not depend on the underlying value we can avoid computing it - which for certain types can avoid flushing style. Bug: 981355 Change-Id: Ic15e863f03f8f7194eea9a453b980f416f1bff37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403263Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#805798}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1595370378-ba0a034250ef2251ee8fa7ce722cfaaf39079474.profdata to chrome-linux-master-1599738815-c7c05d9aad543471c0ca5060fdc90a37df9de6fc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:linux-chrome Tbr: liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I6e5a8685f9c50974b1b1b7bd3f4c0db5d898903a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403600Reviewed-by:
-
Christopher Cameron authored
This is a no-functional-change refactor that changes the function OnShimProcessConnectedForLaunch (which is used to launch the app when an app shim connects) to be more generically written. This is towards unifying four code paths: 1. OnShimProcessConnectedForLaunch, when the user launches an app shim 2. OnShimSelectedProfile, when the user selects a profile from the Profile menu 3. OnShimOpenedFiles, when the user opens files (e.g, by opening in Finder) 4. OnShimReopen, which is the *new* behavior in this bug, which will open a new window when the shim is running but has no active profiles. The next patch in this sequence will changes paths 2 and 3 to use this function. Bug: 1094419 Change-Id: I05265b9923db0f811bed239f2cd4db34e4c6553c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402164Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#805796}
-
