GitLab

TBR=scottmg

Review URL: https://codereview.chromium.org/269813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268046 0039d316-1c4b-4281-b951-d872f2087c98

This was missing from the last upload of https://codereview.chromium.org/265693003 but was present in the initial review.

TBR=scottmg
BUG=

Review URL: https://codereview.chromium.org/265883014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268043 0039d316-1c4b-4281-b951-d872f2087c98

Previously "gn args" printed build arguments. That has now moved to "gn args <outdir> --list" along with a new --short mode that's a bit more convenient for some uses.

Now "gn args" runs your editor on the build arguments for the given output directory, and re-generates the build given those arguments. This is an easier way to manage changing build arguments for a build (previously you would have to re-type everything or edit build.ninja manually).

"gn gen" now always uses the existing arguments for the given output dir, unless "--args" is manually specified (giving the old behavior of just using those). This also allows a more convenient way for a user to recover from a borked build (sincetimes I ran into a state where something was missing that prevent ninja from even starting enough to rebuild the build).

I removed the "show" and "refresh" ninja phony rules since the new commands cover those cases.

This patch adds some additional tracing to build startup since I noticed it was missing when trying to figure out why the args command was so slow (I fixed the main reason, it was with new code I added).

Added proper escaping for printing string values and unit tests for these.

Two minor build file fixes.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/265693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268042 0039d316-1c4b-4281-b951-d872f2087c98

BUG=297040
R=rch@chromium.org

Review URL: https://codereview.chromium.org/269543021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268041 0039d316-1c4b-4281-b951-d872f2087c98

BUG=326370

Review URL: https://codereview.chromium.org/268623009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268040 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268038 0039d316-1c4b-4281-b951-d872f2087c98

TBR=noamsml

Review URL: https://codereview.chromium.org/268763006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268036 0039d316-1c4b-4281-b951-d872f2087c98

To run the toolkit-views app launcher on Mac, it needs a new app list
service + supporting classes. It's going to look a lot like the Linux
one. This CL starts by sharing what can be shared between Windows and
Linux, in preparation for using it on Mac as well.

It does this principally by:
- Moving `app_list_shower` to `app_list_shower_views`, making it views-specific;
- Adding AppListServiceViews, which Win/Linux (and soon Mac) inherit from;
- Rearranging the delegation to eliminate some boilerplate.

Other changes:
- Removed AppList container abstract interface (now just access AppListView);
- Removed AppListFactory (now AppListShower::MakeViewForCurrentProfile());
- Moved AppListControllerDelegateLinux to AppListControllerDelegateViews;
- Most of AppListServiceLinux moves to AppListServiceViews;
- Added AppListShowerDelegate and AppListShower given virtual method
hooks to assist testability (previously AppListShower was given a NULL
service/delegate in tests);
- Positioning logic in AppListWin/AppListLinux made static/stateless;
- Removes the `on_should_dismiss_` closure (now just dismiss via the service;
- Big trim of AppListServiceWin and AppListServiceLinux - now these are
just platform-specific stuff.

BUG=365977
TEST=Just refactoring, nothing should change

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267184

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267354

Review URL: https://codereview.chromium.org/225053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268035 0039d316-1c4b-4281-b951-d872f2087c98

Previously we cannot destroy native side before detach because we would
have leaked hardware resources. This is no longer the case ever since
requestDrawGL takes a waitForCompletion parameter. Now we can
synchronously call nativeOnDetachedFromWindow from inside destroy to
clean up hardware resources, and then actually destroy native side
immediately.

Then also found that AwSettings will crash after destroying native since
it does not always check that the native pointer is not 0. Fixed these
and added a test.

BUG=

Review URL: https://codereview.chromium.org/263903008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268034 0039d316-1c4b-4281-b951-d872f2087c98

SyncExtensionFunction and AsyncExtensionFunction derivates now expose RunSync
and RunAsync respectively. New extension function implementations should just
implement Run directly.


BUG=365732
R=rockot@chromium.org
TBR=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/257333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268033 0039d316-1c4b-4281-b951-d872f2087c98

Also write a big comment explaining what I'm going to do.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/265753006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268032 0039d316-1c4b-4281-b951-d872f2087c98

Do not try to access native objects without making sure they are available.

BUG=

Review URL: https://codereview.chromium.org/267963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268031 0039d316-1c4b-4281-b951-d872f2087c98

There's no need to use recursion when getting the data from a filter.
This version uses a loop instead.

The issue with recursion is that it opens the door to stack exhaustion
if there is no way to limit its depth. In this case, that would be a
hard thing to do given that it basically depends on interactions outside
of our control.

BUG=366149

Review URL: https://codereview.chromium.org/267793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268030 0039d316-1c4b-4281-b951-d872f2087c98

They asked for this since optimizing MakeCurrent will take
significantly longer.

BUG=369316

Review URL: https://codereview.chromium.org/269593008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268029 0039d316-1c4b-4281-b951-d872f2087c98

If you run the following command line, you will get errors like this:

$ gn check
ERROR at
//components/translate/core/browser/translate_accept_languages.cc:13:11:
//Include not allowed.
          ^-----------------------
It is not in any dependency of //components/translate:translate_core_browser
The include file is in the target(s):
//ui/base:ui_base
which should somehow be reachable from //components/translate:translate_core_browser

Adds missing ui_base dependency to fix this.

BUG=367595
TEST=gn check
TBR=brettw@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/262013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268028 0039d316-1c4b-4281-b951-d872f2087c98

R=pkasting@chromium.org
BUG=

Review URL: https://codereview.chromium.org/263023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268027 0039d316-1c4b-4281-b951-d872f2087c98

We can early-out in this function if we have a non-invertible, non-animated
transform. This causes us to not reset some dirty bits (in particular,
|sorted_for_recursion|). Later, when sorting a layer's child list (_before_
we decide to early-out of CalculateDrawProperties), we skip out on sorting
the layer due to the dirty state. This causes badness. We should reset the
state and sort the list properly, including the layers that will be skipped
later.

R=vollick@chromium.org,ajuma@chromium.org,danakj@chromium.org
BUG=366233

Review URL: https://codereview.chromium.org/267713011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268026 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368743

Review URL: https://codereview.chromium.org/253313004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268025 0039d316-1c4b-4281-b951-d872f2087c98

Broke windows compile:

  FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\net\spdy\fuzzing\hpack_fuzz_wrapper.hpack_fuzz_wrapper.obj.rsp /c ..\..\net\spdy\fuzzing\hpack_fuzz_wrapper.cc /Foobj\net\spdy\fuzzing\hpack_fuzz_wrapper.hpack_fuzz_wrapper.obj /Fdobj\net\hpack_fuzz_wrapper.cc.pdb 
  c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_wrapper.cc(38) :error C2440: '<function-style-cast>' : cannot convert from 'std::string' to 'base::FilePath'
          No constructor could take the source type, or constructor overload resolution was ambiguous
  FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\net\spdy\fuzzing\hpack_example_generator.hpack_example_generator.obj.rsp /c ..\..\net\spdy\fuzzing\hpack_example_generator.cc /Foobj\net\spdy\fuzzing\hpack_example_generator.hpack_example_generator.obj /Fdobj\net\hpack_example_generator.cc.pdb 
  c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_example_generator.cc(51) :error C2440: '<function-style-cast>' : cannot convert from 'std::string' to 'base::FilePath'
          No constructor could take the source type, or constructor overload resolution was ambiguous
  c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_example_generator.cc(52) :error C2664: 'base::File::File(base::File::RValue)' : cannot convert argument 1 from 'int' to 'base::File &'
  c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_example_generator.cc(68) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data
  c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_example_generator.cc(69) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data
  FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\net\spdy\fuzzing\hpack_fuzz_mutator.hpack_fuzz_mutator.obj.rsp /c ..\..\net\spdy\fuzzing\hpack_fuzz_mutator.cc /Foobj\net\spdy\fuzzing\hpack_fuzz_mutator.hpack_fuzz_mutator.obj /Fdobj\net\hpack_fuzz_mutator.cc.pdb 
  c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(53) :error C2440: '<function-style-cast>' : cannot convert from 'std::string' to 'base::FilePath'
          No constructor could take the source type, or constructor overload resolution was ambiguous
  c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(56) :error C2440: '<function-style-cast>' : cannot convert from 'std::string' to 'base::FilePath'
          No constructor could take the source type, or constructor overload resolution was ambiguous
  c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(57) :error C2664: 'base::File::File(base::File::RValue)' : cannot convert argument 1 from 'int' to 'base::File &'
  c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(72) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data
  c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(73) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data

> Add hpack_fuzz_wrapper to chromium_builder_asan.
> 
> BUG=353237
> 
> Review URL: https://codereview.chromium.org/266003005

TBR=jgraettinger@chromium.org

Review URL: https://codereview.chromium.org/268863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268024 0039d316-1c4b-4281-b951-d872f2087c98

This is a rehash of ericu's cl https://codereview.chromium.org/259773006/ with a fix in upload_data_stream_builder_unittest.cc to resolve the leak asan found.

TBR=ericu,piman
BUG=108012

Review URL: https://codereview.chromium.org/261993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268023 0039d316-1c4b-4281-b951-d872f2087c98

This modifies a few locations that utilize size_t and int to track the
number of bytes to instead use off_t.

BUG=369279
R=binji@chromium.org, sbc@chromium.org

Review URL: https://codereview.chromium.org/269593011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268022 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds an observer of the current Tab in the Chrome Shell TabManager so
it knows when the underlying content changes.

BUG=361939

Review URL: https://codereview.chromium.org/268703005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268020 0039d316-1c4b-4281-b951-d872f2087c98

BUG=353237

Review URL: https://codereview.chromium.org/266003005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268019 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE

Review URL: https://codereview.chromium.org/262743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268018 0039d316-1c4b-4281-b951-d872f2087c98

ApplyDirtyState can on average 30% of the time of GLES2
draw calls.  It previously set Color, Depth, Stencil masks
and several enables without checking if they changed.

This change caches values used in ApplyDirtyState among
other places, and adds ContextState methods for setting
state with cache checks.

New cached state aware Set methods:
 * ContextState::SetDeviceCapabilityState
 * ContextState::SetDeviceColorMask
 * ContextState::SetDeviceDepthMask
 * ContextState::SetDeviceStencilMaskSeparate

Testing:
 * gpu_unit tests now run both with cache on and off (ignore_cached_state_for_test = true)
   to validate behavior independent of cache layering.
 * New tests specific for caching behavior:
 ** GLES2DecoderManualInitTest.ContextStateCapabilityCaching
 ** GLES2DecoderManualInitTest.CachedColorMask
 ** GLES2DecoderManualInitTest.CachedDepthMask
 ** GLES2DecoderManualInitTest.CachedStencilMask

BUG=347364

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267450

Review URL: https://codereview.chromium.org/245923008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268017 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/269443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268016 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368005
TEST=
R=kbr@chromium.org,qinmin@chromium.org

Review URL: https://codereview.chromium.org/262003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268015 0039d316-1c4b-4281-b951-d872f2087c98

This method no longer used as we are always in composited mode.

R=piman
BUG=251960

Review URL: https://codereview.chromium.org/267863007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268014 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/267803008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268013 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE

Review URL: https://codereview.chromium.org/268573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268012 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/262803014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268011 0039d316-1c4b-4281-b951-d872f2087c98

It's worth noting that the media_browsertests Yuv* tests compare video pixels with a reference image, but whether or not the hardware path is used, copying the pixels from the video into a canvas goes through the software path, so despite looking correct onscreen when GPU-accelerated, the JPEG color range video tests will still fail until the software path properly supports the JPEG color range.

BUG=172898

Review URL: https://codereview.chromium.org/92703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268010 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements the getCharacteristics method of the bluetoothLowEnergy API
and adds a mapping for Characteristic instance IDs to
BluetoothLowEnergyEventRouter.

BUG=265663
TEST=browser_tests --gtest_filter=BluetoothLowEnergyApiTest.*

Review URL: https://codereview.chromium.org/255053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268009 0039d316-1c4b-4281-b951-d872f2087c98

VIEW_ID_FIND_IN_PAGE_TEXT_FIELD is used and tested.
This alternate id isn't actually useful or tested.

BUG=NONE
TEST=No find bar behavior changes or regressions.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/267873004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268008 0039d316-1c4b-4281-b951-d872f2087c98

webview upon showing context menu.

Fire an event "contextmenu" on <webview> when context menu is
about to be shown.

This CL only fires the event with menu items' info, doesn't do
anything else.

The doc (for the complete API) is here:
https://docs.google.com/a/chromium.org/document/d/11pE2PRGSyLbZGVVP1pspViK_xLWv_A-1dJDY2kjjbgc/edit

BUG=140315
Test=
In a chrome app, create a <webview> element.
Add contextmenu event listener to the element:
var w = document.querySelector('webview');
w.addEventListener('contextmenu', function(e) {
  // e.items is an array of objects that represent menu items.
  // object = struct of .commandId = the id of the item, .label = the label of the itme.
});

The event fires when you right-click on the <webview> to bring up context menu.

Review URL: https://codereview.chromium.org/258533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268007 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354155

Review URL: https://codereview.chromium.org/226363004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268006 0039d316-1c4b-4281-b951-d872f2087c98

<video> must always be placed under the plugin, but it wasn't always
positioned properly. Moved video-container inside horizontally-centered div
so now video-container always occupies the same area as the <video> and the
plugin.

BUG=321825

Review URL: https://codereview.chromium.org/269793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268005 0039d316-1c4b-4281-b951-d872f2087c98

BUG=340886
TEST=gpu_unittests

Review URL: https://codereview.chromium.org/262953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268004 0039d316-1c4b-4281-b951-d872f2087c98

Reports:

ui/app_list/app_list_model.h:126:  Add #include <string> for string
[build/include_what_you_use] [4]
ui/app_list/views/top_icon_animation_view.h:5:  #ifndef header guard has
wrong style, please use: UI_APP_LIST_VIEWS_TOP_ICON_ANIMATION_VIEW_H_
[build/header_guard] [5]
ui/app_list/views/top_icon_animation_view.h:78:  #endif line should be
"#endif  // UI_APP_LIST_VIEWS_TOP_ICON_ANIMATION_VIEW_H_"
[build/header_guard] [5]
ui/app_list/views/folder_header_view.cc:169:  Add #include <algorithm>
for min  [build/include_what_you_use] [4]
ui/app_list/views/app_list_folder_view.cc:320:  Add #include <string>
for string  [build/include_what_you_use] [4]
ui/app_list/views/app_list_view.h:38:  Do not leave a blank line after
"public:"  [whitespace/blank_line] [3]
ui/app_list/views/apps_container_view.h:109:  Add #include <vector> for
vector<>  [build/include_what_you_use] [4]
ui/app_list/views/folder_header_view_delegate.h:26:  Add #include
<string> for string  [build/include_what_you_use] [4]
ui/app_list/views/apps_grid_view.h:328:  Add #include <string> for
string  [build/include_what_you_use] [4]
ui/app_list/views/app_list_folder_view.h:93:  Add #include <string> for
string  [build/include_what_you_use] [4]
ui/app_list/views/search_result_view.h:46:  Single-argument constructors
should be marked explicit.  [runtime/explicit] [5]

The report was generated by the following command line:
$ find ui/app_list -name "*.cc" -o -name "*.h" | grep -v cocoa | xargs
cpplint.py

After this the total errors found is ZERO!

BUG=337484
TEST=None, no functional changes
TBR=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/268813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268003 0039d316-1c4b-4281-b951-d872f2087c98

FFmpeg has packet side data indicating how many frames should be
trimmed after decoding, we should use it to improve playback of
mp3 and aac audio via <audio> tag.

Specifically:
- AudioBuffer:TrimRange(start,end) is now supported.
- DecoderBuffer:discard_padding() is now a pair of (front, back)
  which indicates how much to trim off the front and rear of the
  data corresponding to the encoded buffer.
- AudioDiscardHelper has been updated to implement this trimming.
- FFmpegDemuxer inserts FFmpeg's skip_samples into DecoderBuffer.

This change paves the way for MediaSource to use this feature to
implement gapless playback support.

BUG=360961
TEST=new unittests!
NOTRY=true

Review URL: https://codereview.chromium.org/251893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268002 0039d316-1c4b-4281-b951-d872f2087c98