- 01 Nov, 2018 40 commits
-
-
Ryan Sturm authored
This CL removes code that allows observers to be added from other threads than the UI thread. We never supported posting to multiple threads (note: IO used to be primary), so this is not needed. Bug: 895618 Change-Id: I23e85793eb6b18f8ad26799ad8b205787251f294 Reviewed-on: https://chromium-review.googlesource.com/c/1308612Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#604712}
-
David Quiroz Marin authored
Added the prefix "Blink." for consistency with the rest of canvas' histograms. Used the new ENUMERATION macro. Cleaned the enum strings in enums.xml for the following histograms: Canvas.CreateImageBitmapSource Canvas.GPUAccelerated2DCanvasDisableDeferralReason Canvas.RequestedImageMimeTypes Canvas.HibernationEvents Bug: 894043 Change-Id: Ifa6afc223e123fea3ef4915b26ff9309e69c710f Reviewed-on: https://chromium-review.googlesource.com/c/1310914 Commit-Queue: David Quiroz Marin <davidqu@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#604711}
-
sczs authored
Currently there's some flakiness for testEditFunctionalityOnSingleURL, since this is one of the longest test cases we have I'm hoping that splitting it in two will reduce the flakiness. Bug: 898572 Change-Id: Ifd623dada4a369c9b1af3586e750e34f31f5dc52 Reviewed-on: https://chromium-review.googlesource.com/c/1311799 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#604710}
-
Erik Luo authored
Bug: 865674 Change-Id: I42c6a50ca475615179ccd33bd1c8efb1549f1d69 Reviewed-on: https://chromium-review.googlesource.com/c/1300415 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#604709}
-
Chris Morin authored
BUG=b:76152951 Change-Id: Id64901e4434c77a06e65005dbb3cfaa0f047c94f Reviewed-on: https://chromium-review.googlesource.com/c/1312616Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Christopher Morin <cmtm@google.com> Cr-Commit-Position: refs/heads/master@{#604708}
-
Sahel Sharify authored
Registering the FlingScheduler after processing a GFS causes a frame of jank at the beginning of the fling. This is because the first OnAnimationStep call after observer's registration might be missing and/or incorrectly have the timestamp of the last begin frame before the observer's registration rather than the first begin frame after the registration. To avoid this issue, in this cl we register the observer on GSB instead of GFS so that the potential missing/incorrect OnAnimationStep call passes by the time that the GFS is processed. We unregister the observer on GSE instead of when the fling stops since not all GSBs are followed by GFS events. Bug: 882907 Test: GestureEventQueueWithCompositorEventQueueTest.FlingSchedulerOpbserverRegisteredOnGSB Change-Id: I149469fce31c9146c7282bee5cba7152ee65b1ea Reviewed-on: https://chromium-review.googlesource.com/c/1313270Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#604707}
-
Xiaocheng Hu authored
This patch converts the layout test with W3C testharness to reduce the usage of legacy js-test.js. It is also preparation for using Element.innerText as text dump, as the layout test produces different text dumps on Android and other platforms after using innerText (*). (*) See crrev.com/c/1308253 Bug: 887148 Change-Id: Ie3df2db21e6779af4f70bc8fec2ebc37458fba89 Reviewed-on: https://chromium-review.googlesource.com/c/1312302 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604706}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7216ea73e7fd..9b86cb69f2f2 git log 7216ea73e7fd..9b86cb69f2f2 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 tsepez@chromium.org Add pdf_cjs_util_fuzzer. 2018-11-01 thestig@chromium.org Roll third_party/freetype/src/ abd997aa7..f56830ed4 (18 commits) Created with: gclient setdep -r src/third_party/pdfium@9b86cb69f2f2 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0589a3f166aa5d698fca64ab6e98fbeb2fd11a4e Reviewed-on: https://chromium-review.googlesource.com/c/1313272Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604705}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6d546b5cd1b6..21d4b4c50dbe git log 6d546b5cd1b6..21d4b4c50dbe --date=short --no-merges --format='%ad %ae %s' 2018-11-01 benjaminwagner@google.com Un-omit Win10 IntelIris540 Vulkan tests. 2018-11-01 michaelludwig@google.com Remove vertex-shader perspective divide 2018-11-01 michaelludwig@google.com Expose aaType in simple mesh draw op helper 2018-11-01 michaelludwig@google.com Send correct 3rd component for uvr vertex attribute 2018-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader adfbbcbed6e7..75889d00033b (1 commits) Created with: gclient setdep -r src/third_party/skia@21d4b4c50dbe The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I837d025dd1a1ed9e5dfa216dedb565839f7b2b5b Reviewed-on: https://chromium-review.googlesource.com/c/1313271Reviewed-by:
-
Robert Ma authored
The service account was created at https://crbug.com/863229. Bug: 863229 Change-Id: Iec2bf7379955bd15169b475a4855cc1479c54471 Reviewed-on: https://chromium-review.googlesource.com/c/1313553Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#604703}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/189013bef993..096d016accb0 git log 189013bef993..096d016accb0 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 sprang@webrtc.org Update MultiplexEncoderAdapter to use EncoderInfo 2018-11-01 apehrson@mozilla.com Add guards to VideoCaptureDS::Init for when pins are null 2018-11-01 sprang@webrtc.org Use EncoderInfo in SimulcastEncoderAdapter 2018-11-01 Peter) Slatala Plug-in media transport state listener Created with: gclient setdep -r src/third_party/webrtc@096d016accb0 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id8a3e86cb163512e80cd6a705f51d7125df95662 Reviewed-on: https://chromium-review.googlesource.com/c/1313128Reviewed-by:
-
John Chen authored
On environment that doesn't support maximizing window, try to simulate its effect. Bug: 868599, chromedriver:2522 Change-Id: I44afe1883849a6b6396d1011fe2fe4aae38055dd Reviewed-on: https://chromium-review.googlesource.com/c/1312990Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604701}
-
Mohamed Heikal authored
This reverts commit d3fd7a3e. Reason for revert: breaks ui tests Original change's description: > Reland "[Android] Remove most resource names in resources.arsc" > > This is a reland of 86259392 > > TBR=This is the same cl no changes > > Original change's description: > > [Android] Remove most resource names in resources.arsc > > > > resource names are stored in the resources.arsc file to allow for > > getIdentifier with the string name of the resource to work. This cl > > obfuscates all of those resources to one name (and thus stored only > > once) for all resources that are not accessed via getIdentifier. > > > > This improves binary size by about 200KB. > > > > Bug: 894208 > > > > Change-Id: I28c440c22b90cd045f53017073fdb88c7410d530 > > Reviewed-on: https://chromium-review.googlesource.com/c/1265897 > > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > > Reviewed-by: Richard Coles <torne@chromium.org> > > Reviewed-by: agrieve <agrieve@chromium.org> > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#603229} > > Bug: 894208 > Change-Id: Id023518c91c0c98cf68f15efad286c4874b4976d > Reviewed-on: https://chromium-review.googlesource.com/c/1308991 > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604426} TBR=torne@chromium.org,tedchoc@chromium.org,agrieve@chromium.org,mheikal@chromium.org Change-Id: I1e4d1de0ea707d6dddfc82b13a44854fc30be753 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 894208 Reviewed-on: https://chromium-review.googlesource.com/c/1313279Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#604700}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I866e601bea944e76070eb16853ac448a5aaf62ca Reviewed-on: https://chromium-review.googlesource.com/c/1313229Reviewed-by:
-
Shimi Zhang authored
Bug: 900778, b/110313642 Change-Id: Ic530e933fd5e9b14e5f54e2a9d34d5e46b83a41f Reviewed-on: https://chromium-review.googlesource.com/c/1287829Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#604698}
-
Regan Hsu authored
MultiDevice.DeviceSyncService.FindEligibleDevices.Result* Add success of finding eligible devices (FindEligibleDevices), and metrics which breaks down the percentages of reasons when failure occurs on FindEligibleDevices. Bug: 870138 Change-Id: I63140be659f5d4723998a0cc87b53e830f36f09d Reviewed-on: https://chromium-review.googlesource.com/c/1311086 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#604697}
-
Owen Min authored
The policy force installs Chrome Reporting Extension and overrides any other extension policies about extensions black list, blcoked permissions, allowed/blocked runtime hosts, minimum version requirment, allowed type and update url. The policy does not override install source policy as it does not affect force-installed extension. Bug: 898673 Change-Id: I8f17d2073b200448d268a34dc07ab61ff65753d8 Reviewed-on: https://chromium-review.googlesource.com/c/1306233 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604696}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f6fd71fba4d7..669b0a7d9028 Created with: gclient setdep -r src-internal@669b0a7d9028 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:892384 TBR=mmoss@chromium.org Change-Id: I2006a448fb1e57466af14659cc8e030bdb4db7bc Reviewed-on: https://chromium-review.googlesource.com/c/1313033Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604695}
-
Eric Karl authored
Follow up to: https://chromium-review.googlesource.com/c/chromium/src/+/1311835 Re-enables tests after rebaselining. TBR=kbr@chromium.org Bug: 900599 Change-Id: I4f3adb6adb934f73868c5f3e047d5ac4763e304a Reviewed-on: https://chromium-review.googlesource.com/c/1313269Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#604694}
-
Scott Violet authored
Adds explicit and removes unused function. BUG=none TEST=none Change-Id: I3e7d09498384660d1d3c3eacd27d7cae34bf2ac1 Reviewed-on: https://chromium-review.googlesource.com/c/1312980Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#604693}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/51fdcfba7593..b281d52b301d git log 51fdcfba7593..b281d52b301d --date=short --no-merges --format='%ad %ae %s' 2018-11-01 nednguyen@google.com Remove keychain util code Created with: gclient setdep -r src/third_party/catapult@b281d52b301d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:714231 TBR=sullivan@chromium.org Change-Id: I56b6c60a5ef489282695ae8e318d66576f949d4f Reviewed-on: https://chromium-review.googlesource.com/c/1313228Reviewed-by:
-
Ryan Sturm authored
This requires 2 things: more robustly setting the Network Quality and turning on Data Reduction Network Service feature. The latter is required because IsDataReductionProxyEnabled is used by previews to determine whether the user is a data saver user. Bug: 778793 Change-Id: Ib0721ecb6bc25f2f324a966a997d3a6c2f5e60a5 Reviewed-on: https://chromium-review.googlesource.com/c/1313070Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#604691}
-
Alexander Timin authored
As a final step, replace all includes back: - mv message_loop_current.h message_loop.h - s/message_loop_forward.h/message_loop.h/ in all includes. - s/message_loop_forward.h/message_loop.h/ in base/BUILD.gn - Remove message_loop_forward.h from third_party/DEPS. TBR=gab@chromium.org R=gab@chromium.org BUG=891670 Change-Id: I623077025701459ddb7045cbcfdad138aa90a9e4 Reviewed-on: https://chromium-review.googlesource.com/c/1313110Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#604690}
-
Josh Karlin authored
After the switch to NetworkConnectionTracker, the GetConnectionType call wasn't checking for a synchronous return. In the case of a synchronous return OnConnectionChanged needs to be called. This led to BackgroundSyncManager not getting the correct connection type on startup. Bug: 900943 Change-Id: I21ffcacdea9cca4c0780f40561e55b10fb9866b1 Reviewed-on: https://chromium-review.googlesource.com/c/1312676 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#604689}
-
rbpotter authored
Add a CloudPrintInterface interface base class and make CloudPrintInterfaceJS and the CloudPrintInterfaceStub implement it. This will allow adding a new type of cloud print interface later. Bug: 829414 Change-Id: I274bb5e8aabf104eca8a1aac46b9dfd519ed467a Reviewed-on: https://chromium-review.googlesource.com/c/1309223Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#604688}
-
Eric Roman authored
The overall design is to decide on the proxies to mark as bad, and when to restart a request as part of the DRP's URLLoaderThrottle. This CL is complete enough to pass fallback browser_tests, however it hacks around one piece of unimplemented functionality: the DRP configuration is not yet synchronized to throttle, so it guesses it. This needs to be addressed in a follow-up. Bug: 721403 Change-Id: If95e52aad825d6e2c3b73fd12fdfeb9e53ae6cc6 Reviewed-on: https://chromium-review.googlesource.com/c/1297238 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#604687}
-
Alexander Timin authored
As a preparation for the MessageLoop/MessageLoopImpl split rename the current files to _impl versions. R=gab@chromium.org BUG=891670 Change-Id: I8fb55b82b1c57de2203b579948ebb922cc72bea6 Reviewed-on: https://chromium-review.googlesource.com/c/1313109Reviewed-by:
-
Zhongyi Shi authored
Add a histogram to collect how often the signal is detected by QUIC to attempt migration before handshake and how often the new connection is attmped, i.e., an alternate network is available to retry the connection. Bug: 790547 Change-Id: Ibe4630e1fa4d813330d0d7f48f2b4bf99663a3be Reviewed-on: https://chromium-review.googlesource.com/c/1311493 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#604685}
-
Scott Chen authored
Bug: 881937 Change-Id: Ia7e27b79ed334ba8811da12ece93a2706bfb1a71 Reviewed-on: https://chromium-review.googlesource.com/c/1309225Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604684}
-
Etienne Bergeron authored
We decided to remove the scheduling category. If we plan to look again on our the scheduler is performing through slow-reports, we gonna add a specific scenario since this is doubling the amoung of events. R=oysteine@chromium.org Change-Id: Id280597bcb41fd1a0765773c4ed42a97dabd83aa Reviewed-on: https://chromium-review.googlesource.com/c/1307893Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#604683}
-
David Jacobo authored
This cl fixes a couple of warnings generated by lint. Bug: None Test: git cl lint seems ok now, builds. Change-Id: Ife5ee050bc3896e2243d7af0a25a093801fa2d07 Reviewed-on: https://chromium-review.googlesource.com/c/1311802Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#604682}
-
Erik Chen authored
The metric will only measure tasks posted on the UI and IO tasks, not native events. Based on Slow Reports on Desktop, this seems likely to be sufficient to detect jank in the wild on Android as well. Bug: 859155 Change-Id: Ia573e6311d9315597334108955f215be61fc3b07 Reviewed-on: https://chromium-review.googlesource.com/c/1312681Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604681}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a69842065243..7216ea73e7fd git log a69842065243..7216ea73e7fd --date=short --no-merges --format='%ad %ae %s' 2018-11-01 thestig@chromium.org Roll third_party/skia/ 23564b924..fa7df23d8 (940 commits; 44 trivial rolls) 2018-11-01 thestig@chromium.org Roll third_party/skia/ 8b354dca8..23564b924 (1 commit) 2018-11-01 thestig@chromium.org Roll third_party/skia/ 4f94ef6cb..8b354dca8 (137 commits) 2018-11-01 thestig@chromium.org Roll third_party/skia/ b98fb5b08..4f94ef6cb (1 commit) Created with: gclient setdep -r src/third_party/pdfium@7216ea73e7fd The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I9b26b4eea428980c1c8493de6b4d241474563760 Reviewed-on: https://chromium-review.googlesource.com/c/1313129Reviewed-by:
-
Scott Violet authored
The client area is dictated by the bounds of the ClientView. This patch makes DesktopWindowTreeHostMus observe bounds changes of the ClientView, not the non-client-frame-view. BUG=891064 TEST=covered by test Change-Id: Ia96c2be5b9af1bce24d253e01dbf673accc20d3a Reviewed-on: https://chromium-review.googlesource.com/c/1312482Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#604679}
-
Xiaohui Chen authored
* Introduce assistant_state_proxy as a convenient mojom proxy client for voice_interaction_controller. * Introduce assistant_state_base as POD that can be shared between assistant_state_proxy and voice_interaction_controller to store state * Change assistant state accessers to base::Optional to reflect the async nature of reading these values. * Remove async Is___Enabled(Callback). The observer now will initialize state after attach. * Fixes assistant_manager_service_impl start up sequence to avoid potential multiple restarts with async assistant pref queries * Fixes a potential race when restarting assistant_manager Bug: b/112281490 Test: locally build and run Change-Id: I7c57adef0919583283f2fb1312f6d6e191bf266a Reviewed-on: https://chromium-review.googlesource.com/c/1303333 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#604678}
-
bsheedy authored
Renames the variables in fake_openvr_impl_api.cc to be consistent with Chromium style guidelines instead of using the original names from openvr.h. Also drive-by fixes a timeout that was flakily getting hit. Bug: 892717 Change-Id: Id6f25826df26212be5e0fae659cc4715c459f093 Reviewed-on: https://chromium-review.googlesource.com/c/1312195Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#604677}
-
Sergey Ulanov authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/847fc0b..d0a4800 BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I79b19367a340cc2cdeb539c1c06390fb5cf477ec Reviewed-on: https://chromium-review.googlesource.com/c/1306339 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#604676}
-
Aleks Totic authored
Bug: 900921 Change-Id: I4ce730d9fefb2b099cacc113d951238d302f8cc1 Reviewed-on: https://chromium-review.googlesource.com/c/1313168Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#604675}
-
Matthew Jones authored
This patch reduces the number of functions independently responsible for changing the visibility of the omnibox suggestions. Since the only visible part of the results container is the list, the visibility of the container should depend on whether the suggestions list visibility. To support this change, a new method has been added to the UrlFocusChangeListener interface: onUrlAnimationFinished. This method triggers after the animation for focusing or unfocusing the omnibox has completed. Change-Id: I110379fd59dd2d54182d03cc91ed75dd3cba765b Reviewed-on: https://chromium-review.googlesource.com/c/1294423 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#604674}
-
bsheedy authored
Adds support for the newer histograms format in addition to the older chartjson format to resource_sizes.py and diff_resource_sizes.py. This is a prerequisite for using these scripts with perf dashboard uploading on LUCI, as the chartjson format uses IP whitelisting when uploading, which is no longer practical on LUCI. Bug: 892302, 892344 Change-Id: I1a636ed1476df46cda5313e8c5cbfa18e5cacc83 Reviewed-on: https://chromium-review.googlesource.com/c/1311117Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#604673}
-
