Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 22 Jul, 2020 32 commits
  3. 21 Jul, 2020 8 commits
    • Bruce Dawson's avatar
      Revert "Implement the WindowsSystemProxyResolutionService/Request" · 5889b656
      Bruce Dawson authored 
      This reverts commit 33f234e7.

Reason for revert: Windows 7 test bots are failing

This is because WinHttpCreateProxyResolver requires Windows 8+.
https://docs.microsoft.com/en-us/windows/win32/api/winhttp/nf-winhttp-winhttpcreateproxyresolver

Original change's description:
> Implement the WindowsSystemProxyResolutionService/Request
> 
> This change creates a functional proxy resolver for Windows that relies
> on WinHttp APIs. This is not in its final state, though. This CL
> represents the simplest, least-work way to implement this proxy
> resolution service. Work still to come includes:
> - Complete NetLogs
> - Better error reporting from WinHttp APIs
> - Proxy Delegate
> - Proxy retry info
> - Assurance that the proxy configs we're receiving are from the system
> 
> The WindowsSystemProxyResolutionService is the object that external
> callers use to resolve a proxy. These callers can keep track of the
> status of this proxy resolution via a ProxyResolutionRequest,
> implemented here as a WindowsSystemProxyResolutionRequest. The request
> object is mainly intended to kick off a specific proxy resolution and
> report a result via a caller-provided callback. Both of these objects
> deal with a WindowsSystemProxyResolver.
> 
> The WindowsSystemProxyResolver is a new class that does all the required
> interfacing with WinHttp APIs. It is a reference counted object created
> by the WindowsSystemProxyResolutionService. Once created, it is used for
> the lifetime of the WindowsSystemProxyResolutionService. Throughout that
> time, the Resolver indirectly keeps a WinHttp session handle open. Each
> WindowsSystemProxyResolutionRequest is given a reference to the new
> resolver. When the Request object attempts to resolve a proxy for a
> given URL, it'll call into the Resolver object. Under the hood, the
> Resolver object creates a handle for the proxy resolution and runs the
> async call to WinHttp. At any time, the Request object can choose to
> ignore a pending result from the Resolver (ex: shutdown). The Resolver
> object must be reference counted because async WinHttp calls call back
> directly into the Resolver object, so it needs to stay alive as long as
> we're waiting for an async response from WinHttp.
> 
> The only other new object is the WinHttpAPIWrapper, which is just a thin
> wrapper over WinHttp APIs which we use to enable easier testing and
> to simplify some interactions with WinHttp. A WinHttpAPIWrapper is owned
> by a WindowsSystemProxyResolver. The Resolver object is the only object
> that should interact with the Wrapper object in any meaningful way.
> Internally, the WinHttpAPIWrapper keeps track of the opened WinHttp
> session handle that we're using for the lifetime of the Resolver object.
> 
> This change includes tests for the WindowsSystemProxyResolver layer (by
> mocking out the WinHttpAPIWrapper) and the
> WindowsSystemProxyResolutionService (by mocking out the
> WindowsSystemProxyResolver).
> 
> Bug: 1032820
> Change-Id: Ic1c60033ff148e6e8f3708e37a2af366613fefac
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159128
> Commit-Queue: Nicolas Arciniega <niarci@microsoft.com>
> Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
> Reviewed-by: Eric Roman <eroman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#790493}

TBR=eroman@chromium.org,rhalavati@chromium.org,niarci@microsoft.com

Change-Id: I54d4659d5165261af912c427fdeb8f372a7bb2bf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1032820
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311063Reviewed-by: default avatarBruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790602}
      5889b656
    • Koji Ishii's avatar
      Remove DCHECKs from |PostLayout| · 6ca73b8f
      Koji Ishii authored 
      r790297 crrev.com/c/2309494 added comments saying the DCHECK
can hit, but forgot to remove it.

This patch removes it.

Bug: 1107204
Change-Id: I716e8faca243a7a9b8457c4acc2bb43cd8d33dfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309877
Commit-Queue: Kent Tamura <tkent@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790601}
      6ca73b8f
    • Internal Frameworks Autoroller's avatar
      Roll src/ios/third_party/material_components_ios/src/ 3132beea7..6aea60a14 (6 commits) · fc807121
      Internal Frameworks Autoroller authored 
      TBR=bling-team@google.com

Change-Id: Ic2810ce2ccd866697f36b7bfd44a8ed27dcc76b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311111Reviewed-by: default avatarInternal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#790600}
      fc807121
    • Frank Liberato's avatar
      Allow D3D11VideoDecoder on NVIDIA >= 25.21.14.1721 · 18d99fb7
      Frank Liberato authored 
      As part of this, introduced "nvidia_driver" schema for workarounds.

Bug: 1041166
Change-Id: I6debe871f65fd261aa6d03b46906286995cdfa28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308853
Auto-Submit: Frank Liberato <liberato@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: default avatarZhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790599}
      18d99fb7
    • Philip Rogers's avatar
      [Reland] Skip commits for threaded scrolls. · 3e38b167
      Philip Rogers authored 
      Threaded scrolls unnecessarily cause commits on every change. This
patch implements an optimization from pre-BlinkGenPropertyTrees in
layer list mode to avoid these commits.

When an impl-side scroll occurs, cc can immediately apply the scroll
before notifying blink so that the blink update only causes a commit if
needed (e.g., interest rect changed). This has been implemented in
LayerTreeHost::UpdateScrollOffsetFromImpl. A second change was needed in
PropertyTreeManager::DirectlyUpdateScrollOffsetTransform to avoid
commits if cc already matches blink.

This is a reland of https://crrev.com/745110.

Bug: 1048384f
Change-Id: Id50a0d0a944f7d1f763906304bbcfccdf81cb301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297709
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: default avatarKhushal <khushalsagar@chromium.org>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790598}
      3e38b167
    • Nathan Zabriskie's avatar
      Use alpha_type stored with SharedImage for raster CopySubTexture · a5e53f92
      Nathan Zabriskie authored 
      In the past we had to pass in the alpha type of a SharedImage when
copying it. Recent CL's have added this information to the SharedImage
itself so now we can avoid redundancy and set the alpha type once
when creating the SharedImage. This CL removes
|unpack_premultiply_alpha| from RasterDecoder::CopySubTextureINTERNAL
in favor of using the alpha state stored with the image.

Bug: 1034086
Change-Id: I592bb7f6629212905614fcadf4f8717993923490
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310971Reviewed-by: default avatarKhushal <khushalsagar@chromium.org>
Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#790597}
      a5e53f92
    • Sunny Sachanandani's avatar
      viz: Do not apply white level scaling for RGBA fp16 HDR video · d8db845e
      Sunny Sachanandani authored 
      Since SDR white level was baked into the display color space, HDR video
YUV quads with PQ color space had white level adjusted to skip white
level scaling.  However, that workaround didn't apply to RGBA HDR video
texture quads with scRGB linear color space.

This CL applies the white level adjustment to that case.  Texture quads
containing video are marked so that the white level adjustment applies
only to video and not webgl or canvas.  The default white level for
scRGB linear is set to 80 nits so that it matches the SRGB white level.

Bug: 1084689
Change-Id: I59c50bb2fe0f702c5ea48ed5d2b71b69572f0f8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296006
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: default avatarRobert Liao <robliao@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarccameron <ccameron@chromium.org>
Reviewed-by: default avatarDale Curtis <dalecurtis@chromium.org>
Reviewed-by: default avatarkylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790596}
      d8db845e
    • Archana Simha's avatar
      [Extensions] Refactor profile wide ExtensionPrefs with complex values. · 5da3a970
      Archana Simha authored 
      Add methods for to get and set dictionary, time and url profile wide
ExtensionPrefs.

Design Doc: http://go/extprefrefactor

Bug: 1069560
Change-Id: Ia922a3be11fb77715e185f2a286eb3d4f59622cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308857
Commit-Queue: Archana Simha <archanasimha@chromium.org>
Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790595}
      5da3a970