GitLab

BUG=861810

Change-Id: I26ddbc6dde99e3c26407e4fedfe379833c2ecd73
Reviewed-on: https://chromium-review.googlesource.com/1129389Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573411}

https://android.googlesource.com/platform/external/perfetto.git/+log/68eaa07bdfa0..916c76140064


git log 68eaa07bdfa0..916c76140064 --date=short --no-merges --format='%ad %ae %s'
2018-07-09 hjd@google.com perfetto-ui: Add state holder
2018-07-09 hjd@google.com perfetto-ui: Fix copyright headers
2018-07-09 hjd@google.com perfetto-ui: Allow PascalCase component names


Created with:
  gclient setdep -r src/third_party/perfetto@916c76140064

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:111101304
TBR=perfetto-bugs@google.com

Change-Id: I35f1be9b54fd487b4962c11ca418b4ea11de679d
Reviewed-on: https://chromium-review.googlesource.com/1129379
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#573410}

This CL includes the implementation class for the abstract class
HashUtils defined in the Nearby library. It implements a string-based
interface for MD5 and SHA-256 hashing.

Because the actual Nearby library has yet to be merged into the CrOS
directory, this CL includes stand-in Nearby abstract classes under
the temporary directory //chromeos/components/nearby/library.
This directory will be removed after the Nearby library gets imported
to //third_party (in-progress CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1113198).

Bug: 861813
Change-Id: I41dc7d74d5913ae8168041c82d3cacf70628ce19
Reviewed-on: https://chromium-review.googlesource.com/1119492
Commit-Queue: Kyle Qian <kyleqian@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573409}

OopAsh mode (enabled with --enable-features=OopAsh) on CrOS was
crashing at start because the Ozone/Drm DRM and cursor services
were not accessible to the Ash/WS2 host. In this change, the WS2
service is extended to add and bind these interfaces.

Tested by hand by running on device (chell):

	sudo -u chronos ./chrome  --enable-features=OopAsh \
		--user-data-dir=/home/chronos --homedir=/ --login-manager

BUG=850168
TBR=tsepez@chromium.org

Change-Id: I9b6a195f1f5fcce64174eb8e851561c70861dc81
Reviewed-on: https://chromium-review.googlesource.com/1121830
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573408}

Updated the privacy document (approved by msramek: https://docs.google.com/document/d/1BNQ5nLOtPuwP7oxr9r-XKNKr5iObXEiA_69WXAvuYAo/edit?usp=sharing)


Bug: 775644
Change-Id: If9e16711af2d27a7209366a61883997e865c9b50
Reviewed-on: https://chromium-review.googlesource.com/1126332Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573407}

This is a reland of db409e20

Original change's description:
> Truncate string attributes in the accessibility tree
> 
> Adds the helper function
> BlinkAXTreeSource::TruncateAndAddStringAttribute, which truncates string
> attributes when Blink's tree is serialized for accessibility. String
> attributes are truncated at BlinkAXTreeSource::kMaxStringAttributeLength
> bytes, currently set to 10000 bytes.
> 
> Bug: 644805
> Change-Id: Ibd1af03a77814aa524dcb067ad1be3f3f4291c8b
> Reviewed-on: https://chromium-review.googlesource.com/1113946
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570818}

Bug: 644805
Change-Id: If084733234602882bbd37fc1891e49011b12ada8
Reviewed-on: https://chromium-review.googlesource.com/1129399Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573406}

These flags are old and no longer needed, so should be removed.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iad382b68937e084358f6d2bc9417a25aa1ecbfc5

TBR=jam@chromium.org

Change-Id: Iad382b68937e084358f6d2bc9417a25aa1ecbfc5
Reviewed-on: https://chromium-review.googlesource.com/1128247Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573405}

Previously firing a notification only worked when an AccessibleNode
had an element. Add a quick fix to ensure it works even when it
doesn't.

Bug: 761901
Change-Id: I0ec6723e748947d94f1207f72f38ec94f0f6b335
Reviewed-on: https://chromium-review.googlesource.com/962862
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573404}

crypto::HKDF was originally written for QUIC and has QUIC-specific
assumptions in it, and hence it's moved into the QUIC codebase.

The new API is just a thin wrapper around BoringSSL's HKDF
implementation.  I intend to do the same to crypto::HKDF itself, but for
now it's parked in QUIC platform impl directory.

Change-Id: Ie60072dab4570bc840d9e6aaa5b1fef72fb387a2
Reviewed-on: https://chromium-review.googlesource.com/1122698
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573403}

When selecting the Leave option in the Leave Incognito Mode dialog that
launches an intent to the Play Store, Chrome crashes if the store is
disabled/uninstalled.

This fix checks whether the intent can be handled before showing the
dialog, and just avoids showing the dialog if not. It also removes the
need to check for ActivityNotFoundExceptions, and instead performs this
check first.

Tests are added to test behaviour with the Play Store installed and
uninstalled.

Bug: 820709
Change-Id: Ic6fec319887f77368262e825a95c419c1644b81b
Reviewed-on: https://chromium-review.googlesource.com/1113900Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573402}

Reminders is classified a web deep link, so it automatically will
open in the AssistantWebView (though we are only providing
placeholder content for the time being).

Onboarding will be wired up in a follow up CL.

This CL:
- Adds IsAssistantOnboardingDeepLink API.
- Adds IsAssistantRemindersDeepLink API.
- Adds ParseDeepLinkParams API. Some deep links, like onboarding, will
  have parameters and so I've added a method to parse parameters from
  a provided deep link and to return them in a provided map.
- Adds unit tests.

Bug: b:110986528
Change-Id: Ic17c625bd4b6869a256e1df09b4740fd2b6f1ee0
Reviewed-on: https://chromium-review.googlesource.com/1121581Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#573401}

This is the first step towards implementing a contact picker for
Chrome for Android, broken down into multiple steps for easier
reviewing.

First part includes simply showing a toast with the message
"Not implemented" when text/json+contacts is supplied as an
accepted file type.

Includes a Finch tie-in and a flag to turn this on manully
("Enable new contacts picker" in chrome://flags.

Bug: 860467
Change-Id: Ibbb2a3da6b5d60702bf833129bfbdebd38d03803
Reviewed-on: https://chromium-review.googlesource.com/1127023
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573400}

Bug: 861600
Change-Id: I8d78eacceae4d11ab3b5759a479915f79470072c
Reviewed-on: https://chromium-review.googlesource.com/1129470
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573399}

Change .4 to .5

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0adb555b7c75ccb2d05a04fc517cb952ae2b05c4
Reviewed-on: https://chromium-review.googlesource.com/1118856
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573398}

Network panel currently "translates" wheel events into
"set the new scrollTop" for its viewported scrolling.

This CL makes wheel events translate into smooth scrolls.
If all wheel ticks were smooth with scrollBy, consecutive
ticks would cancel each other out, so a burst of wheel
events will revert to instant jumping.

Screenshot: https://imgur.com/a/UB31WZs

Bug: 786796
Change-Id: If440e711369b8f35398004a2cfdd18e8c5e1ef87
Reviewed-on: https://chromium-review.googlesource.com/1112668Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573397}

Bug: 773382
Change-Id: I6cf4d2fc30efdd8f00d67badc1cb8233aab05f46
Reviewed-on: https://chromium-review.googlesource.com/1127353
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573396}

When a RenderWidgetHostViewBase doesn't have a valid InputTargetClient
in rare cases on Mac, fallback to early return itself as the target.

Bug: 859492
Change-Id: If473238b947ab2d13512c3ae8d5a818da71584dc
Reviewed-on: https://chromium-review.googlesource.com/1127358
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573395}

Mock:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeqwFvuvKaZQ/files/MCHiVGjUR16sLc0S1m6c9nL_wMSJbxAVNpw

Bug: 827376
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I10151db7eb9dc586af5987815e31abd72c8aa309
Reviewed-on: https://chromium-review.googlesource.com/1106804
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573394}

When a bad input is created the target indices can point far out of
bounds. Based on the fuzzing this should be promoted to a runtime
LOG(ERROR). Once we have a method to fail a write gracefully this
should be updated to fail the write step.

Bug: 860857
Change-Id: Ie8e4eaf9a655a71e0a2bf3efe2efae52574813db
Reviewed-on: https://chromium-review.googlesource.com/1128813
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573393}

This reverts commit 7521decc.

Reason for revert: Caused failures on fast/history/history-back-initial-vs-final-url.html (and possibly other tests, see https://crbug.com/861808)

Original change's description:
> Transmit the response's body datapipe in CommitNavigation().
> 
> # Summary of the current behavior:
> 
> When a navigation occurs, the mojo::URLLoaderClient interface is first
> bound to the content::NavigationURLLoaderImpl in the browser process.
> When the browser knows in which renderer process the navigation will
> commit, the interface is bound to the content::URLLoaderClientImpl in
> the renderer process to continue the navigation. The switching from one
> to another happens when mojo::URLLoaderClient::OnReceiveResponse() is
> called. This is described here: https://goo.gl/Rrrc7n
> 
> # What are we trying to do:
> 
> After the mojo::URLLoaderClient interface is unbound in the browser
> process and bound again in the renderer process, it takes some amount of
> time to receive URLLoader::OnStartLoadingResponseBody(). It may be worth
> sending the data pipe with RenderFrameHostImpl::CommitNavigation() and
> give it to the renderer process immediatly instead of waiting for it. It
> would allow the Renderer process to get the main resource's data
> earlier, especially when the renderer process is busy.
> 
> Note: It doesn't look like there are any strong reasons to make
>       URLLoaderClient::OnReceiveResponse(response_head) and
>       URLLoaderClient::OnStartLoadingResponseBody(response_body)
>       separate messages, maybe at some point, they could be merged into:
>       URLLoaderClient::OnReceiveResponse(response_head, response_body)
> 
> # What this CL does:
> 
> This CL makes the switch to happen in
> URLLoaderClient::OnStartLoadingResponseBody(). The data pipe is
> transmitted in CommitNavigation().
> 
> This is enabled/disabled using the NavigationImmediateResponse experiment
> The goal is to look for performance improvement or regressions on
> Canary.
> 
> Bug: 831155
> Change-Id: Id6cf667fdc1482baf27f41aab754e58d9a5a569b
> Reviewed-on: https://chromium-review.googlesource.com/1100830
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#573276}

TBR=pkasting@chromium.org,kinuko@chromium.org,nasko@chromium.org,yhirano@chromium.org,clamy@chromium.org,arthursonzogni@chromium.org

Change-Id: I22eac2d660f9cf1d8128331b547c304af729a85a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 831155
Reviewed-on: https://chromium-review.googlesource.com/1129659Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573392}

TBR=jkarlin@chromium.org

Bug: 721512
Change-Id: Ia9d793aae153328d6ec7602f056017a3a6a93928
Reviewed-on: https://chromium-review.googlesource.com/1129325
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573391}

The (rva_lo_bits & 0xFFF) == rva_lo_bits DCHECK fails when the input
data is invalid. This occurs if the RelocHeader contains |rva_hi_bits|
which are mismatched from the |target_rva| for a given |ref|. This
results in |rva_lo_bits| which are invalid. Until Zucchini is
refactored to support failing to write gracefully we will just print
a loud error and skip the RVA.

This only fails in situations where the input is bad so shouldn't
occur in normal use.

Bug: 860857
Change-Id: I0472286fc54786be26b95f65e6bd18a587bc0c8b
Reviewed-on: https://chromium-review.googlesource.com/1128812
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573390}

- Change the owner of histograms to a current team member if the current
  owner has moved on to another team
- Make MediaRouter.Ui.FirstAction and MediaRouter.Route.CreationOutcome
  use enum= instead of units= so that the enums are actually used

Change-Id: I241848a8a955080673b9a9d144092cc0abf2e5fe
Reviewed-on: https://chromium-review.googlesource.com/1128208Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573389}

Change-Id: I4d0a224d4a256a96a6b8fdfa798f0b9a14c02ee1
Reviewed-on: https://chromium-review.googlesource.com/1129472
Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573388}

Sadly, Julia is no longer working on Chrome, so she shouldn't be
expected to do reviews.

Also make all net/OWNERS owners of files where this change would leave
only one person as an owner.

Bug: none
Change-Id: I2a9ef11376eeea123096ca6f7cfc6b24134547cc
Reviewed-on: https://chromium-review.googlesource.com/1129324Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573387}

ToolbarManager#onDeferredStartup may post a delayed task to the UI thread that
calls itself. If the activity that owns the ToolbarManager is destroyed before
the task is run (and ToolbarManager#destroy is called) then the
mOmniboxStartupMetrics could be a null pointer. This cl adds a check to see if
the activity is finishing when the delayed task is run and noops out if it has.

Bug: 860449
Change-Id: Iac8333d26311142ce8e130b42aa5c7c551b844ca
Reviewed-on: https://chromium-review.googlesource.com/1127304Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573386}

Bug: None
Change-Id: I0e49baa5bdfffbd1a3280ff39281b3c1c3392088
TBR: mlamouri@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1128250Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573385}

R=hajimehoshi@chromium.org
CC=yutak@chromium.org

Change-Id: I9592e4756eb00f16224f15acd366021f3de580d3
Reviewed-on: https://chromium-review.googlesource.com/1118234
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573384}

When the submenu is reopened, its bounds doesn't get
updated. This causes where if the menu is scrolled after
opening the submenu, the submenu will show up in the old
position. This CL fixes this issue by updating the bounds
if the submenu is reopened.

Bug: 852915
Change-Id: I3664cb67f0ea4b15c0802b5fb37af6e7d3c3d789
Reviewed-on: https://chromium-review.googlesource.com/1125202Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573383}

Bug: 830062
Change-Id: I794edcc4800db91f253455fca072c28ba9d055b7
Reviewed-on: https://chromium-review.googlesource.com/1125340Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573382}

This change reduces focus rings from 4dip thick inset by 2dip to 2dip thick inset
by 1dip.

Bug: 851122
Change-Id: I8e38df43fd410cb4f1dc526c767b4f77b26733cd
Reviewed-on: https://chromium-review.googlesource.com/1127929
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573381}

Canonicalize username when we save PasswordHashData. For example,
user.name@gmail.com should always saved as username@gmail.com.  Since
some users might have already had non-canonicalized username saved. This
change also makes sure when we retrieve or clear saved PasswordHashData,
HashPasswordManager always compares canonicalized usernames.

Bug: 858865
Change-Id: Iac6df28a5660dcf5f77e9ee29c5b81805a02245f
Reviewed-on: https://chromium-review.googlesource.com/1123102Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573380}

Some of the URLs are out of date, or not so useful anymore.
This CL removes / and updates some of the items.

Change-Id: Idb61bac850901ba5abc31c40a421d16ba24bbb85
Reviewed-on: https://chromium-review.googlesource.com/1129387Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573379}

Based on the code for blink::Length in ../gdb/blink.py

Change-Id: I5bb31ea12619d3c6356ec2c5d685c2b4740a4184
Reviewed-on: https://chromium-review.googlesource.com/1126379Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573378}

This will be a KeyedService that could be used manage multiple LanguageModel objects (which are
not KeyedServices anymore).

This also gives us a place to put per-profile initialization logic for Translate.

Bug: 855192
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If048ddcaacc91ae5b58a14d66020d5fe4db7d50f
Reviewed-on: https://chromium-review.googlesource.com/1121036Reviewed-by: Michael Martis <martis@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573377}

To make components_unittests link with is_chromecast=true:
- include pdf code only if enable_plugins is set (it's false both
  on android and on cast/linux, and components/pdf/renderer relies
  on plugin code)
- include linux_key_storage tests only when the code under test is
  included as well (desktop_linux && !chromecast)

Depends on https://chromium-review.googlesource.com/c/chromium/src/+/1129259
to get services_unittests to link under cast.

Bug: 843511
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I186facb2ccc3edf11667168ccd2d7dd28863e3ae
Reviewed-on: https://chromium-review.googlesource.com/1128939
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573376}

This has been sitting behind a flag for, like, ever and we have no
plans to launch it. If that ever changes we can re-land this code.

Bug: 724585
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If29a5aca5d5aca885fbbe76fba1790f234618249
Reviewed-on: https://chromium-review.googlesource.com/1128166
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573375}

Settings is moving to a different set of fonts and colors from other
collections. This CL adds a CollectionViewCellStyle property to shared cells.

BUG=805213

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8a38c07fcbee95aafb84cfcf4a4a3589e35bd4e3
Reviewed-on: https://chromium-review.googlesource.com/1129039
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573374}

The dependency to sync is artifical and actually the code can be moved
trivially to components/sync_sessions, where it belongs.

Bug: 853731
Change-Id: I52f74b92e21f8f126fbb8a4037807b14e9eb4835
Reviewed-on: https://chromium-review.googlesource.com/1107813Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573373}

This check isn't very helpful. It only finds pathological but valid
situations. Typically, the resulting patch is very compressible and
this only checks the uncompressed size, which is inflated due to having
many headers for ZTF and Raw regions.

Bug: 860845
Change-Id: I5747e787a1c9888c4ef70d8449572517669f39cd
Reviewed-on: https://chromium-review.googlesource.com/1128810
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573372}