- 16 Mar, 2020 40 commits
-
-
Timothy Loh authored
This CL updates the notification displayed when Plugin VM fails to launch to accommodate both the new error codes, and the unknown error cases. A subsequent CL will probably change this notification into a dialog, so I've temporarily omitted adding screenshots for the strings. Bug: 1041313 Change-Id: I47b3036d167807cc611bc7d7788acc9669060a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100453 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#750492}
-
Keita Suzuki authored
This commit removes all original pywebsocket dependencies. Change-Id: Ied7fb043ed5f82fc87b328f4aa9600624552fbee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100148Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Keita Suzuki <suzukikeita@google.com> Cr-Commit-Position: refs/heads/master@{#750491}
-
Hiroshige Hayashizaki authored
This CL makes stripUrlForUseAsReferrer() more spec-conformant, in order to support `data:` URLs as the argument, which can happen in testing subresource requests from data: URL workers (no such tests so far though). Bug: 906850 Change-Id: I3ba7b1fbf27e79624d9c09fa2c65862b45d17338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102302Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#750490}
-
Andreas Haas authored
This CL replaces the use of ArrayBuffer in EncodedVideoChunk by DOMArrayBuffer. ArrayBuffer is deprecated. R=yukishiino@chromium.org Bug: chromium:1008840 Change-Id: I3b1bdefce6a7e60e6b30ddaf6f55dbe1b748da3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102584Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Kent Tamura authored
This is a preparation to enable LayoutNG for <input type=file>, which will use the normal LayoutNGBlockFlow. Change the argument type of LayoutFileUploadControl constructor because CreateObject<> template asks a LayoutObject constructor for taking an Element* argument. This CL has no behavior changes for now because FileInputType has TypeShouldForceLegacyLayout. Bug: 1040826 Change-Id: I57a1bc5adb03ed7222d7793155f76abd148b1c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104808 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#750488}
-
Shik Chen authored
When the system is extremely slow, the buffer allocation of the output buffer can fail and upper layer would get the raw un-rotated buffer. This CL mitigates the issue by reusing the original buffer for 180 degrees rotate, which is the default orientation of the user facing camera on Nocturne. Bug: 1061346 Test: Run Hangouts Meet with screen rotated with 0, 90, 180, 270 degrees. Change-Id: I7051fa9e0c3857345ff3ad1916fd3d91d6a59f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101324Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#750487}
-
Hiroshige Hayashizaki authored
Manual change: wpt/mixed-content/spec.src.json. Previously, it omitted `http-rp/unset` tests because it expected redundant tests `meta/unset`. However, in certain worker-related tests, there are no `meta` tests, and thus `http-rp/unset` is not redundant. This CL enables generating such non-redundant `http-rp/unset` tests, namely `sharedworker-{classic,module}.http-rp/unset`, i.e. SharedWorkers served from HTTPS origin without no opt-in CSP headers. All other changes are mechanical. Bug: 1061679, 1056500 Change-Id: Ib8c323cf06e1c6e0a0bdeae713bd13848335b95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103967 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: -
Hiroshige Hayashizaki authored
This CL excludes "sharedworker-module" subresources in `spec.src.json`s, because such generated tests are not added to the repository. Bug: 906850 Change-Id: I8d73dbed296c9dda35a4c6e6a8913881f6baeadf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102829 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
Previously, dump_test_parameters() (which uses json.dumps()) was used to calculate the keys of `exclusion_dict`, so that the keys of `exclusion_dict` include all the fields of the selections. However, this was slow. This CL instead uses `excluded_selection_pattern % selection` where excluded_selection_pattern incudes "`%(key)s`" for all the keys of the selections, except for "expansion". (The exclusion of "expansion" is probably good, as differences in "expansion" fields shouldn't prevent excluded test matching) This CL improves the generator's performance about 5x. This CL doesn't change the generated results or test behavior. Bug: 906850 Change-Id: I67f2cf6e960d7867a9b409cb84bf8249ac1912c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100562 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
`spec_json.js` are not used in WPT production runs. This CL removes them, to omit `spec_json.js`-related diffs in upcoming CLs. This CL doesn't change the generated results or test behavior. Bug: 906850 Change-Id: I1001286f2680294f1d8e747f23a25040f5bfd253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103728 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Eriko Kurimoto <elkurin@chromium.org> Cr-Commit-Position: refs/heads/master@{#750483}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/735a9cd7804e..314e048432c6 Created with: gclient setdep -r src-internal@314e048432c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1061670 Tbr: jbudorick@google.com Change-Id: Ife9c6b05dab3509413b2a1e40abe3304bb3108c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104695Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750482}
-
Yoshifumi Inoue authored
This patch changes implementation of |LayoutNGEnabled()| in parameterized unit tests to use runtime enabled flag instead of unit test's parameter for ease of verifying features depend on "LayoutNG", e.g. "LayoutNGFragmentItem", "EditingNG", etc, on checking both legacy layout and LayoutNG. Note: This is mechanical change with "git cl format". Bug: 982194 Change-Id: I4436318135f1a7f1a5de3f44071e670db82e420e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103980 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#750481}
-
Hiroshige Hayashizaki authored
To remove special handling in the generator. This CL doesn't change the generated results or test behavior. Bug: 906850, https://github.com/web-platform-tests/wpt/issues/21708 Change-Id: Ibb6586d618a04dba96304ba4a21555034bd30d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102387 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
This CL adds a new item “Webpage, Single File (Web Bundle)” in the “Save as type” select box of “Save As” dialog box for Desktop when SavePageAsWebBundle feature flag is set using --enable-features command line flag. The logic of Web Bundle generation in WebBundler is not implemented yet. WebBundler just returns WebBundlerError::kNotImplemented error. So the request of save as WebBundle is just canceled. Bug: 1040752 Change-Id: Iacb8a66e2fa8bc6b630d200a54bacd64a723eb0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053745Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#750479}
-
Fergal Daly authored
Split RenderFrameHostManager::Init into InitRoot and InitChild. Add CreateRenderFrameHost::CreateFrameEnum and pass it to CreateRenderFrameHost to capture the context in which creation is done, to allow validation of expectations. Change-Id: Ic23c40d62f5cd1f461ab2e8fccd6a9fe9024d8b9 Bug: 1059678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084038 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#750478}
-
Xianzhu Wang authored
... instead of v8::Isolate::Current() which is discouraged. Bug: 954679 Change-Id: I0b27a84f7da62a8dcd8b8851ccdbe61c8662799d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104771Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#750477}
-
Ayu Ishii authored
This change removes the mojo `message` parameter[1] from SmsReceiver Receive because it is no longer used since the API shape change to be a part of credential manager. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2098499/7/third_party/blink/public/mojom/sms/sms_receiver.mojom Bug: 1045526 Change-Id: I1c49a71ca8c07fab2dd7008d0e755cc4f7d7de4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098499Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Andreas Haas authored
The FlexibleTypedArray depended on TypedArray just to access the underlying type. However, the underlying can be passed in as a template argument directly. R=haraken@chromium.org Bug: 1008840 Change-Id: I7256fb21c603e09cacba39580ece47808f64abf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104049Reviewed-by:
-
Kei Nakashima authored
Implemented |NewLinkedHashSet::find| and |NewLinkedHashSet::Contains| and added tests Change-Id: I2488db864e2f618899a3a4fda49a9440f1264c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100558 Commit-Queue: Kei Nakashima <keinakashima@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Kent Tamura authored
- New behavior matches to Firefox. - File upload controls in LayoutNG will have overflow:hidden by default. The new behavior will be necessary for site compatibility. Bug: 1040826 Change-Id: I1c620f98806a1751252b4f5a96545609fa90cc1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102997Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/222b156b486b..5609eb6d5256 git log 222b156b486b..5609eb6d5256 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@5609eb6d5256 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3db3e800db1b68fa3d1f17e933624284882d6236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104691Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750472}
-
Joel Hockey authored
Bug: 1061822 Change-Id: I334d2ff8add76d42dc7aa4f96cc7e7a8a341c0b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102996 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#750471}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ibee86744d9313d0908c7722f222d0ae99a678e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104657Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750470}
-
Kunihiko Sakamoto authored
TBR=arthursonzogni@chromium.org No-try: true Bug: 1061029 Change-Id: Ic6c21749e873ebfd8623767febbf49eb62ba2262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103978Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#750469}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/572d6abf7f22..ca93436e5b1b $ git log 572d6abf7..ca93436e5 --date=short --no-merges --format='%ad %ae %s' 2020-03-15 junyer Update Unicode data to 13.0.0. 2020-03-12 junyer SRWLOCK requires Windows Vista or Windows Server 2008 at minimum. 2020-03-04 donatas.saulys Using slim RW lock on windows 2020-03-02 junyer Set SONAME to 6. 2020-03-01 junyer Bump SONAME to reflect the ABI break. 2020-02-28 junyer Add macOS and Xcode jobs to the Travis CI matrix. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Change-Id: I2f8c6ee0a33a594a595ab70840bba2b066385d19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104262Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#750468}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c48fb8427c8c..8cf12290bab8 git log c48fb8427c8c..8cf12290bab8 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@8cf12290bab8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I8c6189ade78c7eb85f5d716baf3dc49ec2ef2da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104687Reviewed-by:
-
Alan Cutter authored
It is possible for CancelDownloads() to be called after the callback_ has already been called via successful download or a previous navigation. This CL adds a null check to avoid crashing in these corner case scenarios. Bug: 1059847 Change-Id: Idc97407ba67195beba51a9053ee2d71dcbd911f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102995Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#750466}
-
Trent Apted authored
Failin on linux-chromeos-chrome internal bot since https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3955 Error like "[FAIL] [directoryTreeExpandHorizontalScrollRTL]: Tree should not scroll right This is blocking src-internal rolls (for >1 day). Tbr: majidvp@chromium.org, noel@chromium.org Bug: 1061821, 1061670 Change-Id: I27dd3fca5a5d9154519680b748c6dd054f2dd021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103012Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#750465}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I215d45b0f382bb0ae99350dd8d0ec8770a10e8f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104512Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750464}
-
Koji Ishii authored
This patch converts a non-file-based image in clipboard to an <img> tag with data URL when pasting to an editing host. The generated markup matches |URLToImageMarkup| and the one Firefox generates for the same case. In addition to the unittests, manually tested by taking screenshots to clipboard by pressing Alt+PrtScrn key on Windows and confirmed: * Pastable to `contenteditable`. * Pastable to `-webkit-user-modify: read-write`. * Not pastable to `<input>`, `<textarea>`, nor to `-webkit-user-modify: read-write-plaintext-only`. Bug: 1008927 Change-Id: I19c17591567ad150575ed15af7743e819eaeb67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086463 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Kent Tamura authored
This CL has no behavior changes. Bug: 1052232 Change-Id: I9e59f2c291c216f784df57796191d87764a73f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103991 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a4a42e6d0baa..cb9a86a9d867 git log a4a42e6d0baa..cb9a86a9d867 --date=short --first-parent --format='%ad %ae %s' 2020-03-15 ynovikov@chromium.org Skip SwANGLE GLES31 tests which crash with 32-bit Subzero. Created with: gclient setdep -r src/third_party/angle@cb9a86a9d867 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: Ifc12641bb8fcc30402b841874ed2a9ce2b4c62aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103666Reviewed-by:
-
Daniele Castagna authored
This patch adds a flag to enable/disable splitting quads when partially occluded to reduce compositing overdraw. This flag currently disables the optimization, so that we can consider merging this patch back to 81 along with the optimization (then the optimization will need to be explicitly enabled via the flag in 81). Bug: 1061708 Test: Power consumption of meets on a chromebook with the flag on and off Change-Id: I4417076a21c7074244e7bb960b1e1cf477fb721a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103721 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#750460}
-
Dominic Farolino authored
This CL removes two lazy load image tests from the TestExpectations file since they are already passing. It also renames the two tests, since there were typos in their filenames. Bug: 626703 Change-Id: I0497342a7729ca3f551910b25bd14c17de83b65d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103009Reviewed-by:
-
Noel Gordon authored
Bug: 992818 Change-Id: I45a74425ddbc340526696b4e67fded93be96c5ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102937 Auto-Submit: Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#750458}
-
Joel Hockey authored
Allow AppBrowserController to set default bounds for apps. After the first launch, we will use the regular persistence of position and size for subsequent open or restore. Previous positioning of terminal settings is no longer required. Bug: 1058670 Change-Id: I9793dc1cb046fc0c409471ca589f5f4bfaf57e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100951 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#750457}
-
Trent Apted authored
This reverts commit 2e21ac99. Reason for revert: Persistent compile failure is blocking any src-internal roll for 30+ hours error: no matching constructor for initialization of 'chromeos::assistant::action::CrosActionModule' return unique_ptr<_Tp>(new _Tp(_VSTD::forward<_Args>(__args)...)); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../chromeos/services/assistant/assistant_manager_service_impl.cc:160:27: note: in instantiation of function template specialization 'std::__1::make_unique<chromeos::assistant::action::CrosActionModule, chromeos::assistant::AssistantManagerServiceImpl *, bool, bool, bool>' requested here action_module_(std::make_unique<action::CrosActionModule>( ^ ../../chromeos/assistant/internal/action/cros_action_module.h:159:12: note: candidate constructor not viable: requires at most 3 arguments, but 4 were provided explicit CrosActionModule(AssistantActionObserver* assistant_event_observer, link: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3983 Original change's description: > chromeos/assistant: CrosActionModule ctor fix compilation > > Roll src/chromeos/assistant/internal/ d3a99ca02..4e7273378 > added a parameter to CrosActionModule ctor, but the code what was > instantiating one still assumes there are only three parameters. > > This CL adds the fourth parameter where we instantiate CrosActionModule. > > Bug: b:149570650 > Test: Now chrome for chromeos compiles > Change-Id: I950a3557df7d996b5d0695b9fa2de4633c448afe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103717 > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Auto-Submit: Daniele Castagna <dcastagna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750409} TBR=dcastagna@chromium.org,xiaohuic@chromium.org,dmblack@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1061670, b:149570650 Change-Id: I385b38f8dfde3233cccc8213e85ebb9d67f88a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102994Reviewed-by:
-
Toni Barzic authored
Adds histograms that record value set by user for accessibility setting to show shelf navigation buttons in tablet mode. The action is recorded separately for OS a11y settings and OOBE. The value set by user is recorded with a 10 second delay, to avoid overreporting if the user toggles the setting few times in short succession (when the value changes, the previous requests to record the metric are canceled). BUG=1055688 Change-Id: Ie8a8104e4feda6844632b3a249242163949098d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099335Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#750455}
-
Anand K. Mistry authored
This prevents a UAF when called with a callback bound using base::Unretained(), which is a common pattern for owned objects. Bug: 1052729 Change-Id: I017877c2aa88f3dddae26deffe99b7e5eff68b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103733Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#750454}
-
Kunihiko Sakamoto authored
This reverts commit db2ea179. Reason for revert: toBlob-in-detached-document.html is consistently crashing on Mac and Windows bots. https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/100726 https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/45010 https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/52120 https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/22974 Original change's description: > Handle a null context in CanvasAsyncBlobCreator constructor > > Bug: 1061309 > Test: fast/canvas/toBlob-in-detached-doument.html > Change-Id: I3d515666c9228d6d32791bad588149f879020b2e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103046 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Nate Chapin <japhet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750299} TBR=dcheng@chromium.org,japhet@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1061309 Change-Id: I88be96615ea2bf3a164a3b9d1d17f378f22046b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103010Reviewed-by:
-
