- 24 Jun, 2019 40 commits
-
-
Eugene But authored
CommitPendingItem used to rely on pending item index to check which item to commit (one from context or one from navigation manager). This logic was not correct because it is possible to have back-forward and new navigation simultaniously, so CommitPendingItem should commit item from context if one exists. Bug: 944044 Change-Id: If83bb2427780b56c1a2d24a6811640aa4a3375c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670307 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#671835}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/b3523d57461c..16f6e6ab932f git log b3523d57461c..16f6e6ab932f --date=short --no-merges --format='%ad %ae %s' 2019-06-24 zoddicus@users.noreply.github.com Remove SetShaderModel from API (#734) Created with: gclient setdep -r src/third_party/shaderc/src@16f6e6ab932f The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: I1a78f3aaad6a6dd49107fe1b6e2f72706c6e7680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673459Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671834}
-
Lucas Tenório authored
Bug: 977566 Change-Id: I7c8983f732a53800f3b32dcb400884ff75266567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673017 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#671833}
-
Victor Hugo Vianna Silva authored
Bug: 978012 Change-Id: I0bde7292674e03241c2fddbcac0bfe073dd74502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674163 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#671832}
-
James Cook authored
See bug for discussion. These are still important, so push the expiration out by a year. Sonny graciously volunteered to own them. Bug: 975955 Change-Id: Ibd9e9eae31bd4144fd0b5cbb552a4f07b490325c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666703 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#671831}
-
Matt Reynolds authored
This CL renames test utilities used by FIDO authenticator tests to simulate FIDO HID devices. FakeHidConnection -> FakeFidoHidConnection FakeHidManager -> FakeFidoHidManager ScopedFakeHidManager -> ScopedFakeFidoHidManager FakeHidManager and FakeHidConnection conflict with the test utilities defined in //services/device/public/cpp/hid that share the same names. BUG=None Change-Id: Icb2e5abe0efca27ab492fdb8a5b320c0a4bc24f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672454Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#671830}
-
Antoine Labour authored
Making sure there are at least 2 owners after I leave. This CL was uploaded by git cl split. R=dcastagna@chromium.org Change-Id: Idb6a39f806f36f13814501e83aaf7a1a93e65819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674637 Auto-Submit: Antoine Labour <piman@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#671829}
-
Lucas Tenório authored
This reverts commit 7662f044. Reason for revert: Kiosk Next is canceled. Original change's description: > Disable Assistant when Kiosk Next is enabled. > > Bug: 973985 > Change-Id: I06377f374f3c2e5985b7c80914fb184be94a5a05 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658854 > Commit-Queue: Lucas Tenório <ltenorio@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#670220} TBR=xiyuan@chromium.org,sammc@chromium.org,wutao@chromium.org,ltenorio@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 973985 Change-Id: Ib7834c4100c7bf10100906bec6461d1e3f8ccfcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674224Reviewed-by:
Lucas Tenório <ltenorio@chromium.org> Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Cr-Commit-Position: refs/heads/master@{#671828}
-
Mohamed Heikal authored
Latest aapt2 is required for enabling resource path shortening. This also fixes an xml resources size regression for bundles where raw xml values were being unnecessarily kept. Binary-Size: More generated -keeps, but size overall shrinks Bug: 753402, 912804 Change-Id: Id1599926277b83b978f3b01a556dd54c304d1955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669171 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#671827}
-
Natalie Chouinard authored
Migrate the Usage and Crash Reports Preference Fragment from the deprecated Framework preferences to the preferences support library. Bug: 968592 Change-Id: I7603dccab366bc6964b2d79473bf7227e8619c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670147Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#671826}
-
Akihiro Ota authored
This change allows popup buttons to take SetSize values, which is inherited from the wrapped menulist popup, if one is present.The SetSize is then reported to the user in ChromeVox if the popup button is expanded. Tests have been added to ensure correct behavior in ui/accessibility and ChromeVox. Bug: 914666 Change-Id: I8f46b3d0fab297e12d5f70a8100984455f1e0078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666779 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#671825}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e9cac4fe8335..f4996d436060 git log e9cac4fe8335..f4996d436060 --date=short --no-merges --format='%ad %ae %s' 2019-06-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 163d6b20..d6c73f30 (671624:671737) Created with: gclient setdep -r src/third_party/webrtc@f4996d436060 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iae615a940f794dc3fb5494337032a77274a9ca18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674585Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671824}
-
Natalie Chouinard authored
Migrate the Clear browsing data settings screen from the deprecated framework preferences to the support library preferences. This is the first preference screen migrated with preferences that include icons, so this change makes the necessary additions to the shared preference layout to allow icons to be displayed. Previously, this settings screen replaced the PreferenceFragment's layout resource, which is not a well-supported use of the support library PreferenceFragmentCompat. Instead, we're using the default PreferenceFragmentCompat layout, and appending the custom button to the bottom of that view. By returning to default implementations, this also fixes some issues with keyboard accessibility on this screen (although there's still room for improvement, further documented on: https://crbug.com/674736). Bug: 968592, 674736, 977284 Change-Id: Idd604b449e237527cf2e6baf4f6fb9d2d434630c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666593 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#671823}
-
Lan Wei authored
We should only update hover on local root frame, so when we set the hover bit dirty, we should only set to local root frame. Bug: 877132 Change-Id: I0adc8edbce862f370455c07ef71b99d077a65da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668574Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#671822}
-
Yilkal Abe authored
This reverts commit 181be7a0. Bug: 977019 Original change's description: > Focus Kiosk Next Home app after waking from sleep > > Bug: 966892 > Change-Id: If7294cafdeec92b76da35c6c0fbcb3c91a41cb65 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647149 > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#668948} TBR=jamescook@chromium.org,michaelpg@chromium.org,yilkal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 966892 Change-Id: Ib45433b2af9f27b5617b8349df632d6a24c5077f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674440 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#671821}
-
Brett Wilson authored
https://gn.googlesource.com/gn.git/+log/8c7f4910..972ed755 972ed755 Update to more uses of C++11. a3e0807f Make exec_process_unittest.cc work with Python 3. e6b6049e Adds support for iOS colorsets. 2e73d712 Add command_launcher field to tools 86d2534a Add -Lnative link search paths for non-Rust deps ce1fa07c Allow get_target_outputs() on generated_file() targets Change-Id: I1d754f58447cd1ba689c26dd6fce911f35a99d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661406Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#671820}
-
Ella Ge authored
We do not handle mouse drag (drag-n-drop & selection) when mouse/pen is not drag with drag button (left mouse button or pen drag button) However we do not clear mouse_down_may_start_drag_ when returns here. This causes following mouse moves still think dragging may happen and does not pass mousemove events to iframe. Bug: 974790 Change-Id: Id1b7e4d71cb9607f918f3dc1b9e014fbb891ce5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661712Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#671819}
-
Xing Liu authored
This CL moves the icon id, which is located in public API but only used internally by the scheduler, to NotificationEntry. Bug: 977255 Change-Id: Ib35c65300fac87bed9722d14cd73d9a7edde1e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670300Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#671818}
-
Ben Pastene authored
And promote out of experiment. R=jbudorick, dpranke Bug: 978051, 932269 Change-Id: Ic9355ad8d95f9311b03bcd64992d89a41194fefc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673751Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#671817}
-
Tommy Steimel authored
Bug: 977452 Change-Id: I5ed7e10988f45e648d582914b173878e4ad19c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673649Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#671816}
-
Ian Vollick authored
With this change, JavascriptModalDialog can construct a touchless- friendly dialog property model. Bug: 977633 Change-Id: I68ab94b80ac47beef46184167c2b011a63de90c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671048Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#671815}
-
Tibor Goldschwendt authored
The build system will verify that the manifest packages match if you specify it in both GN and the manifest. Bug: 891996 Change-Id: I39c3f158d01908b971a3ef47cb90af73019284a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667687 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#671814}
-
Daniel McArdle authored
Bug: 977619 Change-Id: I9267e6ccab7d13a46b865f573e165f28062fe75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671931 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#671813}
-
Pavel Yatsuk authored
ProfileSyncService.get() can return null depending on configuration (for example when sync is disabled from command line). IdentityDiscController should check PSS reference for null before calling addSyncStateChangedListener(). BUG=977626,976089 R=twellington@chromium.org Change-Id: Ic04fbcfbe36b6074118823d94aac960bdcb8ff9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672182 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#671812}
-
Tarun Bansal authored
Add UMA metric to record how long peer to peer connections last. This is the amount of duration for which we would need to throttle the browser traffic. Bug: 913424 Change-Id: I209dd5720c9f3c0923a2616f198db8611a789d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674447Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#671811}
-
Rune Lillesveen authored
We ended keeping a deleted LayoutObject as part of whitespace re- attachement because the previous next_sibling was detached at the next iteration. Reset the next_sibling for each iteration. I have not been able to reproduce the issue locally with the clusterfuzz cases, and not figured out how to construct a case which causes this to happen, so this is a speculative fix. Bug: 977616 Change-Id: I31c840096897b757aaeccb3d8085ad57cf6b3060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674019Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#671810}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e92b5481..d32b1ad1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibeb38fc79c8fbcd9cd60927dd6b21709bb037529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673672Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671809}
-
Bill Orr authored
This type will be used for WebXR mojo instead of using an array of floats. Change-Id: I25cc78a51a22b4a01dde3602bbfabf8c5e211e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672406Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#671808}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a7344dc0fbc7..79519d67783b git log a7344dc0fbc7..79519d67783b --date=short --no-merges --format='%ad %ae %s' 2019-06-24 primiano@google.com Fix tools/install-build-deps 2019-06-24 treehugger-gerrit@google.com Merge "[processor] Add string names for async ref types" 2019-06-24 taylori@google.com Merge "perfetto-ui: Quantize thread states less agressively" 2019-06-24 fmayer@google.com Merge "Convert relpc to abspc for pprof." 2019-06-24 taylori@google.com Merge "perfetto-ui: Use sched_waking for scheduling latency" Created with: gclient setdep -r src/third_party/perfetto@79519d67783b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia765d32dd159e3adda3be847de2d715271e79c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673521Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671807}
-
Tibor Goldschwendt authored
This is a reland of 07f70727 that has the uses-sdk assert disabled. We will enable once all dependency repos are updated. Original change's description: > [build] Cleanup for specifying [min|target|max]SdkVersion in GN > > crrev/c/1650265 enforced setting [min|target|max]SdkVersion in GN. > However, this is to strict for some dependencies, e.g. WebRTC. > Therefore, relax rules so that you can specify the SDK versions in both > GN and the AndroidManifest.xml. And the build system will assert that > these values match. > > + Update some SDK versions that had been changed inadvertently in > crrev/c/1650265. > > TBR=tedchoc@chromium.org,torne@chromium.org > > Bug: 891996 > Bug: 977417 > Bug: 977328 > Change-Id: I89b944c1f73a35ba8fcdafdf4bdf62508759811e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660361 > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671446} TBR=tedchoc@chromium.org,agrieve@chromium.org,estevenson@chromium.org,yusufo@chromium.org Bug: 891996, 977417, 977328 Change-Id: I97fd301368108f754f89b59beaa733121751a46a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674324Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#671806}
-
Theresa authored
A previous CL changed the order in which ToolbarPhone is notified about overview mode showing and the find-in-page toolbar hiding. Prior to that CL, the find-in-page toolbar hiding notification came in first, followed by the overview mode show. After the CL, the order was swapped causing the ToolbarPhone visibility to be incorrectly set after the find-in-page toolbar was hidden. This CL updates ToolbarPhone#handleFindLocationBarStateChange to take into account the current mTabSwitcherState. BUG=977529 Change-Id: Iec4d1a11e0a79b0ffad3fee707e739be2ed550b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674346Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#671805}
-
David Bertoni authored
This CL changes the current WorkerRefCount test to be one based on a Service Worker background page extension. Bug: 973540 Change-Id: I5661470f85d17fe14b8d782e14a29d09260c1c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671864 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#671804}
-
Julian Kung authored
The eager page load strategy considers a page loaded when the document.readyState is 'interactive'. This changelist implements it as an option for users to use. A test was added 'testEagerMode' to ensure that it is working properly. R=crouleau@chromium.org, johnchen@chromium.org Bug: chromedriver:1902 Change-Id: Ic83af73e959df9043de359d593a79c6adbc36992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669658 Commit-Queue: Julian Kung <juliankung@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#671803}
-
Peter Wen authored
Also corrects obsolete tag, since it was added to the wrong histogram originally in https://crrev.com/2653733002. These histograms were useful to monitor and keep tabs on regressions from new deferred startup tasks. As we haven't used them in over two years, setting these to expire until they are needed to diagnose a known regression again. They can be quickly reactivated with a finch trial. See: go/histogram-expiry-gdoc Bug: 975356 Change-Id: Id191be3c3bfb538d72a15d0cb2488add9818da0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674327 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#671802}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I5c745f6720f759f0fdd72242670d4d91e59ba302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673523Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671801}
-
Hesen Zhang authored
native Bug: 963287 Change-Id: I0e3363c3e5f45e032e30aa97fea658a4d4b0bc10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668576 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#671800}
-
Yoav Weiss authored
The value of secureConnectionStart should be non-zero for secure context navigations. It wasn't. This CL makes sure that it is! Bug: 977519 Change-Id: Ia12e2842bc061e687512f1ed94d02c07f4dd42ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672068Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#671799}
-
Sidney San Martín authored
With this change, `autocorrect=off` turns off all substitutions, and `spellcheck=false` just turns off quote and dash substitution, leaving custom substitutions on. Bug: 42434 Change-Id: I9ddf49f765e0ce061c8431563768f02e802d919b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672539 Auto-Submit: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#671798}
-
Esmael El-Moslimany authored
The about page is copied over to the OS Settings. The non-CrOS parts are removed as well as checks for the platform for CrOS parts. The detail subpage, browser procy and dialogs files were not copied over. They will continue to be shared by both about pages until their content needs to change or after the SplitSettings feature flag is removed. Added a link to the side menu in OS Settings to the chrome://os-settings/help page. Changed the chrome://management link to be an external link that opens in the browser. The existing chrome://settings/help is not rendered differently on CrOS for when the SplitSettings feature flag is enabled. This will be done in a follow-up CL. Bug: 974378 Change-Id: I34177a9717dc3e5d292b13e435971bbe093187fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669185 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#671797}
-
Finnur Thorarinsson authored
Bug: 734095 Change-Id: Ib06241c0995bf1adf554ecd8c4eda06c7fd3952d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670893 Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#671796}
-